* [PATCH] staging: et131x: remove unneccessary 'out of memory' message
@ 2014-09-30 17:19 Karthik Nayak
2014-09-30 17:40 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Karthik Nayak @ 2014-09-30 17:19 UTC (permalink / raw
To: linux-kernel; +Cc: devel, gamerh2o, gregkh, mark.einon, Karthik Nayak
Removes the 'out of memory' warning issues by checkpatch
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
drivers/staging/et131x/et131x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 41fcaa0..f1a9296 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -2423,7 +2423,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
skb = dev_alloc_skb(rfd->len + 2);
if (!skb) {
- dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
return NULL;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message
2014-09-30 17:19 Karthik Nayak
@ 2014-09-30 17:40 ` Fabio Estevam
2014-09-30 17:53 ` karthik nayak
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2014-09-30 17:40 UTC (permalink / raw
To: Karthik Nayak
Cc: linux-kernel, devel, gamerh2o, Mark Einon, Greg Kroah-Hartman
On Tue, Sep 30, 2014 at 2:19 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
> Removes the 'out of memory' warning issues by checkpatch
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
> drivers/staging/et131x/et131x.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index 41fcaa0..f1a9296 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -2423,7 +2423,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
>
> skb = dev_alloc_skb(rfd->len + 2);
> if (!skb) {
> - dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
> return NULL;
> }
Then you could also remove the braces:
if (!skb)
return NULL;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message
2014-09-30 17:40 ` Fabio Estevam
@ 2014-09-30 17:53 ` karthik nayak
0 siblings, 0 replies; 5+ messages in thread
From: karthik nayak @ 2014-09-30 17:53 UTC (permalink / raw
To: Fabio Estevam
Cc: linux-kernel, devel, gamerh2o, Mark Einon, Greg Kroah-Hartman
Oops, i sent the old commit again, sorry!
Regards,
Karthik Nayak
On Tue, Sep 30, 2014 at 11:10 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Sep 30, 2014 at 2:19 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> Removes the 'out of memory' warning issues by checkpatch
>>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>> drivers/staging/et131x/et131x.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
>> index 41fcaa0..f1a9296 100644
>> --- a/drivers/staging/et131x/et131x.c
>> +++ b/drivers/staging/et131x/et131x.c
>> @@ -2423,7 +2423,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
>>
>> skb = dev_alloc_skb(rfd->len + 2);
>> if (!skb) {
>> - dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
>> return NULL;
>> }
>
> Then you could also remove the braces:
>
> if (!skb)
> return NULL;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: et131x: remove unneccessary 'out of memory' message
@ 2014-09-30 17:55 Karthik Nayak
2014-09-30 18:50 ` Mark Einon
0 siblings, 1 reply; 5+ messages in thread
From: Karthik Nayak @ 2014-09-30 17:55 UTC (permalink / raw
To: linux-kernel; +Cc: devel, gamerh2o, gregkh, mark.einon, Karthik Nayak
Removes the 'out of memory' warning issued by checkpatch
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
drivers/staging/et131x/et131x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 41fcaa0..f92cceb 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -2422,10 +2422,8 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
rfd->len = len;
skb = dev_alloc_skb(rfd->len + 2);
- if (!skb) {
- dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
+ if (!skb)
return NULL;
- }
adapter->netdev->stats.rx_bytes += rfd->len;
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message
2014-09-30 17:55 [PATCH] staging: et131x: remove unneccessary 'out of memory' message Karthik Nayak
@ 2014-09-30 18:50 ` Mark Einon
0 siblings, 0 replies; 5+ messages in thread
From: Mark Einon @ 2014-09-30 18:50 UTC (permalink / raw
To: Karthik Nayak; +Cc: linux-kernel, devel, gamerh2o, gregkh, mark.einon
On Tue, Sep 30, 2014 at 11:25:43PM +0530, Karthik Nayak wrote:
> Removes the 'out of memory' warning issued by checkpatch
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
Hi,
I'm not sure which tree you're working agianst, but this change has already
been made and is on both staging-next and linux-next.
Cheers,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-30 18:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-30 17:55 [PATCH] staging: et131x: remove unneccessary 'out of memory' message Karthik Nayak
2014-09-30 18:50 ` Mark Einon
-- strict thread matches above, loose matches on Subject: below --
2014-09-30 17:19 Karthik Nayak
2014-09-30 17:40 ` Fabio Estevam
2014-09-30 17:53 ` karthik nayak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.