* [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode
@ 2013-10-04 16:15 Fabio Estevam
2013-10-04 16:15 ` [PATCH 2/3] ARM: dts: imx53-qsb: SDHC1 does not have cd-gpios Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-10-04 16:15 UTC (permalink / raw
To: shawn.guo; +Cc: linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
SDHC3 is 8 bit-wide, so pass the bus-width property to reflect that.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx53-qsb.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 94597c3..b646ef1 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -136,6 +136,7 @@
pinctrl-0 = <&pinctrl_esdhc3_1>;
cd-gpios = <&gpio3 11 0>;
wp-gpios = <&gpio3 12 0>;
+ bus-width = <8>;
status = "okay";
};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] ARM: dts: imx53-qsb: SDHC1 does not have cd-gpios
2013-10-04 16:15 [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode Fabio Estevam
@ 2013-10-04 16:15 ` Fabio Estevam
2013-10-04 16:15 ` [PATCH 3/3] ARM: dts: imx53-qsb: Do not use GPIO1_8 as wakeup source Fabio Estevam
2013-10-06 11:54 ` [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-10-04 16:15 UTC (permalink / raw
To: shawn.guo; +Cc: linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
SDHC1 does not have any GPIO for reading the card detection status, so
remove 'cd-gpios'.
After this change card detection works via the internal SD controller mechanism.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx53-qsb.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index b646ef1..029ae42 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -122,7 +122,6 @@
&esdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_esdhc1_1>;
- cd-gpios = <&gpio3 13 0>;
status = "okay";
};
@@ -153,7 +152,6 @@
MX53_PAD_PATA_DATA15__GPIO2_15 0x80000000
MX53_PAD_EIM_DA11__GPIO3_11 0x80000000
MX53_PAD_EIM_DA12__GPIO3_12 0x80000000
- MX53_PAD_EIM_DA13__GPIO3_13 0x80000000
MX53_PAD_PATA_DA_0__GPIO7_6 0x80000000
MX53_PAD_PATA_DA_2__GPIO7_8 0x80000000
MX53_PAD_GPIO_16__GPIO7_11 0x80000000
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] ARM: dts: imx53-qsb: Do not use GPIO1_8 as wakeup source
2013-10-04 16:15 [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode Fabio Estevam
2013-10-04 16:15 ` [PATCH 2/3] ARM: dts: imx53-qsb: SDHC1 does not have cd-gpios Fabio Estevam
@ 2013-10-04 16:15 ` Fabio Estevam
2013-10-06 11:54 ` [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-10-04 16:15 UTC (permalink / raw
To: shawn.guo; +Cc: linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
On the mx53qsb board with mc34708 PMIC, GPIO1_8 resets the system, so better not
to use it as a wakeup source.
Use GPIO 2_14 and 2_15 for wakeup sources instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx53-qsb.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 029ae42..91a5935 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -55,19 +55,20 @@
label = "Power Button";
gpios = <&gpio1 8 0>;
linux,code = <116>; /* KEY_POWER */
- gpio-key,wakeup;
};
volume-up {
label = "Volume Up";
gpios = <&gpio2 14 0>;
linux,code = <115>; /* KEY_VOLUMEUP */
+ gpio-key,wakeup;
};
volume-down {
label = "Volume Down";
gpios = <&gpio2 15 0>;
linux,code = <114>; /* KEY_VOLUMEDOWN */
+ gpio-key,wakeup;
};
};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode
2013-10-04 16:15 [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode Fabio Estevam
2013-10-04 16:15 ` [PATCH 2/3] ARM: dts: imx53-qsb: SDHC1 does not have cd-gpios Fabio Estevam
2013-10-04 16:15 ` [PATCH 3/3] ARM: dts: imx53-qsb: Do not use GPIO1_8 as wakeup source Fabio Estevam
@ 2013-10-06 11:54 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2013-10-06 11:54 UTC (permalink / raw
To: Fabio Estevam; +Cc: linux-kernel, Fabio Estevam
On Fri, Oct 04, 2013 at 01:15:26PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> SDHC3 is 8 bit-wide, so pass the bus-width property to reflect that.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied all 3, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-06 11:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 16:15 [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode Fabio Estevam
2013-10-04 16:15 ` [PATCH 2/3] ARM: dts: imx53-qsb: SDHC1 does not have cd-gpios Fabio Estevam
2013-10-04 16:15 ` [PATCH 3/3] ARM: dts: imx53-qsb: Do not use GPIO1_8 as wakeup source Fabio Estevam
2013-10-06 11:54 ` [PATCH 1/3] ARM: dts: imx53-qsb: SDHC3 is connected in 8-bit mode Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.