All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] video: ssd1307fb: Remove redundant of_match_ptr
@ 2013-09-30  8:57 Sachin Kamat
  2013-09-30 16:43 ` Maxime Ripard
  2013-10-09  8:48 ` Tomi Valkeinen
  0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-30  8:57 UTC (permalink / raw
  To: linux-fbdev

The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/video/ssd1307fb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/ssd1307fb.c b/drivers/video/ssd1307fb.c
index 44967c8..f4daa59 100644
--- a/drivers/video/ssd1307fb.c
+++ b/drivers/video/ssd1307fb.c
@@ -569,7 +569,7 @@ static struct i2c_driver ssd1307fb_driver = {
 	.id_table = ssd1307fb_i2c_id,
 	.driver = {
 		.name = "ssd1307fb",
-		.of_match_table = of_match_ptr(ssd1307fb_of_match),
+		.of_match_table = ssd1307fb_of_match,
 		.owner = THIS_MODULE,
 	},
 };
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] video: ssd1307fb: Remove redundant of_match_ptr
  2013-09-30  8:57 [PATCH 1/3] video: ssd1307fb: Remove redundant of_match_ptr Sachin Kamat
@ 2013-09-30 16:43 ` Maxime Ripard
  2013-10-09  8:48 ` Tomi Valkeinen
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2013-09-30 16:43 UTC (permalink / raw
  To: linux-fbdev

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

On Mon, Sep 30, 2013 at 02:15:31PM +0530, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] video: ssd1307fb: Remove redundant of_match_ptr
  2013-09-30  8:57 [PATCH 1/3] video: ssd1307fb: Remove redundant of_match_ptr Sachin Kamat
  2013-09-30 16:43 ` Maxime Ripard
@ 2013-10-09  8:48 ` Tomi Valkeinen
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2013-10-09  8:48 UTC (permalink / raw
  To: linux-fbdev

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

On 30/09/13 11:45, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  drivers/video/ssd1307fb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/ssd1307fb.c b/drivers/video/ssd1307fb.c
> index 44967c8..f4daa59 100644
> --- a/drivers/video/ssd1307fb.c
> +++ b/drivers/video/ssd1307fb.c
> @@ -569,7 +569,7 @@ static struct i2c_driver ssd1307fb_driver = {
>  	.id_table = ssd1307fb_i2c_id,
>  	.driver = {
>  		.name = "ssd1307fb",
> -		.of_match_table = of_match_ptr(ssd1307fb_of_match),
> +		.of_match_table = ssd1307fb_of_match,
>  		.owner = THIS_MODULE,
>  	},
>  };
> 

Thanks, queuing this series for 3.13.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-09  8:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30  8:57 [PATCH 1/3] video: ssd1307fb: Remove redundant of_match_ptr Sachin Kamat
2013-09-30 16:43 ` Maxime Ripard
2013-10-09  8:48 ` Tomi Valkeinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.