* + mm-fix-lost-kswapd-wakeup-in-kswapd_stop.patch added to -mm tree
@ 2012-07-13 22:26 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2012-07-13 22:26 UTC (permalink / raw
To: mm-commits
Cc: aaditya.kumar.30, aaditya.kumar, kosaki.motohiro, mel, minchan,
stable
The patch titled
Subject: mm: fix lost kswapd wakeup in kswapd_stop()
has been added to the -mm tree. Its filename is
mm-fix-lost-kswapd-wakeup-in-kswapd_stop.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Aaditya Kumar <aaditya.kumar.30@gmail.com>
Subject: mm: fix lost kswapd wakeup in kswapd_stop()
Offlining memory may block forever, waiting for kswapd() to wake up
because kswapd() does not check the event kthread->should_stop before
sleeping.
The proper pattern, from Documentation/memory-barriers.txt, is:
--- waker ---
event_indicated = 1;
wake_up_process(event_daemon);
--- sleeper ---
for (;;) {
set_current_state(TASK_UNINTERRUPTIBLE);
if (event_indicated)
break;
schedule();
}
set_current_state() may be wrapped by:
prepare_to_wait();
In the kswapd() case, event_indicated is kthread->should_stop.
=== offlining memory (waker) ===
kswapd_stop()
kthread_stop()
kthread->should_stop = 1
wake_up_process()
wait_for_completion()
=== kswapd_try_to_sleep (sleeper) ===
kswapd_try_to_sleep()
prepare_to_wait()
.
.
schedule()
.
.
finish_wait()
The schedule() needs to be protected by a test of kthread->should_stop,
which is wrapped by kthread_should_stop().
Reproducer:
Do heavy file I/O in background.
Do a memory offline/online in a tight loop
Signed-off-by: Aaditya Kumar <aaditya.kumar@ap.sony.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
Acked-by: Mel Gorman <mel@csn.ul.ie>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmscan.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff -puN mm/vmscan.c~mm-fix-lost-kswapd-wakeup-in-kswapd_stop mm/vmscan.c
--- a/mm/vmscan.c~mm-fix-lost-kswapd-wakeup-in-kswapd_stop
+++ a/mm/vmscan.c
@@ -2706,7 +2706,10 @@ static void kswapd_try_to_sleep(pg_data_
* them before going back to sleep.
*/
set_pgdat_percpu_threshold(pgdat, calculate_normal_threshold);
- schedule();
+
+ if (!kthread_should_stop())
+ schedule();
+
set_pgdat_percpu_threshold(pgdat, calculate_pressure_threshold);
} else {
if (remaining)
_
Subject: Subject: mm: fix lost kswapd wakeup in kswapd_stop()
Patches currently in -mm which might be from aaditya.kumar.30@gmail.com are
mm-fix-lost-kswapd-wakeup-in-kswapd_stop.patch
memory-hotplug-fix-kswapd-looping-forever-problem.patch
memory-hotplug-fix-kswapd-looping-forever-problem-fix.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-13 22:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-13 22:26 + mm-fix-lost-kswapd-wakeup-in-kswapd_stop.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.