* [U-Boot] [PATCH] pci: move pciauto_config_init() to pci.h
@ 2012-03-03 20:05 Linus Walleij
2012-03-04 20:22 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2012-03-03 20:05 UTC (permalink / raw
To: u-boot
Fixing build regressions for the Integrator I get find that a few
boards try to work around the missing declaration of
pciauto_config_init() by declaring it in the local scope. This
does not make sense when the sibling functions are in <pci.h>
so move the function to the header, ridding the build error
in the Integrator and getting rid of the local declarations
here and there.
Reported-by: Wolfgang Denk <wd@denx.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
board/esd/cpci750/pci.c | 1 -
board/prodrive/p3mx/pci.c | 1 -
drivers/pci/fsl_pci_init.c | 1 -
drivers/pci/pci.c | 1 -
include/pci.h | 1 +
5 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/board/esd/cpci750/pci.c b/board/esd/cpci750/pci.c
index a2c1c50..24ab13f 100644
--- a/board/esd/cpci750/pci.c
+++ b/board/esd/cpci750/pci.c
@@ -29,7 +29,6 @@
#include <pci.h>
#ifdef CONFIG_PCI_PNP
-void pciauto_config_init(struct pci_controller *hose);
int pciauto_region_allocate(struct pci_region* res, unsigned int size, unsigned int *bar);
#endif
diff --git a/board/prodrive/p3mx/pci.c b/board/prodrive/p3mx/pci.c
index e36b676..712c21c 100644
--- a/board/prodrive/p3mx/pci.c
+++ b/board/prodrive/p3mx/pci.c
@@ -29,7 +29,6 @@
#include <pci.h>
#ifdef CONFIG_PCI_PNP
-void pciauto_config_init(struct pci_controller *hose);
int pciauto_region_allocate(struct pci_region* res, unsigned int size, unsigned int *bar);
#endif
diff --git a/drivers/pci/fsl_pci_init.c b/drivers/pci/fsl_pci_init.c
index bff1314..d04a08c 100644
--- a/drivers/pci/fsl_pci_init.c
+++ b/drivers/pci/fsl_pci_init.c
@@ -51,7 +51,6 @@ void pciauto_prescan_setup_bridge(struct pci_controller *hose,
pci_dev_t dev, int sub_bus);
void pciauto_postscan_setup_bridge(struct pci_controller *hose,
pci_dev_t dev, int sub_bus);
-void pciauto_config_init(struct pci_controller *hose);
#ifndef CONFIG_SYS_PCI_MEMORY_BUS
#define CONFIG_SYS_PCI_MEMORY_BUS 0
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index bee2b52..007b850 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -518,7 +518,6 @@ void pci_cfgfunc_do_nothing(struct pci_controller *hose,
* to get the correct result when scanning bridges
*/
extern int pciauto_config_device(struct pci_controller *hose, pci_dev_t dev);
-extern void pciauto_config_init(struct pci_controller *hose);
#if defined(CONFIG_CMD_PCI) || defined(CONFIG_PCI_SCAN_SHOW)
const char * pci_class_str(u8 class)
diff --git a/include/pci.h b/include/pci.h
index 1284c42..7d98ad4 100644
--- a/include/pci.h
+++ b/include/pci.h
@@ -527,6 +527,7 @@ extern void pciauto_setup_device(struct pci_controller *hose,
struct pci_region *mem,
struct pci_region *prefetch,
struct pci_region *io);
+extern void pciauto_config_init(struct pci_controller *hose);
int pciauto_config_device(struct pci_controller *hose, pci_dev_t dev);
extern pci_dev_t pci_find_device (unsigned int vendor, unsigned int device, int index);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] pci: move pciauto_config_init() to pci.h
2012-03-03 20:05 [U-Boot] [PATCH] pci: move pciauto_config_init() to pci.h Linus Walleij
@ 2012-03-04 20:22 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2012-03-04 20:22 UTC (permalink / raw
To: u-boot
Dear "Linus Walleij",
In message <1330805108-24007-1-git-send-email-linus.walleij@linaro.org> you wrote:
> Fixing build regressions for the Integrator I get find that a few
> boards try to work around the missing declaration of
> pciauto_config_init() by declaring it in the local scope. This
> does not make sense when the sibling functions are in <pci.h>
> so move the function to the header, ridding the build error
> in the Integrator and getting rid of the local declarations
> here and there.
>
> Reported-by: Wolfgang Denk <wd@denx.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> board/esd/cpci750/pci.c | 1 -
> board/prodrive/p3mx/pci.c | 1 -
> drivers/pci/fsl_pci_init.c | 1 -
> drivers/pci/pci.c | 1 -
> include/pci.h | 1 +
> 5 files changed, 1 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Everyone who comes in here wants three things:
1. They want it quick.
2. They want it good.
3. They want it cheap.
I tell 'em to pick two and call me back.
- sign on the back wall of a small printing company in Delaware
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-04 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-03 20:05 [U-Boot] [PATCH] pci: move pciauto_config_init() to pci.h Linus Walleij
2012-03-04 20:22 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.