From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: James.Bottomley@HansenPartnership.com, mcarlson@broadcom.com,
rjw@sisk.pl, linux-kernel@vger.kernel.org,
kernel-testers@vger.kernel.org, maciej.rutecki@gmail.com,
florian@mickler.org, bhutchings@solarflare.com,
netdev@vger.kernel.org
Subject: Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1
Date: Wed, 29 Feb 2012 13:46:56 -0500 (EST) [thread overview]
Message-ID: <20120229.134656.2184805638060629954.davem@davemloft.net> (raw)
In-Reply-To: <1330508017.7993.3.camel@HP1>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 29 Feb 2012 01:33:37 -0800
> Subject: [PATCH net] tg3: Fix tg3_get_stats64 for 5700 / 5701 devs
>
> From: Matt Carlson <mcarlson@broadcom.com>
>
> tg3_get_stats64() takes tp->lock when dealing with non-serdes bcm5700
> and bcm5701 devices. However, functions that call tg3_halt() have
> already acquired tp->lock. When tg3_get_stats64() is called in
> tg3_halt(), deadlock will occur.
>
> This patch fixes the problem by separating the stat gathering code into
> a new tg3_get_nstats() function. tg3_get_stats64() is recoded to call
> this function and take tp->lock. The code that takes tp->lock in
> tg3_calc_crc_errors() has been removed. Function signatures have been
> cleaned up too.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks everyone.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org
Cc: James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
mcarlson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
rjw-KKrjLPT3xs0@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
florian-sVu6HhrpSfRAfugRpC6u6w@public.gmane.org,
bhutchings-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1
Date: Wed, 29 Feb 2012 13:46:56 -0500 (EST) [thread overview]
Message-ID: <20120229.134656.2184805638060629954.davem@davemloft.net> (raw)
In-Reply-To: <1330508017.7993.3.camel@HP1>
From: "Michael Chan" <mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Date: Wed, 29 Feb 2012 01:33:37 -0800
> Subject: [PATCH net] tg3: Fix tg3_get_stats64 for 5700 / 5701 devs
>
> From: Matt Carlson <mcarlson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
>
> tg3_get_stats64() takes tp->lock when dealing with non-serdes bcm5700
> and bcm5701 devices. However, functions that call tg3_halt() have
> already acquired tp->lock. When tg3_get_stats64() is called in
> tg3_halt(), deadlock will occur.
>
> This patch fixes the problem by separating the stat gathering code into
> a new tg3_get_nstats() function. tg3_get_stats64() is recoded to call
> this function and take tp->lock. The code that takes tp->lock in
> tg3_calc_crc_errors() has been removed. Function signatures have been
> cleaned up too.
>
> Signed-off-by: Matt Carlson <mcarlson-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Michael Chan <mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Applied, thanks everyone.
next prev parent reply other threads:[~2012-02-29 18:47 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:51 3.3-rc4+: Reported regressions from 3.2 Rafael J. Wysocki
2012-02-23 22:51 ` Rafael J. Wysocki
2012-02-23 22:51 ` [Bug #42669] 3.3-rc1: compiling problems nvme , l2cap_sock , mc13892-regulator , and snd-pcsp don't work Rafael J. Wysocki
2012-02-23 23:19 ` David Miller
2012-02-23 23:19 ` David Miller
2012-02-23 23:30 ` Rafael J. Wysocki
2012-02-23 23:30 ` Rafael J. Wysocki
2012-02-24 10:48 ` werner
2012-02-24 19:57 ` David Miller
2012-02-24 19:57 ` David Miller
2012-02-24 21:55 ` werner
2012-02-24 21:55 ` werner
2012-02-25 22:48 ` Florian Mickler
2012-02-23 22:55 ` [Bug #42678] [3.3-rc1] radeon stuck in kernel after lockup Rafael J. Wysocki
2012-02-24 9:14 ` Torsten Kaiser
2012-02-24 9:14 ` Torsten Kaiser
2012-02-23 22:55 ` [Bug #42686] iwlagn is getting even worse with 3.3-rc1 Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1 Rafael J. Wysocki
2012-02-27 23:44 ` James Bottomley
2012-02-28 1:24 ` Matt Carlson
2012-02-28 21:07 ` David Miller
2012-02-28 21:07 ` David Miller
2012-02-28 23:32 ` Matt Carlson
2012-02-28 23:32 ` Matt Carlson
2012-02-29 0:58 ` James Bottomley
2012-02-29 0:58 ` James Bottomley
2012-02-29 9:33 ` Michael Chan
2012-02-29 18:46 ` David Miller [this message]
2012-02-29 18:46 ` David Miller
2012-02-23 22:55 ` [Bug #42683] WARN... Device 'cpu1' does not have a release() function, it is broken and must be fixed. when doing 'xl vcpu-set <guest_id> 1' Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-24 4:33 ` Konrad Rzeszutek Wilk
2012-02-24 4:33 ` Konrad Rzeszutek Wilk
2012-02-23 22:55 ` [Bug #42713] Regression in skge that started around acb42a3 (so past v3.3-rc1) Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42735] kobject (ffff88003ffbb4b8): tried to init an initialized object, something is seriously wrong Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42733] Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42746] 3.3-rc2 snd_pcm lockdep backtrace Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42734] dosemu graphics broken in v3.3-rc1 Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42761] Possible circular locking dependency (3.3-rc2) Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42776] OF-related boot crash in 3.3.0-rc3-00188-g3ec1e88 Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42798] i915 regression with 3.3-rc3+git Rafael J. Wysocki
2012-02-23 23:28 ` 3.3-rc4+: Reported regressions from 3.2 David Miller
2012-02-23 23:28 ` David Miller
2012-02-24 0:13 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2012-03-04 20:29 3.3-rc6: " Rafael J. Wysocki
2012-03-04 20:31 ` [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1 Rafael J. Wysocki
2012-03-04 20:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229.134656.2184805638060629954.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bhutchings@solarflare.com \
--cc=florian@mickler.org \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.