* [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly
2011-10-14 10:17 [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly Alexey Starikovskiy
@ 2011-10-14 10:17 ` Alexey Starikovskiy
2011-10-14 12:47 ` Peter Maydell
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Alexey Starikovskiy @ 2011-10-14 10:17 UTC (permalink / raw
To: qemu-devel
** Patch added: "fix for the problem"
https://bugs.launchpad.net/bugs/874038/+attachment/2542719/+files/fix_carry_in_thumb2
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
New
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly
@ 2011-10-14 10:17 Alexey Starikovskiy
2011-10-14 10:17 ` [Qemu-devel] [Bug 874038] " Alexey Starikovskiy
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Alexey Starikovskiy @ 2011-10-14 10:17 UTC (permalink / raw
To: qemu-devel
Public bug reported:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
** Affects: qemu
Importance: Undecided
Status: New
** Tags: arm flags
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
New
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly
2011-10-14 10:17 [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly Alexey Starikovskiy
2011-10-14 10:17 ` [Qemu-devel] [Bug 874038] " Alexey Starikovskiy
@ 2011-10-14 12:47 ` Peter Maydell
2011-10-17 17:23 ` Alexey Starikovskiy
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2011-10-14 12:47 UTC (permalink / raw
To: qemu-devel
The existing code looks OK to me -- there's no need to call
gen_set_CF_bit31() early because the inputs t0 and t1 to
gen_thumb2_data_op() should always be distinct TCG values, and so
gen_thumb2_data_op() will never trash t1. (There was a bug in this area
involving ORN, but that was fixed in rev 29501f1, and I can see from
your patch that you have that fix.)
Can you clarify which exact instruction, input data and output data case
this patch is intended to fix, please?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
New
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly
2011-10-14 10:17 [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly Alexey Starikovskiy
2011-10-14 10:17 ` [Qemu-devel] [Bug 874038] " Alexey Starikovskiy
2011-10-14 12:47 ` Peter Maydell
@ 2011-10-17 17:23 ` Alexey Starikovskiy
2011-10-17 18:06 ` Peter Maydell
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Alexey Starikovskiy @ 2011-10-17 17:23 UTC (permalink / raw
To: qemu-devel
MVNS with immediate fails in attached test program at 0x82c0 location.
My patch fixes that.
** Attachment added: "failed test for MVNS.IMM opcode"
https://bugs.launchpad.net/qemu/+bug/874038/+attachment/2554573/+files/mvns_imm.exe
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
New
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly
2011-10-14 10:17 [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly Alexey Starikovskiy
` (2 preceding siblings ...)
2011-10-17 17:23 ` Alexey Starikovskiy
@ 2011-10-17 18:06 ` Peter Maydell
2011-10-17 19:27 ` Alexey Starikovskiy
2011-10-17 21:48 ` Peter Maydell
2011-10-18 10:24 ` Alexey Starikovskiy
5 siblings, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2011-10-17 18:06 UTC (permalink / raw
To: qemu-devel
Current git master works for me on that test program without your patch:
cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe
cam-vm-266:maverick:qemu$ echo $?
0
(I tested on qemu-0.14 just to confirm that I'm running the test program
correctly, and that indeed fails as I would expect it to, exiting with
status 255.)
Which qemu version have you been testing with?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
New
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly
2011-10-17 18:06 ` Peter Maydell
@ 2011-10-17 19:27 ` Alexey Starikovskiy
0 siblings, 0 replies; 8+ messages in thread
From: Alexey Starikovskiy @ 2011-10-17 19:27 UTC (permalink / raw
To: qemu-devel
0.15.0 fails for me.
On Mon, Oct 17, 2011 at 10:06 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> Current git master works for me on that test program without your patch:
> cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe
> cam-vm-266:maverick:qemu$ echo $?
> 0
>
> (I tested on qemu-0.14 just to confirm that I'm running the test program
> correctly, and that indeed fails as I would expect it to, exiting with
> status 255.)
>
> Which qemu version have you been testing with?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/874038
>
> Title:
> ARM thumb2 does not propogate carry flag properly
>
> Status in QEMU:
> New
>
> Bug description:
> information on carry flag is lost if gen_set_CF_bit31(t1) is called
> after logic operation.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
>
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
New
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly
2011-10-14 10:17 [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly Alexey Starikovskiy
` (3 preceding siblings ...)
2011-10-17 18:06 ` Peter Maydell
@ 2011-10-17 21:48 ` Peter Maydell
2011-10-18 10:24 ` Alexey Starikovskiy
5 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2011-10-17 21:48 UTC (permalink / raw
To: qemu-devel
> 0.15.0 fails for me.
Hmm. Works for me:
pm215@canth:/tmp$ wget http://wiki.qemu.org/download/qemu-0.15.0.tar.gz
[...]
pm215@canth:/tmp$ tar xzf qemu-0.15.0.tar.gz
pm215@canth:/tmp$ cd qemu-0.15.0/
pm215@canth:/tmp/qemu-0.15.0$ ./configure --target-list=arm-linux-user && make -j4
[...]
pm215@canth:/tmp/qemu-0.15.0$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe
pm215@canth:/tmp/qemu-0.15.0$ echo $?
0
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
New
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly
2011-10-14 10:17 [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly Alexey Starikovskiy
` (4 preceding siblings ...)
2011-10-17 21:48 ` Peter Maydell
@ 2011-10-18 10:24 ` Alexey Starikovskiy
5 siblings, 0 replies; 8+ messages in thread
From: Alexey Starikovskiy @ 2011-10-18 10:24 UTC (permalink / raw
To: qemu-devel
Sorry for the noise, it appears I've checked on not clean 0.15.0
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/874038
Title:
ARM thumb2 does not propogate carry flag properly
Status in QEMU:
Invalid
Bug description:
information on carry flag is lost if gen_set_CF_bit31(t1) is called
after logic operation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/874038/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-10-18 10:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14 10:17 [Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly Alexey Starikovskiy
2011-10-14 10:17 ` [Qemu-devel] [Bug 874038] " Alexey Starikovskiy
2011-10-14 12:47 ` Peter Maydell
2011-10-17 17:23 ` Alexey Starikovskiy
2011-10-17 18:06 ` Peter Maydell
2011-10-17 19:27 ` Alexey Starikovskiy
2011-10-17 21:48 ` Peter Maydell
2011-10-18 10:24 ` Alexey Starikovskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.