* [PATCH] insane.bbclass: fix the check for bad RPATH
@ 2011-02-03 7:00 Denys Dmytriyenko
2011-02-12 0:38 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2011-02-03 7:00 UTC (permalink / raw
To: openembedded-devel
* Variable 'sane' is boolean, so adding to it breaks the error condition
* Fixes previous commit 6aa31074 ported from Yocto
Signed-off-by: Denys Dmytriyenko <denis@denix.org>
---
classes/insane.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index 50752b5..a846832 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -174,7 +174,7 @@ def package_qa_check_rpath(file,name,d, elf):
for dir in bad_dirs:
if dir in line:
error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
- sane = sane + package_qa_handle_error(1, error_msg, name, file, d)
+ sane = package_qa_handle_error(1, error_msg, name, file, d)
return sane
--
1.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] insane.bbclass: fix the check for bad RPATH
2011-02-03 7:00 [PATCH] insane.bbclass: fix the check for bad RPATH Denys Dmytriyenko
@ 2011-02-12 0:38 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2011-02-12 0:38 UTC (permalink / raw
To: openembedded-devel
On (03/02/11 02:00), Denys Dmytriyenko wrote:
> * Variable 'sane' is boolean, so adding to it breaks the error condition
> * Fixes previous commit 6aa31074 ported from Yocto
>
> Signed-off-by: Denys Dmytriyenko <denis@denix.org>
Acked-by: Khem Raj <raj.khem@gmail.com>
> ---
> classes/insane.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/insane.bbclass b/classes/insane.bbclass
> index 50752b5..a846832 100644
> --- a/classes/insane.bbclass
> +++ b/classes/insane.bbclass
> @@ -174,7 +174,7 @@ def package_qa_check_rpath(file,name,d, elf):
> for dir in bad_dirs:
> if dir in line:
> error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
> - sane = sane + package_qa_handle_error(1, error_msg, name, file, d)
> + sane = package_qa_handle_error(1, error_msg, name, file, d)
>
> return sane
>
> --
> 1.7.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] insane.bbclass: fix the check for bad RPATH
@ 2011-02-13 15:50 Andreas Mueller
2011-02-13 20:33 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Mueller @ 2011-02-13 15:50 UTC (permalink / raw
To: openembedded-devel
Hi OE folks,
Yesterday I merged latest head into my working branch and started a fresh build for xfce46-image. I get
ERROR: QA Issue with db: package db contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db/usr/lib/libdb-5.0.so
ERROR: QA Issue with db: package db contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db/usr/lib/libdb-5.0.so
ERROR: QA Issue with db-bin: package db-bin contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db-bin/usr/bin/db_checkpoint
ERROR: QA Issue with db-bin: package db-bin contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db-bin/usr/bin/db_checkpoint
...
FATAL: QA run found fatal errors. Please consider fixing them.
ERROR: Error in executing python function in: /home/Superandi/data/OpenEmbedded/gumstix-oe/recipes/db/db_5.0.21.bb
ERROR: Exception:<type 'exceptions.SystemExit'> Message:1
ERROR: Printing the environment of the function
ERROR: Function do_package_qa failed
Without having further checks I think commit 14f7dd0965f14a09169dc5a2df18ff0b06f8bad5 causes this behaviour.
What makes me wondering:
- even in case I use the -k option the build aborts at the same position. Is that intended?
- Commit 6aa31074adaccffcfd3080e8390065ab5abda2a6 brings up many undetected RPATH cases which have to be fixed. With the current situation it is not possible to check which there are.
How about creating a list (I know Frans did already - but I think it was before the latest RPATH commit) listing the packages with QA errors / the type of QA error / and (to prevent double efforts) a person willing to take care. (Although I know nobody uses it :-) I take a look for clutter-box2d which has RPATH error)
Or is there something ongoing I have missed?
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] insane.bbclass: fix the check for bad RPATH
2011-02-13 15:50 [PATCH] insane.bbclass: fix the check for bad RPATH Andreas Mueller
@ 2011-02-13 20:33 ` Khem Raj
2011-02-13 22:36 ` Tom Rini
2011-02-14 9:18 ` [PATCH] insane.bbclass: make RPATH issues temporary not fatal Martin Jansa
0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2011-02-13 20:33 UTC (permalink / raw
To: openembedded-devel
On Sun, Feb 13, 2011 at 7:50 AM, Andreas Mueller <schnitzeltony@gmx.de> wrote:
> Hi OE folks,
>
> Yesterday I merged latest head into my working branch and started a fresh build for xfce46-image. I get
>
> ERROR: QA Issue with db: package db contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db/usr/lib/libdb-5.0.so
> ERROR: QA Issue with db: package db contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db/usr/lib/libdb-5.0.so
> ERROR: QA Issue with db-bin: package db-bin contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db-bin/usr/bin/db_checkpoint
> ERROR: QA Issue with db-bin: package db-bin contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db-bin/usr/bin/db_checkpoint
> ...
> FATAL: QA run found fatal errors. Please consider fixing them.
> ERROR: Error in executing python function in: /home/Superandi/data/OpenEmbedded/gumstix-oe/recipes/db/db_5.0.21.bb
> ERROR: Exception:<type 'exceptions.SystemExit'> Message:1
> ERROR: Printing the environment of the function
> ERROR: Function do_package_qa failed
>
> Without having further checks I think commit 14f7dd0965f14a09169dc5a2df18ff0b06f8bad5 causes this behaviour.
>
> What makes me wondering:
>
> - even in case I use the -k option the build aborts at the same position. Is that intended?
> - Commit 6aa31074adaccffcfd3080e8390065ab5abda2a6 brings up many undetected RPATH cases which have to be fixed. With the current situation it is not possible to check which there are.
>
> How about creating a list (I know Frans did already - but I think it was before the latest RPATH commit) listing the packages with QA errors / the type of QA error / and (to prevent double efforts) a person willing to take care. (Although I know nobody uses it :-) I take a look for clutter-box2d which has RPATH error)
>
> Or is there something ongoing I have missed?
>
hmm I think there are too many QA errors now it is reporting as errors
and bailing out build. While we should fix
the QA errors but I think we should not be that strict yet
> Andreas
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] insane.bbclass: fix the check for bad RPATH
2011-02-13 20:33 ` Khem Raj
@ 2011-02-13 22:36 ` Tom Rini
2011-02-14 9:18 ` [PATCH] insane.bbclass: make RPATH issues temporary not fatal Martin Jansa
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2011-02-13 22:36 UTC (permalink / raw
To: openembedded-devel
On 02/13/2011 01:33 PM, Khem Raj wrote:
> On Sun, Feb 13, 2011 at 7:50 AM, Andreas Mueller<schnitzeltony@gmx.de> wrote:
>> Hi OE folks,
>>
>> Yesterday I merged latest head into my working branch and started a fresh build for xfce46-image. I get
>>
>> ERROR: QA Issue with db: package db contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db/usr/lib/libdb-5.0.so
>> ERROR: QA Issue with db: package db contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db/usr/lib/libdb-5.0.so
>> ERROR: QA Issue with db-bin: package db-bin contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db-bin/usr/bin/db_checkpoint
>> ERROR: QA Issue with db-bin: package db-bin contains bad RPATH /home/Superandi/tmp/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib in file /home/Superandi/tmp/work/armv7a-angstrom-linux-gnueabi/db-5.0.21-r3/packages-split/db-bin/usr/bin/db_checkpoint
>> ...
>> FATAL: QA run found fatal errors. Please consider fixing them.
>> ERROR: Error in executing python function in: /home/Superandi/data/OpenEmbedded/gumstix-oe/recipes/db/db_5.0.21.bb
>> ERROR: Exception:<type 'exceptions.SystemExit'> Message:1
>> ERROR: Printing the environment of the function
>> ERROR: Function do_package_qa failed
>>
>> Without having further checks I think commit 14f7dd0965f14a09169dc5a2df18ff0b06f8bad5 causes this behaviour.
>>
>> What makes me wondering:
>>
>> - even in case I use the -k option the build aborts at the same position. Is that intended?
>> - Commit 6aa31074adaccffcfd3080e8390065ab5abda2a6 brings up many undetected RPATH cases which have to be fixed. With the current situation it is not possible to check which there are.
>>
>> How about creating a list (I know Frans did already - but I think it was before the latest RPATH commit) listing the packages with QA errors / the type of QA error / and (to prevent double efforts) a person willing to take care. (Although I know nobody uses it :-) I take a look for clutter-box2d which has RPATH error)
>>
>> Or is there something ongoing I have missed?
>>
>
> hmm I think there are too many QA errors now it is reporting as errors
> and bailing out build. While we should fix
> the QA errors but I think we should not be that strict yet
I think we should see how many of these we can easily pull a fix out of
from poky.
--
Tom Rini
Mentor Graphics Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] insane.bbclass: make RPATH issues temporary not fatal
2011-02-13 20:33 ` Khem Raj
2011-02-13 22:36 ` Tom Rini
@ 2011-02-14 9:18 ` Martin Jansa
1 sibling, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2011-02-14 9:18 UTC (permalink / raw
To: openembedded-devel
* should be reverted as soon as we fix most of new QA issues found by better check
---
classes/insane.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index a846832..a4823db 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -116,7 +116,7 @@ def package_qa_make_fatal_error(error_class, name, path,d):
TODO: Load a whitelist of known errors
"""
- return not error_class in [0, 5, 7]
+ return not error_class in [0, 1, 5, 7]
def package_qa_write_error(error_class, name, path, d):
"""
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-14 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-13 15:50 [PATCH] insane.bbclass: fix the check for bad RPATH Andreas Mueller
2011-02-13 20:33 ` Khem Raj
2011-02-13 22:36 ` Tom Rini
2011-02-14 9:18 ` [PATCH] insane.bbclass: make RPATH issues temporary not fatal Martin Jansa
-- strict thread matches above, loose matches on Subject: below --
2011-02-03 7:00 [PATCH] insane.bbclass: fix the check for bad RPATH Denys Dmytriyenko
2011-02-12 0:38 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.