* [PATCH] blackfin/acvilon: Fix timeout usage for I2C
@ 2010-04-04 14:04 Wolfram Sang
[not found] ` <1270389856-32003-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2010-04-04 14:04 UTC (permalink / raw
To: uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang, Mike Frysinger,
Valentin Yakovenkov
The timeout value is in jiffies, so it should be using HZ, not a plain
number. As '10000' is ambiguous, 1HZ is used as conservative default.
Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: Valentin Yakovenkov <yakovenkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/blackfin/mach-bf561/boards/acvilon.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/blackfin/mach-bf561/boards/acvilon.c b/arch/blackfin/mach-bf561/boards/acvilon.c
index 5163e2c..bfcfa86 100644
--- a/arch/blackfin/mach-bf561/boards/acvilon.c
+++ b/arch/blackfin/mach-bf561/boards/acvilon.c
@@ -44,6 +44,7 @@
#include <linux/spi/flash.h>
#include <linux/irq.h>
#include <linux/interrupt.h>
+#include <linux/jiffies.h>
#include <linux/i2c-pca-platform.h>
#include <linux/delay.h>
#include <linux/io.h>
@@ -112,7 +113,7 @@ static struct resource bfin_i2c_pca_resources[] = {
struct i2c_pca9564_pf_platform_data pca9564_platform_data = {
.gpio = -1,
.i2c_clock_speed = 330000,
- .timeout = 10000
+ .timeout = HZ,
};
/* PCA9564 I2C Bus driver */
--
1.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] blackfin/acvilon: Fix timeout usage for I2C
[not found] ` <1270389856-32003-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2010-05-10 2:36 ` Wolfram Sang
[not found] ` <20100510023639.GA25544-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2010-05-10 2:36 UTC (permalink / raw
To: uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Mike Frysinger,
Valentin Yakovenkov
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
On Sun, Apr 04, 2010 at 04:04:16PM +0200, Wolfram Sang wrote:
> The timeout value is in jiffies, so it should be using HZ, not a plain
> number. As '10000' is ambiguous, 1HZ is used as conservative default.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
> Cc: Valentin Yakovenkov <yakovenkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/blackfin/mach-bf561/boards/acvilon.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/blackfin/mach-bf561/boards/acvilon.c b/arch/blackfin/mach-bf561/boards/acvilon.c
> index 5163e2c..bfcfa86 100644
> --- a/arch/blackfin/mach-bf561/boards/acvilon.c
> +++ b/arch/blackfin/mach-bf561/boards/acvilon.c
> @@ -44,6 +44,7 @@
> #include <linux/spi/flash.h>
> #include <linux/irq.h>
> #include <linux/interrupt.h>
> +#include <linux/jiffies.h>
> #include <linux/i2c-pca-platform.h>
> #include <linux/delay.h>
> #include <linux/io.h>
> @@ -112,7 +113,7 @@ static struct resource bfin_i2c_pca_resources[] = {
> struct i2c_pca9564_pf_platform_data pca9564_platform_data = {
> .gpio = -1,
> .i2c_clock_speed = 330000,
> - .timeout = 10000
> + .timeout = HZ,
> };
>
> /* PCA9564 I2C Bus driver */
Ping.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Uclinux-dist-devel] [PATCH] blackfin/acvilon: Fix timeout usage for I2C
[not found] ` <20100510023639.GA25544-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2010-05-10 2:39 ` Mike Frysinger
[not found] ` <v2o8bd0f97a1005091939nc0de1b9ckf33b402e72983de1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2010-05-10 2:39 UTC (permalink / raw
To: Wolfram Sang
Cc: uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b,
Valentin Yakovenkov, linux-i2c-u79uwXL29TY76Z2rM5mHXA
i'll pick this up for the next merge window (i.e. the one in a few
days) if Valentin has no feedback by then
-mike
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Uclinux-dist-devel] [PATCH] blackfin/acvilon: Fix timeout usage for I2C
[not found] ` <v2o8bd0f97a1005091939nc0de1b9ckf33b402e72983de1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2010-05-10 2:44 ` Wolfram Sang
2010-05-28 19:52 ` Valentin Yakovenkov
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2010-05-10 2:44 UTC (permalink / raw
To: Mike Frysinger
Cc: uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b,
Valentin Yakovenkov, linux-i2c-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Sun, May 09, 2010 at 10:39:24PM -0400, Mike Frysinger wrote:
> i'll pick this up for the next merge window (i.e. the one in a few
> days) if Valentin has no feedback by then
Thanks, this was the last board using a plain number. Case closed for now.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Uclinux-dist-devel] [PATCH] blackfin/acvilon: Fix timeout usage for I2C
[not found] ` <v2o8bd0f97a1005091939nc0de1b9ckf33b402e72983de1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-10 2:44 ` Wolfram Sang
@ 2010-05-28 19:52 ` Valentin Yakovenkov
1 sibling, 0 replies; 5+ messages in thread
From: Valentin Yakovenkov @ 2010-05-28 19:52 UTC (permalink / raw
To: Mike Frysinger
Cc: Wolfram Sang, uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
10.05.2010 6:39, Mike Frysinger wrote:
> i'll pick this up for the next merge window (i.e. the one in a few
> days) if Valentin has no feedback by then
Sorry, it's so much business and emails, so i've just saw this messages.
It's ok.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-28 19:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-04 14:04 [PATCH] blackfin/acvilon: Fix timeout usage for I2C Wolfram Sang
[not found] ` <1270389856-32003-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-10 2:36 ` Wolfram Sang
[not found] ` <20100510023639.GA25544-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-10 2:39 ` [Uclinux-dist-devel] " Mike Frysinger
[not found] ` <v2o8bd0f97a1005091939nc0de1b9ckf33b402e72983de1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-10 2:44 ` Wolfram Sang
2010-05-28 19:52 ` Valentin Yakovenkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.