* Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955
@ 2009-11-18 10:34 Koen Kooi
2009-11-18 11:41 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 7+ messages in thread
From: Koen Kooi @ 2009-11-18 10:34 UTC (permalink / raw
To: openembedded-devel
Hi,
Since 406cd0fee12ad99ba6d6f7d55f743cc4c6697955 broke all
glibc-internal-iconv builds and I'm too lazy/stupid to fix it properly
for uclibc I reverted this commit.
Koen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955
2009-11-18 10:34 Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955 Koen Kooi
@ 2009-11-18 11:41 ` Bernhard Reutner-Fischer
2009-11-18 11:44 ` Leon Woestenberg
0 siblings, 1 reply; 7+ messages in thread
From: Bernhard Reutner-Fischer @ 2009-11-18 11:41 UTC (permalink / raw
To: openembedded-devel
On Wed, Nov 18, 2009 at 11:34:28AM +0100, Koen Kooi wrote:
>Hi,
>
>Since 406cd0fee12ad99ba6d6f7d55f743cc4c6697955 broke all
>glibc-internal-iconv builds and I'm too lazy/stupid to fix it
>properly for uclibc I reverted this commit.
for unpatched uClibc you could just
TARGET_CPPFLAGS += -D_Exit=_exit
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955
2009-11-18 11:41 ` Bernhard Reutner-Fischer
@ 2009-11-18 11:44 ` Leon Woestenberg
2009-11-18 12:30 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 7+ messages in thread
From: Leon Woestenberg @ 2009-11-18 11:44 UTC (permalink / raw
To: openembedded-devel
Hello Bernhard,
On Wed, Nov 18, 2009 at 12:41 PM, Bernhard Reutner-Fischer
<rep.dot.nop@gmail.com> wrote:
> On Wed, Nov 18, 2009 at 11:34:28AM +0100, Koen Kooi wrote:
>>Hi,
>>
>>Since 406cd0fee12ad99ba6d6f7d55f743cc4c6697955 broke all
>>glibc-internal-iconv builds and I'm too lazy/stupid to fix it
>>properly for uclibc I reverted this commit.
>
> for unpatched uClibc you could just
> TARGET_CPPFLAGS += -D_Exit=_exit
>
Thanks, and what's the patched uClibc alternative (and where's the
patch)? It defines _Exit()?
Maybe that's better for OE.
Regards,
--
Leon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955
2009-11-18 11:44 ` Leon Woestenberg
@ 2009-11-18 12:30 ` Bernhard Reutner-Fischer
2009-11-18 22:10 ` Henning Heinold
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Bernhard Reutner-Fischer @ 2009-11-18 12:30 UTC (permalink / raw
To: openembedded-devel
On Wed, Nov 18, 2009 at 12:44:39PM +0100, Leon Woestenberg wrote:
>Hello Bernhard,
>
>On Wed, Nov 18, 2009 at 12:41 PM, Bernhard Reutner-Fischer
><rep.dot.nop@gmail.com> wrote:
>> On Wed, Nov 18, 2009 at 11:34:28AM +0100, Koen Kooi wrote:
>>>Hi,
>>>
>>>Since 406cd0fee12ad99ba6d6f7d55f743cc4c6697955 broke all
>>>glibc-internal-iconv builds and I'm too lazy/stupid to fix it
>>>properly for uclibc I reverted this commit.
>>
>> for unpatched uClibc you could just
>> TARGET_CPPFLAGS += -D_Exit=_exit
>>
>Thanks, and what's the patched uClibc alternative (and where's the
>patch)? It defines _Exit()?
I suggest to just #define it to _exit, yes.
(glibc has it as weak alias but i'd prefer to get away with a define),
like:
_Exit(): define to _exit()
Signed-off-by: Bernhard Reutner-Fischer <me>
---
include/stdlib.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/include/stdlib.h b/include/stdlib.h
index e462c1c..c993f8f 100644
--- a/include/stdlib.h
+++ b/include/stdlib.h
@@ -545,12 +545,14 @@ extern void exit (int __status) __THROW
__attribute__ ((__noreturn__));
libc_hidden_proto(exit)
__END_NAMESPACE_STD
-#ifdef __USE_ISOC99
+#if 0 /* def __USE_ISOC99 */
__BEGIN_NAMESPACE_C99
/* Terminate the program with STATUS without calling any of the
functions registered with `atexit' or `on_exit'. */
extern void _Exit (int __status) __THROW __attribute__
((__noreturn__));
__END_NAMESPACE_C99
+#else
+# define _Exit _exit
#endif
--
1.6.5.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955
2009-11-18 12:30 ` Bernhard Reutner-Fischer
@ 2009-11-18 22:10 ` Henning Heinold
2009-11-19 15:40 ` Bernhard Reutner-Fischer
2010-01-23 10:02 ` Holger Hans Peter Freyther
2 siblings, 0 replies; 7+ messages in thread
From: Henning Heinold @ 2009-11-18 22:10 UTC (permalink / raw
To: openembedded-devel
Hi Bernhard,
thanks for the patch, but _exit is not the problem. Problem is crappy iconv stuff.
But I will fix it now the right way.
Bye Henning
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955
2009-11-18 12:30 ` Bernhard Reutner-Fischer
2009-11-18 22:10 ` Henning Heinold
@ 2009-11-19 15:40 ` Bernhard Reutner-Fischer
2010-01-23 10:02 ` Holger Hans Peter Freyther
2 siblings, 0 replies; 7+ messages in thread
From: Bernhard Reutner-Fischer @ 2009-11-19 15:40 UTC (permalink / raw
To: openembedded-devel
On Wed, Nov 18, 2009 at 01:30:12PM +0100, Bernhard Reutner-Fischer wrote:
>On Wed, Nov 18, 2009 at 12:44:39PM +0100, Leon Woestenberg wrote:
>>Hello Bernhard,
>>
>>On Wed, Nov 18, 2009 at 12:41 PM, Bernhard Reutner-Fischer
>><rep.dot.nop@gmail.com> wrote:
>>> On Wed, Nov 18, 2009 at 11:34:28AM +0100, Koen Kooi wrote:
>>>>Hi,
>>>>
>>>>Since 406cd0fee12ad99ba6d6f7d55f743cc4c6697955 broke all
>>>>glibc-internal-iconv builds and I'm too lazy/stupid to fix it
>>>>properly for uclibc I reverted this commit.
>>>
>>> for unpatched uClibc you could just
>>> TARGET_CPPFLAGS += -D_Exit=_exit
>>>
>>Thanks, and what's the patched uClibc alternative (and where's the
>>patch)? It defines _Exit()?
>
>I suggest to just #define it to _exit, yes.
>(glibc has it as weak alias but i'd prefer to get away with a define),
>like:
>
>_Exit(): define to _exit()
OTOH someone may want to override it locally, so to play safe let's
follow suite:
http://git.uclibc.org/uClibc/commit/?h=0_9_30&id=e4adfdc4128c5909adeefecdaf870e30172922a9
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955
2009-11-18 12:30 ` Bernhard Reutner-Fischer
2009-11-18 22:10 ` Henning Heinold
2009-11-19 15:40 ` Bernhard Reutner-Fischer
@ 2010-01-23 10:02 ` Holger Hans Peter Freyther
2 siblings, 0 replies; 7+ messages in thread
From: Holger Hans Peter Freyther @ 2010-01-23 10:02 UTC (permalink / raw
To: openembedded-devel
On Wednesday 18 November 2009 13:30:12 Bernhard Reutner-Fischer wrote:
> I suggest to just #define it to _exit, yes.
> (glibc has it as weak alias but i'd prefer to get away with a define),
> like:
Two things..
1.) The patch can not be applied as someone's mailer has linewrapped it
2.) Does the issue still apply?
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-01-23 10:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 10:34 Revert of 406cd0fee12ad99ba6d6f7d55f743cc4c6697955 Koen Kooi
2009-11-18 11:41 ` Bernhard Reutner-Fischer
2009-11-18 11:44 ` Leon Woestenberg
2009-11-18 12:30 ` Bernhard Reutner-Fischer
2009-11-18 22:10 ` Henning Heinold
2009-11-19 15:40 ` Bernhard Reutner-Fischer
2010-01-23 10:02 ` Holger Hans Peter Freyther
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.