* [PATCH] atmel_lcdfb: Correct fifo size for some products
@ 2009-05-15 10:34 ` Nicolas Ferre
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2009-05-15 10:34 UTC (permalink / raw
To: Andrew Morton, Andrew Victor; +Cc: linux-fbdev-devel, Haavard Skinnemoen
Remove wrong fifo size definition for some AT91 products.
Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
the same fifo size of 512 words.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Can we consider this fix for .30-final ?
drivers/video/atmel_lcdfb.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 9a577a8..2fb63f6 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -29,14 +29,8 @@
/* configurable parameters */
#define ATMEL_LCDC_CVAL_DEFAULT 0xc8
-#define ATMEL_LCDC_DMA_BURST_LEN 8
-
-#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \
- defined(CONFIG_ARCH_AT91SAM9RL)
-#define ATMEL_LCDC_FIFO_SIZE 2048
-#else
-#define ATMEL_LCDC_FIFO_SIZE 512
-#endif
+#define ATMEL_LCDC_DMA_BURST_LEN 8 /* words */
+#define ATMEL_LCDC_FIFO_SIZE 512 /* words */
#if defined(CONFIG_ARCH_AT91)
#define ATMEL_LCDFB_FBINFO_DEFAULT (FBINFO_DEFAULT \
--
1.5.3.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] atmel_lcdfb: Correct fifo size for some products
@ 2009-05-15 10:34 ` Nicolas Ferre
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2009-05-15 10:34 UTC (permalink / raw
To: Andrew Morton, Andrew Victor; +Cc: linux-fbdev-devel, Haavard Skinnemoen
Remove wrong fifo size definition for some AT91 products.
Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
the same fifo size of 512 words.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Can we consider this fix for .30-final ?
drivers/video/atmel_lcdfb.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 9a577a8..2fb63f6 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -29,14 +29,8 @@
/* configurable parameters */
#define ATMEL_LCDC_CVAL_DEFAULT 0xc8
-#define ATMEL_LCDC_DMA_BURST_LEN 8
-
-#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \
- defined(CONFIG_ARCH_AT91SAM9RL)
-#define ATMEL_LCDC_FIFO_SIZE 2048
-#else
-#define ATMEL_LCDC_FIFO_SIZE 512
-#endif
+#define ATMEL_LCDC_DMA_BURST_LEN 8 /* words */
+#define ATMEL_LCDC_FIFO_SIZE 512 /* words */
#if defined(CONFIG_ARCH_AT91)
#define ATMEL_LCDFB_FBINFO_DEFAULT (FBINFO_DEFAULT \
--
1.5.3.7
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] atmel_lcdfb: Correct fifo size for some products
2009-05-15 10:34 ` Nicolas Ferre
(?)
@ 2009-05-19 8:02 ` Haavard Skinnemoen
-1 siblings, 0 replies; 6+ messages in thread
From: Haavard Skinnemoen @ 2009-05-19 8:02 UTC (permalink / raw
To: Nicolas Ferre
Cc: Haavard, Andrew Morton, linux-fbdev-devel, Andrew Victor,
Skinnemoen
Nicolas Ferre wrote:
> Remove wrong fifo size definition for some AT91 products.
>
> Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
> has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
> the same fifo size of 512 words.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Can we consider this fix for .30-final ?
Fine by me as it doesn't affect AVR32 in any way.
Haavard
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables
unlimited royalty-free distribution of the report engine
for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atmel_lcdfb: Correct fifo size for some products
2009-05-15 10:34 ` Nicolas Ferre
(?)
(?)
@ 2009-05-28 7:35 ` Andrew Morton
2009-06-08 15:36 ` Nicolas Ferre
-1 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2009-05-28 7:35 UTC (permalink / raw
To: Nicolas Ferre; +Cc: Andrew Victor, linux-fbdev-devel, Haavard Skinnemoen
On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Remove wrong fifo size definition for some AT91 products.
>
> Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
> has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
> the same fifo size of 512 words.
>
Changelog fails to describe the impact of the bug, so people who are
working out which kernel versions it should be ported into don't know
what to do.
Furthermore, people who are hitting a bug in this driver in older
kernel versions will have difficulty working out whether this patch
might fix their bug.
> Can we consider this fix for .30-final ?
Sure, but for what reason?
What about 2.6.29.x, 2.6.28.x, earlier?
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -29,14 +29,8 @@
>
> /* configurable parameters */
> #define ATMEL_LCDC_CVAL_DEFAULT 0xc8
> -#define ATMEL_LCDC_DMA_BURST_LEN 8
> -
> -#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \
> - defined(CONFIG_ARCH_AT91SAM9RL)
> -#define ATMEL_LCDC_FIFO_SIZE 2048
> -#else
> -#define ATMEL_LCDC_FIFO_SIZE 512
> -#endif
> +#define ATMEL_LCDC_DMA_BURST_LEN 8 /* words */
> +#define ATMEL_LCDC_FIFO_SIZE 512 /* words */
>
> #if defined(CONFIG_ARCH_AT91)
> #define ATMEL_LCDFB_FBINFO_DEFAULT (FBINFO_DEFAULT \
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atmel_lcdfb: Correct fifo size for some products
2009-05-28 7:35 ` Andrew Morton
@ 2009-06-08 15:36 ` Nicolas Ferre
2009-06-09 0:21 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Ferre @ 2009-06-08 15:36 UTC (permalink / raw
To: Andrew Morton, Greg Kroah-Hartman
Cc: Andrew Victor, linux-fbdev-devel, Haavard Skinnemoen
Andrew Morton :
> On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> Remove wrong fifo size definition for some AT91 products.
>>
>> Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
>> has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
>> the same fifo size of 512 words.
>>
>
> Changelog fails to describe the impact of the bug, so people who are
> working out which kernel versions it should be ported into don't know
> what to do.
>
> Furthermore, people who are hitting a bug in this driver in older
> kernel versions will have difficulty working out whether this patch
> might fix their bug.
Ok, you are right, I will try to add some information.
In fact, if you mis-configure the fifo watermark making it too high you
end without the capacity of issuing burst transfers on the internal AHB
bus. This will decrease overall system performance as the LCD will ask
for data as soon as the fifo will have one byte available (not efficient
single accesses).
>> Can we consider this fix for .30-final ?
>
> Sure, but for what reason?
>
> What about 2.6.29.x, 2.6.28.x, earlier?
Indeed, should be valuable to extend this correction to stable kernel
series. I added Greg to the loop for this purpose.
>> --- a/drivers/video/atmel_lcdfb.c
>> +++ b/drivers/video/atmel_lcdfb.c
>> @@ -29,14 +29,8 @@
>>
>> /* configurable parameters */
>> #define ATMEL_LCDC_CVAL_DEFAULT 0xc8
>> -#define ATMEL_LCDC_DMA_BURST_LEN 8
>> -
>> -#if defined(CONFIG_ARCH_AT91SAM9263) || defined(CONFIG_ARCH_AT91CAP9) || \
>> - defined(CONFIG_ARCH_AT91SAM9RL)
>> -#define ATMEL_LCDC_FIFO_SIZE 2048
>> -#else
>> -#define ATMEL_LCDC_FIFO_SIZE 512
>> -#endif
>> +#define ATMEL_LCDC_DMA_BURST_LEN 8 /* words */
>> +#define ATMEL_LCDC_FIFO_SIZE 512 /* words */
>>
>> #if defined(CONFIG_ARCH_AT91)
>> #define ATMEL_LCDFB_FBINFO_DEFAULT (FBINFO_DEFAULT \
Thanks to have taken immediately this patch into account ; even before
my late explanation ;-)
Best regards,
--
Nicolas Ferre
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atmel_lcdfb: Correct fifo size for some products
2009-06-08 15:36 ` Nicolas Ferre
@ 2009-06-09 0:21 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2009-06-09 0:21 UTC (permalink / raw
To: Nicolas Ferre
Cc: Andrew Morton, linux-fbdev-devel, Andrew Victor,
Haavard Skinnemoen
On Mon, Jun 08, 2009 at 05:36:20PM +0200, Nicolas Ferre wrote:
> Andrew Morton :
> > On Fri, 15 May 2009 12:34:18 +0200 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> >
> >> Remove wrong fifo size definition for some AT91 products.
> >>
> >> Due to a misunderstanding of some AT91 datasheets, a fifo size of 2048 (words)
> >> has been introduced by mistake. In fact, all products (AT91/AT32) are sharing
> >> the same fifo size of 512 words.
> >>
> >
> > Changelog fails to describe the impact of the bug, so people who are
> > working out which kernel versions it should be ported into don't know
> > what to do.
> >
> > Furthermore, people who are hitting a bug in this driver in older
> > kernel versions will have difficulty working out whether this patch
> > might fix their bug.
>
> Ok, you are right, I will try to add some information.
>
> In fact, if you mis-configure the fifo watermark making it too high you
> end without the capacity of issuing burst transfers on the internal AHB
> bus. This will decrease overall system performance as the LCD will ask
> for data as soon as the fifo will have one byte available (not efficient
> single accesses).
>
> >> Can we consider this fix for .30-final ?
> >
> > Sure, but for what reason?
> >
> > What about 2.6.29.x, 2.6.28.x, earlier?
>
> Indeed, should be valuable to extend this correction to stable kernel
> series. I added Greg to the loop for this purpose.
For stable stuff, please send any requested patches, with the git commit
id of the patch in Linus's tree, to stable@kernel.org, otherwise I might
miss it :)
Also, you can add:
Cc: stable <stable@kernel.org>
to the signed-off-by area of the patch, and when it is taken into
Linus's tree, the stable team will automatically get notified of it and
include it in the next stable releases without any other work needed to
be done by you.
hope this helps,
greg k-h
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-06-09 1:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-15 10:34 [PATCH] atmel_lcdfb: Correct fifo size for some products Nicolas Ferre
2009-05-15 10:34 ` Nicolas Ferre
2009-05-19 8:02 ` Haavard Skinnemoen
2009-05-28 7:35 ` Andrew Morton
2009-06-08 15:36 ` Nicolas Ferre
2009-06-09 0:21 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.