From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org,
Randy Dunlap <randy.dunlap@oracle.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][mmtom] clean up once printk routine
Date: Tue, 26 May 2009 15:52:32 +0900 (JST) [thread overview]
Message-ID: <20090526155155.6871.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090526135733.3c38f758.minchan.kim@barrios-desktop>
> == CUT HERE ==
>
> There are some places to be able to use printk_once instead of hard coding.
>
> It will help code readability and maintenance.
> This patch doesn't change function's behavior.
>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> CC: Dominik Brodowski <linux@dominikbrodowski.net>
> CC: David S. Miller <davem@davemloft.net>
> CC: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/kernel/cpu/common.c | 8 ++------
> drivers/net/3c515.c | 7 ++-----
> drivers/pcmcia/pcmcia_ioctl.c | 9 +++------
> 3 files changed, 7 insertions(+), 17 deletions(-)
Please separete to three patches ;)
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org,
Randy Dunlap <randy.dunlap@oracle.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][mmtom] clean up once printk routine
Date: Tue, 26 May 2009 15:52:32 +0900 (JST) [thread overview]
Message-ID: <20090526155155.6871.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090526135733.3c38f758.minchan.kim@barrios-desktop>
> == CUT HERE ==
>
> There are some places to be able to use printk_once instead of hard coding.
>
> It will help code readability and maintenance.
> This patch doesn't change function's behavior.
>
> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> CC: Dominik Brodowski <linux@dominikbrodowski.net>
> CC: David S. Miller <davem@davemloft.net>
> CC: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/kernel/cpu/common.c | 8 ++------
> drivers/net/3c515.c | 7 ++-----
> drivers/pcmcia/pcmcia_ioctl.c | 9 +++------
> 3 files changed, 7 insertions(+), 17 deletions(-)
Please separete to three patches ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-26 6:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 4:57 [PATCH][mmtom] clean up once printk routine Minchan Kim
2009-05-26 6:52 ` KOSAKI Motohiro [this message]
2009-05-26 6:52 ` KOSAKI Motohiro
2009-05-26 6:59 ` Minchan Kim
2009-05-26 6:59 ` Minchan Kim
2009-05-26 20:41 ` Andrew Morton
2009-05-26 20:41 ` Andrew Morton
2009-05-26 23:31 ` [PATCH][mmtom] clean up printk_once of get_cpu_vendor Minchan Kim
2009-05-26 23:31 ` Minchan Kim
2009-05-26 8:35 ` [PATCH][mmtom] clean up once printk routine Pavel Machek
2009-05-26 8:35 ` Pavel Machek
2009-05-26 9:40 ` Minchan Kim
2009-05-26 9:40 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526155155.6871.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@dominikbrodowski.net \
--cc=minchan.kim@gmail.com \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.