From: Minchan Kim <minchan.kim@gmail.com>
To: akpm@linux-foundation.org
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH][mmtom] clean up once printk routine
Date: Tue, 26 May 2009 13:57:33 +0900 [thread overview]
Message-ID: <20090526135733.3c38f758.minchan.kim@barrios-desktop> (raw)
On Tue, 26 May 2009 12:29:34 +0900
Paul Mundt <lethal@linux-sh.org> wrote:
> On Sun, May 24, 2009 at 07:42:02PM -0700, Randy Dunlap wrote:
> > KOSAKI Motohiro wrote:
> > >> + if (!printed) {
> > >> + printed = 1;
> > >> + printk(KERN_WARNING "All of swap is in use. Some pages cannot be swapped out.");
> > >> + }
> > >
> > > Why don't you use WARN_ONCE()?
> >
> > Someone earlier in this patch thread (maybe Pavel?) commented that
> > WARN_ONCE() would cause a stack dump and that would be too harsh,
> > especially for users. I.e., just the message is needed here, not a
> > stack dump.
> >
> Note that this is precisely what we have printk_once() for these days,
> which will do what this patch is doing already. Of course if the variable
> will be reset, then it is best left as is.
Yes. There are also some places to be able to use printk_once().
Are there any place I missed ?
== CUT HERE ==
There are some places to be able to use printk_once instead of hard coding.
It will help code readability and maintenance.
This patch doesn't change function's behavior.
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
CC: Dominik Brodowski <linux@dominikbrodowski.net>
CC: David S. Miller <davem@davemloft.net>
CC: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/common.c | 8 ++------
drivers/net/3c515.c | 7 ++-----
drivers/pcmcia/pcmcia_ioctl.c | 9 +++------
3 files changed, 7 insertions(+), 17 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 82bec86..dc0f694 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -496,13 +496,9 @@ static void __cpuinit get_cpu_vendor(struct cpuinfo_x86 *c)
}
}
- if (!printed) {
- printed++;
- printk(KERN_ERR
+ printk_once(KERN_ERR
"CPU: vendor_id '%s' unknown, using generic init.\n", v);
-
- printk(KERN_ERR "CPU: Your system may be unstable.\n");
- }
+ printk_once(KERN_ERR "CPU: Your system may be unstable.\n");
c->x86_vendor = X86_VENDOR_UNKNOWN;
this_cpu = &default_cpu;
diff --git a/drivers/net/3c515.c b/drivers/net/3c515.c
index 167bf23..0450605 100644
--- a/drivers/net/3c515.c
+++ b/drivers/net/3c515.c
@@ -430,15 +430,12 @@ int init_module(void)
struct net_device *tc515_probe(int unit)
{
struct net_device *dev = corkscrew_scan(unit);
- static int printed;
if (!dev)
return ERR_PTR(-ENODEV);
- if (corkscrew_debug > 0 && !printed) {
- printed = 1;
- printk(version);
- }
+ if (corkscrew_debug > 0)
+ printk_once(version);
return dev;
}
diff --git a/drivers/pcmcia/pcmcia_ioctl.c b/drivers/pcmcia/pcmcia_ioctl.c
index 1703b20..78af368 100644
--- a/drivers/pcmcia/pcmcia_ioctl.c
+++ b/drivers/pcmcia/pcmcia_ioctl.c
@@ -915,12 +915,9 @@ static int ds_ioctl(struct inode * inode, struct file * file,
err = -EPERM;
goto free_out;
} else {
- static int printed = 0;
- if (!printed) {
- printk(KERN_WARNING "2.6. kernels use pcmciamtd instead of memory_cs.c and do not require special\n");
- printk(KERN_WARNING "MTD handling any more.\n");
- printed++;
- }
+ printk_once(KERN_WARNING
+ "2.6. kernels use pcmciamtd instead of memory_cs.c and do not require special\n");
+ printk_once(KERN_WARNING "MTD handling any more.\n");
}
err = -EINVAL;
goto free_out;
--
1.5.4.3
--
Kinds Regards
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-05-26 4:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 4:57 Minchan Kim [this message]
2009-05-26 6:52 ` [PATCH][mmtom] clean up once printk routine KOSAKI Motohiro
2009-05-26 6:52 ` KOSAKI Motohiro
2009-05-26 6:59 ` Minchan Kim
2009-05-26 6:59 ` Minchan Kim
2009-05-26 20:41 ` Andrew Morton
2009-05-26 20:41 ` Andrew Morton
2009-05-26 23:31 ` [PATCH][mmtom] clean up printk_once of get_cpu_vendor Minchan Kim
2009-05-26 23:31 ` Minchan Kim
2009-05-26 8:35 ` [PATCH][mmtom] clean up once printk routine Pavel Machek
2009-05-26 8:35 ` Pavel Machek
2009-05-26 9:40 ` Minchan Kim
2009-05-26 9:40 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526135733.3c38f758.minchan.kim@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.