All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/4] b43legacy: fix led naming
@ 2009-01-31 14:52 Danny Kukawka
  2009-01-31 16:28 ` Larry Finger
  0 siblings, 1 reply; 2+ messages in thread
From: Danny Kukawka @ 2009-01-31 14:52 UTC (permalink / raw
  To: linux-wireless; +Cc: Helmut Schaa

From: Danny Kukawka <dkukawka@suse.de>
Subject: b43legacy: fix led naming

Fixed led device naming for the b43legacy driver. Due to the
documentation of the led subsystem/class the naming should be
"devicename:colour:function" while not applying sections
should be left blank.
    
This should lead to e.g. "b43legacy-%s::rx" instead of 
"b43legacy-%s:rx".

Signed-off-by: Danny Kukawka <dkukawka@suse.de>
--
 leds.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/b43legacy/leds.c b/drivers/net/wireless/b43legacy/leds.c
index cacb786..cb4511f 100644
--- a/drivers/net/wireless/b43legacy/leds.c
+++ b/drivers/net/wireless/b43legacy/leds.c
@@ -146,12 +146,12 @@ static void b43legacy_map_led(struct b43legacy_wldev *dev,
 	case B43legacy_LED_TRANSFER:
 	case B43legacy_LED_APTRANSFER:
 		snprintf(name, sizeof(name),
-			 "b43legacy-%s:tx", wiphy_name(hw->wiphy));
+			 "b43legacy-%s::tx", wiphy_name(hw->wiphy));
 		b43legacy_register_led(dev, &dev->led_tx, name,
 				 ieee80211_get_tx_led_name(hw),
 				 led_index, activelow);
 		snprintf(name, sizeof(name),
-			 "b43legacy-%s:rx", wiphy_name(hw->wiphy));
+			 "b43legacy-%s::rx", wiphy_name(hw->wiphy));
 		b43legacy_register_led(dev, &dev->led_rx, name,
 				 ieee80211_get_rx_led_name(hw),
 				 led_index, activelow);
@@ -161,7 +161,7 @@ static void b43legacy_map_led(struct b43legacy_wldev *dev,
 	case B43legacy_LED_RADIO_B:
 	case B43legacy_LED_MODE_BG:
 		snprintf(name, sizeof(name),
-			 "b43legacy-%s:radio", wiphy_name(hw->wiphy));
+			 "b43legacy-%s::radio", wiphy_name(hw->wiphy));
 		b43legacy_register_led(dev, &dev->led_radio, name,
 				 b43legacy_rfkill_led_name(dev),
 				 led_index, activelow);
@@ -172,7 +172,7 @@ static void b43legacy_map_led(struct b43legacy_wldev *dev,
 	case B43legacy_LED_WEIRD:
 	case B43legacy_LED_ASSOC:
 		snprintf(name, sizeof(name),
-			 "b43legacy-%s:assoc", wiphy_name(hw->wiphy));
+			 "b43legacy-%s::assoc", wiphy_name(hw->wiphy));
 		b43legacy_register_led(dev, &dev->led_assoc, name,
 				 ieee80211_get_assoc_led_name(hw),
 				 led_index, activelow);

-- 
Danny Kukawka
dkukawka@suse.de
R&D Team Mobile Devices
SUSE LINUX a Novell Business
Maxfeldstr. 5, D-90409 Nuernberg, Germany
SUSE LINUX Products GmbH, Nuernberg; GF: Markus Rex, HRB 16746 (AG Nuernberg)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/4] b43legacy: fix led naming
  2009-01-31 14:52 [PATCH 2/4] b43legacy: fix led naming Danny Kukawka
@ 2009-01-31 16:28 ` Larry Finger
  0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2009-01-31 16:28 UTC (permalink / raw
  To: Danny Kukawka; +Cc: linux-wireless, Helmut Schaa

Danny Kukawka wrote:
> From: Danny Kukawka <dkukawka@suse.de>
> Subject: b43legacy: fix led naming
> 
> Fixed led device naming for the b43legacy driver. Due to the
> documentation of the led subsystem/class the naming should be
> "devicename:colour:function" while not applying sections
> should be left blank.
>     
> This should lead to e.g. "b43legacy-%s::rx" instead of 
> "b43legacy-%s:rx".
> 
> Signed-off-by: Danny Kukawka <dkukawka@suse.de>
> --
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-31 16:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-31 14:52 [PATCH 2/4] b43legacy: fix led naming Danny Kukawka
2009-01-31 16:28 ` Larry Finger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.