* [2.6 patch] mtd: make onenand_scan_bbt() static
@ 2008-04-14 14:20 Adrian Bunk
2008-04-22 14:57 ` David Woodhouse
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-04-14 14:20 UTC (permalink / raw
To: dwmw2; +Cc: linux-mtd, linux-kernel
This patch makes the needlessly global onenand_scan_bbt() static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/mtd/onenand/onenand_bbt.c | 3 +--
include/linux/mtd/bbm.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
c54bdc9336c6627a6baa5d268edb41563451f191 diff --git a/drivers/mtd/onenand/onenand_bbt.c b/drivers/mtd/onenand/onenand_bbt.c
index aecdd50..1d590cd 100644
--- a/drivers/mtd/onenand/onenand_bbt.c
+++ b/drivers/mtd/onenand/onenand_bbt.c
@@ -175,7 +175,7 @@ static int onenand_isbad_bbt(struct mtd_info *mtd, loff_t offs, int allowbbt)
* by the onenand_release function.
*
*/
-int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
+static int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
{
struct onenand_chip *this = mtd->priv;
struct bbm_info *bbm = this->bbm;
@@ -246,5 +246,4 @@ int onenand_default_bbt(struct mtd_info *mtd)
return onenand_scan_bbt(mtd, bbm->badblock_pattern);
}
-EXPORT_SYMBOL(onenand_scan_bbt);
EXPORT_SYMBOL(onenand_default_bbt);
diff --git a/include/linux/mtd/bbm.h b/include/linux/mtd/bbm.h
index fff8c53..0c07c7a 100644
--- a/include/linux/mtd/bbm.h
+++ b/include/linux/mtd/bbm.h
@@ -126,7 +126,6 @@ struct bbm_info {
};
/* OneNAND BBT interface */
-extern int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd);
extern int onenand_default_bbt(struct mtd_info *mtd);
#endif /* __LINUX_MTD_BBM_H */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] mtd: make onenand_scan_bbt() static
2008-04-14 14:20 [2.6 patch] mtd: make onenand_scan_bbt() static Adrian Bunk
@ 2008-04-22 14:57 ` David Woodhouse
0 siblings, 0 replies; 2+ messages in thread
From: David Woodhouse @ 2008-04-22 14:57 UTC (permalink / raw
To: Adrian Bunk; +Cc: linux-mtd, linux-kernel
On Mon, 2008-04-14 at 17:20 +0300, Adrian Bunk wrote:
> This patch makes the needlessly global onenand_scan_bbt() static.
Nak. It's not unlikely that a board driver will need this. It just
introduces a gratuitous difference between NAND and OneNAND.
--
dwmw2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-22 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-14 14:20 [2.6 patch] mtd: make onenand_scan_bbt() static Adrian Bunk
2008-04-22 14:57 ` David Woodhouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.