* [2.6 patch] mn10300: export kernel_thread
@ 2008-04-14 14:19 Adrian Bunk
2008-04-14 15:14 ` David Howells
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2008-04-14 14:19 UTC (permalink / raw
To: dhowells, yasutake.koichi; +Cc: linux-am33-list, linux-kernel
This patch fixes the following build error:
<-- snip -->
...
MODPOST 1256 modules
ERROR: "kernel_thread" [net/sunrpc/sunrpc.ko] undefined!
ERROR: "kernel_thread" [net/ipv4/ipvs/ip_vs.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/hidp/hidp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/cmtp/cmtp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/bnep/bnep.ko] undefined!
ERROR: "kernel_thread" [fs/nfs/nfs.ko] undefined!
ERROR: "kernel_thread" [fs/lockd/lockd.ko] undefined!
ERROR: "kernel_thread" [fs/jffs2/jffs2.ko] undefined!
ERROR: "kernel_thread" [drivers/usb/atm/usbatm.ko] undefined!
...
make[2]: *** [__modpost] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
ca4c4f445e4b7cfbedc815cfc08ab2c70581c774 diff --git a/arch/mn10300/kernel/process.c b/arch/mn10300/kernel/process.c
index 3b0d579..194574e 100644
--- a/arch/mn10300/kernel/process.c
+++ b/arch/mn10300/kernel/process.c
@@ -154,6 +154,7 @@ int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
return do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0, ®s, 0,
NULL, NULL);
}
+EXPORT_SYMBOL_GPL(kernel_thread);
/*
* free current thread data structures etc..
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [2.6 patch] mn10300: export kernel_thread
2008-04-14 14:19 [2.6 patch] mn10300: export kernel_thread Adrian Bunk
@ 2008-04-14 15:14 ` David Howells
2008-04-14 18:42 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: David Howells @ 2008-04-14 15:14 UTC (permalink / raw
To: Adrian Bunk; +Cc: dhowells, yasutake.koichi, linux-am33-list, linux-kernel
Adrian Bunk <bunk@kernel.org> wrote:
> +EXPORT_SYMBOL_GPL(kernel_thread);
Please use EXPORT_SYMBOL() to be consistent with the other archs, but apart
from that, it looks fine.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] mn10300: export kernel_thread
2008-04-14 15:14 ` David Howells
@ 2008-04-14 18:42 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-04-14 18:42 UTC (permalink / raw
To: David Howells; +Cc: yasutake.koichi, linux-am33-list, linux-kernel
On Mon, Apr 14, 2008 at 04:14:29PM +0100, David Howells wrote:
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > +EXPORT_SYMBOL_GPL(kernel_thread);
>
> Please use EXPORT_SYMBOL() to be consistent with the other archs, but apart
> from that, it looks fine.
Updated patch below.
> David
cu
Adrian
<-- snip -->
This patch fixes the following build error:
<-- snip -->
...
MODPOST 1256 modules
ERROR: "kernel_thread" [net/sunrpc/sunrpc.ko] undefined!
ERROR: "kernel_thread" [net/ipv4/ipvs/ip_vs.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/hidp/hidp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/cmtp/cmtp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/bnep/bnep.ko] undefined!
ERROR: "kernel_thread" [fs/nfs/nfs.ko] undefined!
ERROR: "kernel_thread" [fs/lockd/lockd.ko] undefined!
ERROR: "kernel_thread" [fs/jffs2/jffs2.ko] undefined!
ERROR: "kernel_thread" [drivers/usb/atm/usbatm.ko] undefined!
...
make[2]: *** [__modpost] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
29ac94237884159dbf941c276daf4d3dbe3cf2a5 diff --git a/arch/mn10300/kernel/process.c b/arch/mn10300/kernel/process.c
index 3b0d579..345dadb 100644
--- a/arch/mn10300/kernel/process.c
+++ b/arch/mn10300/kernel/process.c
@@ -154,6 +154,7 @@ int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
return do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0, ®s, 0,
NULL, NULL);
}
+EXPORT_SYMBOL(kernel_thread);
/*
* free current thread data structures etc..
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [2.6 patch] mn10300: export kernel_thread
@ 2008-06-12 22:11 Adrian Bunk
2008-06-13 13:11 ` David Howells
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2008-06-12 22:11 UTC (permalink / raw
To: dhowells, yasutake.koichi; +Cc: linux-am33-list, linux-kernel, Andrew Morton
This patch fixes thefollowing build error:
<-- snip -->
...
MODPOST 1310 modules
ERROR: "kernel_thread" [net/sunrpc/sunrpc.ko] undefined!
ERROR: "kernel_thread" [net/ipv4/ipvs/ip_vs.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/hidp/hidp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/cmtp/cmtp.ko] undefined!
ERROR: "kernel_thread" [net/bluetooth/bnep/bnep.ko] undefined!
ERROR: "kernel_thread" [fs/nfs/nfs.ko] undefined!
ERROR: "kernel_thread" [fs/lockd/lockd.ko] undefined!
ERROR: "kernel_thread" [fs/jffs2/jffs2.ko] undefined!
...
WARNING: modpost: Found 2 section mismatch(es).
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/mn10300/kernel/mn10300_ksyms.c | 3 +++
1 file changed, 3 insertions(+)
f6120ef1dbb0831e753b6f241bbca4600aa94c10 diff --git a/arch/mn10300/kernel/mn10300_ksyms.c b/arch/mn10300/kernel/mn10300_ksyms.c
index 6d19628..aba584a 100644
--- a/arch/mn10300/kernel/mn10300_ksyms.c
+++ b/arch/mn10300/kernel/mn10300_ksyms.c
@@ -10,6 +10,7 @@
*/
#include <linux/module.h>
#include <asm/uaccess.h>
+#include <asm/processor.h>
EXPORT_SYMBOL(change_bit);
@@ -35,3 +36,5 @@ EXPORT_SYMBOL(__ashrdi3);
EXPORT_SYMBOL(__ashldi3);
EXPORT_SYMBOL(__lshrdi3);
EXPORT_SYMBOL(__negdi2);
+
+EXPORT_SYMBOL(kernel_thread);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [2.6 patch] mn10300: export kernel_thread
2008-06-12 22:11 Adrian Bunk
@ 2008-06-13 13:11 ` David Howells
2008-06-13 13:22 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: David Howells @ 2008-06-13 13:11 UTC (permalink / raw
To: Adrian Bunk
Cc: dhowells, yasutake.koichi, linux-am33-list, linux-kernel,
Andrew Morton
Adrian Bunk <bunk@kernel.org> wrote:
> --- a/arch/mn10300/kernel/mn10300_ksyms.c
> +++ b/arch/mn10300/kernel/mn10300_ksyms.c
Why put it here? It should really go with the definition of kernel_thread()
in arch/mn10300/kernel/process.c.
I've just posted my own patch to deal with this and empty_zero_page. I also
submitted an additional patch to provide __ucmpdi2() so that allmodconfig
builds for me.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] mn10300: export kernel_thread
2008-06-13 13:11 ` David Howells
@ 2008-06-13 13:22 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-06-13 13:22 UTC (permalink / raw
To: David Howells
Cc: yasutake.koichi, linux-am33-list, linux-kernel, Andrew Morton
On Fri, Jun 13, 2008 at 02:11:16PM +0100, David Howells wrote:
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > --- a/arch/mn10300/kernel/mn10300_ksyms.c
> > +++ b/arch/mn10300/kernel/mn10300_ksyms.c
>
> Why put it here?
Because I was blind....
> It should really go with the definition of kernel_thread()
> in arch/mn10300/kernel/process.c.
>
> I've just posted my own patch to deal with this and empty_zero_page. I also
> submitted an additional patch to provide __ucmpdi2() so that allmodconfig
> builds for me.
Thanks!
> David
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-06-13 13:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-14 14:19 [2.6 patch] mn10300: export kernel_thread Adrian Bunk
2008-04-14 15:14 ` David Howells
2008-04-14 18:42 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2008-06-12 22:11 Adrian Bunk
2008-06-13 13:11 ` David Howells
2008-06-13 13:22 ` Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.