* [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X
@ 2008-04-11 8:32 Jarkko Nikula
2008-04-14 13:50 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Jarkko Nikula @ 2008-04-11 8:32 UTC (permalink / raw
To: alsa-devel; +Cc: Jarkko Nikula
Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
---
sound/soc/codecs/tlv320aic3x.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index e6a730b..630684f 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -661,42 +661,52 @@ struct aic3x_rate_divs {
static const struct aic3x_rate_divs aic3x_divs[] = {
/* 8k */
{12000000, 8000, 48000, 0xa, 16, 3840},
+ {19200000, 8000, 48000, 0xa, 10, 2400},
{22579200, 8000, 48000, 0xa, 8, 7075},
{33868800, 8000, 48000, 0xa, 5, 8049},
/* 11.025k */
{12000000, 11025, 44100, 0x6, 15, 528},
+ {19200000, 11025, 44100, 0x6, 9, 4080},
{22579200, 11025, 44100, 0x6, 8, 0},
{33868800, 11025, 44100, 0x6, 5, 3333},
/* 16k */
{12000000, 16000, 48000, 0x4, 16, 3840},
+ {19200000, 16000, 48000, 0x4, 10, 2400},
{22579200, 16000, 48000, 0x4, 8, 7075},
{33868800, 16000, 48000, 0x4, 5, 8049},
/* 22.05k */
{12000000, 22050, 44100, 0x2, 15, 528},
+ {19200000, 22050, 44100, 0x2, 9, 4080},
{22579200, 22050, 44100, 0x2, 8, 0},
{33868800, 22050, 44100, 0x2, 5, 3333},
/* 32k */
{12000000, 32000, 48000, 0x1, 16, 3840},
+ {19200000, 32000, 48000, 0x1, 10, 2400},
{22579200, 32000, 48000, 0x1, 8, 7075},
{33868800, 32000, 48000, 0x1, 5, 8049},
/* 44.1k */
{12000000, 44100, 44100, 0x0, 15, 528},
+ {19200000, 44100, 44100, 0x0, 9, 4080},
{22579200, 44100, 44100, 0x0, 8, 0},
{33868800, 44100, 44100, 0x0, 5, 3333},
/* 48k */
{12000000, 48000, 48000, 0x0, 16, 3840},
+ {19200000, 48000, 48000, 0x0, 10, 2400},
{22579200, 48000, 48000, 0x0, 8, 7075},
{33868800, 48000, 48000, 0x0, 5, 8049},
/* 64k */
{12000000, 64000, 96000, 0x1, 16, 3840},
+ {19200000, 64000, 96000, 0x1, 10, 2400},
{22579200, 64000, 96000, 0x1, 8, 7075},
{33868800, 64000, 96000, 0x1, 5, 8049},
/* 88.2k */
{12000000, 88200, 88200, 0x0, 15, 528},
+ {19200000, 88200, 88200, 0x0, 9, 4080},
{22579200, 88200, 88200, 0x0, 8, 0},
{33868800, 88200, 88200, 0x0, 5, 3333},
/* 96k */
{12000000, 96000, 96000, 0x0, 16, 3840},
+ {19200000, 96000, 96000, 0x0, 10, 2400},
{22579200, 96000, 96000, 0x0, 8, 7075},
{33868800, 96000, 96000, 0x0, 5, 8049},
};
@@ -818,6 +828,7 @@ static int aic3x_set_dai_sysclk(struct snd_soc_codec_dai *codec_dai,
switch (freq) {
case 12000000:
+ case 19200000:
case 22579200:
case 33868800:
aic3x->sysclk = freq;
--
1.5.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X
@ 2008-04-14 11:34 Mark Brown
2008-04-14 12:29 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2008-04-14 11:34 UTC (permalink / raw
To: Takashi Iwai; +Cc: alsa-devel, Mark Brown, Jarkko Nikula
From: Jarkko Nikula <jarkko.nikula@nokia.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/tlv320aic3x.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index e6a730b..630684f 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -661,42 +661,52 @@ struct aic3x_rate_divs {
static const struct aic3x_rate_divs aic3x_divs[] = {
/* 8k */
{12000000, 8000, 48000, 0xa, 16, 3840},
+ {19200000, 8000, 48000, 0xa, 10, 2400},
{22579200, 8000, 48000, 0xa, 8, 7075},
{33868800, 8000, 48000, 0xa, 5, 8049},
/* 11.025k */
{12000000, 11025, 44100, 0x6, 15, 528},
+ {19200000, 11025, 44100, 0x6, 9, 4080},
{22579200, 11025, 44100, 0x6, 8, 0},
{33868800, 11025, 44100, 0x6, 5, 3333},
/* 16k */
{12000000, 16000, 48000, 0x4, 16, 3840},
+ {19200000, 16000, 48000, 0x4, 10, 2400},
{22579200, 16000, 48000, 0x4, 8, 7075},
{33868800, 16000, 48000, 0x4, 5, 8049},
/* 22.05k */
{12000000, 22050, 44100, 0x2, 15, 528},
+ {19200000, 22050, 44100, 0x2, 9, 4080},
{22579200, 22050, 44100, 0x2, 8, 0},
{33868800, 22050, 44100, 0x2, 5, 3333},
/* 32k */
{12000000, 32000, 48000, 0x1, 16, 3840},
+ {19200000, 32000, 48000, 0x1, 10, 2400},
{22579200, 32000, 48000, 0x1, 8, 7075},
{33868800, 32000, 48000, 0x1, 5, 8049},
/* 44.1k */
{12000000, 44100, 44100, 0x0, 15, 528},
+ {19200000, 44100, 44100, 0x0, 9, 4080},
{22579200, 44100, 44100, 0x0, 8, 0},
{33868800, 44100, 44100, 0x0, 5, 3333},
/* 48k */
{12000000, 48000, 48000, 0x0, 16, 3840},
+ {19200000, 48000, 48000, 0x0, 10, 2400},
{22579200, 48000, 48000, 0x0, 8, 7075},
{33868800, 48000, 48000, 0x0, 5, 8049},
/* 64k */
{12000000, 64000, 96000, 0x1, 16, 3840},
+ {19200000, 64000, 96000, 0x1, 10, 2400},
{22579200, 64000, 96000, 0x1, 8, 7075},
{33868800, 64000, 96000, 0x1, 5, 8049},
/* 88.2k */
{12000000, 88200, 88200, 0x0, 15, 528},
+ {19200000, 88200, 88200, 0x0, 9, 4080},
{22579200, 88200, 88200, 0x0, 8, 0},
{33868800, 88200, 88200, 0x0, 5, 3333},
/* 96k */
{12000000, 96000, 96000, 0x0, 16, 3840},
+ {19200000, 96000, 96000, 0x0, 10, 2400},
{22579200, 96000, 96000, 0x0, 8, 7075},
{33868800, 96000, 96000, 0x0, 5, 8049},
};
@@ -818,6 +828,7 @@ static int aic3x_set_dai_sysclk(struct snd_soc_codec_dai *codec_dai,
switch (freq) {
case 12000000:
+ case 19200000:
case 22579200:
case 33868800:
aic3x->sysclk = freq;
--
1.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X
2008-04-14 11:34 Mark Brown
@ 2008-04-14 12:29 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2008-04-14 12:29 UTC (permalink / raw
To: Mark Brown; +Cc: alsa-devel, Jarkko Nikula
At Mon, 14 Apr 2008 12:34:21 +0100,
Mark Brown wrote:
>
> From: Jarkko Nikula <jarkko.nikula@nokia.com>
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied. Thanks.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X
2008-04-11 8:32 [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X Jarkko Nikula
@ 2008-04-14 13:50 ` Mark Brown
2008-04-15 6:41 ` Jarkko Nikula
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2008-04-14 13:50 UTC (permalink / raw
To: Jarkko Nikula; +Cc: alsa-devel
On Fri, Apr 11, 2008 at 11:32:15AM +0300, Jarkko Nikula wrote:
> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Thanks - I've added this to the ASoC tree and upstream queue.
Rather than maintaining this table it might be worth looking at adding
code to allow the driver to calculate a suitable configuration at run
time. The WM8753 and WM9713 drivers do this for the PLL configuration,
for example.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X
2008-04-14 13:50 ` Mark Brown
@ 2008-04-15 6:41 ` Jarkko Nikula
2008-04-15 12:34 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Jarkko Nikula @ 2008-04-15 6:41 UTC (permalink / raw
To: ext Mark Brown; +Cc: alsa-devel
On Mon, 14 Apr 2008 14:50:46 +0100
"ext Mark Brown" <broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Apr 11, 2008 at 11:32:15AM +0300, Jarkko Nikula wrote:
> > Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
>
> Thanks - I've added this to the ASoC tree and upstream queue.
>
> Rather than maintaining this table it might be worth looking at adding
> code to allow the driver to calculate a suitable configuration at run
> time. The WM8753 and WM9713 drivers do this for the PLL
> configuration, for example.
>
Agree, I was also thinking this some time ago but went for simple
solution first since OMAP's seems to be happy with either 12 or 19.2
MHz :-)
Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X
2008-04-15 6:41 ` Jarkko Nikula
@ 2008-04-15 12:34 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2008-04-15 12:34 UTC (permalink / raw
To: Jarkko Nikula; +Cc: alsa-devel
On Tue, Apr 15, 2008 at 09:41:39AM +0300, Jarkko Nikula wrote:
> "ext Mark Brown" <broonie@opensource.wolfsonmicro.com> wrote:
> > Rather than maintaining this table it might be worth looking at adding
> > code to allow the driver to calculate a suitable configuration at run
> > time. The WM8753 and WM9713 drivers do this for the PLL
> > configuration, for example.
> Agree, I was also thinking this some time ago but went for simple
> solution first since OMAP's seems to be happy with either 12 or 19.2
> MHz :-)
That actually matches our experiences fairly well - most users use one
of a small set of standard inputs. It's only a relatively small
proportion of systems that end up using something unusual.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-04-15 12:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-11 8:32 [PATCH] ASoC: Add support for 19.2 MHz MCLK in TLV320AIC3X Jarkko Nikula
2008-04-14 13:50 ` Mark Brown
2008-04-15 6:41 ` Jarkko Nikula
2008-04-15 12:34 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2008-04-14 11:34 Mark Brown
2008-04-14 12:29 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.