All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Filippo Giunchedi <filippo@debian.org>
To: 322732@bugs.debian.org, 322732-submitter@bugs.debian.org
Cc: bluez-devel@lists.sf.net, control@bugs.debian.org
Subject: [Bluez-devel] more on this bug (was: rfcomm bind fails with obscure error message)
Date: Fri, 19 May 2006 15:48:15 -0500	[thread overview]
Message-ID: <20060519204815.GA8424@esaurito.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

tags 322732 + upstream
thanks

> Hello
> 
> When the 'rfcomm' kernel module isn't compiled with CONFIG_BT_RFCOMM_TTY
> enabled, 'rfcomm bind' will fail with an obscure error message, "Can't
> create device: Operation not supported".  It does this when it's trying to
> bind to a device in /dev.
> 
> Could this be changed to report something more useful, such as "Check
> rfcomm.ko is compiled with TTY support"?

Hi,
I agree with this bug and the ioctl is mostly likely to fail when there is no
rfcomm tty support, here is my proposed patch:

--- rfcomm/main.c       (revision 154)
+++ rfcomm/main.c       (working copy)
@@ -172,8 +172,10 @@
                        req.channel = 1;
        }

-       if ((err = ioctl(ctl, RFCOMMCREATEDEV, &req)) < 0 )
+       if ((err = ioctl(ctl, RFCOMMCREATEDEV, &req)) < 0 ){
                perror("Can't create device");
+               fprintf(stderr, "Check RFCOMM TTY availabily");
+    }

        return err;
 }

comments? 

thanks,
filippo
--
Filippo Giunchedi - http://esaurito.net
PGP key: 0x6B79D401
random quote follows:

What a strange illusion it is to suppose that beauty is goodness.
-- Lev Tolstoj

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2006-05-19 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-19 20:48 Filippo Giunchedi [this message]
2006-05-29 13:16 ` [Pkg-bluetooth-maintainers] Bug#322732: [Bluez-devel] more on this bug (was: rfcomm bind fails with obscure error message) Marcel Holtmann
2006-06-04 15:15   ` Bug#322732: " Filippo Giunchedi
2006-06-04 15:46     ` Bug#322732: [Bluez-devel] [Pkg-bluetooth-maintainers] Bug#322732: " Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060519204815.GA8424@esaurito.net \
    --to=filippo@debian.org \
    --cc=322732-submitter@bugs.debian.org \
    --cc=322732@bugs.debian.org \
    --cc=bluez-devel@lists.sf.net \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=control@bugs.debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.