* [PATCH] Small fix for shadow_remove_all_access_in_page
@ 2005-09-13 2:38 Michael Vrable
2005-09-13 9:15 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Michael Vrable @ 2005-09-13 2:38 UTC (permalink / raw
To: xen-devel
Here's a fairly simple patch to correct a bug I hit when experimenting
with VM forking earlier. Let me know if there's anything wrong with the
changeset; this is the first time I've tried exporting a changeset from
Mercurial.
--Michael Vrable
# HG changeset patch
# User Michael Vrable <mvrable@cs.ucsd.edu>
# Node ID df9609e384a4a819a69d01556b8231b842b04050
# Parent d8637529dafff3c610e4bb31349d4ae00a23a18e
Fix a bug in shadow_remove_all_access_in_page.
Fixes a fairly obvious bug, in which an if statement was reversed. The
bug has been present for a while, so apparently this code isn't well
tested.
Signed-off-by: Michael Vrable <mvrable@cs.ucsd.edu>
diff -r d8637529daff -r df9609e384a4 xen/arch/x86/shadow32.c
--- a/xen/arch/x86/shadow32.c Mon Sep 12 21:42:26 2005
+++ b/xen/arch/x86/shadow32.c Tue Sep 13 02:00:19 2005
@@ -2226,7 +2226,7 @@
for (i = 0; i < L1_PAGETABLE_ENTRIES; i++)
{
- if ( unlikely(!l1e_has_changed(pl1e[i], match, flags) == 0) )
+ if ( unlikely(!l1e_has_changed(pl1e[i], match, flags)) )
{
l1_pgentry_t ol2e = pl1e[i];
pl1e[i] = l1e_empty();
diff -r d8637529daff -r df9609e384a4 xen/arch/x86/shadow_public.c
--- a/xen/arch/x86/shadow_public.c Mon Sep 12 21:42:26 2005
+++ b/xen/arch/x86/shadow_public.c Tue Sep 13 02:00:19 2005
@@ -1634,7 +1634,7 @@
for (i = 0; i < L1_PAGETABLE_ENTRIES; i++)
{
- if ( unlikely(!l1e_has_changed(pl1e[i], match, flags) == 0) )
+ if ( unlikely(!l1e_has_changed(pl1e[i], match, flags)) )
{
l1_pgentry_t ol2e = pl1e[i];
pl1e[i] = l1e_empty();
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Small fix for shadow_remove_all_access_in_page
2005-09-13 2:38 [PATCH] Small fix for shadow_remove_all_access_in_page Michael Vrable
@ 2005-09-13 9:15 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2005-09-13 9:15 UTC (permalink / raw
To: Michael Vrable; +Cc: xen-devel
On 13 Sep 2005, at 03:38, Michael Vrable wrote:
> Here's a fairly simple patch to correct a bug I hit when experimenting
> with VM forking earlier. Let me know if there's anything wrong with
> the
> changeset; this is the first time I've tried exporting a changeset from
> Mercurial.
Thanks. An embarrassing bug for whoever it was committed that code!
-- Keir
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-09-13 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-13 2:38 [PATCH] Small fix for shadow_remove_all_access_in_page Michael Vrable
2005-09-13 9:15 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.