* include order for i2c-amd8111
@ 2003-01-05 23:13 Pavel Machek
2003-01-06 0:40 ` Rusty Russell
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2003-01-05 23:13 UTC (permalink / raw
To: Rusty trivial patch monkey Russell, kernel list
Hi!
It seems all linux then all asm is prefered order...
Pavel
--- clean/drivers/i2c/busses/i2c-amd8111.c 2003-01-05 22:58:27.000000000 +0100
+++ linux-sensors/drivers/i2c/busses/i2c-amd8111.c 2003-01-05 21:13:25.000000000 +0100
@@ -11,7 +11,6 @@
#include <linux/version.h>
#include <linux/module.h>
#include <linux/pci.h>
-#include <asm/io.h>
#include <linux/kernel.h>
#include <linux/stddef.h>
#include <linux/sched.h>
@@ -19,6 +18,7 @@
#include <linux/init.h>
#include <linux/i2c.h>
#include <linux/delay.h>
+#include <asm/io.h>
MODULE_LICENSE("GPL");
MODULE_AUTHOR ("Vojtech Pavlik <vojtech@suse.cz>");
--
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: include order for i2c-amd8111
2003-01-05 23:13 include order for i2c-amd8111 Pavel Machek
@ 2003-01-06 0:40 ` Rusty Russell
2003-01-07 10:44 ` Vojtech Pavlik
0 siblings, 1 reply; 4+ messages in thread
From: Rusty Russell @ 2003-01-06 0:40 UTC (permalink / raw
To: Pavel Machek, kernel list
In message <20030105231349.GA8714@elf.ucw.cz> you write:
> Hi!
>
> It seems all linux then all asm is prefered order...
> Pavel
Yes, but not for any great reason, AFAICT. I think this comes under
the "too trivial" rule (ie. I'll accept it from the author, but not
someone else).
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: include order for i2c-amd8111
2003-01-06 0:40 ` Rusty Russell
@ 2003-01-07 10:44 ` Vojtech Pavlik
2003-01-08 12:06 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Vojtech Pavlik @ 2003-01-07 10:44 UTC (permalink / raw
To: Rusty Russell; +Cc: Pavel Machek, kernel list
On Mon, Jan 06, 2003 at 11:40:20AM +1100, Rusty Russell wrote:
> In message <20030105231349.GA8714@elf.ucw.cz> you write:
> > Hi!
> >
> > It seems all linux then all asm is prefered order...
> > Pavel
>
> Yes, but not for any great reason, AFAICT. I think this comes under
> the "too trivial" rule (ie. I'll accept it from the author, but not
> someone else).
The author (me ;) definitely doesn't mind you applying the patch, but
would prefer if the one who pushed the 8111 driver into the kernel
(Pavel) would update it to the version found in lm_sensors 2.7.0 at the
same time.
Thanks.
--
Vojtech Pavlik
SuSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: include order for i2c-amd8111
2003-01-07 10:44 ` Vojtech Pavlik
@ 2003-01-08 12:06 ` Pavel Machek
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2003-01-08 12:06 UTC (permalink / raw
To: Vojtech Pavlik; +Cc: Rusty Russell, Pavel Machek, kernel list
Hi!
> > > It seems all linux then all asm is prefered order...
> > > > > Yes, but not for any great reason, AFAICT. I think this comes under
> > the "too trivial" rule (ie. I'll accept it from the author, but not
> > someone else).
>
> The author (me ;) definitely doesn't mind you applying the patch, but
> would prefer if the one who pushed the 8111 driver into the kernel
> (Pavel) would update it to the version found in lm_sensors 2.7.0 at the
> same time.
Do you think you can mail me that file?
Pavel
--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-01-10 18:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-01-05 23:13 include order for i2c-amd8111 Pavel Machek
2003-01-06 0:40 ` Rusty Russell
2003-01-07 10:44 ` Vojtech Pavlik
2003-01-08 12:06 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.