* Old Debian patches
@ 2002-12-21 15:17 Jordi Mallach
2002-12-23 14:19 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Jordi Mallach @ 2002-12-21 15:17 UTC (permalink / raw
To: alsa-devel; +Cc: stevenk, madkiss
[-- Attachment #1: Type: text/plain, Size: 2808 bytes --]
Hello!
As promised, we've been trying to track down some of the old patches
lying around in our package for quite soem time. We'd like you guys to
see if they are still needed so you can apply them upstream, or we can
get rid of them.
Bug#141114: improper call to snd_power_lock in ppc (reported against
beta12).
Jack Howarth reported:
> On debian ppc sid, the new alsa-source 0.9beta12-1 doesn't build
> the powermac sound driver properly. The current source has an
> improper call to snd_power_lock which has changed its api. Also
> the powermac driver builds with unresolved symbols for udelay
> and mdelay. The attached patch needs to be added to the current
> alsa-source 0.9+beta12 debian sources to resolve these issues.
> With this patch the powermac sound module builds and operates fine
> under Linux 2.4.19pre5.
--- alsa-driver-0.9.0rc5.orig/alsa-kernel/ppc/keywest.c Mon Feb 25 20:50:13 2002
+++ alsa-driver-0.9.0rc5/alsa-kernel/ppc/keywest.c Sun May 12 20:56:25 2002
@@ -21,6 +21,7 @@
#include <sound/driver.h>
#include <linux/init.h>
+#include <linux/delay.h>
#include <linux/i2c.h>
#include <linux/i2c-dev.h>
#include <linux/slab.h>
-----
Bug#167633: usbaudio fails to build on 2.2 kernels (reported against
rc5)
Aaron M. Ucko provided the following fix:
--- /usr/src/modules/alsa-driver/usb/usbaudio.c~ 2002-10-10 08:25:03.0000
+++ /usr/src/modules/alsa-driver/usb/usbaudio.c 2002-11-03 19:43:22.000000000 -0
@@ -171,6 +171,7 @@
void snd_compat_usb_driver_claim_interface(struct snd_compat_usb_driver *driver
{
+ struct snd_usb_reg_table *tbl;
if ((tbl = find_matchingUsb_driver(driver)) != NULL)
usb_driver_claim_interface(&tbl->driver, iface, ptr);
}
-----
Bug#142693: depmod problem with provided isapnp (reported against
beta12)
"K-Bay" reported:
> After initialisation of ALSA version 0.9b12 the depmod complains about
> problems in snd-isapnp module.
>
> The following patch should get rid of the problem:
--- isapnp.c Sat Feb 9 19:30:13 2002
+++ isapnp.c.fix Mon Apr 8 11:18:13 2002
@@ -2094,7 +2094,7 @@
static void isapnp_release_resource(struct resource *res)
{
if (res) {
- release_resource(res);
+ isapnp_release_resource(res);
kfree(res);
}
}
We never got feedback from the user when we took over ALSA, so it was
never applied. I don't know if it's needed/valid.
That's all for the moment.
Jordi
--
Jordi Mallach Pérez -- Debian developer http://www.debian.org/
jordi@sindominio.net jordi@debian.org http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/~jordi/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Old Debian patches
2002-12-21 15:17 Old Debian patches Jordi Mallach
@ 2002-12-23 14:19 ` Takashi Iwai
2002-12-23 16:43 ` Jordi Mallach
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2002-12-23 14:19 UTC (permalink / raw
To: Jordi Mallach; +Cc: alsa-devel, stevenk, madkiss
Hi Jordi,
thanks for the patches!
At Sat, 21 Dec 2002 16:17:22 +0100,
Jordi Mallach wrote:
>
> Hello!
>
> As promised, we've been trying to track down some of the old patches
> lying around in our package for quite soem time. We'd like you guys to
> see if they are still needed so you can apply them upstream, or we can
> get rid of them.
>
> Bug#141114: improper call to snd_power_lock in ppc (reported against
> beta12).
already fixed.
>
> Jack Howarth reported:
>
> > On debian ppc sid, the new alsa-source 0.9beta12-1 doesn't build
> > the powermac sound driver properly. The current source has an
> > improper call to snd_power_lock which has changed its api. Also
> > the powermac driver builds with unresolved symbols for udelay
> > and mdelay. The attached patch needs to be added to the current
> > alsa-source 0.9+beta12 debian sources to resolve these issues.
> > With this patch the powermac sound module builds and operates fine
> > under Linux 2.4.19pre5.
>
>
> --- alsa-driver-0.9.0rc5.orig/alsa-kernel/ppc/keywest.c Mon Feb 25 20:50:13 2002
> +++ alsa-driver-0.9.0rc5/alsa-kernel/ppc/keywest.c Sun May 12 20:56:25 2002
> @@ -21,6 +21,7 @@
>
> #include <sound/driver.h>
> #include <linux/init.h>
> +#include <linux/delay.h>
> #include <linux/i2c.h>
> #include <linux/i2c-dev.h>
> #include <linux/slab.h>
applied to cvs now.
> -----
> Bug#167633: usbaudio fails to build on 2.2 kernels (reported against
> rc5)
>
> Aaron M. Ucko provided the following fix:
>
>
> --- /usr/src/modules/alsa-driver/usb/usbaudio.c~ 2002-10-10 08:25:03.0000
> +++ /usr/src/modules/alsa-driver/usb/usbaudio.c 2002-11-03 19:43:22.000000000 -0
> @@ -171,6 +171,7 @@
>
> void snd_compat_usb_driver_claim_interface(struct snd_compat_usb_driver *driver
> {
> + struct snd_usb_reg_table *tbl;
> if ((tbl = find_matchingUsb_driver(driver)) != NULL)
> usb_driver_claim_interface(&tbl->driver, iface, ptr);
> }
already fixed.
> -----
> Bug#142693: depmod problem with provided isapnp (reported against
> beta12)
>
> "K-Bay" reported:
>
> > After initialisation of ALSA version 0.9b12 the depmod complains about
> > problems in snd-isapnp module.
> >
> > The following patch should get rid of the problem:
>
> --- isapnp.c Sat Feb 9 19:30:13 2002
> +++ isapnp.c.fix Mon Apr 8 11:18:13 2002
> @@ -2094,7 +2094,7 @@
> static void isapnp_release_resource(struct resource *res)
> {
> if (res) {
> - release_resource(res);
> + isapnp_release_resource(res);
> kfree(res);
> }
> }
>
> We never got feedback from the user when we took over ALSA, so it was
> never applied. I don't know if it's needed/valid.
apparently this will cause an infinite loop, won't it?
i haven't seen any isapnp-problems on my 2.2 environment...
so, skipped now.
thanks,
Takashi
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Old Debian patches
2002-12-23 14:19 ` Takashi Iwai
@ 2002-12-23 16:43 ` Jordi Mallach
0 siblings, 0 replies; 3+ messages in thread
From: Jordi Mallach @ 2002-12-23 16:43 UTC (permalink / raw
To: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On Mon, Dec 23, 2002 at 03:19:11PM +0100, Takashi Iwai wrote:
> thanks for the patches!
Thanks for reviewing :)
> > > After initialisation of ALSA version 0.9b12 the depmod complains about
> > > problems in snd-isapnp module.
> > >
> > > The following patch should get rid of the problem:
> >
> > --- isapnp.c Sat Feb 9 19:30:13 2002
> > +++ isapnp.c.fix Mon Apr 8 11:18:13 2002
> > @@ -2094,7 +2094,7 @@
> > static void isapnp_release_resource(struct resource *res)
> > {
> > if (res) {
> > - release_resource(res);
> > + isapnp_release_resource(res);
> > kfree(res);
> > }
> > }
> >
> > We never got feedback from the user when we took over ALSA, so it was
> > never applied. I don't know if it's needed/valid.
> apparently this will cause an infinite loop, won't it?
> i haven't seen any isapnp-problems on my 2.2 environment...
> so, skipped now.
Ok. As I said, I've asked the submitter to check against recent alsa
verisons and never got new feedback, so we'll just close the bug. If
it's still there he can always reopen.
Jordi
--
Jordi Mallach Pérez -- Debian developer http://www.debian.org/
jordi@sindominio.net jordi@debian.org http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/~jordi/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-12-23 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-21 15:17 Old Debian patches Jordi Mallach
2002-12-23 14:19 ` Takashi Iwai
2002-12-23 16:43 ` Jordi Mallach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.