* [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
@ 2001-04-24 15:19 Ernesto Silva
2001-04-24 15:45 ` AJ Lewis
0 siblings, 1 reply; 12+ messages in thread
From: Ernesto Silva @ 2001-04-24 15:19 UTC (permalink / raw
To: linux-lvm
Hi,
In order to make things right I downloaded the 2.4.3 kernel and
compiled it (i386).
With the new kernel running (lvm-mod load ok) I'm trying to compile lvm
tools, but there are lots of warinigs, all the same thing, the first of them is:
-----------------------------------------------------------
gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I ../../tools - debug.o
debug.c
In file included from ../../tools/lib/liblvm.h:97
from basename.c:34
../../tools/lib/lvm_log.h:47:59: warning: nothing can be pasted after this token
../../tools/lib/lvm_log.h:48:59: warning: nothing can be pasted after this token
../../tools/lib/lvm_log.h:49:59: warning: nothing can be pasted after this token
../../tools/lib/lvm_log.h:52:39: warning: nothing can be pasted after this token
gasename.c:41:69: warning: pasting would not give a valid preprocessing token
gasename.c:59:68: warning: pasting would not give a valid preprocessing token
----------------------------------------------------------
This messages repeats several times.
Does anyone had a problem like this before???
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-24 15:19 [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem Ernesto Silva
@ 2001-04-24 15:45 ` AJ Lewis
2001-04-24 16:09 ` Ernesto Silva
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: AJ Lewis @ 2001-04-24 15:45 UTC (permalink / raw
To: linux-lvm
[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]
On Tue, Apr 24, 2001 at 12:19:45PM -0300, Ernesto Silva wrote:
> Hi,
>
> In order to make things right I downloaded the 2.4.3 kernel and
> compiled it (i386).
>
> With the new kernel running (lvm-mod load ok) I'm trying to compile lvm
> tools, but there are lots of warinigs, all the same thing, the first of them is:
> -----------------------------------------------------------
> gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I ../../tools - debug.o
> debug.c
> In file included from ../../tools/lib/liblvm.h:97
> from basename.c:34
> ../../tools/lib/lvm_log.h:47:59: warning: nothing can be pasted after this token
<...snip...>
> Does anyone had a problem like this before???
Hmm...I don't get that at all! Which version of GCC are you using? Did you
download the 0.9.1_beta7 tarball or grab something from the cvs?
Regards,
--
AJ Lewis
Sistina Software Inc. Voice: 612-379-3951
1313 5th St SE, Suite 111 Fax: 612-379-3952
Minneapolis, MN 55414 E-Mail: lewis@sistina.com
http://www.sistina.com
Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B 52A0 941E 1261 0029 2648
Get my key at: http://www.sistina.com/~lewis/gpgkey
(Unfortunately, the PKS-type keyservers do not work with multiple sub-keys)
-----Begin Obligatory Humorous Quote----------------------------------------
THE LESSER-KNOWN PROGRAMMING LANGUAGES #16:
C- This language was named for the grade received by its creator when he
submitted it as a class project in a graduate programming class. C- is
best described as a "low-level" programming language. In fact, the
language generally requires more C- statements than machine-code statements
to execute a given task. In this respect, it is very similar to COBOL.
-----End Obligatory Humorous Quote------------------------------------------
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-24 15:45 ` AJ Lewis
@ 2001-04-24 16:09 ` Ernesto Silva
2001-04-25 14:30 ` Patrick Caulfield
2001-04-25 3:19 ` S. Michael Denton
2001-04-25 8:01 ` Patrick Caulfield
2 siblings, 1 reply; 12+ messages in thread
From: Ernesto Silva @ 2001-04-24 16:09 UTC (permalink / raw
To: linux-lvm
I'm using gcc 2.96 from RedHat 7.0 and I downloaded the tarball.
I also applied the patch from the tarball to the kernel.
On Tue, 24 Apr 2001, you wrote:
>
> On Tue, Apr 24, 2001 at 12:19:45PM -0300, Ernesto Silva wrote:
> > Hi,
> >
> > In order to make things right I downloaded the 2.4.3 kernel and
> > compiled it (i386).
> >
> > With the new kernel running (lvm-mod load ok) I'm trying to compile lvm
> > tools, but there are lots of warinigs, all the same thing, the first of them is:
> > -----------------------------------------------------------
> > gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I ../../tools - debug.o
> > debug.c
> > In file included from ../../tools/lib/liblvm.h:97
> > from basename.c:34
> > ../../tools/lib/lvm_log.h:47:59: warning: nothing can be pasted after this token
> <...snip...>
> > Does anyone had a problem like this before???
>
> Hmm...I don't get that at all! Which version of GCC are you using? Did you
> download the 0.9.1_beta7 tarball or grab something from the cvs?
>
> Regards,
> --
> AJ Lewis
> Sistina Software Inc. Voice: 612-379-3951
> 1313 5th St SE, Suite 111 Fax: 612-379-3952
> Minneapolis, MN 55414 E-Mail: lewis@sistina.com
> http://www.sistina.com
>
> Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B 52A0 941E 1261 0029 2648
> Get my key at: http://www.sistina.com/~lewis/gpgkey
> (Unfortunately, the PKS-type keyservers do not work with multiple sub-keys)
>
> -----Begin Obligatory Humorous Quote----------------------------------------
> THE LESSER-KNOWN PROGRAMMING LANGUAGES #16:
> C- This language was named for the grade received by its creator when he
> submitted it as a class project in a graduate programming class. C- is
> best described as a "low-level" programming language. In fact, the
> language generally requires more C- statements than machine-code statements
> to execute a given task. In this respect, it is very similar to COBOL.
> -----End Obligatory Humorous Quote------------------------------------------
>
----------------------------------------
Content-Type: application/pgp-signature; name="unnamed"
Content-Transfer-Encoding: 7bit
Content-Description:
----------------------------------------
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
@ 2001-04-24 17:21 Paulo Fessel
2001-04-24 18:37 ` Ernesto Silva
0 siblings, 1 reply; 12+ messages in thread
From: Paulo Fessel @ 2001-04-24 17:21 UTC (permalink / raw
To: 'linux-lvm@sistina.com'
[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]
I've run into problems trying to compile 2.4.3 on Mandrake 7.2 with 2.4.3
(Linus) and 2.4.3-8mdk (Mandrake customized kernel). So I've copied the
files from lvm "kernel" directory to their proper places and everything
worked out smoothly. Try to do the same thing...
HugZ
Paulo Afonso Graner Fessel
Suporte de Sistemas
OptiGlobe Telecom, Ltda. - The Internet Lives Here
R.Bento Branco de Andrade Filho, 621
São Paulo, SP, 04757-000
Brasil
http://www.optiglobe.com.br
Tel.:+55 11 3365-4478
Fax:+55 11 3365-4445
Cel.:+55 11 9198-9985
E-mail: paulo_fessel@optiglobe.com.br
> -----Original Message-----
> From: Ernesto Silva [mailto:silva@athenea.ort.edu.uy]
> Sent: Tuesday, April 24, 2001 12:20 PM
> To: linux-lvm@sistina.com
> Subject: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
>
>
> Hi,
>
> In order to make things right I downloaded the 2.4.3 kernel and
> compiled it (i386).
>
> With the new kernel running (lvm-mod load ok) I'm
> trying to compile lvm
> tools, but there are lots of warinigs, all the same thing,
> the first of them is:
> -----------------------------------------------------------
> gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I
> ../../tools - debug.o
> debug.c
> In file included from ../../tools/lib/liblvm.h:97
> from basename.c:34
> ../../tools/lib/lvm_log.h:47:59: warning: nothing can be
> pasted after this token
> ../../tools/lib/lvm_log.h:48:59: warning: nothing can be
> pasted after this token
> ../../tools/lib/lvm_log.h:49:59: warning: nothing can be
> pasted after this token
> ../../tools/lib/lvm_log.h:52:39: warning: nothing can be
> pasted after this token
> gasename.c:41:69: warning: pasting would not give a valid
> preprocessing token
> gasename.c:59:68: warning: pasting would not give a valid
> preprocessing token
> ----------------------------------------------------------
> This messages repeats several times.
>
> Does anyone had a problem like this before???
>
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
>
[-- Attachment #2: Type: text/html, Size: 4368 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-24 17:21 Paulo Fessel
@ 2001-04-24 18:37 ` Ernesto Silva
2001-04-25 13:11 ` Ernesto Silva
0 siblings, 1 reply; 12+ messages in thread
From: Ernesto Silva @ 2001-04-24 18:37 UTC (permalink / raw
To: linux-lvm
Sorry HugZ,
I just did it but I'm still getting the same garbage.....
Does anyone have another idea????
WOUUW, I let it compile, with all the warnings and it worked, I just
run vgscan and it found something.
I'll let you know what happends next......
Ernesto.
On Tue, 24 Apr 2001, Paulo Fessel wrote:
>
> I've run into problems trying to compile 2.4.3 on Mandrake 7.2 with 2.4.3
> (Linus) and 2.4.3-8mdk (Mandrake customized kernel). So I've copied the
> files from lvm "kernel" directory to their proper places and everything
> worked out smoothly. Try to do the same thing...
>
> HugZ
>
> Paulo Afonso Graner Fessel
> Suporte de Sistemas
> OptiGlobe Telecom, Ltda. - The Internet Lives Here
> R.Bento Branco de Andrade Filho, 621
> S�o Paulo, SP, 04757-000
> Brasil
> http://www.optiglobe.com.br
>
> Tel.:+55 11 3365-4478
> Fax:+55 11 3365-4445
> Cel.:+55 11 9198-9985
> E-mail: paulo_fessel@optiglobe.com.br
>
>
>
> > -----Original Message-----
> > From: Ernesto Silva [mailto:silva@athenea.ort.edu.uy]
> > Sent: Tuesday, April 24, 2001 12:20 PM
> > To: linux-lvm@sistina.com
> > Subject: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
> >
> >
> > Hi,
> >
> > In order to make things right I downloaded the 2.4.3 kernel and
> > compiled it (i386).
> >
> > With the new kernel running (lvm-mod load ok) I'm
> > trying to compile lvm
> > tools, but there are lots of warinigs, all the same thing,
> > the first of them is:
> > -----------------------------------------------------------
> > gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I
> > ../../tools - debug.o
> > debug.c
> > In file included from ../../tools/lib/liblvm.h:97
> > from basename.c:34
> > ../../tools/lib/lvm_log.h:47:59: warning: nothing can be
> > pasted after this token
> > ../../tools/lib/lvm_log.h:48:59: warning: nothing can be
> > pasted after this token
> > ../../tools/lib/lvm_log.h:49:59: warning: nothing can be
> > pasted after this token
> > ../../tools/lib/lvm_log.h:52:39: warning: nothing can be
> > pasted after this token
> > gasename.c:41:69: warning: pasting would not give a valid
> > preprocessing token
> > gasename.c:59:68: warning: pasting would not give a valid
> > preprocessing token
> > ----------------------------------------------------------
> > This messages repeats several times.
> >
> > Does anyone had a problem like this before???
> >
> > _______________________________________________
> > linux-lvm mailing list
> > linux-lvm@sistina.com
> > http://lists.sistina.com/mailman/listinfo/linux-lvm
> >
>
----------------------------------------
Content-Type: text/html; name="unnamed"
Content-Transfer-Encoding: quoted-printable
Content-Description:
----------------------------------------
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-24 15:45 ` AJ Lewis
2001-04-24 16:09 ` Ernesto Silva
@ 2001-04-25 3:19 ` S. Michael Denton
2001-04-25 8:01 ` Patrick Caulfield
2 siblings, 0 replies; 12+ messages in thread
From: S. Michael Denton @ 2001-04-25 3:19 UTC (permalink / raw
To: linux-lvm
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Tue, Apr 24, 2001 at 12:19:45PM -0300, Ernesto Silva wrote:
> Hi,
>
> In order to make things right I downloaded the 2.4.3 kernel and
> compiled it (i386).
>
> With the new kernel running (lvm-mod load ok) I'm trying to
> compile lvm tools, but there are lots of warinigs, all the same
> thing, the first of them is:
> -----------------------------------------------------------
> gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I ../../tools
> - debug.o debug.c
Am I reading this right, there's a " - " in between the include line
and the object file? That didn't seem to work all that well on my
gcc (2.95.2). You might want to see what's putting the dash in
there... it probably wants to be a "-o"
> In file included from ../../tools/lib/liblvm.h:97
> from basename.c:34
> ../../tools/lib/lvm_log.h:47:59: warning: nothing can be pasted
> after this token
<...snip...>
> Does anyone had a problem like this before???
Hmm...I don't get that at all! Which version of GCC are you using?
Did you
download the 0.9.1_beta7 tarball or grab something from the cvs?
Regards,
- --
AJ Lewis
Sistina Software Inc. Voice: 612-379-3951
1313 5th St SE, Suite 111 Fax: 612-379-3952
Minneapolis, MN 55414 E-Mail: lewis@sistina.com
http://www.sistina.com
Current GPG fingerprint = 3B5F 6011 5216 76A5 2F6B 52A0 941E 1261
0029 2648
Get my key at: http://www.sistina.com/~lewis/gpgkey
(Unfortunately, the PKS-type keyservers do not work with multiple
sub-keys)
- -----Begin Obligatory Humorous
Quote----------------------------------------
THE LESSER-KNOWN PROGRAMMING LANGUAGES #16:
C- This language was named for the grade received by its creator when
he
submitted it as a class project in a graduate programming class. C-
is
best described as a "low-level" programming language. In fact, the
language generally requires more C- statements than machine-code
statements
to execute a given task. In this respect, it is very similar to
COBOL.
- -----End Obligatory Humorous
Quote------------------------------------------
-----BEGIN PGP SIGNATURE-----
Version: PGP 7.0.1
iQA/AwUBOuZCWHC+DNfF0nVpEQJMVQCfWDINzWztoSaj/ayyOQvE9IRIa6QAoLVw
4/fh74fjjCMWQ4vRksVgKoEY
=SzDr
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-24 15:45 ` AJ Lewis
2001-04-24 16:09 ` Ernesto Silva
2001-04-25 3:19 ` S. Michael Denton
@ 2001-04-25 8:01 ` Patrick Caulfield
2001-04-25 15:55 ` Andreas Dilger
2 siblings, 1 reply; 12+ messages in thread
From: Patrick Caulfield @ 2001-04-25 8:01 UTC (permalink / raw
To: linux-lvm
On Tue, Apr 24, 2001 at 10:45:06AM -0500, AJ Lewis wrote:
> On Tue, Apr 24, 2001 at 12:19:45PM -0300, Ernesto Silva wrote:
> > Hi,
> >
> > In order to make things right I downloaded the 2.4.3 kernel and
> > compiled it (i386).
> >
> > With the new kernel running (lvm-mod load ok) I'm trying to compile lvm
> > tools, but there are lots of warinigs, all the same thing, the first of them is:
> > -----------------------------------------------------------
> > gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I ../../tools - debug.o
> > debug.c
> > In file included from ../../tools/lib/liblvm.h:97
> > from basename.c:34
> > ../../tools/lib/lvm_log.h:47:59: warning: nothing can be pasted after this token
> <...snip...>
> > Does anyone had a problem like this before???
>
> Hmm...I don't get that at all! Which version of GCC are you using? Did you
> download the 0.9.1_beta7 tarball or grab something from the cvs?
I get similar warnings with gcc 3.0 from CVS. The indicated line has changed but
the actual error is the same I think:
lvm_config.c:113:7: warning: pasting ""error: "" and ""error in config file: not in section at line %d"" does not give a valid preprocessing token
lvm_config.c:117:7: warning: pasting ""error: "" and ""couldn't put %s:%s = %s into config"" does not give a valid preprocessing token
lvm_config.c:162:9: warning: pasting ""warning: "" and ""unknown variable %s:%s in config file"" does not give a valid preprocessing token
lvm_config.c:172:5: warning: pasting ""warning: "" and ""more than one value for %s:%s, using most recent"" does not give a valid preprocessing token
lvm_config.c:186:5: warning: pasting ""warning: "" and ""more than one value for %s:%s, using most recent"" does not give a valid preprocessing token
lvm_config.c:342:3: warning: pasting ""warning: "" and ""'%s' not a recognised boolean value, assuming false"" does not give a valid preprocessing token
patrick
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-24 18:37 ` Ernesto Silva
@ 2001-04-25 13:11 ` Ernesto Silva
0 siblings, 0 replies; 12+ messages in thread
From: Ernesto Silva @ 2001-04-25 13:11 UTC (permalink / raw
To: linux-lvm
Well, things seems to be in the right way, I let it compile with all the
warning messages and it finished. I ran vgscan, pvcreate, etc. etc. and made a
ext2 file system, it's working fine.
Late last night I recompile the kernel for other reasons (2.4.3) and I saw a
lot of similar warning, the first of it I believe it was in fd.c or cdrom.c,
but the kernel is working fine.
in short:
Kernel 2.4.3 (the last I found in www.kernel.org)
lvm 0.9.1 beta 7 (tarball)
gcc version 2.96
Distribution: RedHat 7.0 (I prefer SuSE but my boss doesn't)
Compiling: lots of warnings but everythig is working.
Lewis or Michael
you was right, there's a typo in my writing, it is "-o debug.o"
Next:
I'll test it in the following days, I'm waiting for 2 new scsi disks
which I'm going to add and extend the vg or make a new one. I'll let you know
the results.
Thanks to you all ppl, I think discussion lists are the best way to get support
on any thing, it's the only way you can learn something while you fix it.
On Tue, 24 Apr 2001, you wrote:
> Sorry HugZ,
> I just did it but I'm still getting the same garbage.....
>
> Does anyone have another idea????
>
> WOUUW, I let it compile, with all the warnings and it worked, I just
> run vgscan and it found something.
> I'll let you know what happends next......
>
> Ernesto.
>
>
> On Tue, 24 Apr 2001, Paulo Fessel wrote:
> >
> > I've run into problems trying to compile 2.4.3 on Mandrake 7.2 with 2.4.3
> > (Linus) and 2.4.3-8mdk (Mandrake customized kernel). So I've copied the
> > files from lvm "kernel" directory to their proper places and everything
> > worked out smoothly. Try to do the same thing...
> >
> > HugZ
> >
> > Paulo Afonso Graner Fessel
> > Suporte de Sistemas
> > OptiGlobe Telecom, Ltda. - The Internet Lives Here
> > R.Bento Branco de Andrade Filho, 621
> > S�o Paulo, SP, 04757-000
> > Brasil
> > http://www.optiglobe.com.br
> >
> > Tel.:+55 11 3365-4478
> > Fax:+55 11 3365-4445
> > Cel.:+55 11 9198-9985
> > E-mail: paulo_fessel@optiglobe.com.br
> >
> >
> >
> > > -----Original Message-----
> > > From: Ernesto Silva [mailto:silva@athenea.ort.edu.uy]
> > > Sent: Tuesday, April 24, 2001 12:20 PM
> > > To: linux-lvm@sistina.com
> > > Subject: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
> > >
> > >
> > > Hi,
> > >
> > > In order to make things right I downloaded the 2.4.3 kernel and
> > > compiled it (i386).
> > >
> > > With the new kernel running (lvm-mod load ok) I'm
> > > trying to compile lvm
> > > tools, but there are lots of warinigs, all the same thing,
> > > the first of them is:
> > > -----------------------------------------------------------
> > > gcc -c -pipe -g -O2 -Wall -DDEBUG -I ../../tools/lib -I
> > > ../../tools - debug.o
> > > debug.c
> > > In file included from ../../tools/lib/liblvm.h:97
> > > from basename.c:34
> > > ../../tools/lib/lvm_log.h:47:59: warning: nothing can be
> > > pasted after this token
> > > ../../tools/lib/lvm_log.h:48:59: warning: nothing can be
> > > pasted after this token
> > > ../../tools/lib/lvm_log.h:49:59: warning: nothing can be
> > > pasted after this token
> > > ../../tools/lib/lvm_log.h:52:39: warning: nothing can be
> > > pasted after this token
> > > gasename.c:41:69: warning: pasting would not give a valid
> > > preprocessing token
> > > gasename.c:59:68: warning: pasting would not give a valid
> > > preprocessing token
> > > ----------------------------------------------------------
> > > This messages repeats several times.
> > >
> > > Does anyone had a problem like this before???
> > >
> > > _______________________________________________
> > > linux-lvm mailing list
> > > linux-lvm@sistina.com
> > > http://lists.sistina.com/mailman/listinfo/linux-lvm
> > >
> >
>
> ----------------------------------------
> Content-Type: text/html; name="unnamed"
> Content-Transfer-Encoding: quoted-printable
> Content-Description:
> ----------------------------------------
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-24 16:09 ` Ernesto Silva
@ 2001-04-25 14:30 ` Patrick Caulfield
2001-04-25 14:44 ` Joe Thornber
0 siblings, 1 reply; 12+ messages in thread
From: Patrick Caulfield @ 2001-04-25 14:30 UTC (permalink / raw
To: linux-lvm
On Tue, Apr 24, 2001 at 01:09:19PM -0300, Ernesto Silva wrote:
>
> I'm using gcc 2.96 from RedHat 7.0 and I downloaded the tarball.
> I also applied the patch from the tarball to the kernel.
>
This patch works for me using gcc 3.0:
Index: lvm_log.h
===================================================================
RCS file: /home/cvs/LVM/tools/lib/lvm_log.h,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- lvm_log.h 2001/04/24 14:29:21 1.2
+++ lvm_log.h 2001/04/25 08:20:57 1.3
@@ -44,9 +44,9 @@
void print_log(int level, const char *format, ...);
#define plog(l, f, n, x, a...) print_log(l, "%s:%d " x "\n", f, n, ## a)
-#define lvm_info(x...) plog(LOG_INFO, __FILE__, __LINE__, "info: " ## x)
-#define lvm_warn(x...) plog(LOG_WARN, __FILE__, __LINE__, "warning: " ## x)
-#define lvm_err(x...) plog(LOG_ERROR, __FILE__, __LINE__, "error: " ## x)
+#define lvm_info(x...) plog(LOG_INFO, __FILE__, __LINE__, "info: " x)
+#define lvm_warn(x...) plog(LOG_WARN, __FILE__, __LINE__, "warning: " x)
+#define lvm_err(x...) plog(LOG_ERROR, __FILE__, __LINE__, "error: " x)
#define lvm_fatal(x...) do {\
plog(LOG_FATAL, __FILE__, __LINE__, "(FATAL) " ## x); \
patrick
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-25 14:30 ` Patrick Caulfield
@ 2001-04-25 14:44 ` Joe Thornber
2001-04-25 15:07 ` Patrick Caulfield
0 siblings, 1 reply; 12+ messages in thread
From: Joe Thornber @ 2001-04-25 14:44 UTC (permalink / raw
To: linux-lvm
On Wed, Apr 25, 2001 at 03:30:07PM +0100, Patrick Caulfield wrote:
> On Tue, Apr 24, 2001 at 01:09:19PM -0300, Ernesto Silva wrote:
> >
> > I'm using gcc 2.96 from RedHat 7.0 and I downloaded the tarball.
> > I also applied the patch from the tarball to the kernel.
> >
>
> This patch works for me using gcc 3.0:
>
>
> Index: lvm_log.h
> ===================================================================
> RCS file: /home/cvs/LVM/tools/lib/lvm_log.h,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- lvm_log.h 2001/04/24 14:29:21 1.2
> +++ lvm_log.h 2001/04/25 08:20:57 1.3
> @@ -44,9 +44,9 @@
> void print_log(int level, const char *format, ...);
>
> #define plog(l, f, n, x, a...) print_log(l, "%s:%d " x "\n", f, n, ## a)
> -#define lvm_info(x...) plog(LOG_INFO, __FILE__, __LINE__, "info: " ## x)
> -#define lvm_warn(x...) plog(LOG_WARN, __FILE__, __LINE__, "warning: " ## x)
> -#define lvm_err(x...) plog(LOG_ERROR, __FILE__, __LINE__, "error: " ## x)
> +#define lvm_info(x...) plog(LOG_INFO, __FILE__, __LINE__, "info: " x)
> +#define lvm_warn(x...) plog(LOG_WARN, __FILE__, __LINE__, "warning: " x)
> +#define lvm_err(x...) plog(LOG_ERROR, __FILE__, __LINE__, "error: " x)
>
> #define lvm_fatal(x...) do {\
> plog(LOG_FATAL, __FILE__, __LINE__, "(FATAL) " ## x); \
>
If this is the right fix (time for me to download gcc 3.0) why haven't you
changed lvm_fatal and plog ? Does this still do the right thing under older
versions of gcc ?
- Joe
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-25 14:44 ` Joe Thornber
@ 2001-04-25 15:07 ` Patrick Caulfield
0 siblings, 0 replies; 12+ messages in thread
From: Patrick Caulfield @ 2001-04-25 15:07 UTC (permalink / raw
To: linux-lvm
On Wed, Apr 25, 2001 at 03:44:13PM +0100, Joe Thornber wrote:
> >
> > #define lvm_fatal(x...) do {\
> > plog(LOG_FATAL, __FILE__, __LINE__, "(FATAL) " ## x); \
> >
>
> If this is the right fix (time for me to download gcc 3.0) why haven't you
> changed lvm_fatal and plog ? Does this still do the right thing under older
> versions of gcc ?
lvm_fatal I missed! plog should not be changed because the ## is needed to get
rid of the trailing comma in the instance that there is nothing in a.
It is the right fix, it only worked on older gcc because it was lenient about
the problem. ## gets rid of whitespace characters so what was happening was that
the two quoted strings were abutted eg
"error:""there was an error" - not legal C
"error:" "there was an error" - is legal C
I'll fix lvm_fatal; the only reason it fell through was that it does not get
used!
patrick
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.
2001-04-25 8:01 ` Patrick Caulfield
@ 2001-04-25 15:55 ` Andreas Dilger
0 siblings, 0 replies; 12+ messages in thread
From: Andreas Dilger @ 2001-04-25 15:55 UTC (permalink / raw
To: linux-lvm
Patrick writes:
> I get similar warnings with gcc 3.0 from CVS. The indicated line has
> changed but the actual error is the same I think:
>
> lvm_config.c:113:7: warning: pasting ""error: "" and ""error in config file: not in section at line %d"" does not give a valid preprocessing token
> lvm_config.c:117:7: warning: pasting ""error: "" and ""couldn't put %s:%s = %s into config"" does not give a valid preprocessing token
> lvm_config.c:162:9: warning: pasting ""warning: "" and ""unknown variable %s:%s in config file"" does not give a valid preprocessing token
> lvm_config.c:172:5: warning: pasting ""warning: "" and ""more than one value for %s:%s, using most recent"" does not give a valid preprocessing token
> lvm_config.c:186:5: warning: pasting ""warning: "" and ""more than one value for %s:%s, using most recent"" does not give a valid preprocessing token
> lvm_config.c:342:3: warning: pasting ""warning: "" and ""'%s' not a recognised boolean value, assuming false"" does not give a valid preprocessing token
I seem to recall reading that there was some bogus issue about GCC 3.0 not
allowing concatenated strings. This definitely looks like that problem.
Try editing the relevant lines in lvm_config.c to have a single long string
value, and see if that fixes the problem. That would be a real PITA.
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2001-04-25 15:55 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-04-24 15:19 [linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem Ernesto Silva
2001-04-24 15:45 ` AJ Lewis
2001-04-24 16:09 ` Ernesto Silva
2001-04-25 14:30 ` Patrick Caulfield
2001-04-25 14:44 ` Joe Thornber
2001-04-25 15:07 ` Patrick Caulfield
2001-04-25 3:19 ` S. Michael Denton
2001-04-25 8:01 ` Patrick Caulfield
2001-04-25 15:55 ` Andreas Dilger
-- strict thread matches above, loose matches on Subject: below --
2001-04-24 17:21 Paulo Fessel
2001-04-24 18:37 ` Ernesto Silva
2001-04-25 13:11 ` Ernesto Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.