From: Christoph Hellwig <hch@ns.caldera.de>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Friedrich Lobenstock <fl@fl.priv.at>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kbuild@torque.net, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org
Subject: Re: [KBUILD] Re: [BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup))
Date: Mon, 27 Nov 2000 11:49:50 +0100 [thread overview]
Message-ID: <20001127114950.A12206@caldera.de> (raw)
In-Reply-To: <20001117234144.A14461@spaans.ds9a.nl> <20001118123536.A5674@spaans.ds9a.nl> <20001118235352.D2226@spaans.ds9a.nl> <14872.29479.901021.472890@notabene.cse.unsw.edu.au> <3A2074CC.8219AB99@fl.priv.at> <14881.50316.705469.752219@notabene.cse.unsw.edu.au>
In-Reply-To: <14881.50316.705469.752219@notabene.cse.unsw.edu.au>; from neilb@cse.unsw.edu.au on Mon, Nov 27, 2000 at 01:18:52PM +1100
On Mon, Nov 27, 2000 at 01:18:52PM +1100, Neil Brown wrote:
> Thanks for this....
>
> I have looked more deeply, and discovered the error of my ways.
> As the Makefiles now stand, all export-objs (OX_OBJS) get linked
> before non-export-objs (O_OBJS) in the same directory, independantly
> of any ordering imposed within the Makefile.
Yes.
> This caused md.o to get linked before raid?.o.
> Due to carelessness on my part I didn't notice this happening when I
> was testing.
>
> The following patch fixes it. I hope the change to Rules.make is
> acceptable - I have CCed to linux-kbuild incase anyone there has an
> issue with it.
I don't think so. Look at drivers/usb/Makefile for an other (cleaner)
solution to solve this. I don't think it is a good idea to solve the
same problem with two different hacks...
Christoph
--
Always remember that you are unique. Just like everyone else.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-11-27 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-17 22:41 [PATCH] raid5 fix after xor.c cleanup Jasper Spaans
2000-11-18 11:35 ` Jasper Spaans
2000-11-18 22:53 ` [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup) Jasper Spaans
2000-11-20 0:41 ` Neil Brown
2000-11-26 2:26 ` [BUG] 2.4.0-test11-ac3 breaks raid autodetect (was Re: [BUG] raid5 link error? (was [PATCH] raid5 fix after xor.c cleanup)) Friedrich Lobenstock
2000-11-27 2:18 ` Neil Brown
2000-11-27 8:12 ` Luca Berra
2000-11-27 10:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001127114950.A12206@caldera.de \
--to=hch@ns.caldera.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fl@fl.priv.at \
--cc=linux-kbuild@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.