From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E548C47080 for ; Tue, 1 Jun 2021 15:27:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96ED4613AB for ; Tue, 1 Jun 2021 15:27:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96ED4613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5957882EA5; Tue, 1 Jun 2021 17:27:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="n0HKJqoF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AC07182EB9; Tue, 1 Jun 2021 17:27:04 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8FB3A82E8D for ; Tue, 1 Jun 2021 17:27:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrick.delaunay@foss.st.com Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 151FNHeq012792; Tue, 1 Jun 2021 17:26:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=ZRanrWGF0H3xqhjcJpBa5uKG604ZyJXqIjYBQxj0g7k=; b=n0HKJqoFOr1Nvm1lqcYiVjfLhMHzTutEF0oPlaqEpUhg2vzXHsUi4eziGMzfwvVIAH+b F8K3RqwKlUg7YqG7eV+nzoi2CikPccszoa5CGjKJmW/9g4+muli1V6BkextzsOPacJnA bPbblL1lLQUdpuoGE6EArajysXIra/4oTY4B1wOW2Yvei6zN6K66+jndhJCYYG/324lJ snSVcMFmyLo14/jMcg5sAS8eTixM4kGBF41iNn84M9aqqMLKWP9iWT7KRo++D9YLafri hxt7EtXj1cGnjxPoDGvu6CUj3ob27e4Xsc4bupJUbzW/qqo8S7+gZjwKRMJPMerknEAo 0Q== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38w0y7p6y5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Jun 2021 17:26:59 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C530D10002A; Tue, 1 Jun 2021 17:26:58 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B804C23A1C7; Tue, 1 Jun 2021 17:26:58 +0200 (CEST) Received: from lmecxl0994.lme.st.com (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Jun 2021 17:26:57 +0200 Subject: Re: [PATCH] net: dwc_eth_qos: Fix needless phy auto-negotiation restarts To: Daniil Stas , CC: Ramon Fried , Joe Hershberger , Patrice Chotard , Christophe ROULLIER References: <20210523222449.1495352-1-daniil.stas@posteo.net> From: Patrick DELAUNAY Message-ID: <1cf2e476-495a-2785-451a-52ad5f9465dd@foss.st.com> Date: Tue, 1 Jun 2021 17:26:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210523222449.1495352-1-daniil.stas@posteo.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-01_08:2021-06-01, 2021-06-01 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi, On 5/24/21 12:24 AM, Daniil Stas wrote: > Disabling clk_ck clock leads to link up status loss in phy, which > leads to auto-negotiation restart before each network command > execution. > > This issue is especially big for PXE boot protocol because of > auto-negotiation restarts before each configuration filename trial. > > To avoid this issue don't disable clk_ck clock after it was enabled. > > Signed-off-by: Daniil Stas > Cc: Ramon Fried > Cc: Joe Hershberger > Cc: Patrick Delaunay > Cc: Patrice Chotard > --- > drivers/net/dwc_eth_qos.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Patrick Delaunay Thanks Patrick