From: <Parthiban.Veerasooran@microchip.com>
To: <conor@kernel.org>, <ramon.nordin.rodriguez@ferroamp.se>,
<andrew@lunn.ch>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>, <saeedm@nvidia.com>,
<anthony.l.nguyen@intel.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <andrew@lunn.ch>,
<corbet@lwn.net>, <linux-doc@vger.kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<Horatiu.Vultur@microchip.com>, <ruanjinjie@huawei.com>,
<Steen.Hegelund@microchip.com>, <vladimir.oltean@nxp.com>,
<UNGLinuxDriver@microchip.com>,
<Thorsten.Kummermehr@microchip.com>, <Pier.Beruto@onsemi.com>,
<Selvamani.Rajagopal@onsemi.com>, <Nicolas.Ferre@microchip.com>,
<benjamin.bigler@bernformulastudent.ch>
Subject: Re: [PATCH net-next v4 11/12] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY
Date: Mon, 29 Apr 2024 09:47:34 +0000 [thread overview]
Message-ID: <1ae4f1d5-140b-41b1-9191-da14fd67d409@microchip.com> (raw)
In-Reply-To: <20240427-vaporizer-pencil-be6a25030f08@spud>
Hi All,
On 28/04/24 1:27 am, Conor Dooley wrote:
> On Sat, Apr 27, 2024 at 09:19:34PM +0200, Ramón Nordin Rodriguez wrote:
>> Hi,
>>
>> For me the mac driver fails to probe with the following log
>> [ 0.123325] SPI driver lan865x has no spi_device_id for microchip,lan8651
>>
>> With this change the driver probes
>>
>> diff --git a/drivers/net/ethernet/microchip/lan865x/lan865x.c b/drivers/net/ethernet/microchip/lan865x/lan865x.c
>> index 9abefa8b9d9f..72a663f14f50 100644
>> --- a/drivers/net/ethernet/microchip/lan865x/lan865x.c
>> +++ b/drivers/net/ethernet/microchip/lan865x/lan865x.c
>> @@ -364,7 +364,7 @@ static void lan865x_remove(struct spi_device *spi)
>> }
>>
>> static const struct of_device_id lan865x_dt_ids[] = {
>> - { .compatible = "microchip,lan8651", "microchip,lan8650" },
> Huh, that's very strange. I don't see a single instance in the tree of a
> of_device_id struct like this with two compatibles like this (at least
> with a search of `rg "\.compatible.*\", \"" drivers/`.
>
> Given the fallbacks in the binding, only "microchip,lan8650" actually
> needs to be here.
>
>> + { .compatible = "microchip,lan865x", "microchip,lan8650" },
>> { /* Sentinel */ }
>> };
>> MODULE_DEVICE_TABLE(of, lan865x_dt_ids);
>>
>> Along with compatible = "microchip,lan865x" in the dts
> Just to be clear, the compatible w/ an x is unacceptable due to the
> wildcard and the binding should stay as-is. Whatever probing bugs
> the code has need to be resolved instead 🙂
>
Looks like, the below changes needed to work correctly,
lan865x.c:
- compatible string to be changed like below as it is a fallback for all
variants,
.compatible = "microchip,lan8650"
- DRV_NAME to be changed like below,
#define DRV_NAME "lan8650"
microchip,lan865x.example.dts for lan8650:
- compatible string to be changed like below,
.compatible = "microchip,lan8650";
OR
microchip,lan865x.example.dts for lan8651:
- compatible string to be changed like below,
compatible = "microchip,lan8651", "microchip,lan8650";
I tested with the above changes and there was no issues observed. Any
comments on this? Otherwise we can stick with these changes for the next
version.
Best regards,
Parthiban V
> Thanks,
> Conor.
next prev parent reply other threads:[~2024-04-29 9:47 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 12:56 [PATCH net-next v4 00/12] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface Parthiban Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 01/12] Documentation: networking: add OPEN Alliance 10BASE-T1x MAC-PHY serial interface Parthiban Veerasooran
2024-04-28 9:33 ` Bagas Sanjaya
2024-04-29 11:31 ` Parthiban.Veerasooran
2024-04-29 16:17 ` Simon Horman
2024-04-30 11:30 ` Parthiban.Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 02/12] net: ethernet: oa_tc6: implement register write operation Parthiban Veerasooran
2024-04-22 23:48 ` Andrew Lunn
2024-04-23 4:38 ` Parthiban.Veerasooran
2024-04-23 23:14 ` Andrew Lunn
2024-04-26 5:55 ` Parthiban.Veerasooran
2024-04-29 16:36 ` Simon Horman
2024-04-30 8:14 ` Parthiban.Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 03/12] net: ethernet: oa_tc6: implement register read operation Parthiban Veerasooran
2024-04-23 23:17 ` Andrew Lunn
2024-04-26 5:56 ` Parthiban.Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 04/12] net: ethernet: oa_tc6: implement software reset Parthiban Veerasooran
2024-04-23 23:26 ` Andrew Lunn
2024-04-26 6:38 ` Parthiban.Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking Parthiban Veerasooran
2024-04-23 23:27 ` Andrew Lunn
2024-04-27 19:52 ` Ramón Nordin Rodriguez
2024-04-27 21:17 ` Andrew Lunn
2024-04-27 21:55 ` Ramón Nordin Rodriguez
2024-04-28 14:48 ` Andrew Lunn
2024-04-28 9:54 ` Ramón Nordin Rodriguez
2024-04-28 14:59 ` Andrew Lunn
2024-04-28 22:04 ` Ramón Nordin Rodriguez
2024-05-01 18:29 ` Ramón Nordin Rodriguez
2024-05-01 19:58 ` Andrew Lunn
2024-05-01 20:07 ` Andrew Lunn
2024-05-02 10:10 ` Parthiban.Veerasooran
2024-05-02 10:19 ` Ramón Nordin Rodriguez
2024-05-03 7:10 ` Parthiban.Veerasooran
2024-05-06 1:21 ` Andrew Lunn
2024-05-06 6:47 ` Piergiorgio Beruto
2024-05-07 12:44 ` Ramón Nordin Rodriguez
2024-05-13 6:41 ` Ramón Nordin Rodriguez
2024-05-13 13:00 ` Andrew Lunn
2024-05-13 13:50 ` Ramón Nordin Rodriguez
2024-05-13 14:04 ` Andrew Lunn
2024-05-14 4:46 ` Parthiban.Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 06/12] net: ethernet: oa_tc6: implement internal PHY initialization Parthiban Veerasooran
2024-04-23 23:48 ` Andrew Lunn
2024-04-26 13:17 ` Parthiban.Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 07/12] net: ethernet: oa_tc6: enable open alliance tc6 data communication Parthiban Veerasooran
2024-04-23 23:49 ` Andrew Lunn
2024-04-18 12:56 ` [PATCH net-next v4 08/12] net: ethernet: oa_tc6: implement transmit path to transfer tx ethernet frames Parthiban Veerasooran
2024-04-24 0:02 ` Andrew Lunn
2024-04-26 13:19 ` Parthiban.Veerasooran
2024-04-18 12:56 ` [PATCH net-next v4 09/12] net: ethernet: oa_tc6: implement receive path to receive rx " Parthiban Veerasooran
2024-04-24 0:08 ` Andrew Lunn
2024-04-26 13:45 ` Parthiban.Veerasooran
2024-04-26 18:13 ` Andrew Lunn
2024-04-29 6:13 ` Parthiban.Veerasooran
2024-04-27 20:02 ` Ramón Nordin Rodriguez
2024-04-29 8:32 ` Parthiban.Veerasooran
2024-04-29 10:45 ` Ramón Nordin Rodriguez
2024-04-18 12:56 ` [PATCH net-next v4 10/12] net: ethernet: oa_tc6: implement mac-phy interrupt Parthiban Veerasooran
2024-04-24 0:10 ` Andrew Lunn
2024-04-18 12:56 ` [PATCH net-next v4 11/12] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY Parthiban Veerasooran
2024-04-24 0:27 ` Andrew Lunn
2024-04-26 13:32 ` Parthiban.Veerasooran
2024-04-26 18:14 ` Andrew Lunn
2024-04-29 6:13 ` Parthiban.Veerasooran
2024-04-27 19:19 ` Ramón Nordin Rodriguez
2024-04-27 19:57 ` Conor Dooley
2024-04-27 20:13 ` Ramón Nordin Rodriguez
2024-04-27 20:22 ` Conor Dooley
2024-04-27 21:09 ` Ramón Nordin Rodriguez
2024-04-29 9:47 ` Parthiban.Veerasooran [this message]
2024-04-29 12:09 ` Andrew Lunn
2024-04-30 13:30 ` Parthiban.Veerasooran
2024-04-30 16:55 ` Conor Dooley
2024-05-02 5:56 ` Parthiban.Veerasooran
2024-04-27 20:40 ` Andrew Lunn
2024-04-27 21:06 ` Ramón Nordin Rodriguez
2024-04-28 14:18 ` Andrew Lunn
2024-04-27 19:35 ` Ramón Nordin Rodriguez
2024-04-27 20:58 ` Andrew Lunn
2024-04-27 21:29 ` Ramón Nordin Rodriguez
2024-04-28 14:25 ` Andrew Lunn
2024-04-28 22:00 ` Ramón Nordin Rodriguez
2024-04-18 12:56 ` [PATCH net-next v4 12/12] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY Parthiban Veerasooran
2024-04-18 15:39 ` Conor Dooley
2024-04-22 3:59 ` Parthiban.Veerasooran
2024-04-22 15:50 ` Conor Dooley
2024-04-23 3:27 ` Parthiban.Veerasooran
2024-04-22 20:07 ` [PATCH net-next v4 00/12] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface Andrew Lunn
2024-04-22 20:08 ` Andrew Lunn
2024-04-22 23:23 ` Andrew Lunn
2024-05-08 13:05 ` Parthiban.Veerasooran
2024-05-08 17:04 ` Andrew Lunn
2024-05-09 13:04 ` Parthiban.Veerasooran
2024-05-09 20:39 ` Andrew Lunn
2024-05-10 11:22 ` Parthiban.Veerasooran
2024-04-22 23:43 ` Andrew Lunn
2024-04-28 21:16 ` [PATCH net-next v4 13/12] net: lan865x: optional hardware reset Ramón Nordin Rodriguez
2024-04-28 23:17 ` Andrew Lunn
2024-04-29 10:42 ` Ramón Nordin Rodriguez
2024-04-29 6:09 ` Parthiban.Veerasooran
2024-04-29 10:38 ` Ramón Nordin Rodriguez
2024-04-29 12:19 ` Andrew Lunn
2024-04-30 8:04 ` Ramón Nordin Rodriguez
2024-04-30 13:30 ` Parthiban.Veerasooran
2024-04-30 14:14 ` Andrew Lunn
2024-05-02 10:10 ` Parthiban.Veerasooran
2024-04-29 6:09 ` Krzysztof Kozlowski
2024-04-29 10:44 ` Ramón Nordin Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae4f1d5-140b-41b1-9191-da14fd67d409@microchip.com \
--to=parthiban.veerasooran@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Pier.Beruto@onsemi.com \
--cc=Selvamani.Rajagopal@onsemi.com \
--cc=Steen.Hegelund@microchip.com \
--cc=Thorsten.Kummermehr@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=benjamin.bigler@bernformulastudent.ch \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ramon.nordin.rodriguez@ferroamp.se \
--cc=robh+dt@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=saeedm@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.