From: Benjamin Herrenschmidt <bh40@calva.net>
To: Takashi Oe <toe@unlserve.unl.edu>, linuxppc-dev@lists.linuxppc.org
Subject: Re: [Fwd: Bug: 2.2.12 still hangs PPC after some PPP activity]
Date: Wed, 29 Sep 1999 11:13:38 +0200 [thread overview]
Message-ID: <19990929111338.022344@mailhost.mipsys.com> (raw)
In-Reply-To: <Pine.LNX.3.96LJ1.1b7.990929021435.16135B-100000@ofey.inetnebr.com>
On Wed, Sep 29, 1999, Takashi Oe <toe@unlserve.unl.edu> wrote:
>I'm fairly certain it's a bug. Good spotting. The last restore_flags()
>shouldn't be there.
>
>--- macserial.c.ORIG Wed Sep 29 02:05:14 1999
>+++ macserial.c Wed Sep 29 02:05:31 1999
>@@ -1381,7 +1381,6 @@
> if (info->xmit_cnt && !tty->stopped && !info->tx_stopped
> && !info->tx_active)
> transmit_chars(info);
>- restore_flags(flags);
> return ret;
> }
This doesn't look like the only problem. For example, in rs_close, we
call tty_wait_until_sent with interrupt disabled. Can't this cause a
deadlock ? There may be other cases like this.
I'll look into adding some fixes and include them in the next kernel I
post on my page (along with a few other stuffs I'd want to get tested,
including your page_alloc() fix which _apparently_ increased the overall
perfs on my machine but I didn't do real benchmarks). But I'm wondering
if we shouldn't include your DMA driver right now and make sure it works
fine instead of doing yet another bunch of patches to the current
macserial. I didn't try the DMA driver yet, are there known problems with it ?
I'll try to make 2.3.x versions of my various patches if I find some time
this week (may have to wait next week end).
On another issue: Is there someone with a 3400 and this famous
interrupt-less ethernet combo out there who knows how to hack into
pmac_pic.c ? I have managed to get the interrupt working with an horrible
hack in de4x5.c, and I'm trying to implement a clean version with a
cascaded controller the way I did if for gatwick on the wallstreet.
Unfortuntately, the clean version doesn't work yet, I don't have one of
those machine to test, and my remote-tester was not able (or didn't have
time) to find out what's going on with the clean version. Any volunteer ?
--
Perso. e-mail: <mailto:bh40@calva.net>
Work e-mail: <mailto:benh@mipsys.com>
BenH. Web : <http://calvaweb.calvacom.fr/bh40/>
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~1999-09-29 9:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <37F1AD4B.585E99AB@chpc.utah.edu>
1999-09-29 7:11 ` [Fwd: Bug: 2.2.12 still hangs PPC after some PPP activity] Geert Uytterhoeven
1999-09-29 7:16 ` Takashi Oe
1999-09-29 7:40 ` Geert Uytterhoeven
1999-09-29 9:13 ` Benjamin Herrenschmidt [this message]
1999-09-30 0:46 ` Takashi Oe
1999-09-30 8:50 ` Benjamin Herrenschmidt
1999-09-30 16:21 ` Takashi Oe
1999-09-30 16:35 ` Benjamin Herrenschmidt
1999-10-06 5:33 ` update on macserial/DMA Takashi Oe
1999-10-06 8:35 ` Benjamin Herrenschmidt
1999-10-06 13:47 ` Takashi Oe
1999-10-06 16:25 ` Benjamin Herrenschmidt
1999-10-06 16:50 ` Benjamin Herrenschmidt
1999-10-08 7:13 ` Lou Langholtz
1999-10-09 17:57 ` Lou Langholtz
[not found] ` <Pine.LNX.3.96LJ1.1b7.991005234830.1210A-100000@ofey.inetne br.com>
1999-10-07 9:48 ` Franz Sirl
1999-10-07 15:37 ` phandel
1999-10-12 7:20 ` [Fwd: Bug: 2.2.12 still hangs PPC after some PPP activity] Lou Langholtz
1999-09-29 16:44 ` Lou Langholtz
1999-09-29 17:02 ` Benjamin Herrenschmidt
1999-09-29 18:08 ` Lou Langholtz
1999-09-29 18:46 ` Lou Langholtz
1999-09-29 20:00 ` Lou Langholtz
1999-09-30 1:14 ` Takashi Oe
1999-09-30 5:33 ` Geert Uytterhoeven
1999-10-01 13:26 ` Franz Sirl
1999-10-01 13:46 ` Alvin Brattli
[not found] ` <Pine.OSF.3.96.991001153658.16772E-100000@mitra.phys.uit.no >
1999-10-01 14:08 ` Franz Sirl
1999-10-01 16:14 ` Lou Langholtz
[not found] <37F1C0A3.B9F25580@chpc.utah.edu>
1999-09-29 7:39 ` Geert Uytterhoeven
1999-09-10 16:51 Lou Langholtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990929111338.022344@mailhost.mipsys.com \
--to=bh40@calva.net \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=toe@unlserve.unl.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.