From: Ryuichi Oikawa <roikawa@rr.iij4u.or.jp>
To: costabel@wanadoo.fr
Cc: linuxppc-dev@lists.linuxppc.org, cort@ppc.kernel.org
Subject: Re: Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4)
Date: Thu, 03 Jun 1999 01:24:40 GMT [thread overview]
Message-ID: <19990603012440G.roikawa@rr.iij4u.or.jp> (raw)
In-Reply-To: Your message of "Wed, 02 Jun 1999 14:19:09 +0200" <3755213D.3BB3C8B6@wanadoo.fr>
From: Martin Costabel <costabel@wanadoo.fr>
Subject: Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4)
> Index: arch/ppc/mm/init.c
> ===================================================================
> RCS file: /cvs/linux/linux/arch/ppc/mm/init.c,v
> retrieving revision 1.165
> retrieving revision 1.166
> diff -u -r1.165 -r1.166
> --- arch/ppc/mm/init.c 1999/05/14 22:37:29 1.165
> +++ arch/ppc/mm/init.c 1999/05/22 18:18:30 1.166
> @@ -1,5 +1,5 @@
> /*
> - * $Id: init.c,v 1.165 1999/05/14 22:37:29 cort Exp $
> + * $Id: init.c,v 1.166 1999/05/22 18:18:30 cort Exp $
> *
> * PowerPC version
> * Copyright (C) 1995-1996 Gary Thomas (gdt@linuxppc.org)
> @@ -402,7 +402,7 @@
> for (i = 0; i < size; i += PAGE_SIZE)
> map_page(&init_task, v+i, p+i, flags);
> out:
> - return (void *) (v + (p & ~PAGE_MASK));
> + return (void *) (v + (addr & ~PAGE_MASK));
> }
>
> void iounmap(void *addr)
>
> This patch had been proposed on May 21 by R. Oikawa and almost
> immediately been corrected, see
> http://lists.linuxppc.org/listarcs/linuxppc-user/199905/msg00680.html
> Unfortunately, the correction didn't make it into the vger tree. I don't
> know if the correction is good, but I never had problems with the
> version before the patch.
Sorry, but please see the newer patch in msg00680.html. Simply replacing
- return (void *) (v + (p & ~PAGE_MASK));
+ return (void *) (v + (addr & ~PAGE_MASK));
breaks iomap for BAT mapped devices(ex. mac-io/heathrow devices such as
ide, mace, bmac, etc.). Please use the newer one.
Regards,
Ryuichi Oikawa
roikawa@rr.iij4u.or.jp
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. Please check http://lists.linuxppc.org/ ]]
[[ and http://www.linuxppc.org/ for useful information before posting. ]]
next prev parent reply other threads:[~1999-06-03 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-05-27 18:25 Problems with vger 2.3.3/4 Martin Costabel
1999-06-02 12:19 ` Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4) Martin Costabel
1999-06-03 1:24 ` Ryuichi Oikawa [this message]
1999-06-03 2:50 ` Paul Mackerras
1999-06-03 6:26 ` Martin Costabel
1999-06-03 22:24 ` Martin Costabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990603012440G.roikawa@rr.iij4u.or.jp \
--to=roikawa@rr.iij4u.or.jp \
--cc=cort@ppc.kernel.org \
--cc=costabel@wanadoo.fr \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.