From: "Stephen C. Tweedie" <sct@redhat.com>
To: masp0008@stud.uni-sb.de, Linus Torvalds <torvalds@transmeta.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Stephen Tweedie <sct@redhat.com>
Subject: [PATCH] Re: swapcache bug?
Date: Mon, 8 Feb 1999 16:39:20 GMT [thread overview]
Message-ID: <199902081639.QAA03290@dax.scot.redhat.com> (raw)
In-Reply-To: <36BDD9B2.8718B21@stud.uni-sb.de>
Hi,
On Sun, 07 Feb 1999 19:21:38 +0100, Manfred Spraul
<masp0008@stud.uni-sb.de> said:
> I'm currently debugging my physical memory ramdisk, and I see lots of
> entries in the page cache that have 'page->offset' which aren't
> multiples of 4096. (they are multiples of 256)
> All of them belong to swapper_inode.
That is normal.
> If this is the intended behaviour, then page_hash() should be changed:
> it assumes that 'page->offset' is a multiple of 4096.
Good point, the line include/linux/pagemap.h:39,
return s(i+o) & (PAGE_HASH_SIZE-1);
should probably be
return s(i+o+offset) & (PAGE_HASH_SIZE-1);
to mix in the low order bits for swap entries. Well spotted. Anyone
see anything wrong with this one-liner change?
--Stephen
--
To unsubscribe, send a message with 'unsubscribe linux-mm my@address'
in the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
next prev parent reply other threads:[~1999-02-08 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-02-07 18:21 swapcache bug? Manfred Spraul
1999-02-07 21:30 ` Eric W. Biederman
1999-02-08 16:39 ` Stephen C. Tweedie [this message]
1999-02-08 17:32 ` [PATCH] " Linus Torvalds
1999-02-08 17:51 ` Stephen C. Tweedie
1999-02-08 18:48 ` Linus Torvalds
1999-02-08 21:13 ` Matti Aarnio
1999-02-09 7:15 ` Eric W. Biederman
1999-02-09 16:32 ` Linus Torvalds
1999-02-10 0:28 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199902081639.QAA03290@dax.scot.redhat.com \
--to=sct@redhat.com \
--cc=linux-mm@kvack.org \
--cc=masp0008@stud.uni-sb.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.