From: Colin Ian King <colin.king@canonical.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: flash: Remove redundant initialization of variable ret
Date: Mon, 16 Aug 2021 08:55:54 +0100 [thread overview]
Message-ID: <1864790c-4547-9e19-e6ed-c9b342e0c6aa@canonical.com> (raw)
In-Reply-To: <20210816065110.GA7500@duo.ucw.cz>
On 16/08/2021 07:51, Pavel Machek wrote:
> Hi!
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The variable ret is being initialized with a value that is never read,
>> it is being updated later on. The assignment is redundant and can be
>> removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> I did this instead; hopefully that's okay with everyone.
>
> Best regards,
> Pavel
Thanks, looks good to me.
Colin
>
> commit 654933ae7d32f278eecd0bb0f175785574ac4775
> Author: Pavel Machek <pavel@ucw.cz>
> Date: Mon Aug 16 08:47:08 2021 +0200
>
> leds: flash: Remove redundant initialization of variable ret
>
> Adjust initialization not to trigger Coverity warnings.
>
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
> index 6eeb9effcf65..185e17055317 100644
> --- a/drivers/leds/led-class-flash.c
> +++ b/drivers/leds/led-class-flash.c
> @@ -92,14 +92,12 @@ static ssize_t flash_strobe_store(struct device *dev,
> struct led_classdev *led_cdev = dev_get_drvdata(dev);
> struct led_classdev_flash *fled_cdev = lcdev_to_flcdev(led_cdev);
> unsigned long state;
> - ssize_t ret = -EINVAL;
> + ssize_t ret = -EBUSY;
>
> mutex_lock(&led_cdev->led_access);
>
> - if (led_sysfs_is_disabled(led_cdev)) {
> - ret = -EBUSY;
> + if (led_sysfs_is_disabled(led_cdev))
> goto unlock;
> - }
>
> ret = kstrtoul(buf, 10, &state);
> if (ret)
>
>
prev parent reply other threads:[~2021-08-16 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 13:25 [PATCH] leds: flash: Remove redundant initialization of variable ret Colin King
2021-08-16 6:51 ` Pavel Machek
2021-08-16 7:55 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1864790c-4547-9e19-e6ed-c9b342e0c6aa@canonical.com \
--to=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.