* [v2 0/2] Add support to paint already mmaped buffer
@ 2024-03-25 9:37 Vandita Kulkarni
2024-03-25 9:37 ` [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped Vandita Kulkarni
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Vandita Kulkarni @ 2024-03-25 9:37 UTC (permalink / raw
To: igt-dev; +Cc: zbigniew.kempczynski, Vandita Kulkarni
On some of the platforms first write after mmap takes longer time,
hence provide and option to just update the fb incase we are resuing
the mmaped fb.
v2: merge patches 1 and 3 from v1 to patch 1, and fix review comments
Vandita Kulkarni (2):
lib/igt_draw: Dont mmap, if the buffer is already mmapped
tests/kms_async_flips: Reuse the already mmapped buffer
lib/igt_draw.c | 61 ++++++++++++++++----------
lib/igt_draw.h | 2 +-
tests/intel/kms_frontbuffer_tracking.c | 2 +-
tests/kms_async_flips.c | 16 +++++--
4 files changed, 52 insertions(+), 29 deletions(-)
--
2.43.2
^ permalink raw reply [flat|nested] 9+ messages in thread
* [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped
2024-03-25 9:37 [v2 0/2] Add support to paint already mmaped buffer Vandita Kulkarni
@ 2024-03-25 9:37 ` Vandita Kulkarni
2024-03-26 6:18 ` Zbigniew Kempczyński
2024-03-26 7:24 ` [v3] " Vandita Kulkarni
2024-03-25 9:37 ` [v2 2/2] tests/kms_async_flips: Reuse the already mmapped buffer Vandita Kulkarni
` (4 subsequent siblings)
5 siblings, 2 replies; 9+ messages in thread
From: Vandita Kulkarni @ 2024-03-25 9:37 UTC (permalink / raw
To: igt-dev; +Cc: zbigniew.kempczynski, Vandita Kulkarni
This will help add support to tests which would reuse the
same fbs and would not want to mmap again and would just
want to update the fbs.
v2: Handle non null buf ptr cases in non WC mmap cases.
Squash changes in kms_frontbuffer_tracking which is using
this function. (Zbigniew)
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
---
lib/igt_draw.c | 61 ++++++++++++++++----------
lib/igt_draw.h | 2 +-
tests/intel/kms_frontbuffer_tracking.c | 2 +-
3 files changed, 39 insertions(+), 26 deletions(-)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 2c01d7b02..6a3b55377 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -75,6 +75,7 @@ struct buf_data {
uint32_t handle;
uint32_t size;
uint32_t stride;
+ void *buf_ptr;
int width;
int height;
int bpp;
@@ -448,6 +449,8 @@ static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
{
uint32_t *ptr;
+ igt_assert(buf->buf_ptr != NULL);
+
gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_CPU,
I915_GEM_DOMAIN_CPU);
@@ -483,6 +486,8 @@ static void draw_rect_mmap_gtt(int fd, struct buf_data *buf, struct rect *rect,
{
uint32_t *ptr;
+ igt_assert(buf->buf_ptr != NULL);
+
gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
I915_GEM_DOMAIN_GTT);
@@ -499,28 +504,32 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
{
uint32_t *ptr;
- if (is_i915_device(fd)) {
- gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
- I915_GEM_DOMAIN_GTT);
-
- /* We didn't implement suport for the older tiling methods yet. */
- if (tiling != I915_TILING_NONE)
- igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
-
- if (gem_has_lmem(fd))
- ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
- PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
- else if (gem_has_legacy_mmap(fd))
- ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
- else
- ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
- PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
+ if (!buf->buf_ptr) {
+ if (is_i915_device(fd)) {
+ gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
+ I915_GEM_DOMAIN_GTT);
+
+ /* We didn't implement suport for the older tiling methods yet. */
+ if (tiling != I915_TILING_NONE)
+ igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
+
+ if (gem_has_lmem(fd))
+ ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
+ PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ else if (gem_has_legacy_mmap(fd))
+ ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ else
+ ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
+ PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ } else {
+ ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size,
+ PROT_READ | PROT_WRITE);
+ }
} else {
- ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size,
- PROT_READ | PROT_WRITE);
+ ptr = buf->buf_ptr;
}
switch (tiling) {
@@ -538,7 +547,8 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
break;
}
- igt_assert(gem_munmap(ptr, buf->size) == 0);
+ if (ptr != buf->buf_ptr)
+ igt_assert(gem_munmap(ptr, buf->size) == 0);
}
static void draw_rect_pwrite_untiled(int fd, struct buf_data *buf,
@@ -839,6 +849,8 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
* @buf_handle: the handle of the buffer where you're going to draw to
* @buf_size: the size of the buffer
* @buf_stride: the stride of the buffer
+ * @buf_ptr: if required can be used to pass already mmapped buffer ptr
+ * only in case of wc mmap, can be NULL in any other case.
* @buf_width: the width of the buffer
* @buf_height: the height of the buffer
* @tiling: the tiling of the buffer
@@ -855,7 +867,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
*/
void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
- int buf_width, int buf_height,
+ void *buf_ptr, int buf_width, int buf_height,
uint32_t tiling, enum igt_draw_method method,
int rect_x, int rect_y, int rect_w, int rect_h,
uint32_t color, int bpp)
@@ -870,6 +882,7 @@ void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
.handle = buf_handle,
.size = buf_size,
.stride = buf_stride,
+ .buf_ptr = buf_ptr,
.width = buf_width,
.height = buf_height,
.bpp = bpp,
@@ -935,7 +948,7 @@ void igt_draw_rect_fb(int fd, struct buf_ops *bops,
int rect_w, int rect_h, uint32_t color)
{
igt_draw_rect(fd, bops, ctx, fb->gem_handle, fb->size, fb->strides[0],
- fb->width, fb->height,
+ fb->driver_priv, fb->width, fb->height,
igt_fb_mod_to_tiling(fb->modifier), method,
rect_x, rect_y, rect_w, rect_h, color,
igt_drm_format_to_bpp(fb->drm_format));
diff --git a/lib/igt_draw.h b/lib/igt_draw.h
index 1dec95e86..865641ef6 100644
--- a/lib/igt_draw.h
+++ b/lib/igt_draw.h
@@ -54,7 +54,7 @@ bool igt_draw_supports_method(int fd, enum igt_draw_method method);
void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
- int buf_width, int buf_height,
+ void *buf_ptr, int buf_width, int buf_height,
uint32_t tiling, enum igt_draw_method method,
int rect_x, int rect_y, int rect_w, int rect_h,
uint32_t color, int bpp);
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index db2db0ff1..392539408 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -2254,7 +2254,7 @@ static void *busy_thread_func(void *data)
{
while (!busy_thread.stop)
igt_draw_rect(drm.fd, drm.bops, 0, busy_thread.handle,
- busy_thread.size, busy_thread.stride,
+ busy_thread.size, busy_thread.stride, NULL,
busy_thread.width, busy_thread.height,
busy_thread.tiling, IGT_DRAW_BLT, 0, 0,
busy_thread.width, busy_thread.height,
--
2.43.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [v2 2/2] tests/kms_async_flips: Reuse the already mmapped buffer
2024-03-25 9:37 [v2 0/2] Add support to paint already mmaped buffer Vandita Kulkarni
2024-03-25 9:37 ` [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped Vandita Kulkarni
@ 2024-03-25 9:37 ` Vandita Kulkarni
2024-03-25 13:32 ` ✗ Fi.CI.BAT: failure for Add support to paint already mmaped buffer (rev2) Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Vandita Kulkarni @ 2024-03-25 9:37 UTC (permalink / raw
To: igt-dev; +Cc: zbigniew.kempczynski, Vandita Kulkarni
In crc test case where we are trying to update the fb
dont mmap it agian. On some platforms it was found that
updating a newly mmapped buffer takes longer time.
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
tests/kms_async_flips.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 2895168f7..4658ca4c0 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -221,12 +221,19 @@ static void test_init_fbs(data_t *data)
prev_modifier = data->modifier;
if (data->bufs[0].fb_id) {
- for (i = 0; i < NUM_FBS; i++)
+ for (i = 0; i < NUM_FBS; i++) {
+ if (is_intel_device(data->drm_fd))
+ igt_fb_unmap_buffer(&data->bufs[i], data->bufs[i].driver_priv);
igt_remove_fb(data->drm_fd, &data->bufs[i]);
+ }
}
- for (i = 0; i < NUM_FBS; i++)
+ for (i = 0; i < NUM_FBS; i++) {
make_fb(data, &data->bufs[i], width, height, i);
+ if (is_intel_device(data->drm_fd))
+ data->bufs[i].driver_priv = igt_fb_map_buffer(data->drm_fd,
+ &data->bufs[i]);
+ }
}
igt_plane_set_fb(data->plane, &data->bufs[0]);
@@ -730,8 +737,11 @@ igt_main
}
igt_fixture {
- for (i = 0; i < NUM_FBS; i++)
+ for (i = 0; i < NUM_FBS; i++) {
+ if (is_intel_device(data.drm_fd))
+ igt_fb_unmap_buffer(&data.bufs[i], data.bufs[i].driver_priv);
igt_remove_fb(data.drm_fd, &data.bufs[i]);
+ }
if (is_intel_device(data.drm_fd))
buf_ops_destroy(data.bops);
--
2.43.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for Add support to paint already mmaped buffer (rev2)
2024-03-25 9:37 [v2 0/2] Add support to paint already mmaped buffer Vandita Kulkarni
2024-03-25 9:37 ` [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped Vandita Kulkarni
2024-03-25 9:37 ` [v2 2/2] tests/kms_async_flips: Reuse the already mmapped buffer Vandita Kulkarni
@ 2024-03-25 13:32 ` Patchwork
2024-03-25 13:42 ` ✓ CI.xeBAT: success " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-03-25 13:32 UTC (permalink / raw
To: Vandita Kulkarni; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 20534 bytes --]
== Series Details ==
Series: Add support to paint already mmaped buffer (rev2)
URL : https://patchwork.freedesktop.org/series/131167/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14478 -> IGTPW_10899
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_10899 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10899, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/index.html
Participating hosts (36 -> 34)
------------------------------
Additional (2): bat-atsm-1 bat-arls-3
Missing (4): bat-dg2-11 fi-cfl-8109u fi-snb-2520m fi-kbl-8809g
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_10899:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@basic:
- bat-adln-1: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-adln-1/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-adln-1/igt@kms_frontbuffer_tracking@basic.html
- fi-ivb-3770: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-ivb-3770/igt@kms_frontbuffer_tracking@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-ivb-3770/igt@kms_frontbuffer_tracking@basic.html
- bat-mtlp-8: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-mtlp-8/igt@kms_frontbuffer_tracking@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-mtlp-8/igt@kms_frontbuffer_tracking@basic.html
- bat-adls-6: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-adls-6/igt@kms_frontbuffer_tracking@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-adls-6/igt@kms_frontbuffer_tracking@basic.html
- fi-ilk-650: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-ilk-650/igt@kms_frontbuffer_tracking@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-ilk-650/igt@kms_frontbuffer_tracking@basic.html
- bat-jsl-1: [PASS][11] -> [FAIL][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-jsl-1/igt@kms_frontbuffer_tracking@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-jsl-1/igt@kms_frontbuffer_tracking@basic.html
- fi-tgl-1115g4: [PASS][13] -> [FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-tgl-1115g4/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-tgl-1115g4/igt@kms_frontbuffer_tracking@basic.html
- bat-arls-1: [PASS][15] -> [FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-arls-1/igt@kms_frontbuffer_tracking@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-1/igt@kms_frontbuffer_tracking@basic.html
- bat-arls-3: NOTRUN -> [FAIL][17]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_frontbuffer_tracking@basic.html
- bat-adlp-6: [PASS][18] -> [FAIL][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-adlp-6/igt@kms_frontbuffer_tracking@basic.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-adlp-6/igt@kms_frontbuffer_tracking@basic.html
- bat-dg1-7: [PASS][20] -> [FAIL][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-dg1-7/igt@kms_frontbuffer_tracking@basic.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg1-7/igt@kms_frontbuffer_tracking@basic.html
- fi-glk-j4005: [PASS][22] -> [FAIL][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-glk-j4005/igt@kms_frontbuffer_tracking@basic.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-glk-j4005/igt@kms_frontbuffer_tracking@basic.html
- bat-adlp-9: [PASS][24] -> [FAIL][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-adlp-9/igt@kms_frontbuffer_tracking@basic.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-adlp-9/igt@kms_frontbuffer_tracking@basic.html
- fi-kbl-7567u: [PASS][26] -> [FAIL][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-kbl-7567u/igt@kms_frontbuffer_tracking@basic.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-kbl-7567u/igt@kms_frontbuffer_tracking@basic.html
- fi-cfl-8700k: [PASS][28] -> [FAIL][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-cfl-8700k/igt@kms_frontbuffer_tracking@basic.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-cfl-8700k/igt@kms_frontbuffer_tracking@basic.html
- bat-dg2-14: [PASS][30] -> [FAIL][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-dg2-14/igt@kms_frontbuffer_tracking@basic.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-14/igt@kms_frontbuffer_tracking@basic.html
- fi-bsw-nick: [PASS][32] -> [FAIL][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html
- bat-rplp-1: [PASS][34] -> [FAIL][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-rplp-1/igt@kms_frontbuffer_tracking@basic.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-rplp-1/igt@kms_frontbuffer_tracking@basic.html
- fi-rkl-11600: [PASS][36] -> [FAIL][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-rkl-11600/igt@kms_frontbuffer_tracking@basic.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-rkl-11600/igt@kms_frontbuffer_tracking@basic.html
- fi-cfl-guc: [PASS][38] -> [FAIL][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-cfl-guc/igt@kms_frontbuffer_tracking@basic.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-cfl-guc/igt@kms_frontbuffer_tracking@basic.html
- bat-jsl-3: [PASS][40] -> [FAIL][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-jsl-3/igt@kms_frontbuffer_tracking@basic.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-jsl-3/igt@kms_frontbuffer_tracking@basic.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@basic:
- fi-elk-e7500: [SKIP][42] -> [FAIL][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/fi-elk-e7500/igt@kms_frontbuffer_tracking@basic.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/fi-elk-e7500/igt@kms_frontbuffer_tracking@basic.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_frontbuffer_tracking@basic:
- {bat-mtlp-9}: [PASS][44] -> [FAIL][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-mtlp-9/igt@kms_frontbuffer_tracking@basic.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-mtlp-9/igt@kms_frontbuffer_tracking@basic.html
Known issues
------------
Here are the changes found in IGTPW_10899 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-arls-3: NOTRUN -> [SKIP][46] ([i915#9318])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@debugfs_test@basic-hwmon.html
* igt@gem_huc_copy@huc-copy:
- bat-atsm-1: NOTRUN -> [FAIL][47] ([i915#10563])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-arls-3: NOTRUN -> [SKIP][48] ([i915#10213]) +3 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][49] ([i915#4083])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@gem_mmap@basic.html
- bat-arls-3: NOTRUN -> [SKIP][50] ([i915#4083])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-arls-3: NOTRUN -> [SKIP][51] ([i915#10197] / [i915#10211] / [i915#4079])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- bat-arls-3: NOTRUN -> [SKIP][52] ([i915#10196] / [i915#4077]) +2 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][53] ([i915#4079]) +1 other test skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@gem_tiled_pread_basic.html
- bat-arls-3: NOTRUN -> [SKIP][54] ([i915#10206] / [i915#4079])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-atsm-1: NOTRUN -> [SKIP][55] ([i915#6621])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@i915_pm_rps@basic-api.html
- bat-dg2-9: NOTRUN -> [SKIP][56] ([i915#6621])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@i915_pm_rps@basic-api.html
- bat-arls-3: NOTRUN -> [SKIP][57] ([i915#10209])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gem:
- bat-atsm-1: NOTRUN -> [ABORT][58] ([i915#10564])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@guc_multi_lrc:
- bat-dg2-14: [PASS][59] -> [ABORT][60] ([i915#10366])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14478/bat-dg2-14/igt@i915_selftest@live@guc_multi_lrc.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-14/igt@i915_selftest@live@guc_multi_lrc.html
* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-arls-3: NOTRUN -> [SKIP][61] ([i915#10200]) +9 other tests skip
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][62] ([i915#6077]) +37 other tests skip
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@kms_addfb_basic@size-max.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-arls-3: NOTRUN -> [SKIP][63] ([i915#10202]) +1 other test skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-atsm-1: NOTRUN -> [SKIP][64] ([i915#6078]) +22 other tests skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_dsc@dsc-basic:
- bat-arls-3: NOTRUN -> [SKIP][65] ([i915#9886])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-arls-3: NOTRUN -> [SKIP][66] ([i915#10207])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg2-9: NOTRUN -> [SKIP][67]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-atsm-1: NOTRUN -> [SKIP][68] ([i915#6093]) +4 other tests skip
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html
- bat-dg2-9: NOTRUN -> [SKIP][69] ([i915#5274])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
- bat-atsm-1: NOTRUN -> [SKIP][70] ([i915#1836]) +6 other tests skip
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-dg2-9: NOTRUN -> [SKIP][71] ([i915#9197]) +6 other tests skip
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@kms_pipe_crc_basic@hang-read-crc.html
* igt@kms_pm_backlight@basic-brightness:
- bat-arls-3: NOTRUN -> [SKIP][72] ([i915#9812])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_pm_backlight@basic-brightness.html
- bat-dg2-9: NOTRUN -> [SKIP][73] ([i915#5354]) +1 other test skip
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][74] ([i915#7357])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@kms_prop_blob@basic.html
* igt@kms_psr@psr-primary-mmap-gtt:
- bat-arls-3: NOTRUN -> [SKIP][75] ([i915#9732]) +3 other tests skip
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_psr@psr-primary-mmap-gtt.html
* igt@kms_psr@psr-sprite-plane-onoff:
- bat-dg2-9: NOTRUN -> [SKIP][76] ([i915#1072] / [i915#9673] / [i915#9732]) +3 other tests skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@kms_psr@psr-sprite-plane-onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: NOTRUN -> [SKIP][77] ([i915#6094])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg2-9: NOTRUN -> [SKIP][78] ([i915#3555])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
- bat-arls-3: NOTRUN -> [SKIP][79] ([i915#10208] / [i915#8809])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-9: NOTRUN -> [SKIP][80] ([i915#3708] / [i915#9197])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-atsm-1: NOTRUN -> [SKIP][81] ([i915#4077]) +4 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html
- bat-arls-3: NOTRUN -> [SKIP][82] ([i915#10196] / [i915#3708] / [i915#4077]) +1 other test skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@prime_vgem@basic-fence-mmap.html
- bat-dg2-9: NOTRUN -> [SKIP][83] ([i915#3708] / [i915#4077]) +1 other test skip
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- bat-arls-3: NOTRUN -> [SKIP][84] ([i915#10212] / [i915#3708])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-read:
- bat-arls-3: NOTRUN -> [SKIP][85] ([i915#10214] / [i915#3708])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][86] +2 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-atsm-1/igt@prime_vgem@basic-write.html
- bat-dg2-9: NOTRUN -> [SKIP][87] ([i915#3291] / [i915#3708]) +2 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-dg2-9/igt@prime_vgem@basic-write.html
- bat-arls-3: NOTRUN -> [SKIP][88] ([i915#10216] / [i915#3708])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/bat-arls-3/igt@prime_vgem@basic-write.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10196]: https://gitlab.freedesktop.org/drm/intel/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/intel/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/intel/issues/10200
[i915#10202]: https://gitlab.freedesktop.org/drm/intel/issues/10202
[i915#10206]: https://gitlab.freedesktop.org/drm/intel/issues/10206
[i915#10207]: https://gitlab.freedesktop.org/drm/intel/issues/10207
[i915#10208]: https://gitlab.freedesktop.org/drm/intel/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/intel/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/intel/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/intel/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/intel/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/intel/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/intel/issues/10216
[i915#10366]: https://gitlab.freedesktop.org/drm/intel/issues/10366
[i915#10435]: https://gitlab.freedesktop.org/drm/intel/issues/10435
[i915#10563]: https://gitlab.freedesktop.org/drm/intel/issues/10563
[i915#10564]: https://gitlab.freedesktop.org/drm/intel/issues/10564
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
[i915#9157]: https://gitlab.freedesktop.org/drm/intel/issues/9157
[i915#9197]: https://gitlab.freedesktop.org/drm/intel/issues/9197
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
[i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/intel/issues/9812
[i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7780 -> IGTPW_10899
CI-20190529: 20190529
CI_DRM_14478: fc736bbab7abcae683f52604591fe16cf2a85b3e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10899: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/index.html
IGT_7780: 93a5298ac980333738cf75da6b66fa6f3769205f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
-igt@xe_exec_fault_mode@invalid-va
-igt@xe_exec_fault_mode@invalid-va-scratch-nopagefault
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/index.html
[-- Attachment #2: Type: text/html, Size: 22990 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ CI.xeBAT: success for Add support to paint already mmaped buffer (rev2)
2024-03-25 9:37 [v2 0/2] Add support to paint already mmaped buffer Vandita Kulkarni
` (2 preceding siblings ...)
2024-03-25 13:32 ` ✗ Fi.CI.BAT: failure for Add support to paint already mmaped buffer (rev2) Patchwork
@ 2024-03-25 13:42 ` Patchwork
2024-03-26 8:00 ` ✓ CI.xeBAT: success for Add support to paint already mmaped buffer (rev3) Patchwork
2024-03-26 8:11 ` ✗ Fi.CI.BAT: failure " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-03-25 13:42 UTC (permalink / raw
To: Vandita Kulkarni; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 2668 bytes --]
== Series Details ==
Series: Add support to paint already mmaped buffer (rev2)
URL : https://patchwork.freedesktop.org/series/131167/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7780_BAT -> XEIGTPW_10899_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in XEIGTPW_10899_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@xe_evict@evict-beng-small:
- bat-dg2-oem2: [PASS][1] -> [DMESG-WARN][2] ([Intel XE#1373])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7780/bat-dg2-oem2/igt@xe_evict@evict-beng-small.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10899/bat-dg2-oem2/igt@xe_evict@evict-beng-small.html
#### Warnings ####
* igt@xe_evict@evict-beng-mixed-threads-small-multi-vm:
- bat-dg2-oem2: [FAIL][3] ([Intel XE#1259]) -> [TIMEOUT][4] ([Intel XE#1088])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7780/bat-dg2-oem2/igt@xe_evict@evict-beng-mixed-threads-small-multi-vm.html
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10899/bat-dg2-oem2/igt@xe_evict@evict-beng-mixed-threads-small-multi-vm.html
* igt@xe_evict@evict-cm-threads-small:
- bat-dg2-oem2: [TIMEOUT][5] ([Intel XE#1088]) -> [INCOMPLETE][6] ([Intel XE#804])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7780/bat-dg2-oem2/igt@xe_evict@evict-cm-threads-small.html
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10899/bat-dg2-oem2/igt@xe_evict@evict-cm-threads-small.html
[Intel XE#1088]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1088
[Intel XE#1259]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1259
[Intel XE#1373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1373
[Intel XE#804]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/804
Build changes
-------------
* IGT: IGT_7780 -> IGTPW_10899
* Linux: xe-984-093d82c02921344d8d400989af156aaf79b9d961 -> xe-987-fc736bbab7abcae683f52604591fe16cf2a85b3e
IGTPW_10899: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10899/index.html
IGT_7780: 93a5298ac980333738cf75da6b66fa6f3769205f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-984-093d82c02921344d8d400989af156aaf79b9d961: 093d82c02921344d8d400989af156aaf79b9d961
xe-987-fc736bbab7abcae683f52604591fe16cf2a85b3e: fc736bbab7abcae683f52604591fe16cf2a85b3e
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10899/index.html
[-- Attachment #2: Type: text/html, Size: 3363 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped
2024-03-25 9:37 ` [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped Vandita Kulkarni
@ 2024-03-26 6:18 ` Zbigniew Kempczyński
2024-03-26 7:24 ` [v3] " Vandita Kulkarni
1 sibling, 0 replies; 9+ messages in thread
From: Zbigniew Kempczyński @ 2024-03-26 6:18 UTC (permalink / raw
To: Vandita Kulkarni; +Cc: igt-dev
On Mon, Mar 25, 2024 at 03:07:29PM +0530, Vandita Kulkarni wrote:
> This will help add support to tests which would reuse the
> same fbs and would not want to mmap again and would just
> want to update the fbs.
>
> v2: Handle non null buf ptr cases in non WC mmap cases.
> Squash changes in kms_frontbuffer_tracking which is using
> this function. (Zbigniew)
>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
> lib/igt_draw.c | 61 ++++++++++++++++----------
> lib/igt_draw.h | 2 +-
> tests/intel/kms_frontbuffer_tracking.c | 2 +-
> 3 files changed, 39 insertions(+), 26 deletions(-)
>
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index 2c01d7b02..6a3b55377 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -75,6 +75,7 @@ struct buf_data {
> uint32_t handle;
> uint32_t size;
> uint32_t stride;
> + void *buf_ptr;
> int width;
> int height;
> int bpp;
> @@ -448,6 +449,8 @@ static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
> {
> uint32_t *ptr;
>
> + igt_assert(buf->buf_ptr != NULL);
> +
Seems you want the opposite, I mean igt_assert_eq(buf->buf_ptr, NULL);
as you're doing mmaping here.
> gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_CPU,
> I915_GEM_DOMAIN_CPU);
>
> @@ -483,6 +486,8 @@ static void draw_rect_mmap_gtt(int fd, struct buf_data *buf, struct rect *rect,
> {
> uint32_t *ptr;
>
> + igt_assert(buf->buf_ptr != NULL);
Same like above.
--
Zbigniew
> +
> gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
> I915_GEM_DOMAIN_GTT);
>
> @@ -499,28 +504,32 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
> {
> uint32_t *ptr;
>
> - if (is_i915_device(fd)) {
> - gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
> - I915_GEM_DOMAIN_GTT);
> -
> - /* We didn't implement suport for the older tiling methods yet. */
> - if (tiling != I915_TILING_NONE)
> - igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
> -
> - if (gem_has_lmem(fd))
> - ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
> - PAGE_ALIGN(buf->size),
> - PROT_READ | PROT_WRITE);
> - else if (gem_has_legacy_mmap(fd))
> - ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
> - PROT_READ | PROT_WRITE);
> - else
> - ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
> - PAGE_ALIGN(buf->size),
> - PROT_READ | PROT_WRITE);
> + if (!buf->buf_ptr) {
> + if (is_i915_device(fd)) {
> + gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
> + I915_GEM_DOMAIN_GTT);
> +
> + /* We didn't implement suport for the older tiling methods yet. */
> + if (tiling != I915_TILING_NONE)
> + igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
> +
> + if (gem_has_lmem(fd))
> + ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
> + PAGE_ALIGN(buf->size),
> + PROT_READ | PROT_WRITE);
> + else if (gem_has_legacy_mmap(fd))
> + ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
> + PROT_READ | PROT_WRITE);
> + else
> + ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
> + PAGE_ALIGN(buf->size),
> + PROT_READ | PROT_WRITE);
> + } else {
> + ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size,
> + PROT_READ | PROT_WRITE);
> + }
> } else {
> - ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size,
> - PROT_READ | PROT_WRITE);
> + ptr = buf->buf_ptr;
> }
>
> switch (tiling) {
> @@ -538,7 +547,8 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
> break;
> }
>
> - igt_assert(gem_munmap(ptr, buf->size) == 0);
> + if (ptr != buf->buf_ptr)
> + igt_assert(gem_munmap(ptr, buf->size) == 0);
> }
>
> static void draw_rect_pwrite_untiled(int fd, struct buf_data *buf,
> @@ -839,6 +849,8 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
> * @buf_handle: the handle of the buffer where you're going to draw to
> * @buf_size: the size of the buffer
> * @buf_stride: the stride of the buffer
> + * @buf_ptr: if required can be used to pass already mmapped buffer ptr
> + * only in case of wc mmap, can be NULL in any other case.
> * @buf_width: the width of the buffer
> * @buf_height: the height of the buffer
> * @tiling: the tiling of the buffer
> @@ -855,7 +867,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
> */
> void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
> uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
> - int buf_width, int buf_height,
> + void *buf_ptr, int buf_width, int buf_height,
> uint32_t tiling, enum igt_draw_method method,
> int rect_x, int rect_y, int rect_w, int rect_h,
> uint32_t color, int bpp)
> @@ -870,6 +882,7 @@ void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
> .handle = buf_handle,
> .size = buf_size,
> .stride = buf_stride,
> + .buf_ptr = buf_ptr,
> .width = buf_width,
> .height = buf_height,
> .bpp = bpp,
> @@ -935,7 +948,7 @@ void igt_draw_rect_fb(int fd, struct buf_ops *bops,
> int rect_w, int rect_h, uint32_t color)
> {
> igt_draw_rect(fd, bops, ctx, fb->gem_handle, fb->size, fb->strides[0],
> - fb->width, fb->height,
> + fb->driver_priv, fb->width, fb->height,
> igt_fb_mod_to_tiling(fb->modifier), method,
> rect_x, rect_y, rect_w, rect_h, color,
> igt_drm_format_to_bpp(fb->drm_format));
> diff --git a/lib/igt_draw.h b/lib/igt_draw.h
> index 1dec95e86..865641ef6 100644
> --- a/lib/igt_draw.h
> +++ b/lib/igt_draw.h
> @@ -54,7 +54,7 @@ bool igt_draw_supports_method(int fd, enum igt_draw_method method);
>
> void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
> uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
> - int buf_width, int buf_height,
> + void *buf_ptr, int buf_width, int buf_height,
> uint32_t tiling, enum igt_draw_method method,
> int rect_x, int rect_y, int rect_w, int rect_h,
> uint32_t color, int bpp);
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index db2db0ff1..392539408 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -2254,7 +2254,7 @@ static void *busy_thread_func(void *data)
> {
> while (!busy_thread.stop)
> igt_draw_rect(drm.fd, drm.bops, 0, busy_thread.handle,
> - busy_thread.size, busy_thread.stride,
> + busy_thread.size, busy_thread.stride, NULL,
> busy_thread.width, busy_thread.height,
> busy_thread.tiling, IGT_DRAW_BLT, 0, 0,
> busy_thread.width, busy_thread.height,
> --
> 2.43.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [v3] lib/igt_draw: Dont mmap, if the buffer is already mmapped
2024-03-25 9:37 ` [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped Vandita Kulkarni
2024-03-26 6:18 ` Zbigniew Kempczyński
@ 2024-03-26 7:24 ` Vandita Kulkarni
1 sibling, 0 replies; 9+ messages in thread
From: Vandita Kulkarni @ 2024-03-26 7:24 UTC (permalink / raw
To: igt-dev; +Cc: zbigniew.kempczynski, Vandita Kulkarni
This will help add support to tests which would reuse the
same fbs and would not want to mmap again and would just
want to update the fbs.
v2: Handle non null buf ptr cases in non WC mmap cases.
Squash changes in kms_frontbuffer_tracking which is using
this function. (Zbigniew)
v3: Fix the buf ptr handling in non WC mmap cases (Zbigniew)
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
---
lib/igt_draw.c | 61 ++++++++++++++++----------
lib/igt_draw.h | 2 +-
tests/intel/kms_frontbuffer_tracking.c | 2 +-
3 files changed, 39 insertions(+), 26 deletions(-)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 2c01d7b02..a4d5f2f0e 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -75,6 +75,7 @@ struct buf_data {
uint32_t handle;
uint32_t size;
uint32_t stride;
+ void *buf_ptr;
int width;
int height;
int bpp;
@@ -448,6 +449,8 @@ static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
{
uint32_t *ptr;
+ igt_assert(buf->buf_ptr == NULL);
+
gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_CPU,
I915_GEM_DOMAIN_CPU);
@@ -483,6 +486,8 @@ static void draw_rect_mmap_gtt(int fd, struct buf_data *buf, struct rect *rect,
{
uint32_t *ptr;
+ igt_assert(buf->buf_ptr == NULL);
+
gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
I915_GEM_DOMAIN_GTT);
@@ -499,28 +504,32 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
{
uint32_t *ptr;
- if (is_i915_device(fd)) {
- gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
- I915_GEM_DOMAIN_GTT);
-
- /* We didn't implement suport for the older tiling methods yet. */
- if (tiling != I915_TILING_NONE)
- igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
-
- if (gem_has_lmem(fd))
- ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
- PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
- else if (gem_has_legacy_mmap(fd))
- ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
- else
- ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
- PAGE_ALIGN(buf->size),
- PROT_READ | PROT_WRITE);
+ if (!buf->buf_ptr) {
+ if (is_i915_device(fd)) {
+ gem_set_domain(fd, buf->handle, I915_GEM_DOMAIN_GTT,
+ I915_GEM_DOMAIN_GTT);
+
+ /* We didn't implement suport for the older tiling methods yet. */
+ if (tiling != I915_TILING_NONE)
+ igt_require(intel_display_ver(intel_get_drm_devid(fd)) >= 5);
+
+ if (gem_has_lmem(fd))
+ ptr = gem_mmap_offset__fixed(fd, buf->handle, 0,
+ PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ else if (gem_has_legacy_mmap(fd))
+ ptr = gem_mmap__wc(fd, buf->handle, 0, PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ else
+ ptr = gem_mmap_offset__wc(fd, buf->handle, 0,
+ PAGE_ALIGN(buf->size),
+ PROT_READ | PROT_WRITE);
+ } else {
+ ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size,
+ PROT_READ | PROT_WRITE);
+ }
} else {
- ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size,
- PROT_READ | PROT_WRITE);
+ ptr = buf->buf_ptr;
}
switch (tiling) {
@@ -538,7 +547,8 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
break;
}
- igt_assert(gem_munmap(ptr, buf->size) == 0);
+ if (ptr != buf->buf_ptr)
+ igt_assert(gem_munmap(ptr, buf->size) == 0);
}
static void draw_rect_pwrite_untiled(int fd, struct buf_data *buf,
@@ -839,6 +849,8 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
* @buf_handle: the handle of the buffer where you're going to draw to
* @buf_size: the size of the buffer
* @buf_stride: the stride of the buffer
+ * @buf_ptr: if required can be used to pass already mmapped buffer ptr
+ * only in case of wc mmap, can be NULL in any other case.
* @buf_width: the width of the buffer
* @buf_height: the height of the buffer
* @tiling: the tiling of the buffer
@@ -855,7 +867,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
*/
void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
- int buf_width, int buf_height,
+ void *buf_ptr, int buf_width, int buf_height,
uint32_t tiling, enum igt_draw_method method,
int rect_x, int rect_y, int rect_w, int rect_h,
uint32_t color, int bpp)
@@ -870,6 +882,7 @@ void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
.handle = buf_handle,
.size = buf_size,
.stride = buf_stride,
+ .buf_ptr = buf_ptr,
.width = buf_width,
.height = buf_height,
.bpp = bpp,
@@ -935,7 +948,7 @@ void igt_draw_rect_fb(int fd, struct buf_ops *bops,
int rect_w, int rect_h, uint32_t color)
{
igt_draw_rect(fd, bops, ctx, fb->gem_handle, fb->size, fb->strides[0],
- fb->width, fb->height,
+ fb->driver_priv, fb->width, fb->height,
igt_fb_mod_to_tiling(fb->modifier), method,
rect_x, rect_y, rect_w, rect_h, color,
igt_drm_format_to_bpp(fb->drm_format));
diff --git a/lib/igt_draw.h b/lib/igt_draw.h
index 1dec95e86..865641ef6 100644
--- a/lib/igt_draw.h
+++ b/lib/igt_draw.h
@@ -54,7 +54,7 @@ bool igt_draw_supports_method(int fd, enum igt_draw_method method);
void igt_draw_rect(int fd, struct buf_ops *bops, uint32_t ctx,
uint32_t buf_handle, uint32_t buf_size, uint32_t buf_stride,
- int buf_width, int buf_height,
+ void *buf_ptr, int buf_width, int buf_height,
uint32_t tiling, enum igt_draw_method method,
int rect_x, int rect_y, int rect_w, int rect_h,
uint32_t color, int bpp);
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index db2db0ff1..392539408 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -2254,7 +2254,7 @@ static void *busy_thread_func(void *data)
{
while (!busy_thread.stop)
igt_draw_rect(drm.fd, drm.bops, 0, busy_thread.handle,
- busy_thread.size, busy_thread.stride,
+ busy_thread.size, busy_thread.stride, NULL,
busy_thread.width, busy_thread.height,
busy_thread.tiling, IGT_DRAW_BLT, 0, 0,
busy_thread.width, busy_thread.height,
--
2.43.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✓ CI.xeBAT: success for Add support to paint already mmaped buffer (rev3)
2024-03-25 9:37 [v2 0/2] Add support to paint already mmaped buffer Vandita Kulkarni
` (3 preceding siblings ...)
2024-03-25 13:42 ` ✓ CI.xeBAT: success " Patchwork
@ 2024-03-26 8:00 ` Patchwork
2024-03-26 8:11 ` ✗ Fi.CI.BAT: failure " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-03-26 8:00 UTC (permalink / raw
To: Vandita Kulkarni; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]
== Series Details ==
Series: Add support to paint already mmaped buffer (rev3)
URL : https://patchwork.freedesktop.org/series/131167/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7782_BAT -> XEIGTPW_10913_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 3)
------------------------------
Missing (1): bat-dg2-oem2
Known issues
------------
Here are the changes found in XEIGTPW_10913_BAT that come from known issues:
### IGT changes ###
#### Warnings ####
* igt@xe_exec_threads@threads-mixed-userptr-invalidate:
- bat-adlp-7: [INCOMPLETE][1] ([Intel XE#1044] / [Intel XE#1376]) -> [INCOMPLETE][2] ([Intel XE#1044])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7782/bat-adlp-7/igt@xe_exec_threads@threads-mixed-userptr-invalidate.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10913/bat-adlp-7/igt@xe_exec_threads@threads-mixed-userptr-invalidate.html
[Intel XE#1044]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1044
[Intel XE#1376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1376
Build changes
-------------
* IGT: IGT_7782 -> IGTPW_10913
* Linux: xe-988-d1ecfbbbb194e8f7941bd84f77f7c938b461ce14 -> xe-991-4a8fabcf2f1aadbbb777a94edd01549c2aa95caf
IGTPW_10913: 10913
IGT_7782: a404f73182948e843640d00cc279883391cf6ef4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-988-d1ecfbbbb194e8f7941bd84f77f7c938b461ce14: d1ecfbbbb194e8f7941bd84f77f7c938b461ce14
xe-991-4a8fabcf2f1aadbbb777a94edd01549c2aa95caf: 4a8fabcf2f1aadbbb777a94edd01549c2aa95caf
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10913/index.html
[-- Attachment #2: Type: text/html, Size: 2402 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for Add support to paint already mmaped buffer (rev3)
2024-03-25 9:37 [v2 0/2] Add support to paint already mmaped buffer Vandita Kulkarni
` (4 preceding siblings ...)
2024-03-26 8:00 ` ✓ CI.xeBAT: success for Add support to paint already mmaped buffer (rev3) Patchwork
@ 2024-03-26 8:11 ` Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-03-26 8:11 UTC (permalink / raw
To: Vandita Kulkarni; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 14495 bytes --]
== Series Details ==
Series: Add support to paint already mmaped buffer (rev3)
URL : https://patchwork.freedesktop.org/series/131167/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14482 -> IGTPW_10913
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_10913 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10913, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/index.html
Participating hosts (37 -> 34)
------------------------------
Additional (2): bat-arls-4 fi-glk-j4005
Missing (5): bat-dg1-7 fi-snb-2520m bat-dg2-11 bat-mtlp-8 bat-arls-3
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_10913:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
- bat-jsl-1: [PASS][2] -> [FAIL][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-jsl-1/igt@kms_frontbuffer_tracking@basic.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-jsl-1/igt@kms_frontbuffer_tracking@basic.html
- fi-tgl-1115g4: [PASS][4] -> [FAIL][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-tgl-1115g4/igt@kms_frontbuffer_tracking@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-tgl-1115g4/igt@kms_frontbuffer_tracking@basic.html
- bat-arls-1: [PASS][6] -> [FAIL][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-arls-1/igt@kms_frontbuffer_tracking@basic.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-arls-1/igt@kms_frontbuffer_tracking@basic.html
- bat-adlp-9: [PASS][8] -> [FAIL][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-adlp-9/igt@kms_frontbuffer_tracking@basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-adlp-9/igt@kms_frontbuffer_tracking@basic.html
- fi-cfl-8700k: [PASS][10] -> [FAIL][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-cfl-8700k/igt@kms_frontbuffer_tracking@basic.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-cfl-8700k/igt@kms_frontbuffer_tracking@basic.html
- bat-dg2-14: [PASS][12] -> [FAIL][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-dg2-14/igt@kms_frontbuffer_tracking@basic.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-dg2-14/igt@kms_frontbuffer_tracking@basic.html
- fi-rkl-11600: [PASS][14] -> [FAIL][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-rkl-11600/igt@kms_frontbuffer_tracking@basic.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-rkl-11600/igt@kms_frontbuffer_tracking@basic.html
- fi-cfl-guc: [PASS][16] -> [FAIL][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-cfl-guc/igt@kms_frontbuffer_tracking@basic.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-cfl-guc/igt@kms_frontbuffer_tracking@basic.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@basic:
- fi-kbl-7567u: [DMESG-WARN][18] ([i915#8585] / [i915#9730]) -> [FAIL][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-kbl-7567u/igt@kms_frontbuffer_tracking@basic.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-kbl-7567u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-rpls-3: [SKIP][20] ([i915#9920]) -> [SKIP][21] +6 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-rpls-3/igt@kms_pipe_crc_basic@read-crc.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-rpls-3/igt@kms_pipe_crc_basic@read-crc.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- {bat-mtlp-9}: [SKIP][22] ([i915#4213]) -> [SKIP][23] +1 other test skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-mtlp-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-mtlp-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- {bat-mtlp-9}: [PASS][24] -> [SKIP][25] +5 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-mtlp-9/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-mtlp-9/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_dsc@dsc-basic:
- {bat-mtlp-9}: [SKIP][26] ([i915#3555] / [i915#3840] / [i915#9159]) -> [SKIP][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-mtlp-9/igt@kms_dsc@dsc-basic.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-mtlp-9/igt@kms_dsc@dsc-basic.html
* igt@kms_frontbuffer_tracking@basic:
- {bat-arls-4}: NOTRUN -> [FAIL][28]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-arls-4/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@hang-read-crc:
- {bat-mtlp-9}: NOTRUN -> [SKIP][29] +7 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-mtlp-9/igt@kms_pipe_crc_basic@hang-read-crc.html
Known issues
------------
Here are the changes found in IGTPW_10913 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-cfl-8109u: NOTRUN -> [SKIP][30] ([i915#2190])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html
- fi-glk-j4005: NOTRUN -> [SKIP][31] ([i915#2190])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-glk-j4005/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-glk-j4005: NOTRUN -> [SKIP][32] ([i915#4613]) +3 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-glk-j4005/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@verify-random:
- fi-cfl-8109u: NOTRUN -> [SKIP][33] ([i915#4613]) +3 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-cfl-8109u/igt@gem_lmem_swapping@verify-random.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-glk-j4005: NOTRUN -> [SKIP][34] +10 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-glk-j4005/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_pm_backlight@basic-brightness:
- fi-cfl-8109u: NOTRUN -> [SKIP][35] +11 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-cfl-8109u/igt@kms_pm_backlight@basic-brightness.html
#### Possible fixes ####
* igt@gem_lmem_swapping@basic@lmem0:
- bat-dg2-14: [FAIL][36] ([i915#10378]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-dg2-14/igt@gem_lmem_swapping@basic@lmem0.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-dg2-14/igt@gem_lmem_swapping@basic@lmem0.html
* igt@i915_module_load@load:
- fi-kbl-7567u: [DMESG-WARN][38] ([i915#180] / [i915#1982] / [i915#8585]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-kbl-7567u/igt@i915_module_load@load.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-kbl-7567u/igt@i915_module_load@load.html
* igt@i915_selftest@live@execlists:
- bat-dg2-14: [ABORT][40] ([i915#10366]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-dg2-14/igt@i915_selftest@live@execlists.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-dg2-14/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- bat-dg2-9: [ABORT][42] ([i915#10366]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-dg2-9/igt@i915_selftest@live@gt_pm.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-dg2-9/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- bat-rpls-3: [DMESG-WARN][44] ([i915#5591]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@mman:
- bat-dg2-8: [ABORT][46] ([i915#10366]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/bat-dg2-8/igt@i915_selftest@live@mman.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/bat-dg2-8/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [DMESG-WARN][48] ([i915#9730]) -> [PASS][49] +37 other tests pass
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
* igt@kms_addfb_basic@invalid-set-prop:
- fi-kbl-7567u: [DMESG-WARN][50] ([i915#8585] / [i915#9730]) -> [PASS][51] +39 other tests pass
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-kbl-7567u/igt@kms_addfb_basic@invalid-set-prop.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-kbl-7567u/igt@kms_addfb_basic@invalid-set-prop.html
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-7567u: [DMESG-WARN][52] ([i915#8585]) -> [PASS][53] +1 other test pass
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-kbl-7567u/igt@kms_force_connector_basic@prune-stale-modes.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-kbl-7567u/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [DMESG-WARN][54] ([i915#180] / [i915#8585]) -> [PASS][55] +40 other tests pass
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14482/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10196]: https://gitlab.freedesktop.org/drm/intel/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/intel/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/intel/issues/10200
[i915#10202]: https://gitlab.freedesktop.org/drm/intel/issues/10202
[i915#10206]: https://gitlab.freedesktop.org/drm/intel/issues/10206
[i915#10207]: https://gitlab.freedesktop.org/drm/intel/issues/10207
[i915#10208]: https://gitlab.freedesktop.org/drm/intel/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/intel/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/intel/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/intel/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/intel/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/intel/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/intel/issues/10216
[i915#10366]: https://gitlab.freedesktop.org/drm/intel/issues/10366
[i915#10378]: https://gitlab.freedesktop.org/drm/intel/issues/10378
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
[i915#9159]: https://gitlab.freedesktop.org/drm/intel/issues/9159
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
[i915#9730]: https://gitlab.freedesktop.org/drm/intel/issues/9730
[i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/intel/issues/9812
[i915#9886]: https://gitlab.freedesktop.org/drm/intel/issues/9886
[i915#9920]: https://gitlab.freedesktop.org/drm/intel/issues/9920
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7782 -> IGTPW_10913
CI-20190529: 20190529
CI_DRM_14482: 4a8fabcf2f1aadbbb777a94edd01549c2aa95caf @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10913: 10913
IGT_7782: a404f73182948e843640d00cc279883391cf6ef4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10913/index.html
[-- Attachment #2: Type: text/html, Size: 14497 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-03-26 8:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 9:37 [v2 0/2] Add support to paint already mmaped buffer Vandita Kulkarni
2024-03-25 9:37 ` [v2 1/2] lib/igt_draw: Dont mmap, if the buffer is already mmapped Vandita Kulkarni
2024-03-26 6:18 ` Zbigniew Kempczyński
2024-03-26 7:24 ` [v3] " Vandita Kulkarni
2024-03-25 9:37 ` [v2 2/2] tests/kms_async_flips: Reuse the already mmapped buffer Vandita Kulkarni
2024-03-25 13:32 ` ✗ Fi.CI.BAT: failure for Add support to paint already mmaped buffer (rev2) Patchwork
2024-03-25 13:42 ` ✓ CI.xeBAT: success " Patchwork
2024-03-26 8:00 ` ✓ CI.xeBAT: success for Add support to paint already mmaped buffer (rev3) Patchwork
2024-03-26 8:11 ` ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.