From: "Darrick J. Wong" <djwong@kernel.org>
To: cem@kernel.org, djwong@kernel.org
Cc: Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>,
Chandan Babu R <chandanbabu@kernel.org>,
Bill O'Donnell <bodonnel@redhat.com>,
linux-xfs@vger.kernel.org
Subject: [PATCH 60/67] xfs: remove struct xfs_attr_shortform
Date: Mon, 25 Mar 2024 20:18:29 -0700 [thread overview]
Message-ID: <171142127822.2212320.2159420316852953492.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <171142126868.2212320.6212071954549567554.stgit@frogsfrogsfrogs>
From: Christoph Hellwig <hch@lst.de>
Source kernel commit: 414147225400a0c4562ebfb0fdd40f065099ede4
sparse complains about struct xfs_attr_shortform because it embeds a
structure with a variable sized array in a variable sized array.
Given that xfs_attr_shortform is not a very useful structure, and the
dir2 equivalent has been removed a long time ago, remove it as well.
Provide a xfs_attr_sf_firstentry helper that returns the first
xfs_attr_sf_entry behind a xfs_attr_sf_hdr to replace the structure
dereference.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
---
db/attrshort.c | 33 ++++++++++++++++-----------------
db/check.c | 8 ++++----
db/inode.c | 6 +++---
db/metadump.c | 16 +++++++---------
libxfs/libxfs_api_defs.h | 2 ++
libxfs/xfs_attr.c | 4 ++--
libxfs/xfs_attr_leaf.c | 37 ++++++++++++++++++-------------------
libxfs/xfs_attr_leaf.h | 2 +-
libxfs/xfs_attr_sf.h | 13 ++++++++++---
libxfs/xfs_da_format.h | 31 ++++++++++++++++++-------------
libxfs/xfs_inode_fork.c | 5 ++---
libxfs/xfs_ondisk.h | 14 +++++++-------
repair/attr_repair.c | 44 ++++++++++++++++++++------------------------
repair/dinode.c | 21 +++++++++++----------
14 files changed, 121 insertions(+), 115 deletions(-)
diff --git a/db/attrshort.c b/db/attrshort.c
index e234fbd83653..c98b90be3ec0 100644
--- a/db/attrshort.c
+++ b/db/attrshort.c
@@ -18,9 +18,8 @@ static int attr_sf_entry_value_offset(void *obj, int startoff, int idx);
static int attr_shortform_list_count(void *obj, int startoff);
static int attr_shortform_list_offset(void *obj, int startoff, int idx);
-#define OFF(f) bitize(offsetof(struct xfs_attr_shortform, f))
const field_t attr_shortform_flds[] = {
- { "hdr", FLDT_ATTR_SF_HDR, OI(OFF(hdr)), C1, 0, TYP_NONE },
+ { "hdr", FLDT_ATTR_SF_HDR, OI(0), C1, 0, TYP_NONE },
{ "list", FLDT_ATTR_SF_ENTRY, attr_shortform_list_offset,
attr_shortform_list_count, FLD_ARRAY|FLD_COUNT|FLD_OFFSET, TYP_NONE },
{ NULL }
@@ -71,11 +70,11 @@ attr_sf_entry_size(
{
struct xfs_attr_sf_entry *e;
int i;
- struct xfs_attr_shortform *sf;
+ struct xfs_attr_sf_hdr *hdr;
ASSERT(bitoffs(startoff) == 0);
- sf = (struct xfs_attr_shortform *)((char *)obj + byteize(startoff));
- e = &sf->list[0];
+ hdr = (struct xfs_attr_sf_hdr *)((char *)obj + byteize(startoff));
+ e = libxfs_attr_sf_firstentry(hdr);
for (i = 0; i < idx; i++)
e = xfs_attr_sf_nextentry(e);
return bitize((int)xfs_attr_sf_entsize(e));
@@ -113,11 +112,11 @@ attr_shortform_list_count(
void *obj,
int startoff)
{
- struct xfs_attr_shortform *sf;
+ struct xfs_attr_sf_hdr *hdr;
ASSERT(bitoffs(startoff) == 0);
- sf = (struct xfs_attr_shortform *)((char *)obj + byteize(startoff));
- return sf->hdr.count;
+ hdr = (struct xfs_attr_sf_hdr *)((char *)obj + byteize(startoff));
+ return hdr->count;
}
static int
@@ -128,14 +127,14 @@ attr_shortform_list_offset(
{
struct xfs_attr_sf_entry *e;
int i;
- struct xfs_attr_shortform *sf;
+ struct xfs_attr_sf_hdr *hdr;
ASSERT(bitoffs(startoff) == 0);
- sf = (struct xfs_attr_shortform *)((char *)obj + byteize(startoff));
- e = &sf->list[0];
+ hdr = (struct xfs_attr_sf_hdr *)((char *)obj + byteize(startoff));
+ e = libxfs_attr_sf_firstentry(hdr);
for (i = 0; i < idx; i++)
e = xfs_attr_sf_nextentry(e);
- return bitize((int)((char *)e - (char *)sf));
+ return bitize((int)((char *)e - (char *)hdr));
}
/*ARGSUSED*/
@@ -147,13 +146,13 @@ attrshort_size(
{
struct xfs_attr_sf_entry *e;
int i;
- struct xfs_attr_shortform *sf;
+ struct xfs_attr_sf_hdr *hdr;
ASSERT(bitoffs(startoff) == 0);
ASSERT(idx == 0);
- sf = (struct xfs_attr_shortform *)((char *)obj + byteize(startoff));
- e = &sf->list[0];
- for (i = 0; i < sf->hdr.count; i++)
+ hdr = (struct xfs_attr_sf_hdr *)((char *)obj + byteize(startoff));
+ e = libxfs_attr_sf_firstentry(hdr);
+ for (i = 0; i < hdr->count; i++)
e = xfs_attr_sf_nextentry(e);
- return bitize((int)((char *)e - (char *)sf));
+ return bitize((int)((char *)e - (char *)hdr));
}
diff --git a/db/check.c b/db/check.c
index 91d0c094064b..0a53ab7dfde6 100644
--- a/db/check.c
+++ b/db/check.c
@@ -3069,7 +3069,7 @@ process_lclinode(
blkmap_t **blkmapp,
int whichfork)
{
- struct xfs_attr_shortform *asf;
+ struct xfs_attr_sf_hdr *hdr;
xfs_fsblock_t bno;
bno = XFS_INO_TO_FSB(mp, id->ino);
@@ -3082,12 +3082,12 @@ process_lclinode(
error++;
}
else if (whichfork == XFS_ATTR_FORK) {
- asf = (struct xfs_attr_shortform *)XFS_DFORK_APTR(dip);
- if (be16_to_cpu(asf->hdr.totsize) > XFS_DFORK_ASIZE(dip, mp)) {
+ hdr = XFS_DFORK_APTR(dip);
+ if (be16_to_cpu(hdr->totsize) > XFS_DFORK_ASIZE(dip, mp)) {
if (!sflag || id->ilist || CHECK_BLIST(bno))
dbprintf(_("local inode %lld attr is too large "
"(size %d)\n"),
- id->ino, be16_to_cpu(asf->hdr.totsize));
+ id->ino, be16_to_cpu(hdr->totsize));
error++;
}
}
diff --git a/db/inode.c b/db/inode.c
index c9b506b905d0..7a5f5a0cb987 100644
--- a/db/inode.c
+++ b/db/inode.c
@@ -356,7 +356,7 @@ inode_a_size(
int startoff,
int idx)
{
- struct xfs_attr_shortform *asf;
+ struct xfs_attr_sf_hdr *hdr;
struct xfs_dinode *dip;
ASSERT(startoff == 0);
@@ -364,8 +364,8 @@ inode_a_size(
dip = obj;
switch (dip->di_aformat) {
case XFS_DINODE_FMT_LOCAL:
- asf = (struct xfs_attr_shortform *)XFS_DFORK_APTR(dip);
- return bitize(be16_to_cpu(asf->hdr.totsize));
+ hdr = XFS_DFORK_APTR(dip);
+ return bitize(be16_to_cpu(hdr->totsize));
case XFS_DINODE_FMT_EXTENTS:
return (int)xfs_dfork_attr_extents(dip) * bitsz(xfs_bmbt_rec_t);
case XFS_DINODE_FMT_BTREE:
diff --git a/db/metadump.c b/db/metadump.c
index bac35b9cc68c..536d089fbac6 100644
--- a/db/metadump.c
+++ b/db/metadump.c
@@ -1035,16 +1035,15 @@ process_sf_attr(
* values with 'v' (to see a valid string length, as opposed to NULLs)
*/
- struct xfs_attr_shortform *asfp;
- struct xfs_attr_sf_entry *asfep;
+ struct xfs_attr_sf_hdr *hdr = XFS_DFORK_APTR(dip);
+ struct xfs_attr_sf_entry *asfep = libxfs_attr_sf_firstentry(hdr);
int ino_attr_size;
int i;
- asfp = (struct xfs_attr_shortform *)XFS_DFORK_APTR(dip);
- if (asfp->hdr.count == 0)
+ if (hdr->count == 0)
return;
- ino_attr_size = be16_to_cpu(asfp->hdr.totsize);
+ ino_attr_size = be16_to_cpu(hdr->totsize);
if (ino_attr_size > XFS_DFORK_ASIZE(dip, mp)) {
ino_attr_size = XFS_DFORK_ASIZE(dip, mp);
if (metadump.show_warnings)
@@ -1052,9 +1051,8 @@ process_sf_attr(
(long long)metadump.cur_ino);
}
- asfep = &asfp->list[0];
- for (i = 0; (i < asfp->hdr.count) &&
- ((char *)asfep - (char *)asfp < ino_attr_size); i++) {
+ for (i = 0; (i < hdr->count) &&
+ ((char *)asfep - (char *)hdr < ino_attr_size); i++) {
int namelen = asfep->namelen;
@@ -1063,7 +1061,7 @@ process_sf_attr(
print_warning("zero length attr entry in inode "
"%llu", (long long)metadump.cur_ino);
break;
- } else if ((char *)asfep - (char *)asfp +
+ } else if ((char *)asfep - (char *)hdr +
xfs_attr_sf_entsize(asfep) > ino_attr_size) {
if (metadump.show_warnings)
print_warning("attr entry length in inode %llu "
diff --git a/libxfs/libxfs_api_defs.h b/libxfs/libxfs_api_defs.h
index 7c055e8aa61e..36afc5d0234d 100644
--- a/libxfs/libxfs_api_defs.h
+++ b/libxfs/libxfs_api_defs.h
@@ -40,6 +40,8 @@
#define xfs_attr_leaf_newentsize libxfs_attr_leaf_newentsize
#define xfs_attr_namecheck libxfs_attr_namecheck
#define xfs_attr_set libxfs_attr_set
+#define xfs_attr_sf_firstentry libxfs_attr_sf_firstentry
+#define xfs_attr_shortform_verify libxfs_attr_shortform_verify
#define __xfs_bmap_add_free __libxfs_bmap_add_free
#define xfs_bmapi_read libxfs_bmapi_read
diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index a383024dbd7f..055d204101a5 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -1050,9 +1050,9 @@ xfs_attr_set(
static inline int xfs_attr_sf_totsize(struct xfs_inode *dp)
{
- struct xfs_attr_shortform *sf = dp->i_af.if_data;
+ struct xfs_attr_sf_hdr *sf = dp->i_af.if_data;
- return be16_to_cpu(sf->hdr.totsize);
+ return be16_to_cpu(sf->totsize);
}
/*
diff --git a/libxfs/xfs_attr_leaf.c b/libxfs/xfs_attr_leaf.c
index 9b6dcff349c9..cf172b6ea4ab 100644
--- a/libxfs/xfs_attr_leaf.c
+++ b/libxfs/xfs_attr_leaf.c
@@ -701,10 +701,10 @@ struct xfs_attr_sf_entry *
xfs_attr_sf_findname(
struct xfs_da_args *args)
{
- struct xfs_attr_shortform *sf = args->dp->i_af.if_data;
+ struct xfs_attr_sf_hdr *sf = args->dp->i_af.if_data;
struct xfs_attr_sf_entry *sfe;
- for (sfe = &sf->list[0];
+ for (sfe = xfs_attr_sf_firstentry(sf);
sfe < xfs_attr_sf_endptr(sf);
sfe = xfs_attr_sf_nextentry(sfe)) {
if (xfs_attr_match(args, sfe->namelen, sfe->nameval,
@@ -727,7 +727,7 @@ xfs_attr_shortform_add(
struct xfs_inode *dp = args->dp;
struct xfs_mount *mp = dp->i_mount;
struct xfs_ifork *ifp = &dp->i_af;
- struct xfs_attr_shortform *sf = ifp->if_data;
+ struct xfs_attr_sf_hdr *sf = ifp->if_data;
struct xfs_attr_sf_entry *sfe;
int size;
@@ -747,8 +747,8 @@ xfs_attr_shortform_add(
sfe->flags = args->attr_filter;
memcpy(sfe->nameval, args->name, args->namelen);
memcpy(&sfe->nameval[args->namelen], args->value, args->valuelen);
- sf->hdr.count++;
- be16_add_cpu(&sf->hdr.totsize, size);
+ sf->count++;
+ be16_add_cpu(&sf->totsize, size);
xfs_trans_log_inode(args->trans, dp, XFS_ILOG_CORE | XFS_ILOG_ADATA);
xfs_sbversion_add_attr2(mp, args->trans);
@@ -779,9 +779,9 @@ xfs_attr_sf_removename(
{
struct xfs_inode *dp = args->dp;
struct xfs_mount *mp = dp->i_mount;
- struct xfs_attr_shortform *sf = dp->i_af.if_data;
+ struct xfs_attr_sf_hdr *sf = dp->i_af.if_data;
struct xfs_attr_sf_entry *sfe;
- uint16_t totsize = be16_to_cpu(sf->hdr.totsize);
+ uint16_t totsize = be16_to_cpu(sf->totsize);
void *next, *end;
int size = 0;
@@ -806,9 +806,9 @@ xfs_attr_sf_removename(
end = xfs_attr_sf_endptr(sf);
if (next < end)
memmove(sfe, next, end - next);
- sf->hdr.count--;
+ sf->count--;
totsize -= size;
- sf->hdr.totsize = cpu_to_be16(totsize);
+ sf->totsize = cpu_to_be16(totsize);
/*
* Fix up the start offset of the attribute fork
@@ -865,21 +865,21 @@ xfs_attr_shortform_to_leaf(
{
struct xfs_inode *dp = args->dp;
struct xfs_ifork *ifp = &dp->i_af;
- struct xfs_attr_shortform *sf = ifp->if_data;
+ struct xfs_attr_sf_hdr *sf = ifp->if_data;
struct xfs_attr_sf_entry *sfe;
+ int size = be16_to_cpu(sf->totsize);
struct xfs_da_args nargs;
char *tmpbuffer;
- int error, i, size;
+ int error, i;
xfs_dablk_t blkno;
struct xfs_buf *bp;
trace_xfs_attr_sf_to_leaf(args);
- size = be16_to_cpu(sf->hdr.totsize);
tmpbuffer = kmem_alloc(size, 0);
ASSERT(tmpbuffer != NULL);
memcpy(tmpbuffer, ifp->if_data, size);
- sf = (struct xfs_attr_shortform *)tmpbuffer;
+ sf = (struct xfs_attr_sf_hdr *)tmpbuffer;
xfs_idata_realloc(dp, -size, XFS_ATTR_FORK);
xfs_bmap_local_to_extents_empty(args->trans, dp, XFS_ATTR_FORK);
@@ -902,8 +902,8 @@ xfs_attr_shortform_to_leaf(
nargs.trans = args->trans;
nargs.op_flags = XFS_DA_OP_OKNOENT;
- sfe = &sf->list[0];
- for (i = 0; i < sf->hdr.count; i++) {
+ sfe = xfs_attr_sf_firstentry(sf);
+ for (i = 0; i < sf->count; i++) {
nargs.name = sfe->nameval;
nargs.namelen = sfe->namelen;
nargs.value = &sfe->nameval[nargs.namelen];
@@ -970,10 +970,10 @@ xfs_attr_shortform_allfit(
/* Verify the consistency of a raw inline attribute fork. */
xfs_failaddr_t
xfs_attr_shortform_verify(
- struct xfs_attr_shortform *sfp,
+ struct xfs_attr_sf_hdr *sfp,
size_t size)
{
- struct xfs_attr_sf_entry *sfep;
+ struct xfs_attr_sf_entry *sfep = xfs_attr_sf_firstentry(sfp);
struct xfs_attr_sf_entry *next_sfep;
char *endp;
int i;
@@ -987,8 +987,7 @@ xfs_attr_shortform_verify(
endp = (char *)sfp + size;
/* Check all reported entries */
- sfep = &sfp->list[0];
- for (i = 0; i < sfp->hdr.count; i++) {
+ for (i = 0; i < sfp->count; i++) {
/*
* struct xfs_attr_sf_entry has a variable length.
* Check the fixed-offset parts of the structure are
diff --git a/libxfs/xfs_attr_leaf.h b/libxfs/xfs_attr_leaf.h
index 35e668ae744f..9b9948639c0f 100644
--- a/libxfs/xfs_attr_leaf.h
+++ b/libxfs/xfs_attr_leaf.h
@@ -53,7 +53,7 @@ int xfs_attr_sf_removename(struct xfs_da_args *args);
struct xfs_attr_sf_entry *xfs_attr_sf_findname(struct xfs_da_args *args);
int xfs_attr_shortform_allfit(struct xfs_buf *bp, struct xfs_inode *dp);
int xfs_attr_shortform_bytesfit(struct xfs_inode *dp, int bytes);
-xfs_failaddr_t xfs_attr_shortform_verify(struct xfs_attr_shortform *sfp,
+xfs_failaddr_t xfs_attr_shortform_verify(struct xfs_attr_sf_hdr *sfp,
size_t size);
void xfs_attr_fork_remove(struct xfs_inode *ip, struct xfs_trans *tp);
diff --git a/libxfs/xfs_attr_sf.h b/libxfs/xfs_attr_sf.h
index a774d4d87763..9abf7de95465 100644
--- a/libxfs/xfs_attr_sf.h
+++ b/libxfs/xfs_attr_sf.h
@@ -41,7 +41,14 @@ static inline int xfs_attr_sf_entsize(struct xfs_attr_sf_entry *sfep)
return struct_size(sfep, nameval, sfep->namelen + sfep->valuelen);
}
-/* next entry in struct */
+/* first entry in the SF attr fork */
+static inline struct xfs_attr_sf_entry *
+xfs_attr_sf_firstentry(struct xfs_attr_sf_hdr *hdr)
+{
+ return (struct xfs_attr_sf_entry *)(hdr + 1);
+}
+
+/* next entry after sfep */
static inline struct xfs_attr_sf_entry *
xfs_attr_sf_nextentry(struct xfs_attr_sf_entry *sfep)
{
@@ -50,9 +57,9 @@ xfs_attr_sf_nextentry(struct xfs_attr_sf_entry *sfep)
/* pointer to the space after the last entry, e.g. for adding a new one */
static inline struct xfs_attr_sf_entry *
-xfs_attr_sf_endptr(struct xfs_attr_shortform *sf)
+xfs_attr_sf_endptr(struct xfs_attr_sf_hdr *sf)
{
- return (void *)sf + be16_to_cpu(sf->hdr.totsize);
+ return (void *)sf + be16_to_cpu(sf->totsize);
}
#endif /* __XFS_ATTR_SF_H__ */
diff --git a/libxfs/xfs_da_format.h b/libxfs/xfs_da_format.h
index f9015f88eca7..24f9d1461f9a 100644
--- a/libxfs/xfs_da_format.h
+++ b/libxfs/xfs_da_format.h
@@ -578,20 +578,25 @@ xfs_dir2_block_leaf_p(struct xfs_dir2_block_tail *btp)
#define XFS_ATTR_LEAF_MAPSIZE 3 /* how many freespace slots */
/*
- * Entries are packed toward the top as tight as possible.
+ * Attribute storage when stored inside the inode.
+ *
+ * Small attribute lists are packed as tightly as possible so as to fit into the
+ * literal area of the inode.
+ *
+ * These "shortform" attribute forks consist of a single xfs_attr_sf_hdr header
+ * followed by zero or more xfs_attr_sf_entry structures.
*/
-struct xfs_attr_shortform {
- struct xfs_attr_sf_hdr { /* constant-structure header block */
- __be16 totsize; /* total bytes in shortform list */
- __u8 count; /* count of active entries */
- __u8 padding;
- } hdr;
- struct xfs_attr_sf_entry {
- uint8_t namelen; /* actual length of name (no NULL) */
- uint8_t valuelen; /* actual length of value (no NULL) */
- uint8_t flags; /* flags bits (see xfs_attr_leaf.h) */
- uint8_t nameval[]; /* name & value bytes concatenated */
- } list[]; /* variable sized array */
+struct xfs_attr_sf_hdr { /* constant-structure header block */
+ __be16 totsize; /* total bytes in shortform list */
+ __u8 count; /* count of active entries */
+ __u8 padding;
+};
+
+struct xfs_attr_sf_entry {
+ __u8 namelen; /* actual length of name (no NULL) */
+ __u8 valuelen; /* actual length of value (no NULL) */
+ __u8 flags; /* flags bits (XFS_ATTR_*) */
+ __u8 nameval[]; /* name & value bytes concatenated */
};
typedef struct xfs_attr_leaf_map { /* RLE map of free bytes */
diff --git a/libxfs/xfs_inode_fork.c b/libxfs/xfs_inode_fork.c
index c95abd43ab0b..208b283ba338 100644
--- a/libxfs/xfs_inode_fork.c
+++ b/libxfs/xfs_inode_fork.c
@@ -277,10 +277,9 @@ static uint16_t
xfs_dfork_attr_shortform_size(
struct xfs_dinode *dip)
{
- struct xfs_attr_shortform *atp =
- (struct xfs_attr_shortform *)XFS_DFORK_APTR(dip);
+ struct xfs_attr_sf_hdr *sf = XFS_DFORK_APTR(dip);
- return be16_to_cpu(atp->hdr.totsize);
+ return be16_to_cpu(sf->totsize);
}
void
diff --git a/libxfs/xfs_ondisk.h b/libxfs/xfs_ondisk.h
index d9c988c5ad69..81885a6a028e 100644
--- a/libxfs/xfs_ondisk.h
+++ b/libxfs/xfs_ondisk.h
@@ -93,13 +93,13 @@ xfs_check_ondisk_structs(void)
XFS_CHECK_OFFSET(xfs_attr_leaf_name_remote_t, namelen, 8);
XFS_CHECK_OFFSET(xfs_attr_leaf_name_remote_t, name, 9);
XFS_CHECK_STRUCT_SIZE(xfs_attr_leafblock_t, 32);
- XFS_CHECK_STRUCT_SIZE(struct xfs_attr_shortform, 4);
- XFS_CHECK_OFFSET(struct xfs_attr_shortform, hdr.totsize, 0);
- XFS_CHECK_OFFSET(struct xfs_attr_shortform, hdr.count, 2);
- XFS_CHECK_OFFSET(struct xfs_attr_shortform, list[0].namelen, 4);
- XFS_CHECK_OFFSET(struct xfs_attr_shortform, list[0].valuelen, 5);
- XFS_CHECK_OFFSET(struct xfs_attr_shortform, list[0].flags, 6);
- XFS_CHECK_OFFSET(struct xfs_attr_shortform, list[0].nameval, 7);
+ XFS_CHECK_STRUCT_SIZE(struct xfs_attr_sf_hdr, 4);
+ XFS_CHECK_OFFSET(struct xfs_attr_sf_hdr, totsize, 0);
+ XFS_CHECK_OFFSET(struct xfs_attr_sf_hdr, count, 2);
+ XFS_CHECK_OFFSET(struct xfs_attr_sf_entry, namelen, 0);
+ XFS_CHECK_OFFSET(struct xfs_attr_sf_entry, valuelen, 1);
+ XFS_CHECK_OFFSET(struct xfs_attr_sf_entry, flags, 2);
+ XFS_CHECK_OFFSET(struct xfs_attr_sf_entry, nameval, 3);
XFS_CHECK_STRUCT_SIZE(xfs_da_blkinfo_t, 12);
XFS_CHECK_STRUCT_SIZE(xfs_da_intnode_t, 16);
XFS_CHECK_STRUCT_SIZE(xfs_da_node_entry_t, 8);
diff --git a/repair/attr_repair.c b/repair/attr_repair.c
index c3a6d50267e2..31c50c127d41 100644
--- a/repair/attr_repair.c
+++ b/repair/attr_repair.c
@@ -210,27 +210,25 @@ process_shortform_attr(
struct xfs_dinode *dip,
int *repair)
{
- struct xfs_attr_shortform *asf;
+ struct xfs_attr_sf_hdr *hdr = XFS_DFORK_APTR(dip);
struct xfs_attr_sf_entry *currententry, *nextentry, *tempentry;
int i, junkit;
int currentsize, remainingspace;
*repair = 0;
- asf = (struct xfs_attr_shortform *) XFS_DFORK_APTR(dip);
-
/* Assumption: hdr.totsize is less than a leaf block and was checked
* by lclinode for valid sizes. Check the count though.
*/
- if (asf->hdr.count == 0)
+ if (hdr->count == 0)
/* then the total size should just be the header length */
- if (be16_to_cpu(asf->hdr.totsize) != sizeof(xfs_attr_sf_hdr_t)) {
+ if (be16_to_cpu(hdr->totsize) != sizeof(xfs_attr_sf_hdr_t)) {
/* whoops there's a discrepancy. Clear the hdr */
if (!no_modify) {
do_warn(
_("there are no attributes in the fork for inode %" PRIu64 "\n"),
ino);
- asf->hdr.totsize =
+ hdr->totsize =
cpu_to_be16(sizeof(xfs_attr_sf_hdr_t));
*repair = 1;
return(1);
@@ -243,15 +241,15 @@ process_shortform_attr(
}
currentsize = sizeof(xfs_attr_sf_hdr_t);
- remainingspace = be16_to_cpu(asf->hdr.totsize) - currentsize;
- nextentry = &asf->list[0];
- for (i = 0; i < asf->hdr.count; i++) {
+ remainingspace = be16_to_cpu(hdr->totsize) - currentsize;
+ nextentry = libxfs_attr_sf_firstentry(hdr);
+ for (i = 0; i < hdr->count; i++) {
currententry = nextentry;
junkit = 0;
/* don't go off the end if the hdr.count was off */
if ((currentsize + (sizeof(struct xfs_attr_sf_entry) - 1)) >
- be16_to_cpu(asf->hdr.totsize))
+ be16_to_cpu(hdr->totsize))
break; /* get out and reset count and totSize */
/* if the namelen is 0, can't get to the rest of the entries */
@@ -326,7 +324,7 @@ process_shortform_attr(
((intptr_t) currententry +
xfs_attr_sf_entsize(currententry));
memmove(currententry,tempentry,remainingspace);
- asf->hdr.count -= 1;
+ hdr->count -= 1;
i--; /* no worries, it will wrap back to 0 */
*repair = 1;
continue; /* go back up now */
@@ -344,33 +342,33 @@ process_shortform_attr(
} /* end the loop */
- if (asf->hdr.count != i) {
+ if (hdr->count != i) {
if (no_modify) {
do_warn(
_("would have corrected attribute entry count in inode %" PRIu64 " from %d to %d\n"),
- ino, asf->hdr.count, i);
+ ino, hdr->count, i);
} else {
do_warn(
_("corrected attribute entry count in inode %" PRIu64 ", was %d, now %d\n"),
- ino, asf->hdr.count, i);
- asf->hdr.count = i;
+ ino, hdr->count, i);
+ hdr->count = i;
*repair = 1;
}
}
/* ASSUMPTION: currentsize <= totsize */
- if (be16_to_cpu(asf->hdr.totsize) != currentsize) {
+ if (be16_to_cpu(hdr->totsize) != currentsize) {
if (no_modify) {
do_warn(
_("would have corrected attribute totsize in inode %" PRIu64 " from %d to %d\n"),
- ino, be16_to_cpu(asf->hdr.totsize),
+ ino, be16_to_cpu(hdr->totsize),
currentsize);
} else {
do_warn(
_("corrected attribute entry totsize in inode %" PRIu64 ", was %d, now %d\n"),
- ino, be16_to_cpu(asf->hdr.totsize),
+ ino, be16_to_cpu(hdr->totsize),
currentsize);
- asf->hdr.totsize = cpu_to_be16(currentsize);
+ hdr->totsize = cpu_to_be16(currentsize);
*repair = 1;
}
}
@@ -1232,14 +1230,12 @@ process_attributes(
int err;
__u8 aformat = dip->di_aformat;
#ifdef DEBUG
- struct xfs_attr_shortform *asf;
-
- asf = (struct xfs_attr_shortform *) XFS_DFORK_APTR(dip);
+ struct xfs_attr_sf_hdr *hdr = XFS_DFORK_APTR(dip);
#endif
if (aformat == XFS_DINODE_FMT_LOCAL) {
- ASSERT(be16_to_cpu(asf->hdr.totsize) <=
- XFS_DFORK_ASIZE(dip, mp));
+ ASSERT(be16_to_cpu(hdr->totsize) <= XFS_DFORK_ASIZE(dip, mp));
+
err = process_shortform_attr(mp, ino, dip, repair);
} else if (aformat == XFS_DINODE_FMT_EXTENTS ||
aformat == XFS_DINODE_FMT_BTREE) {
diff --git a/repair/dinode.c b/repair/dinode.c
index c1cfadc8833e..636e753fc744 100644
--- a/repair/dinode.c
+++ b/repair/dinode.c
@@ -99,10 +99,10 @@ _("would have cleared inode %" PRIu64 " attributes\n"), ino_num);
*/
if (!no_modify) {
- struct xfs_attr_shortform *asf = (struct xfs_attr_shortform *)
- XFS_DFORK_APTR(dino);
- asf->hdr.totsize = cpu_to_be16(sizeof(xfs_attr_sf_hdr_t));
- asf->hdr.count = 0;
+ struct xfs_attr_sf_hdr *hdr = XFS_DFORK_APTR(dino);
+
+ hdr->totsize = cpu_to_be16(sizeof(struct xfs_attr_sf_hdr));
+ hdr->count = 0;
dino->di_forkoff = 0; /* got to do this after asf is set */
}
@@ -993,7 +993,7 @@ process_lclinode(
struct xfs_dinode *dip,
int whichfork)
{
- struct xfs_attr_shortform *asf;
+ struct xfs_attr_sf_hdr *hdr;
xfs_ino_t lino;
lino = XFS_AGINO_TO_INO(mp, agno, ino);
@@ -1005,18 +1005,19 @@ process_lclinode(
XFS_DFORK_DSIZE(dip, mp));
return(1);
} else if (whichfork == XFS_ATTR_FORK) {
- asf = (struct xfs_attr_shortform *)XFS_DFORK_APTR(dip);
- if (be16_to_cpu(asf->hdr.totsize) > XFS_DFORK_ASIZE(dip, mp)) {
+ hdr = XFS_DFORK_APTR(dip);
+
+ if (be16_to_cpu(hdr->totsize) > XFS_DFORK_ASIZE(dip, mp)) {
do_warn(
_("local inode %" PRIu64 " attr fork too large (size %d, max = %zu)\n"),
- lino, be16_to_cpu(asf->hdr.totsize),
+ lino, be16_to_cpu(hdr->totsize),
XFS_DFORK_ASIZE(dip, mp));
return(1);
}
- if (be16_to_cpu(asf->hdr.totsize) < sizeof(xfs_attr_sf_hdr_t)) {
+ if (be16_to_cpu(hdr->totsize) < sizeof(xfs_attr_sf_hdr_t)) {
do_warn(
_("local inode %" PRIu64 " attr too small (size = %d, min size = %zd)\n"),
- lino, be16_to_cpu(asf->hdr.totsize),
+ lino, be16_to_cpu(hdr->totsize),
sizeof(xfs_attr_sf_hdr_t));
return(1);
}
next prev parent reply other threads:[~2024-03-26 3:18 UTC|newest]
Thread overview: 310+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 2:45 [PATCHBOMB v2] xfsprogs: everything headed towards 6.9 Darrick J. Wong
2024-03-26 2:54 ` Darrick J. Wong
2024-03-26 2:54 ` [PATCHSET 01/18] xfsprogs: convert utilities to use new rt helpers Darrick J. Wong
2024-03-26 2:59 ` [PATCH 01/13] libxfs: fix incorrect porting to 6.7 Darrick J. Wong
2024-03-26 2:59 ` [PATCH 02/13] mkfs: fix log sunit rounding when external logs are in use Darrick J. Wong
2024-03-26 3:00 ` [PATCH 03/13] xfs_repair: fix confusing rt space units in the duplicate detection code Darrick J. Wong
2024-03-26 3:00 ` [PATCH 04/13] libxfs: create a helper to compute leftovers of realtime extents Darrick J. Wong
2024-03-26 3:00 ` [PATCH 05/13] libxfs: use helpers to convert rt block numbers to rt extent numbers Darrick J. Wong
2024-03-26 3:00 ` [PATCH 06/13] xfs_repair: convert utility to use new rt extent helpers and types Darrick J. Wong
2024-03-26 3:01 ` [PATCH 07/13] mkfs: " Darrick J. Wong
2024-03-26 3:01 ` [PATCH 08/13] xfs_{db,repair}: convert open-coded xfs_rtword_t pointer accesses to helper Darrick J. Wong
2024-03-26 3:01 ` [PATCH 09/13] xfs_repair: convert helpers for rtbitmap block/wordcount computations Darrick J. Wong
2024-03-26 3:02 ` [PATCH 10/13] xfs_{db,repair}: use accessor functions for bitmap words Darrick J. Wong
2024-03-26 3:02 ` [PATCH 11/13] xfs_{db,repair}: use helpers for rtsummary block/wordcount computations Darrick J. Wong
2024-03-26 3:02 ` [PATCH 12/13] xfs_{db,repair}: use accessor functions for summary info words Darrick J. Wong
2024-03-26 3:02 ` [PATCH 13/13] xfs_{db,repair}: use m_blockwsize instead of sb_blocksize for rt blocks Darrick J. Wong
2024-03-26 2:55 ` [PATCHSET 02/18] libxfs: sync with 6.8 Darrick J. Wong
2024-03-26 3:03 ` [PATCH 01/67] xfs: use xfs_defer_pending objects to recover intent items Darrick J. Wong
2024-03-26 3:03 ` [PATCH 02/67] xfs: recreate work items when recovering " Darrick J. Wong
2024-03-26 3:03 ` [PATCH 03/67] xfs: use xfs_defer_finish_one to finish recovered work items Darrick J. Wong
2024-03-26 3:03 ` [PATCH 04/67] xfs: move ->iop_recover to xfs_defer_op_type Darrick J. Wong
2024-03-26 3:04 ` [PATCH 05/67] xfs: hoist intent done flag setting to ->finish_item callsite Darrick J. Wong
2024-03-26 3:04 ` [PATCH 06/67] xfs: hoist ->create_intent boilerplate to its callsite Darrick J. Wong
2024-03-26 3:04 ` [PATCH 07/67] xfs: use xfs_defer_create_done for the relogging operation Darrick J. Wong
2024-03-26 3:04 ` [PATCH 08/67] xfs: clean out XFS_LI_DIRTY setting boilerplate from ->iop_relog Darrick J. Wong
2024-03-26 3:05 ` [PATCH 09/67] xfs: hoist xfs_trans_add_item calls to defer ops functions Darrick J. Wong
2024-03-26 3:05 ` [PATCH 10/67] xfs: move ->iop_relog to struct xfs_defer_op_type Darrick J. Wong
2024-03-26 3:05 ` [PATCH 11/67] xfs: make rextslog computation consistent with mkfs Darrick J. Wong
2024-03-26 3:05 ` [PATCH 12/67] xfs: fix 32-bit truncation in xfs_compute_rextslog Darrick J. Wong
2024-03-26 3:06 ` [PATCH 13/67] xfs: don't allow overly small or large realtime volumes Darrick J. Wong
2024-03-26 3:06 ` [PATCH 14/67] xfs: elide ->create_done calls for unlogged deferred work Darrick J. Wong
2024-03-26 3:06 ` [PATCH 15/67] xfs: don't append work items to logged xfs_defer_pending objects Darrick J. Wong
2024-03-26 3:07 ` [PATCH 16/67] xfs: allow pausing of pending deferred work items Darrick J. Wong
2024-03-26 3:07 ` [PATCH 17/67] xfs: remove __xfs_free_extent_later Darrick J. Wong
2024-03-26 3:07 ` [PATCH 18/67] xfs: automatic freeing of freshly allocated unwritten space Darrick J. Wong
2024-03-26 3:07 ` [PATCH 19/67] xfs: remove unused fields from struct xbtree_ifakeroot Darrick J. Wong
2024-03-26 3:08 ` [PATCH 20/67] xfs: force small EFIs for reaping btree extents Darrick J. Wong
2024-03-26 3:08 ` [PATCH 21/67] xfs: ensure logflagsp is initialized in xfs_bmap_del_extent_real Darrick J. Wong
2024-03-26 3:08 ` [PATCH 22/67] xfs: update dir3 leaf block metadata after swap Darrick J. Wong
2024-03-26 3:08 ` [PATCH 23/67] xfs: extract xfs_da_buf_copy() helper function Darrick J. Wong
2024-03-26 3:09 ` [PATCH 24/67] xfs: move xfs_ondisk.h to libxfs/ Darrick J. Wong
2024-03-26 3:09 ` [PATCH 25/67] xfs: consolidate the xfs_attr_defer_* helpers Darrick J. Wong
2024-03-26 3:09 ` [PATCH 26/67] xfs: store an ops pointer in struct xfs_defer_pending Darrick J. Wong
2024-03-26 3:09 ` [PATCH 27/67] xfs: pass the defer ops instead of type to xfs_defer_start_recovery Darrick J. Wong
2024-03-26 3:10 ` [PATCH 28/67] xfs: pass the defer ops directly to xfs_defer_add Darrick J. Wong
2024-03-26 3:10 ` [PATCH 29/67] xfs: force all buffers to be written during btree bulk load Darrick J. Wong
2024-03-26 3:10 ` [PATCH 30/67] xfs: set XBF_DONE on newly formatted btree block that are ready for writing Darrick J. Wong
2024-03-26 3:10 ` [PATCH 31/67] xfs: read leaf blocks when computing keys for bulkloading into node blocks Darrick J. Wong
2024-03-26 3:11 ` [PATCH 32/67] xfs: move btree bulkload record initialization to ->get_record implementations Darrick J. Wong
2024-03-26 3:11 ` [PATCH 33/67] xfs: constrain dirty buffers while formatting a staged btree Darrick J. Wong
2024-03-26 3:11 ` [PATCH 34/67] xfs: repair free space btrees Darrick J. Wong
2024-03-26 3:11 ` [PATCH 35/67] xfs: repair inode btrees Darrick J. Wong
2024-03-26 3:12 ` [PATCH 36/67] xfs: repair refcount btrees Darrick J. Wong
2024-03-26 3:12 ` [PATCH 37/67] xfs: dont cast to char * for XFS_DFORK_*PTR macros Darrick J. Wong
2024-03-26 3:12 ` [PATCH 38/67] xfs: set inode sick state flags when we zap either ondisk fork Darrick J. Wong
2024-03-26 3:13 ` [PATCH 39/67] xfs: zap broken inode forks Darrick J. Wong
2024-03-26 3:13 ` [PATCH 40/67] xfs: repair inode fork block mapping data structures Darrick J. Wong
2024-03-26 3:13 ` [PATCH 41/67] xfs: create a ranged query function for refcount btrees Darrick J. Wong
2024-03-26 3:13 ` [PATCH 42/67] xfs: create a new inode fork block unmap helper Darrick J. Wong
2024-03-26 3:14 ` [PATCH 43/67] xfs: improve dquot iteration for scrub Darrick J. Wong
2024-03-26 3:14 ` [PATCH 44/67] xfs: add lock protection when remove perag from radix tree Darrick J. Wong
2024-03-26 3:14 ` [PATCH 45/67] xfs: fix perag leak when growfs fails Darrick J. Wong
2024-03-26 3:14 ` [PATCH 46/67] xfs: remove the xfs_alloc_arg argument to xfs_bmap_btalloc_accounting Darrick J. Wong
2024-03-26 3:15 ` [PATCH 47/67] xfs: also use xfs_bmap_btalloc_accounting for RT allocations Darrick J. Wong
2024-03-26 3:15 ` [PATCH 48/67] xfs: return -ENOSPC from xfs_rtallocate_* Darrick J. Wong
2024-03-26 3:15 ` [PATCH 49/67] xfs: indicate if xfs_bmap_adjacent changed ap->blkno Darrick J. Wong
2024-03-26 3:15 ` [PATCH 50/67] xfs: move xfs_rtget_summary to xfs_rtbitmap.c Darrick J. Wong
2024-03-26 3:16 ` [PATCH 51/67] xfs: split xfs_rtmodify_summary_int Darrick J. Wong
2024-03-26 3:16 ` [PATCH 52/67] xfs: remove rt-wrappers from xfs_format.h Darrick J. Wong
2024-03-26 3:16 ` [PATCH 53/67] xfs: remove XFS_RTMIN/XFS_RTMAX Darrick J. Wong
2024-03-26 3:16 ` [PATCH 54/67] xfs: make if_data a void pointer Darrick J. Wong
2024-03-26 3:17 ` [PATCH 55/67] xfs: return if_data from xfs_idata_realloc Darrick J. Wong
2024-03-26 3:17 ` [PATCH 56/67] xfs: move the xfs_attr_sf_lookup tracepoint Darrick J. Wong
2024-03-26 3:17 ` [PATCH 57/67] xfs: simplify xfs_attr_sf_findname Darrick J. Wong
2024-03-26 3:17 ` [PATCH 58/67] xfs: remove xfs_attr_shortform_lookup Darrick J. Wong
2024-03-26 3:18 ` [PATCH 59/67] xfs: use xfs_attr_sf_findname in xfs_attr_shortform_getvalue Darrick J. Wong
2024-03-26 3:18 ` Darrick J. Wong [this message]
2024-03-26 3:18 ` [PATCH 61/67] xfs: remove xfs_attr_sf_hdr_t Darrick J. Wong
2024-03-26 3:19 ` [PATCH 62/67] xfs: turn the XFS_DA_OP_REPLACE checks in xfs_attr_shortform_addname into asserts Darrick J. Wong
2024-03-26 3:19 ` [PATCH 63/67] xfs: fix a use after free in xfs_defer_finish_recovery Darrick J. Wong
2024-03-26 3:19 ` [PATCH 64/67] xfs: use the op name in trace_xlog_intent_recovery_failed Darrick J. Wong
2024-03-26 3:19 ` [PATCH 65/67] xfs: fix backwards logic in xfs_bmap_alloc_account Darrick J. Wong
2024-03-26 3:20 ` [PATCH 66/67] xfs: reset XFS_ATTR_INCOMPLETE filter on node removal Darrick J. Wong
2024-03-26 3:20 ` [PATCH 67/67] xfs: remove conditional building of rt geometry validator functions Darrick J. Wong
2024-03-26 2:55 ` [PATCHSET 03/18] xfs_repair: faster btree bulkloading Darrick J. Wong
2024-03-26 3:20 ` [PATCH 1/2] xfs_repair: adjust btree bulkloading slack computations to match online repair Darrick J. Wong
2024-03-26 3:20 ` [PATCH 2/2] xfs_repair: bulk load records into new btree blocks Darrick J. Wong
2024-03-26 2:55 ` [PATCHSET 04/18] xfsprogs: bug fixes for 6.8 Darrick J. Wong
2024-03-26 3:21 ` [PATCH 1/5] xfs_repair: double-check with shortform attr verifiers Darrick J. Wong
2024-03-26 3:21 ` [PATCH 2/5] xfs_db: fix alignment checks in getbitval Darrick J. Wong
2024-03-26 5:14 ` Christoph Hellwig
2024-03-26 16:28 ` Darrick J. Wong
2024-03-26 16:36 ` Christoph Hellwig
2024-03-26 17:31 ` Darrick J. Wong
2024-03-26 3:21 ` [PATCH 3/5] xfs_scrub: fix threadcount estimates for phase 6 Darrick J. Wong
2024-03-26 5:15 ` Christoph Hellwig
2024-03-26 16:30 ` Darrick J. Wong
2024-03-26 16:36 ` Christoph Hellwig
2024-03-26 3:21 ` [PATCH 4/5] xfs_scrub: don't fail while reporting media scan errors Darrick J. Wong
2024-03-26 5:15 ` Christoph Hellwig
2024-03-26 3:22 ` [PATCH 5/5] xfs_io: add linux madvise advice codes Darrick J. Wong
2024-03-26 5:15 ` Christoph Hellwig
2024-03-26 2:56 ` [PATCHSET V2 05/18] xfsprogs: fix log sector size detection Darrick J. Wong
2024-03-26 3:00 ` Darrick J. Wong
2024-03-26 5:16 ` Christoph Hellwig
2024-03-26 3:22 ` [PATCH 1/5] libxfs: remove the unused fs_topology_t typedef Darrick J. Wong
2024-03-26 3:22 ` [PATCH 2/5] libxfs: refactor the fs_topology structure Darrick J. Wong
2024-03-26 3:22 ` [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology Darrick J. Wong
2024-03-26 3:23 ` [PATCH 4/5] libxfs: also query log device topology in get_topology Darrick J. Wong
2024-03-26 3:23 ` [PATCH 5/5] mkfs: use a sensible log sector size default Darrick J. Wong
2024-03-26 2:56 ` [PATCHSET 06/18] mkfs: scale shards on ssds Darrick J. Wong
2024-03-26 3:23 ` [PATCH 1/2] mkfs: allow sizing allocation groups for concurrency Darrick J. Wong
2024-03-26 3:23 ` [PATCH 2/2] mkfs: allow sizing internal logs " Darrick J. Wong
2024-03-26 2:56 ` [PATCHSET v29.4 07/18] xfs_scrub: scan metadata files in parallel Darrick J. Wong
2024-03-26 3:24 ` [PATCH 1/3] libfrog: rename XFROG_SCRUB_TYPE_* to XFROG_SCRUB_GROUP_* Darrick J. Wong
2024-03-26 3:24 ` [PATCH 2/3] libfrog: promote XFROG_SCRUB_DESCR_SUMMARY to a scrub type Darrick J. Wong
2024-03-26 3:24 ` [PATCH 3/3] xfs_scrub: scan whole-fs metadata files in parallel Darrick J. Wong
2024-03-26 2:56 ` [PATCHSET v29.4 08/18] xfs_repair: rebuild inode fork mappings Darrick J. Wong
2024-03-26 3:25 ` [PATCH 1/3] xfs_repair: push inode buf and dinode pointers all the way to inode fork processing Darrick J. Wong
2024-03-26 3:25 ` [PATCH 2/3] xfs_repair: sync bulkload data structures with kernel newbt code Darrick J. Wong
2024-03-26 3:25 ` [PATCH 3/3] xfs_repair: rebuild block mappings from rmapbt data Darrick J. Wong
2024-03-26 2:57 ` [PATCHSET 09/18] xfs_repair: support more than 4 billion records Darrick J. Wong
2024-03-26 3:25 ` [PATCH 1/8] xfs_db: add a bmbt inflation command Darrick J. Wong
2024-03-26 3:26 ` [PATCH 2/8] xfs_repair: slab and bag structs need to track more than 2^32 items Darrick J. Wong
2024-03-26 3:26 ` [PATCH 3/8] xfs_repair: support more than 2^32 rmapbt records per AG Darrick J. Wong
2024-03-26 3:26 ` [PATCH 4/8] xfs_repair: support more than 2^32 owners per physical block Darrick J. Wong
2024-03-26 3:26 ` [PATCH 5/8] xfs_repair: clean up lock resources Darrick J. Wong
2024-03-26 3:27 ` [PATCH 6/8] xfs_repair: constrain attr fork extent count Darrick J. Wong
2024-03-26 3:27 ` [PATCH 7/8] xfs_repair: don't create block maps for data files Darrick J. Wong
2024-03-26 3:27 ` [PATCH 8/8] xfs_repair: support more than INT_MAX block maps Darrick J. Wong
2024-03-26 2:57 ` [PATCHSET v29.4 10/18] libxfs: prepare to sync with 6.9 Darrick J. Wong
2024-03-26 3:27 ` [PATCH 1/3] libxfs: actually set m_fsname Darrick J. Wong
2024-03-26 3:28 ` [PATCH 2/3] libxfs: clean up xfs_da_unmount usage Darrick J. Wong
2024-03-26 3:28 ` [PATCH 3/3] libfrog: create a new scrub group for things requiring full inode scans Darrick J. Wong
2024-03-26 2:57 ` [PATCHSET 11/18] libxfs: sync with 6.9 Darrick J. Wong
2024-03-26 3:28 ` [PATCH 001/110] xfs: convert kmem_zalloc() to kzalloc() Darrick J. Wong
2024-03-26 3:28 ` [PATCH 002/110] xfs: convert kmem_alloc() to kmalloc() Darrick J. Wong
2024-03-26 3:29 ` [PATCH 003/110] xfs: convert remaining kmem_free() to kfree() Darrick J. Wong
2024-03-26 3:29 ` [PATCH 004/110] xfs: use __GFP_NOLOCKDEP instead of GFP_NOFS Darrick J. Wong
2024-03-26 3:29 ` [PATCH 005/110] xfs: use GFP_KERNEL in pure transaction contexts Darrick J. Wong
2024-03-26 3:29 ` [PATCH 006/110] xfs: clean up remaining GFP_NOFS users Darrick J. Wong
2024-03-26 3:30 ` [PATCH 007/110] xfs: use xfs_defer_alloc a bit more Darrick J. Wong
2024-03-26 3:30 ` [PATCH 008/110] xfs: Replace xfs_isilocked with xfs_assert_ilocked Darrick J. Wong
2024-03-26 3:30 ` [PATCH 009/110] xfs: create a static name for the dot entry too Darrick J. Wong
2024-03-26 3:31 ` [PATCH 010/110] xfs: create a predicate to determine if two xfs_names are the same Darrick J. Wong
2024-03-26 3:31 ` [PATCH 011/110] xfs: create a macro for decoding ftypes in tracepoints Darrick J. Wong
2024-03-26 3:31 ` [PATCH 012/110] xfs: report the health of quota counts Darrick J. Wong
2024-03-26 3:31 ` [PATCH 013/110] xfs: implement live quotacheck inode scan Darrick J. Wong
2024-03-26 3:32 ` [PATCH 014/110] xfs: report health of inode link counts Darrick J. Wong
2024-03-26 3:32 ` [PATCH 015/110] xfs: teach scrub to check file nlinks Darrick J. Wong
2024-03-26 3:32 ` [PATCH 016/110] xfs: separate the marking of sick and checked metadata Darrick J. Wong
2024-03-26 3:32 ` [PATCH 017/110] xfs: report fs corruption errors to the health tracking system Darrick J. Wong
2024-03-26 3:33 ` [PATCH 018/110] xfs: report ag header " Darrick J. Wong
2024-03-26 3:33 ` [PATCH 019/110] xfs: report block map " Darrick J. Wong
2024-03-26 3:33 ` [PATCH 020/110] xfs: report btree block corruption errors to the health system Darrick J. Wong
2024-03-26 3:33 ` [PATCH 021/110] xfs: report dir/attr " Darrick J. Wong
2024-03-26 3:34 ` [PATCH 022/110] xfs: report inode " Darrick J. Wong
2024-03-26 3:34 ` [PATCH 023/110] xfs: report realtime metadata " Darrick J. Wong
2024-03-26 3:34 ` [PATCH 024/110] xfs: report XFS_IS_CORRUPT " Darrick J. Wong
2024-03-26 3:34 ` [PATCH 025/110] xfs: add secondary and indirect classes to the health tracking system Darrick J. Wong
2024-03-26 3:35 ` [PATCH 026/110] xfs: remember sick inodes that get inactivated Darrick J. Wong
2024-03-26 3:35 ` [PATCH 027/110] xfs: update health status if we get a clean bill of health Darrick J. Wong
2024-03-26 3:35 ` [PATCH 028/110] xfs: consolidate btree block freeing tracepoints Darrick J. Wong
2024-03-26 3:35 ` [PATCH 029/110] xfs: consolidate btree block allocation tracepoints Darrick J. Wong
2024-03-26 3:36 ` [PATCH 030/110] xfs: set the btree cursor bc_ops in xfs_btree_alloc_cursor Darrick J. Wong
2024-03-26 3:36 ` [PATCH 031/110] xfs: drop XFS_BTREE_CRC_BLOCKS Darrick J. Wong
2024-03-26 3:36 ` [PATCH 032/110] xfs: encode the btree geometry flags in the btree ops structure Darrick J. Wong
2024-03-26 3:37 ` [PATCH 033/110] xfs: remove bc_ino.flags Darrick J. Wong
2024-03-26 3:37 ` [PATCH 034/110] xfs: consolidate the xfs_alloc_lookup_* helpers Darrick J. Wong
2024-03-26 3:37 ` [PATCH 035/110] xfs: turn the allocbt cursor active field into a btree flag Darrick J. Wong
2024-03-26 3:37 ` [PATCH 036/110] xfs: extern some btree ops structures Darrick J. Wong
2024-03-26 3:38 ` [PATCH 037/110] xfs: initialize btree blocks using btree_ops structure Darrick J. Wong
2024-03-26 3:38 ` [PATCH 038/110] xfs: rename btree block/buffer init functions Darrick J. Wong
2024-03-26 3:38 ` [PATCH 039/110] xfs: btree convert xfs_btree_init_block to xfs_btree_init_buf calls Darrick J. Wong
2024-03-26 3:38 ` [PATCH 040/110] xfs: remove the unnecessary daddr paramter to _init_block Darrick J. Wong
2024-03-26 3:39 ` [PATCH 041/110] xfs: set btree block buffer ops in _init_buf Darrick J. Wong
2024-03-26 3:39 ` [PATCH 042/110] xfs: move lru refs to the btree ops structure Darrick J. Wong
2024-03-26 3:39 ` [PATCH 043/110] xfs: move the btree stats offset into struct btree_ops Darrick J. Wong
2024-03-26 3:39 ` [PATCH 044/110] xfs: factor out a xfs_btree_owner helper Darrick J. Wong
2024-03-26 3:40 ` [PATCH 045/110] xfs: factor out a btree block owner check Darrick J. Wong
2024-03-26 3:40 ` [PATCH 046/110] xfs: store the btree pointer length in struct xfs_btree_ops Darrick J. Wong
2024-03-26 3:40 ` [PATCH 047/110] xfs: split out a btree type from the btree ops geometry flags Darrick J. Wong
2024-03-26 3:40 ` [PATCH 048/110] xfs: split the per-btree union in struct xfs_btree_cur Darrick J. Wong
2024-03-26 3:41 ` [PATCH 049/110] xfs: create predicate to determine if cursor is at inode root level Darrick J. Wong
2024-03-26 3:41 ` [PATCH 050/110] xfs: move comment about two 2 keys per pointer in the rmap btree Darrick J. Wong
2024-03-26 3:41 ` [PATCH 051/110] xfs: add a xfs_btree_init_ptr_from_cur Darrick J. Wong
2024-03-26 3:41 ` [PATCH 052/110] xfs: don't override bc_ops for staging btrees Darrick J. Wong
2024-03-26 3:42 ` [PATCH 053/110] xfs: fold xfs_allocbt_init_common into xfs_allocbt_init_cursor Darrick J. Wong
2024-03-26 3:42 ` [PATCH 054/110] xfs: remove xfs_allocbt_stage_cursor Darrick J. Wong
2024-03-26 3:42 ` [PATCH 055/110] xfs: fold xfs_inobt_init_common into xfs_inobt_init_cursor Darrick J. Wong
2024-03-26 3:43 ` [PATCH 056/110] xfs: remove xfs_inobt_stage_cursor Darrick J. Wong
2024-03-26 3:43 ` [PATCH 057/110] xfs: fold xfs_refcountbt_init_common into xfs_refcountbt_init_cursor Darrick J. Wong
2024-03-26 3:43 ` [PATCH 058/110] xfs: remove xfs_refcountbt_stage_cursor Darrick J. Wong
2024-03-26 3:43 ` [PATCH 059/110] xfs: fold xfs_rmapbt_init_common into xfs_rmapbt_init_cursor Darrick J. Wong
2024-03-26 3:44 ` [PATCH 060/110] xfs: remove xfs_rmapbt_stage_cursor Darrick J. Wong
2024-03-26 3:44 ` [PATCH 061/110] xfs: make full use of xfs_btree_stage_ifakeroot in xfs_bmbt_stage_cursor Darrick J. Wong
2024-03-26 3:44 ` [PATCH 062/110] xfs: make staging file forks explicit Darrick J. Wong
2024-03-26 3:44 ` [PATCH 063/110] xfs: fold xfs_bmbt_init_common into xfs_bmbt_init_cursor Darrick J. Wong
2024-03-26 3:45 ` [PATCH 064/110] xfs: remove xfs_bmbt_stage_cursor Darrick J. Wong
2024-03-26 3:45 ` [PATCH 065/110] xfs: split the agf_roots and agf_levels arrays Darrick J. Wong
2024-03-26 3:45 ` [PATCH 066/110] xfs: add a name field to struct xfs_btree_ops Darrick J. Wong
2024-03-26 3:45 ` [PATCH 067/110] xfs: add a sick_mask " Darrick J. Wong
2024-03-26 3:46 ` [PATCH 068/110] xfs: split xfs_allocbt_init_cursor Darrick J. Wong
2024-03-26 3:46 ` [PATCH 069/110] xfs: remove xfs_inobt_cur Darrick J. Wong
2024-03-26 3:46 ` [PATCH 070/110] xfs: remove the btnum argument to xfs_inobt_count_blocks Darrick J. Wong
2024-03-26 3:46 ` [PATCH 071/110] xfs: split xfs_inobt_insert_sprec Darrick J. Wong
2024-03-26 3:47 ` [PATCH 072/110] xfs: split xfs_inobt_init_cursor Darrick J. Wong
2024-03-26 3:47 ` [PATCH 073/110] xfs: pass a 'bool is_finobt' to xfs_inobt_insert Darrick J. Wong
2024-03-26 3:47 ` [PATCH 074/110] xfs: remove xfs_btnum_t Darrick J. Wong
2024-03-26 3:47 ` [PATCH 075/110] xfs: simplify xfs_btree_check_sblock_siblings Darrick J. Wong
2024-03-26 3:48 ` [PATCH 076/110] xfs: simplify xfs_btree_check_lblock_siblings Darrick J. Wong
2024-03-26 3:48 ` [PATCH 077/110] xfs: open code xfs_btree_check_lptr in xfs_bmap_btree_to_extents Darrick J. Wong
2024-03-26 3:48 ` [PATCH 078/110] xfs: consolidate btree ptr checking Darrick J. Wong
2024-03-26 3:49 ` [PATCH 079/110] xfs: misc cleanups for __xfs_btree_check_sblock Darrick J. Wong
2024-03-26 3:49 ` [PATCH 080/110] xfs: remove the crc variable in __xfs_btree_check_lblock Darrick J. Wong
2024-03-26 3:49 ` [PATCH 081/110] xfs: tighten up validation of root block in inode forks Darrick J. Wong
2024-03-26 3:49 ` [PATCH 082/110] xfs: consolidate btree block verification Darrick J. Wong
2024-03-26 3:50 ` [PATCH 083/110] xfs: rename btree helpers that depends on the block number representation Darrick J. Wong
2024-03-26 3:50 ` [PATCH 084/110] xfs: factor out a __xfs_btree_check_lblock_hdr helper Darrick J. Wong
2024-03-26 3:50 ` [PATCH 085/110] xfs: remove xfs_btree_reada_bufl Darrick J. Wong
2024-03-26 3:50 ` [PATCH 086/110] xfs: remove xfs_btree_reada_bufs Darrick J. Wong
2024-03-26 3:51 ` [PATCH 087/110] xfs: move and rename xfs_btree_read_bufl Darrick J. Wong
2024-03-26 3:51 ` [PATCH 088/110] libxfs: teach buftargs to maintain their own buffer hashtable Darrick J. Wong
2024-03-26 3:51 ` [PATCH 089/110] libxfs: add xfile support Darrick J. Wong
2024-03-26 5:29 ` Christoph Hellwig
2024-03-26 16:47 ` Darrick J. Wong
2024-03-26 16:49 ` Christoph Hellwig
2024-03-26 16:51 ` Darrick J. Wong
2024-03-26 17:06 ` Christoph Hellwig
2024-03-26 5:37 ` Christoph Hellwig
2024-03-26 16:50 ` Darrick J. Wong
2024-03-26 3:51 ` [PATCH 090/110] libxfs: partition memfd files to avoid using too many fds Darrick J. Wong
2024-03-26 3:52 ` [PATCH 091/110] xfs: teach buftargs to maintain their own buffer hashtable Darrick J. Wong
2024-03-26 3:52 ` [PATCH 092/110] libxfs: support in-memory buffer cache targets Darrick J. Wong
2024-03-26 3:52 ` [PATCH 093/110] xfs: add a xfs_btree_ptrs_equal helper Darrick J. Wong
2024-03-26 3:52 ` [PATCH 094/110] xfs: support in-memory btrees Darrick J. Wong
2024-03-26 5:32 ` Christoph Hellwig
2024-03-26 17:02 ` Darrick J. Wong
2024-03-26 17:06 ` Christoph Hellwig
2024-03-26 3:53 ` [PATCH 095/110] xfs: launder in-memory btree buffers before transaction commit Darrick J. Wong
2024-03-26 3:53 ` [PATCH 096/110] xfs: create a helper to decide if a file mapping targets the rt volume Darrick J. Wong
2024-03-26 3:53 ` [PATCH 097/110] xfs: repair the rmapbt Darrick J. Wong
2024-03-26 3:53 ` [PATCH 098/110] xfs: create a shadow rmap btree during rmap repair Darrick J. Wong
2024-03-26 3:54 ` [PATCH 099/110] xfs: hook live rmap operations during a repair operation Darrick J. Wong
2024-03-26 3:54 ` [PATCH 100/110] xfs: clean up bmap log intent item tracepoint callsites Darrick J. Wong
2024-03-26 3:54 ` [PATCH 101/110] xfs: move xfs_bmap_defer_add to xfs_bmap_item.c Darrick J. Wong
2024-03-26 3:55 ` [PATCH 102/110] xfs: fix xfs_bunmapi to allow unmapping of partial rt extents Darrick J. Wong
2024-03-26 3:55 ` [PATCH 103/110] xfs: add a realtime flag to the bmap update log redo items Darrick J. Wong
2024-03-26 3:55 ` [PATCH 104/110] xfs: support deferred bmap updates on the attr fork Darrick J. Wong
2024-03-26 3:55 ` [PATCH 105/110] xfs: xfs_bmap_finish_one should map unwritten extents properly Darrick J. Wong
2024-03-26 3:56 ` [PATCH 106/110] xfs: move xfs_symlink_remote.c declarations to xfs_symlink_remote.h Darrick J. Wong
2024-03-26 3:56 ` [PATCH 107/110] xfs: move remote symlink target read function to libxfs Darrick J. Wong
2024-03-26 3:56 ` [PATCH 108/110] xfs: move symlink target write " Darrick J. Wong
2024-03-26 3:56 ` [PATCH 109/110] xfs: xfs_btree_bload_prep_block() should use __GFP_NOFAIL Darrick J. Wong
2024-03-26 3:57 ` [PATCH 110/110] xfs: shrink failure needs to hold AGI buffer Darrick J. Wong
2024-03-26 5:42 ` [PATCHSET 11/18] libxfs: sync with 6.9 Christoph Hellwig
2024-03-26 2:57 ` [PATCHSET v29.4 12/18] xfsprogs: bmap log intent cleanups Darrick J. Wong
2024-03-26 3:57 ` [PATCH 1/4] libxfs: remove kmem_alloc, kmem_zalloc, and kmem_free Darrick J. Wong
2024-03-26 3:57 ` [PATCH 2/4] libxfs: add a bi_entry helper Darrick J. Wong
2024-03-26 3:57 ` [PATCH 3/4] xfs: reuse xfs_bmap_update_cancel_item Darrick J. Wong
2024-03-26 3:58 ` [PATCH 4/4] xfs: add a xattr_entry helper Darrick J. Wong
2024-03-26 2:58 ` [PATCHSET v29.4 13/18] xfsprogs: widen BUI formats to support realtime Darrick J. Wong
2024-03-26 3:58 ` [PATCH 1/1] xfs: add a realtime flag to the bmap update log redo items Darrick J. Wong
2024-03-26 5:42 ` Christoph Hellwig
2024-03-26 2:58 ` [PATCHSET v29.4 14/18] xfs_spaceman: updates for 6.9 Darrick J. Wong
2024-03-26 3:58 ` [PATCH 1/2] xfs_spaceman: report the health of quota counts Darrick J. Wong
2024-03-26 5:43 ` Christoph Hellwig
2024-03-26 3:58 ` [PATCH 2/2] xfs_spaceman: report health of inode link counts Darrick J. Wong
2024-03-26 5:43 ` Christoph Hellwig
2024-03-26 2:58 ` [PATCHSET v29.4 15/18] xfs_scrub: updates for 6.9 Darrick J. Wong
2024-03-26 3:59 ` [PATCH 1/5] xfs_scrub: implement live quotacheck inode scan Darrick J. Wong
2024-03-26 5:44 ` Christoph Hellwig
2024-03-26 3:59 ` [PATCH 2/5] xfs_scrub: check file link counts Darrick J. Wong
2024-03-26 5:44 ` Christoph Hellwig
2024-03-26 3:59 ` [PATCH 3/5] xfs_scrub: update health status if we get a clean bill of health Darrick J. Wong
2024-03-26 5:44 ` Christoph Hellwig
2024-03-26 4:00 ` [PATCH 4/5] xfs_scrub: use multiple threads to run in-kernel metadata scrubs that scan inodes Darrick J. Wong
2024-03-26 5:45 ` Christoph Hellwig
2024-03-26 4:00 ` [PATCH 5/5] xfs_scrub: upload clean bills of health Darrick J. Wong
2024-03-26 5:45 ` Christoph Hellwig
2024-03-26 2:58 ` [PATCHSET v29.4 16/18] xfs_repair: use in-memory rmap btrees Darrick J. Wong
2024-03-26 4:00 ` [PATCH 1/5] xfs_repair: convert regular rmap repair to use in-memory btrees Darrick J. Wong
2024-03-26 5:49 ` Christoph Hellwig
2024-03-26 17:14 ` Darrick J. Wong
2024-03-26 4:00 ` [PATCH 2/5] xfs_repair: verify on-disk rmap btrees with in-memory btree data Darrick J. Wong
2024-03-26 5:52 ` Christoph Hellwig
2024-03-26 4:01 ` [PATCH 3/5] xfs_repair: compute refcount data from in-memory rmap btrees Darrick J. Wong
2024-03-26 5:55 ` Christoph Hellwig
2024-03-26 17:22 ` Darrick J. Wong
2024-03-26 4:01 ` [PATCH 4/5] xfs_repair: reduce rmap bag memory usage when creating refcounts Darrick J. Wong
2024-03-26 5:55 ` Christoph Hellwig
2024-03-26 4:01 ` [PATCH 5/5] xfs_repair: remove the old rmap collection slabs Darrick J. Wong
2024-03-26 5:55 ` Christoph Hellwig
2024-03-26 2:59 ` [PATCHSET v29.4 17/18] xfs_repair: reduce refcount repair memory usage Darrick J. Wong
2024-03-26 4:01 ` [PATCH 1/4] xfs_repair: define an in-memory btree for storing refcount bag info Darrick J. Wong
2024-03-26 5:57 ` Christoph Hellwig
2024-03-26 17:22 ` Darrick J. Wong
2024-03-26 4:02 ` [PATCH 2/4] xfs_repair: create refcount bag Darrick J. Wong
2024-03-26 5:58 ` Christoph Hellwig
2024-03-26 4:02 ` [PATCH 3/4] xfs_repair: port to the new refcount bag structure Darrick J. Wong
2024-03-26 5:58 ` Christoph Hellwig
2024-03-26 4:02 ` [PATCH 4/4] xfs_repair: remove the old bag implementation Darrick J. Wong
2024-03-26 5:58 ` Christoph Hellwig
2024-03-26 2:59 ` [PATCHSET v29.4 18/18] mkfs: cleanups for 6.9 Darrick J. Wong
2024-03-26 4:02 ` [PATCH 1/1] mkfs: use libxfs to create symlinks Darrick J. Wong
2024-03-26 5:56 ` Christoph Hellwig
2024-03-26 17:08 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2024-04-22 16:25 [PATCH 00/67] libxfs: Sync to Linux 6.8 cem
2024-04-22 16:26 ` [PATCH 60/67] xfs: remove struct xfs_attr_shortform cem
2024-04-17 21:16 [PATCHSET 04/11] libxfs: sync with 6.8 Darrick J. Wong
2024-04-17 21:37 ` [PATCH 60/67] xfs: remove struct xfs_attr_shortform Darrick J. Wong
2024-03-13 1:47 [PATCHSET 02/10] libxfs: sync with 6.8 Darrick J. Wong
2024-03-13 2:08 ` [PATCH 60/67] xfs: remove struct xfs_attr_shortform Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171142127822.2212320.2159420316852953492.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=bodonnel@redhat.com \
--cc=cem@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.