From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A98E12838E for ; Tue, 26 Mar 2024 03:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711422515; cv=none; b=Y+ks20BCVXc0Q2I6xcYXvpACxr8uMRnPw500fZnXQl4dYoCkCqbOZCsYo2xk/DTyCTPclWFrU/SkcJCfPbnZgtfTnSE+LdUr2mWtfa3+DLK/BdslrB7gyXkMqbIvDbHKwkxgt99RmAweZj1zQgUnMQ0rKLihjPWAheHJQ/gW9Jc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711422515; c=relaxed/simple; bh=SS62/0B8aFaol+c71WspkiiFzHujP1fRIWH1YHqi3j4=; h=Date:Subject:From:To:Cc:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=refHUPU+nfOxuW+mV1vMHEtA7BmiA4msyihtbBIHFW/K+VUPSy5wfg3gbL1TmvIHaFsR/s00kYmeOTDtOxVtXtKQDi8kT8MTMR7HZ+HE6Q23YlMJEIQ/3TKuQafIIfCYcqyDU5CXRVOkAzk0kWEeSZO2INcYHhSq25ffPCLyz/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E47nCtdy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E47nCtdy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A50B5C433C7; Tue, 26 Mar 2024 03:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711422514; bh=SS62/0B8aFaol+c71WspkiiFzHujP1fRIWH1YHqi3j4=; h=Date:Subject:From:To:Cc:In-Reply-To:References:From; b=E47nCtdypyo23vN7I6QLh3wN5O3OAqEzXSqzy43Eo998ImCPF+eKmZVVHhjP72BCa JfOR8Dnc/nyig5q8Vr1f9Bq2722IH+lIqIfKu9Us99mt7i9fmy5NSLbQhXVP4tNMtG u/YVdALkD/8TdhVe5XgPD6c/ZSv6/CgFwlmBpcxDn1Yw3+QNHj6snQnVntuJNgs2XU jzk+rX4VddTAUdD024S8kNHADRn+rMWAJCr31m9QVcTSb8paKzNJ7Ooh4iLYPU4YhV guLNv2HGnzOOeD6bCNOAUaw8CJ4QLrj/SJ0M61Y1s7iPTmEJ6KRVUtcx7yFGRvElh2 xzRcJw8QCAvLg== Date: Mon, 25 Mar 2024 20:08:34 -0700 Subject: [PATCH 22/67] xfs: update dir3 leaf block metadata after swap From: "Darrick J. Wong" To: cem@kernel.org, djwong@kernel.org Cc: Zhang Tianci , Dave Chinner , Chandan Babu R , Bill O'Donnell , linux-xfs@vger.kernel.org Message-ID: <171142127279.2212320.9780784867815047399.stgit@frogsfrogsfrogs> In-Reply-To: <171142126868.2212320.6212071954549567554.stgit@frogsfrogsfrogs> References: <171142126868.2212320.6212071954549567554.stgit@frogsfrogsfrogs> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit From: Zhang Tianci Source kernel commit: 5759aa4f956034b289b0ae2c99daddfc775442e1 xfs_da3_swap_lastblock() copy the last block content to the dead block, but do not update the metadata in it. We need update some metadata for some kinds of type block, such as dir3 leafn block records its blkno, we shall update it to the dead block blkno. Otherwise, before write the xfs_buf to disk, the verify_write() will fail in blk_hdr->blkno != xfs_buf->b_bn, then xfs will be shutdown. We will get this warning: XFS (dm-0): Metadata corruption detected at xfs_dir3_leaf_verify+0xa8/0xe0 [xfs], xfs_dir3_leafn block 0x178 XFS (dm-0): Unmount and run xfs_repair XFS (dm-0): First 128 bytes of corrupted metadata buffer: 00000000e80f1917: 00 80 00 0b 00 80 00 07 3d ff 00 00 00 00 00 00 ........=....... 000000009604c005: 00 00 00 00 00 00 01 a0 00 00 00 00 00 00 00 00 ................ 000000006b6fb2bf: e4 44 e3 97 b5 64 44 41 8b 84 60 0e 50 43 d9 bf .D...dDA..`.PC.. 00000000678978a2: 00 00 00 00 00 00 00 83 01 73 00 93 00 00 00 00 .........s...... 00000000b28b247c: 99 29 1d 38 00 00 00 00 99 29 1d 40 00 00 00 00 .).8.....).@.... 000000002b2a662c: 99 29 1d 48 00 00 00 00 99 49 11 00 00 00 00 00 .).H.....I...... 00000000ea2ffbb8: 99 49 11 08 00 00 45 25 99 49 11 10 00 00 48 fe .I....E%.I....H. 0000000069e86440: 99 49 11 18 00 00 4c 6b 99 49 11 20 00 00 4d 97 .I....Lk.I. ..M. XFS (dm-0): xfs_do_force_shutdown(0x8) called from line 1423 of file fs/xfs/xfs_buf.c. Return address = 00000000c0ff63c1 XFS (dm-0): Corruption of in-memory data detected. Shutting down filesystem XFS (dm-0): Please umount the filesystem and rectify the problem(s) >>From the log above, we know xfs_buf->b_no is 0x178, but the block's hdr record its blkno is 0x1a0. Fixes: 24df33b45ecf ("xfs: add CRC checking to dir2 leaf blocks") Signed-off-by: Zhang Tianci Suggested-by: Dave Chinner Reviewed-by: "Darrick J. Wong" Signed-off-by: Chandan Babu R Reviewed-by: Bill O'Donnell --- libxfs/xfs_da_btree.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libxfs/xfs_da_btree.c b/libxfs/xfs_da_btree.c index a068a0164363..3903486d19d2 100644 --- a/libxfs/xfs_da_btree.c +++ b/libxfs/xfs_da_btree.c @@ -2312,10 +2312,17 @@ xfs_da3_swap_lastblock( return error; /* * Copy the last block into the dead buffer and log it. + * On CRC-enabled file systems, also update the stamped in blkno. */ memcpy(dead_buf->b_addr, last_buf->b_addr, args->geo->blksize); + if (xfs_has_crc(mp)) { + struct xfs_da3_blkinfo *da3 = dead_buf->b_addr; + + da3->blkno = cpu_to_be64(xfs_buf_daddr(dead_buf)); + } xfs_trans_log_buf(tp, dead_buf, 0, args->geo->blksize - 1); dead_info = dead_buf->b_addr; + /* * Get values from the moved block. */