* [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices
@ 2024-03-23 7:36 INAGAKI Hiroshi
2024-03-23 7:36 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: INAGAKI Hiroshi @ 2024-03-23 7:36 UTC (permalink / raw
To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt
Cc: linux-leds, devicetree, linux-kernel, INAGAKI Hiroshi
This patch series adds some LED_FUNCTION_* definitions mainly for router
devices.
Those definitions are useful for OpenWrt or something.
v1 -> v2
- fix sort order of LED_FUNCTION_MOBILE
- improve the commit description of the first commit
INAGAKI Hiroshi (2):
dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN
include/dt-bindings/leds/common.h | 3 +++
1 file changed, 3 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
2024-03-23 7:36 [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
@ 2024-03-23 7:36 ` INAGAKI Hiroshi
2024-03-23 10:56 ` Krzysztof Kozlowski
2024-03-25 13:26 ` Rob Herring
2024-03-23 7:36 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: INAGAKI Hiroshi @ 2024-03-23 7:36 UTC (permalink / raw
To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt
Cc: linux-leds, devicetree, linux-kernel, INAGAKI Hiroshi,
Hauke Mehrtens
Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
connection. This is useful to distinguish those LEDs from LEDs that
indicates status of wired "wan" connection.
example (on stock fw):
IIJ SA-W2 has "Mobile" LEDs that indicate status (no signal, too low,
low, good) of mobile network connection via dongle connected to USB
port.
- no signal: (none, turned off)
- too low: green:mobile & red:mobile (amber, blink)
- low: green:mobile & red:mobile (amber, turned on)
- good: green:mobile (turned on)
Suggested-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
---
v1 -> v2
- move _MOBILE before _MTD
- improve the commit description
include/dt-bindings/leds/common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index ecea167930d9..6216ecdb06c7 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -90,6 +90,7 @@
#define LED_FUNCTION_INDICATOR "indicator"
#define LED_FUNCTION_LAN "lan"
#define LED_FUNCTION_MAIL "mail"
+#define LED_FUNCTION_MOBILE "mobile"
#define LED_FUNCTION_MTD "mtd"
#define LED_FUNCTION_PANIC "panic"
#define LED_FUNCTION_PROGRAMMING "programming"
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN
2024-03-23 7:36 [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
2024-03-23 7:36 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
@ 2024-03-23 7:36 ` INAGAKI Hiroshi
2024-03-28 11:57 ` [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices Lee Jones
2024-04-11 15:50 ` Lee Jones
3 siblings, 0 replies; 7+ messages in thread
From: INAGAKI Hiroshi @ 2024-03-23 7:36 UTC (permalink / raw
To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt
Cc: linux-leds, devicetree, linux-kernel, INAGAKI Hiroshi
Add LED_FUNCTION_SPEED_LAN and LED_FUNCTION_SPEED_WAN for LEDs that
indicate link speed of ethernet ports on LAN/WAN. This is useful to
distinguish those LEDs from LEDs that indicate link status (up/down).
example:
Fortinet FortiGate 30E/50E have LEDs that indicate link speed on each
of the ethernet ports in addition to LEDs that indicate link status
(up/down).
- 1000 Mbps: green:speed-(lan|wan)-N
- 100 Mbps: amber:speed-(lan|wan)-N
- 10 Mbps: (none, turned off)
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
---
v1 -> v2
(no changes)
include/dt-bindings/leds/common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index 6216ecdb06c7..82a5769725ce 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -96,6 +96,8 @@
#define LED_FUNCTION_PROGRAMMING "programming"
#define LED_FUNCTION_RX "rx"
#define LED_FUNCTION_SD "sd"
+#define LED_FUNCTION_SPEED_LAN "speed-lan"
+#define LED_FUNCTION_SPEED_WAN "speed-wan"
#define LED_FUNCTION_STANDBY "standby"
#define LED_FUNCTION_TORCH "torch"
#define LED_FUNCTION_TX "tx"
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
2024-03-23 7:36 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
@ 2024-03-23 10:56 ` Krzysztof Kozlowski
2024-03-25 13:26 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-23 10:56 UTC (permalink / raw
To: INAGAKI Hiroshi, pavel, lee, robh, krzysztof.kozlowski+dt,
conor+dt
Cc: linux-leds, devicetree, linux-kernel, Hauke Mehrtens
On 23/03/2024 08:36, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection. This is useful to distinguish those LEDs from LEDs that
> indicates status of wired "wan" connection.
>
> example (on stock fw):
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
2024-03-23 7:36 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
2024-03-23 10:56 ` Krzysztof Kozlowski
@ 2024-03-25 13:26 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2024-03-25 13:26 UTC (permalink / raw
To: INAGAKI Hiroshi
Cc: lee, krzysztof.kozlowski+dt, devicetree, Hauke Mehrtens, pavel,
conor+dt, linux-kernel, linux-leds
On Sat, 23 Mar 2024 16:36:09 +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection. This is useful to distinguish those LEDs from LEDs that
> indicates status of wired "wan" connection.
>
> example (on stock fw):
>
> IIJ SA-W2 has "Mobile" LEDs that indicate status (no signal, too low,
> low, good) of mobile network connection via dongle connected to USB
> port.
>
> - no signal: (none, turned off)
> - too low: green:mobile & red:mobile (amber, blink)
> - low: green:mobile & red:mobile (amber, turned on)
> - good: green:mobile (turned on)
>
> Suggested-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
> ---
> v1 -> v2
>
> - move _MOBILE before _MTD
> - improve the commit description
>
> include/dt-bindings/leds/common.h | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices
2024-03-23 7:36 [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
2024-03-23 7:36 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
2024-03-23 7:36 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi
@ 2024-03-28 11:57 ` Lee Jones
2024-04-11 15:50 ` Lee Jones
3 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2024-03-28 11:57 UTC (permalink / raw
To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt,
INAGAKI Hiroshi
Cc: linux-leds, devicetree, linux-kernel
On Sat, 23 Mar 2024 16:36:08 +0900, INAGAKI Hiroshi wrote:
> This patch series adds some LED_FUNCTION_* definitions mainly for router
> devices.
> Those definitions are useful for OpenWrt or something.
>
> v1 -> v2
>
> - fix sort order of LED_FUNCTION_MOBILE
> - improve the commit description of the first commit
>
> [...]
Applied, thanks!
[1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
commit: c332f0450f33c123a538a8fcc69fa8e4e5aedfbb
[2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN
commit: 2588a5d98532244a7faf4514f79dc684fddf4c14
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices
2024-03-23 7:36 [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
` (2 preceding siblings ...)
2024-03-28 11:57 ` [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices Lee Jones
@ 2024-04-11 15:50 ` Lee Jones
3 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2024-04-11 15:50 UTC (permalink / raw
To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt,
INAGAKI Hiroshi
Cc: linux-leds, devicetree, linux-kernel
On Sat, 23 Mar 2024 16:36:08 +0900, INAGAKI Hiroshi wrote:
> This patch series adds some LED_FUNCTION_* definitions mainly for router
> devices.
> Those definitions are useful for OpenWrt or something.
>
> v1 -> v2
>
> - fix sort order of LED_FUNCTION_MOBILE
> - improve the commit description of the first commit
>
> [...]
Applied, thanks!
[1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
commit: b65a10938791d90c88ef4f3ecddee22b9fc23b2e
[2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN
commit: 03075af4c95133dfa14f434dab3b7b97e6cb9b56
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-04-11 15:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-23 7:36 [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
2024-03-23 7:36 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
2024-03-23 10:56 ` Krzysztof Kozlowski
2024-03-25 13:26 ` Rob Herring
2024-03-23 7:36 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi
2024-03-28 11:57 ` [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices Lee Jones
2024-04-11 15:50 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.