From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: [PATCHSET v29.4 01/13] xfs: improve log incompat feature handling
Date: Mon, 26 Feb 2024 18:17:48 -0800 [thread overview]
Message-ID: <170900010739.937966.5871198955451070108.stgit@frogsfrogsfrogs> (raw)
Hi all,
This patchset improves the performance of log incompat feature bit
handling by making a few changes to how the filesystem handles them.
First, we now only clear the bits during a clean unmount to reduce calls
to the (expensive) upgrade function to once per bit per mount. Second,
we now only allow incompat feature upgrades for sysadmins or if the
sysadmin explicitly allows it via mount option. Currently the only log
incompat user is logged xattrs, which requires CONFIG_XFS_DEBUG=y, so
there should be no user visible impact to this change.
If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.
This has been running on the djcloud for months with no problems. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=log-incompat-permissions
---
Commits in this patchset:
* xfs: only clear log incompat flags at clean unmount
* xfs: only add log incompat features with explicit permission
---
Documentation/admin-guide/xfs.rst | 7 +++
.../filesystems/xfs/xfs-online-fsck-design.rst | 3 -
fs/xfs/xfs_log.c | 28 -------------
fs/xfs/xfs_log.h | 2 -
fs/xfs/xfs_log_priv.h | 3 -
fs/xfs/xfs_log_recover.c | 15 -------
fs/xfs/xfs_mount.c | 34 ++++++++++++++++
fs/xfs/xfs_mount.h | 9 ++++
fs/xfs/xfs_super.c | 12 +++++-
fs/xfs/xfs_xattr.c | 42 +++-----------------
10 files changed, 66 insertions(+), 89 deletions(-)
next reply other threads:[~2024-02-27 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 2:17 Darrick J. Wong [this message]
2024-02-27 2:19 ` [PATCH 1/2] xfs: only clear log incompat flags at clean unmount Darrick J. Wong
2024-02-27 18:08 ` Christoph Hellwig
2024-02-27 2:19 ` [PATCH 2/2] xfs: only add log incompat features with explicit permission Darrick J. Wong
2024-02-27 18:09 ` Christoph Hellwig
2024-02-27 18:19 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170900010739.937966.5871198955451070108.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.