* [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const
@ 2023-03-09 8:16 Jani Nikula
2023-03-09 10:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Jani Nikula @ 2023-03-09 8:16 UTC (permalink / raw
To: intel-gfx; +Cc: jani.nikula
There's no need for any of these to be mutable, constify:
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000020 files.0
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000050 files.1
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_def
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_def
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_def
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_def
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_def
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 name_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 class_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 inst_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 mmio_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 caps_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 all_caps_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_attr
drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_attr
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/sysfs_engines.c | 36 ++++++++++++-------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/sysfs_engines.c b/drivers/gpu/drm/i915/gt/sysfs_engines.c
index 7eae3265f8cd..021f51d9b456 100644
--- a/drivers/gpu/drm/i915/gt/sysfs_engines.c
+++ b/drivers/gpu/drm/i915/gt/sysfs_engines.c
@@ -27,7 +27,7 @@ name_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%s\n", kobj_to_engine(kobj)->name);
}
-static struct kobj_attribute name_attr =
+static const struct kobj_attribute name_attr =
__ATTR(name, 0444, name_show, NULL);
static ssize_t
@@ -36,7 +36,7 @@ class_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_class);
}
-static struct kobj_attribute class_attr =
+static const struct kobj_attribute class_attr =
__ATTR(class, 0444, class_show, NULL);
static ssize_t
@@ -45,7 +45,7 @@ inst_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_instance);
}
-static struct kobj_attribute inst_attr =
+static const struct kobj_attribute inst_attr =
__ATTR(instance, 0444, inst_show, NULL);
static ssize_t
@@ -54,7 +54,7 @@ mmio_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "0x%x\n", kobj_to_engine(kobj)->mmio_base);
}
-static struct kobj_attribute mmio_attr =
+static const struct kobj_attribute mmio_attr =
__ATTR(mmio_base, 0444, mmio_show, NULL);
static const char * const vcs_caps[] = {
@@ -125,7 +125,7 @@ caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return __caps_show(engine, engine->uabi_capabilities, buf, true);
}
-static struct kobj_attribute caps_attr =
+static const struct kobj_attribute caps_attr =
__ATTR(capabilities, 0444, caps_show, NULL);
static ssize_t
@@ -134,7 +134,7 @@ all_caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return __caps_show(kobj_to_engine(kobj), -1, buf, false);
}
-static struct kobj_attribute all_caps_attr =
+static const struct kobj_attribute all_caps_attr =
__ATTR(known_capabilities, 0444, all_caps_show, NULL);
static ssize_t
@@ -183,7 +183,7 @@ max_spin_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->props.max_busywait_duration_ns);
}
-static struct kobj_attribute max_spin_attr =
+static const struct kobj_attribute max_spin_attr =
__ATTR(max_busywait_duration_ns, 0644, max_spin_show, max_spin_store);
static ssize_t
@@ -194,7 +194,7 @@ max_spin_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->defaults.max_busywait_duration_ns);
}
-static struct kobj_attribute max_spin_def =
+static const struct kobj_attribute max_spin_def =
__ATTR(max_busywait_duration_ns, 0444, max_spin_default, NULL);
static ssize_t
@@ -237,7 +237,7 @@ timeslice_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->props.timeslice_duration_ms);
}
-static struct kobj_attribute timeslice_duration_attr =
+static const struct kobj_attribute timeslice_duration_attr =
__ATTR(timeslice_duration_ms, 0644, timeslice_show, timeslice_store);
static ssize_t
@@ -248,7 +248,7 @@ timeslice_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->defaults.timeslice_duration_ms);
}
-static struct kobj_attribute timeslice_duration_def =
+static const struct kobj_attribute timeslice_duration_def =
__ATTR(timeslice_duration_ms, 0444, timeslice_default, NULL);
static ssize_t
@@ -288,7 +288,7 @@ stop_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->props.stop_timeout_ms);
}
-static struct kobj_attribute stop_timeout_attr =
+static const struct kobj_attribute stop_timeout_attr =
__ATTR(stop_timeout_ms, 0644, stop_show, stop_store);
static ssize_t
@@ -299,7 +299,7 @@ stop_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->defaults.stop_timeout_ms);
}
-static struct kobj_attribute stop_timeout_def =
+static const struct kobj_attribute stop_timeout_def =
__ATTR(stop_timeout_ms, 0444, stop_default, NULL);
static ssize_t
@@ -344,7 +344,7 @@ preempt_timeout_show(struct kobject *kobj, struct kobj_attribute *attr,
return sysfs_emit(buf, "%lu\n", engine->props.preempt_timeout_ms);
}
-static struct kobj_attribute preempt_timeout_attr =
+static const struct kobj_attribute preempt_timeout_attr =
__ATTR(preempt_timeout_ms, 0644, preempt_timeout_show, preempt_timeout_store);
static ssize_t
@@ -356,7 +356,7 @@ preempt_timeout_default(struct kobject *kobj, struct kobj_attribute *attr,
return sysfs_emit(buf, "%lu\n", engine->defaults.preempt_timeout_ms);
}
-static struct kobj_attribute preempt_timeout_def =
+static const struct kobj_attribute preempt_timeout_def =
__ATTR(preempt_timeout_ms, 0444, preempt_timeout_default, NULL);
static ssize_t
@@ -400,7 +400,7 @@ heartbeat_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->props.heartbeat_interval_ms);
}
-static struct kobj_attribute heartbeat_interval_attr =
+static const struct kobj_attribute heartbeat_interval_attr =
__ATTR(heartbeat_interval_ms, 0644, heartbeat_show, heartbeat_store);
static ssize_t
@@ -411,7 +411,7 @@ heartbeat_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
return sysfs_emit(buf, "%lu\n", engine->defaults.heartbeat_interval_ms);
}
-static struct kobj_attribute heartbeat_interval_def =
+static const struct kobj_attribute heartbeat_interval_def =
__ATTR(heartbeat_interval_ms, 0444, heartbeat_default, NULL);
static void kobj_engine_release(struct kobject *kobj)
@@ -447,7 +447,7 @@ kobj_engine(struct kobject *dir, struct intel_engine_cs *engine)
static void add_defaults(struct kobj_engine *parent)
{
- static const struct attribute *files[] = {
+ static const struct attribute * const files[] = {
&max_spin_def.attr,
&stop_timeout_def.attr,
#if CONFIG_DRM_I915_HEARTBEAT_INTERVAL
@@ -483,7 +483,7 @@ static void add_defaults(struct kobj_engine *parent)
void intel_engines_add_sysfs(struct drm_i915_private *i915)
{
- static const struct attribute *files[] = {
+ static const struct attribute * const files[] = {
&name_attr.attr,
&class_attr.attr,
&inst_attr.attr,
--
2.39.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: make kobj attributes const
2023-03-09 8:16 [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const Jani Nikula
@ 2023-03-09 10:10 ` Patchwork
2023-03-09 10:57 ` [Intel-gfx] [PATCH] " Andrzej Hajda
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-03-09 10:10 UTC (permalink / raw
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5417 bytes --]
== Series Details ==
Series: drm/i915/gt: make kobj attributes const
URL : https://patchwork.freedesktop.org/series/114898/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12829 -> Patchwork_114898v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_114898v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_114898v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/index.html
Participating hosts (36 -> 34)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114898v1:
### IGT changes ###
#### Possible regressions ####
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-hdmi-a-1:
- fi-tgl-1115g4: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/fi-tgl-1115g4/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-hdmi-a-1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/fi-tgl-1115g4/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-hdmi-a-1.html
Known issues
------------
Here are the changes found in Patchwork_114898v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-1: NOTRUN -> [SKIP][7] ([i915#7828])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][8] ([i915#5354]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-1: NOTRUN -> [SKIP][9] ([i915#1845])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: [ABORT][10] ([i915#6687] / [i915#7978]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][12] ([i915#6367]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/bat-rpls-1/igt@i915_selftest@live@slpc.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][14] ([i915#6367] / [i915#7913]) -> [DMESG-FAIL][15] ([i915#6997] / [i915#7913])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/bat-rpls-2/igt@i915_selftest@live@slpc.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
Build changes
-------------
* Linux: CI_DRM_12829 -> Patchwork_114898v1
CI-20190529: 20190529
CI_DRM_12829: d947159409deea43f404f35cc758740c714c8888 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7185: 6707461ddb214bb8a75c5fcf2747941c9d9b11ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114898v1: d947159409deea43f404f35cc758740c714c8888 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
c312ce39b572 drm/i915/gt: make kobj attributes const
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v1/index.html
[-- Attachment #2: Type: text/html, Size: 6442 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const
2023-03-09 8:16 [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const Jani Nikula
2023-03-09 10:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2023-03-09 10:57 ` Andrzej Hajda
2023-03-09 12:47 ` Jani Nikula
2023-03-09 11:08 ` Das, Nirmoy
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Andrzej Hajda @ 2023-03-09 10:57 UTC (permalink / raw
To: Jani Nikula, intel-gfx
On 09.03.2023 09:16, Jani Nikula wrote:
> There's no need for any of these to be mutable, constify:
>
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000020 files.0
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000050 files.1
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 name_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 class_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 inst_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 mmio_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 caps_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 all_caps_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_attr
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
There are more, dunno if all can be const:
$ git grep -c '^static struct kobj_attribute' -- drivers/gpu/drm/i915/
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c:1
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:3
drivers/gpu/drm/i915/gt/sysfs_engines.c:16
For this:
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/gt/sysfs_engines.c | 36 ++++++++++++-------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/sysfs_engines.c b/drivers/gpu/drm/i915/gt/sysfs_engines.c
> index 7eae3265f8cd..021f51d9b456 100644
> --- a/drivers/gpu/drm/i915/gt/sysfs_engines.c
> +++ b/drivers/gpu/drm/i915/gt/sysfs_engines.c
> @@ -27,7 +27,7 @@ name_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%s\n", kobj_to_engine(kobj)->name);
> }
>
> -static struct kobj_attribute name_attr =
> +static const struct kobj_attribute name_attr =
> __ATTR(name, 0444, name_show, NULL);
>
> static ssize_t
> @@ -36,7 +36,7 @@ class_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_class);
> }
>
> -static struct kobj_attribute class_attr =
> +static const struct kobj_attribute class_attr =
> __ATTR(class, 0444, class_show, NULL);
>
> static ssize_t
> @@ -45,7 +45,7 @@ inst_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_instance);
> }
>
> -static struct kobj_attribute inst_attr =
> +static const struct kobj_attribute inst_attr =
> __ATTR(instance, 0444, inst_show, NULL);
>
> static ssize_t
> @@ -54,7 +54,7 @@ mmio_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "0x%x\n", kobj_to_engine(kobj)->mmio_base);
> }
>
> -static struct kobj_attribute mmio_attr =
> +static const struct kobj_attribute mmio_attr =
> __ATTR(mmio_base, 0444, mmio_show, NULL);
>
> static const char * const vcs_caps[] = {
> @@ -125,7 +125,7 @@ caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return __caps_show(engine, engine->uabi_capabilities, buf, true);
> }
>
> -static struct kobj_attribute caps_attr =
> +static const struct kobj_attribute caps_attr =
> __ATTR(capabilities, 0444, caps_show, NULL);
>
> static ssize_t
> @@ -134,7 +134,7 @@ all_caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return __caps_show(kobj_to_engine(kobj), -1, buf, false);
> }
>
> -static struct kobj_attribute all_caps_attr =
> +static const struct kobj_attribute all_caps_attr =
> __ATTR(known_capabilities, 0444, all_caps_show, NULL);
>
> static ssize_t
> @@ -183,7 +183,7 @@ max_spin_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.max_busywait_duration_ns);
> }
>
> -static struct kobj_attribute max_spin_attr =
> +static const struct kobj_attribute max_spin_attr =
> __ATTR(max_busywait_duration_ns, 0644, max_spin_show, max_spin_store);
>
> static ssize_t
> @@ -194,7 +194,7 @@ max_spin_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.max_busywait_duration_ns);
> }
>
> -static struct kobj_attribute max_spin_def =
> +static const struct kobj_attribute max_spin_def =
> __ATTR(max_busywait_duration_ns, 0444, max_spin_default, NULL);
>
> static ssize_t
> @@ -237,7 +237,7 @@ timeslice_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.timeslice_duration_ms);
> }
>
> -static struct kobj_attribute timeslice_duration_attr =
> +static const struct kobj_attribute timeslice_duration_attr =
> __ATTR(timeslice_duration_ms, 0644, timeslice_show, timeslice_store);
>
> static ssize_t
> @@ -248,7 +248,7 @@ timeslice_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.timeslice_duration_ms);
> }
>
> -static struct kobj_attribute timeslice_duration_def =
> +static const struct kobj_attribute timeslice_duration_def =
> __ATTR(timeslice_duration_ms, 0444, timeslice_default, NULL);
>
> static ssize_t
> @@ -288,7 +288,7 @@ stop_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.stop_timeout_ms);
> }
>
> -static struct kobj_attribute stop_timeout_attr =
> +static const struct kobj_attribute stop_timeout_attr =
> __ATTR(stop_timeout_ms, 0644, stop_show, stop_store);
>
> static ssize_t
> @@ -299,7 +299,7 @@ stop_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.stop_timeout_ms);
> }
>
> -static struct kobj_attribute stop_timeout_def =
> +static const struct kobj_attribute stop_timeout_def =
> __ATTR(stop_timeout_ms, 0444, stop_default, NULL);
>
> static ssize_t
> @@ -344,7 +344,7 @@ preempt_timeout_show(struct kobject *kobj, struct kobj_attribute *attr,
> return sysfs_emit(buf, "%lu\n", engine->props.preempt_timeout_ms);
> }
>
> -static struct kobj_attribute preempt_timeout_attr =
> +static const struct kobj_attribute preempt_timeout_attr =
> __ATTR(preempt_timeout_ms, 0644, preempt_timeout_show, preempt_timeout_store);
>
> static ssize_t
> @@ -356,7 +356,7 @@ preempt_timeout_default(struct kobject *kobj, struct kobj_attribute *attr,
> return sysfs_emit(buf, "%lu\n", engine->defaults.preempt_timeout_ms);
> }
>
> -static struct kobj_attribute preempt_timeout_def =
> +static const struct kobj_attribute preempt_timeout_def =
> __ATTR(preempt_timeout_ms, 0444, preempt_timeout_default, NULL);
>
> static ssize_t
> @@ -400,7 +400,7 @@ heartbeat_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.heartbeat_interval_ms);
> }
>
> -static struct kobj_attribute heartbeat_interval_attr =
> +static const struct kobj_attribute heartbeat_interval_attr =
> __ATTR(heartbeat_interval_ms, 0644, heartbeat_show, heartbeat_store);
>
> static ssize_t
> @@ -411,7 +411,7 @@ heartbeat_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.heartbeat_interval_ms);
> }
>
> -static struct kobj_attribute heartbeat_interval_def =
> +static const struct kobj_attribute heartbeat_interval_def =
> __ATTR(heartbeat_interval_ms, 0444, heartbeat_default, NULL);
>
> static void kobj_engine_release(struct kobject *kobj)
> @@ -447,7 +447,7 @@ kobj_engine(struct kobject *dir, struct intel_engine_cs *engine)
>
> static void add_defaults(struct kobj_engine *parent)
> {
> - static const struct attribute *files[] = {
> + static const struct attribute * const files[] = {
> &max_spin_def.attr,
> &stop_timeout_def.attr,
> #if CONFIG_DRM_I915_HEARTBEAT_INTERVAL
> @@ -483,7 +483,7 @@ static void add_defaults(struct kobj_engine *parent)
>
> void intel_engines_add_sysfs(struct drm_i915_private *i915)
> {
> - static const struct attribute *files[] = {
> + static const struct attribute * const files[] = {
> &name_attr.attr,
> &class_attr.attr,
> &inst_attr.attr,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const
2023-03-09 8:16 [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const Jani Nikula
2023-03-09 10:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-03-09 10:57 ` [Intel-gfx] [PATCH] " Andrzej Hajda
@ 2023-03-09 11:08 ` Das, Nirmoy
2023-03-15 10:21 ` Jani Nikula
2023-03-09 11:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: make kobj attributes const (rev2) Patchwork
2023-03-11 1:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 1 reply; 8+ messages in thread
From: Das, Nirmoy @ 2023-03-09 11:08 UTC (permalink / raw
To: Jani Nikula, intel-gfx
On 3/9/2023 9:16 AM, Jani Nikula wrote:
> There's no need for any of these to be mutable, constify:
>
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000020 files.0
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000050 files.1
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_def
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 name_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 class_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 inst_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 mmio_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 caps_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 all_caps_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_attr
> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_attr
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gt/sysfs_engines.c | 36 ++++++++++++-------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/sysfs_engines.c b/drivers/gpu/drm/i915/gt/sysfs_engines.c
> index 7eae3265f8cd..021f51d9b456 100644
> --- a/drivers/gpu/drm/i915/gt/sysfs_engines.c
> +++ b/drivers/gpu/drm/i915/gt/sysfs_engines.c
> @@ -27,7 +27,7 @@ name_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%s\n", kobj_to_engine(kobj)->name);
> }
>
> -static struct kobj_attribute name_attr =
> +static const struct kobj_attribute name_attr =
> __ATTR(name, 0444, name_show, NULL);
>
> static ssize_t
> @@ -36,7 +36,7 @@ class_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_class);
> }
>
> -static struct kobj_attribute class_attr =
> +static const struct kobj_attribute class_attr =
> __ATTR(class, 0444, class_show, NULL);
>
> static ssize_t
> @@ -45,7 +45,7 @@ inst_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_instance);
> }
>
> -static struct kobj_attribute inst_attr =
> +static const struct kobj_attribute inst_attr =
> __ATTR(instance, 0444, inst_show, NULL);
>
> static ssize_t
> @@ -54,7 +54,7 @@ mmio_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "0x%x\n", kobj_to_engine(kobj)->mmio_base);
> }
>
> -static struct kobj_attribute mmio_attr =
> +static const struct kobj_attribute mmio_attr =
> __ATTR(mmio_base, 0444, mmio_show, NULL);
>
> static const char * const vcs_caps[] = {
> @@ -125,7 +125,7 @@ caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return __caps_show(engine, engine->uabi_capabilities, buf, true);
> }
>
> -static struct kobj_attribute caps_attr =
> +static const struct kobj_attribute caps_attr =
> __ATTR(capabilities, 0444, caps_show, NULL);
>
> static ssize_t
> @@ -134,7 +134,7 @@ all_caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return __caps_show(kobj_to_engine(kobj), -1, buf, false);
> }
>
> -static struct kobj_attribute all_caps_attr =
> +static const struct kobj_attribute all_caps_attr =
> __ATTR(known_capabilities, 0444, all_caps_show, NULL);
>
> static ssize_t
> @@ -183,7 +183,7 @@ max_spin_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.max_busywait_duration_ns);
> }
>
> -static struct kobj_attribute max_spin_attr =
> +static const struct kobj_attribute max_spin_attr =
> __ATTR(max_busywait_duration_ns, 0644, max_spin_show, max_spin_store);
>
> static ssize_t
> @@ -194,7 +194,7 @@ max_spin_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.max_busywait_duration_ns);
> }
>
> -static struct kobj_attribute max_spin_def =
> +static const struct kobj_attribute max_spin_def =
> __ATTR(max_busywait_duration_ns, 0444, max_spin_default, NULL);
>
> static ssize_t
> @@ -237,7 +237,7 @@ timeslice_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.timeslice_duration_ms);
> }
>
> -static struct kobj_attribute timeslice_duration_attr =
> +static const struct kobj_attribute timeslice_duration_attr =
> __ATTR(timeslice_duration_ms, 0644, timeslice_show, timeslice_store);
>
> static ssize_t
> @@ -248,7 +248,7 @@ timeslice_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.timeslice_duration_ms);
> }
>
> -static struct kobj_attribute timeslice_duration_def =
> +static const struct kobj_attribute timeslice_duration_def =
> __ATTR(timeslice_duration_ms, 0444, timeslice_default, NULL);
>
> static ssize_t
> @@ -288,7 +288,7 @@ stop_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.stop_timeout_ms);
> }
>
> -static struct kobj_attribute stop_timeout_attr =
> +static const struct kobj_attribute stop_timeout_attr =
> __ATTR(stop_timeout_ms, 0644, stop_show, stop_store);
>
> static ssize_t
> @@ -299,7 +299,7 @@ stop_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.stop_timeout_ms);
> }
>
> -static struct kobj_attribute stop_timeout_def =
> +static const struct kobj_attribute stop_timeout_def =
> __ATTR(stop_timeout_ms, 0444, stop_default, NULL);
>
> static ssize_t
> @@ -344,7 +344,7 @@ preempt_timeout_show(struct kobject *kobj, struct kobj_attribute *attr,
> return sysfs_emit(buf, "%lu\n", engine->props.preempt_timeout_ms);
> }
>
> -static struct kobj_attribute preempt_timeout_attr =
> +static const struct kobj_attribute preempt_timeout_attr =
> __ATTR(preempt_timeout_ms, 0644, preempt_timeout_show, preempt_timeout_store);
>
> static ssize_t
> @@ -356,7 +356,7 @@ preempt_timeout_default(struct kobject *kobj, struct kobj_attribute *attr,
> return sysfs_emit(buf, "%lu\n", engine->defaults.preempt_timeout_ms);
> }
>
> -static struct kobj_attribute preempt_timeout_def =
> +static const struct kobj_attribute preempt_timeout_def =
> __ATTR(preempt_timeout_ms, 0444, preempt_timeout_default, NULL);
>
> static ssize_t
> @@ -400,7 +400,7 @@ heartbeat_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->props.heartbeat_interval_ms);
> }
>
> -static struct kobj_attribute heartbeat_interval_attr =
> +static const struct kobj_attribute heartbeat_interval_attr =
> __ATTR(heartbeat_interval_ms, 0644, heartbeat_show, heartbeat_store);
>
> static ssize_t
> @@ -411,7 +411,7 @@ heartbeat_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
> return sysfs_emit(buf, "%lu\n", engine->defaults.heartbeat_interval_ms);
> }
>
> -static struct kobj_attribute heartbeat_interval_def =
> +static const struct kobj_attribute heartbeat_interval_def =
> __ATTR(heartbeat_interval_ms, 0444, heartbeat_default, NULL);
>
> static void kobj_engine_release(struct kobject *kobj)
> @@ -447,7 +447,7 @@ kobj_engine(struct kobject *dir, struct intel_engine_cs *engine)
>
> static void add_defaults(struct kobj_engine *parent)
> {
> - static const struct attribute *files[] = {
> + static const struct attribute * const files[] = {
> &max_spin_def.attr,
> &stop_timeout_def.attr,
> #if CONFIG_DRM_I915_HEARTBEAT_INTERVAL
> @@ -483,7 +483,7 @@ static void add_defaults(struct kobj_engine *parent)
>
> void intel_engines_add_sysfs(struct drm_i915_private *i915)
> {
> - static const struct attribute *files[] = {
> + static const struct attribute * const files[] = {
> &name_attr.attr,
> &class_attr.attr,
> &inst_attr.attr,
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: make kobj attributes const (rev2)
2023-03-09 8:16 [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const Jani Nikula
` (2 preceding siblings ...)
2023-03-09 11:08 ` Das, Nirmoy
@ 2023-03-09 11:56 ` Patchwork
2023-03-11 1:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-03-09 11:56 UTC (permalink / raw
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5019 bytes --]
== Series Details ==
Series: drm/i915/gt: make kobj attributes const (rev2)
URL : https://patchwork.freedesktop.org/series/114898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12829 -> Patchwork_114898v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/index.html
Participating hosts (36 -> 35)
------------------------------
Additional (1): bat-atsm-1
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_114898v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@eof:
- bat-atsm-1: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-atsm-1/igt@fbdev@eof.html
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][2] ([i915#4083])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-atsm-1/igt@gem_mmap@basic.html
* igt@gem_sync@basic-each:
- bat-atsm-1: NOTRUN -> [FAIL][3] ([i915#8062]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-atsm-1/igt@gem_sync@basic-each.html
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][4] ([i915#4077]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#4079]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-atsm-1/igt@gem_tiled_pread_basic.html
* igt@i915_hangman@error-state-basic:
- bat-atsm-1: NOTRUN -> [ABORT][6] ([i915#8060])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-atsm-1/igt@i915_hangman@error-state-basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][7] -> [ABORT][8] ([i915#7911] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [PASS][9] -> [ABORT][10] ([i915#4983] / [i915#7913])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/bat-rpls-2/igt@i915_selftest@live@reset.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-1: NOTRUN -> [SKIP][11] ([i915#7828])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-1: NOTRUN -> [SKIP][12] ([i915#1845])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-rpls-1: [ABORT][13] ([i915#6687] / [i915#7978]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8060]: https://gitlab.freedesktop.org/drm/intel/issues/8060
[i915#8062]: https://gitlab.freedesktop.org/drm/intel/issues/8062
Build changes
-------------
* Linux: CI_DRM_12829 -> Patchwork_114898v2
CI-20190529: 20190529
CI_DRM_12829: d947159409deea43f404f35cc758740c714c8888 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7185: 6707461ddb214bb8a75c5fcf2747941c9d9b11ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114898v2: d947159409deea43f404f35cc758740c714c8888 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
e81230b57b7f drm/i915/gt: make kobj attributes const
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/index.html
[-- Attachment #2: Type: text/html, Size: 5957 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const
2023-03-09 10:57 ` [Intel-gfx] [PATCH] " Andrzej Hajda
@ 2023-03-09 12:47 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2023-03-09 12:47 UTC (permalink / raw
To: Andrzej Hajda, intel-gfx
On Thu, 09 Mar 2023, Andrzej Hajda <andrzej.hajda@intel.com> wrote:
> On 09.03.2023 09:16, Jani Nikula wrote:
>> There's no need for any of these to be mutable, constify:
>>
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000020 files.0
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000050 files.1
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 name_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 class_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 inst_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 mmio_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 caps_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 all_caps_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_attr
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> There are more, dunno if all can be const:
>
> $ git grep -c '^static struct kobj_attribute' -- drivers/gpu/drm/i915/
> drivers/gpu/drm/i915/gt/intel_gt_sysfs.c:1
> drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:3
> drivers/gpu/drm/i915/gt/sysfs_engines.c:16
Looks like some could, but not all. Anything that ends up in struct
attribute_group won't work because the attrs and bin_attrs members are
non-const pointers.
>
> For this:
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Thanks.
>
> Regards
> Andrzej
>
>
>> ---
>> drivers/gpu/drm/i915/gt/sysfs_engines.c | 36 ++++++++++++-------------
>> 1 file changed, 18 insertions(+), 18 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/sysfs_engines.c b/drivers/gpu/drm/i915/gt/sysfs_engines.c
>> index 7eae3265f8cd..021f51d9b456 100644
>> --- a/drivers/gpu/drm/i915/gt/sysfs_engines.c
>> +++ b/drivers/gpu/drm/i915/gt/sysfs_engines.c
>> @@ -27,7 +27,7 @@ name_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%s\n", kobj_to_engine(kobj)->name);
>> }
>>
>> -static struct kobj_attribute name_attr =
>> +static const struct kobj_attribute name_attr =
>> __ATTR(name, 0444, name_show, NULL);
>>
>> static ssize_t
>> @@ -36,7 +36,7 @@ class_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_class);
>> }
>>
>> -static struct kobj_attribute class_attr =
>> +static const struct kobj_attribute class_attr =
>> __ATTR(class, 0444, class_show, NULL);
>>
>> static ssize_t
>> @@ -45,7 +45,7 @@ inst_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_instance);
>> }
>>
>> -static struct kobj_attribute inst_attr =
>> +static const struct kobj_attribute inst_attr =
>> __ATTR(instance, 0444, inst_show, NULL);
>>
>> static ssize_t
>> @@ -54,7 +54,7 @@ mmio_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "0x%x\n", kobj_to_engine(kobj)->mmio_base);
>> }
>>
>> -static struct kobj_attribute mmio_attr =
>> +static const struct kobj_attribute mmio_attr =
>> __ATTR(mmio_base, 0444, mmio_show, NULL);
>>
>> static const char * const vcs_caps[] = {
>> @@ -125,7 +125,7 @@ caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return __caps_show(engine, engine->uabi_capabilities, buf, true);
>> }
>>
>> -static struct kobj_attribute caps_attr =
>> +static const struct kobj_attribute caps_attr =
>> __ATTR(capabilities, 0444, caps_show, NULL);
>>
>> static ssize_t
>> @@ -134,7 +134,7 @@ all_caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return __caps_show(kobj_to_engine(kobj), -1, buf, false);
>> }
>>
>> -static struct kobj_attribute all_caps_attr =
>> +static const struct kobj_attribute all_caps_attr =
>> __ATTR(known_capabilities, 0444, all_caps_show, NULL);
>>
>> static ssize_t
>> @@ -183,7 +183,7 @@ max_spin_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.max_busywait_duration_ns);
>> }
>>
>> -static struct kobj_attribute max_spin_attr =
>> +static const struct kobj_attribute max_spin_attr =
>> __ATTR(max_busywait_duration_ns, 0644, max_spin_show, max_spin_store);
>>
>> static ssize_t
>> @@ -194,7 +194,7 @@ max_spin_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.max_busywait_duration_ns);
>> }
>>
>> -static struct kobj_attribute max_spin_def =
>> +static const struct kobj_attribute max_spin_def =
>> __ATTR(max_busywait_duration_ns, 0444, max_spin_default, NULL);
>>
>> static ssize_t
>> @@ -237,7 +237,7 @@ timeslice_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.timeslice_duration_ms);
>> }
>>
>> -static struct kobj_attribute timeslice_duration_attr =
>> +static const struct kobj_attribute timeslice_duration_attr =
>> __ATTR(timeslice_duration_ms, 0644, timeslice_show, timeslice_store);
>>
>> static ssize_t
>> @@ -248,7 +248,7 @@ timeslice_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.timeslice_duration_ms);
>> }
>>
>> -static struct kobj_attribute timeslice_duration_def =
>> +static const struct kobj_attribute timeslice_duration_def =
>> __ATTR(timeslice_duration_ms, 0444, timeslice_default, NULL);
>>
>> static ssize_t
>> @@ -288,7 +288,7 @@ stop_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.stop_timeout_ms);
>> }
>>
>> -static struct kobj_attribute stop_timeout_attr =
>> +static const struct kobj_attribute stop_timeout_attr =
>> __ATTR(stop_timeout_ms, 0644, stop_show, stop_store);
>>
>> static ssize_t
>> @@ -299,7 +299,7 @@ stop_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.stop_timeout_ms);
>> }
>>
>> -static struct kobj_attribute stop_timeout_def =
>> +static const struct kobj_attribute stop_timeout_def =
>> __ATTR(stop_timeout_ms, 0444, stop_default, NULL);
>>
>> static ssize_t
>> @@ -344,7 +344,7 @@ preempt_timeout_show(struct kobject *kobj, struct kobj_attribute *attr,
>> return sysfs_emit(buf, "%lu\n", engine->props.preempt_timeout_ms);
>> }
>>
>> -static struct kobj_attribute preempt_timeout_attr =
>> +static const struct kobj_attribute preempt_timeout_attr =
>> __ATTR(preempt_timeout_ms, 0644, preempt_timeout_show, preempt_timeout_store);
>>
>> static ssize_t
>> @@ -356,7 +356,7 @@ preempt_timeout_default(struct kobject *kobj, struct kobj_attribute *attr,
>> return sysfs_emit(buf, "%lu\n", engine->defaults.preempt_timeout_ms);
>> }
>>
>> -static struct kobj_attribute preempt_timeout_def =
>> +static const struct kobj_attribute preempt_timeout_def =
>> __ATTR(preempt_timeout_ms, 0444, preempt_timeout_default, NULL);
>>
>> static ssize_t
>> @@ -400,7 +400,7 @@ heartbeat_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.heartbeat_interval_ms);
>> }
>>
>> -static struct kobj_attribute heartbeat_interval_attr =
>> +static const struct kobj_attribute heartbeat_interval_attr =
>> __ATTR(heartbeat_interval_ms, 0644, heartbeat_show, heartbeat_store);
>>
>> static ssize_t
>> @@ -411,7 +411,7 @@ heartbeat_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.heartbeat_interval_ms);
>> }
>>
>> -static struct kobj_attribute heartbeat_interval_def =
>> +static const struct kobj_attribute heartbeat_interval_def =
>> __ATTR(heartbeat_interval_ms, 0444, heartbeat_default, NULL);
>>
>> static void kobj_engine_release(struct kobject *kobj)
>> @@ -447,7 +447,7 @@ kobj_engine(struct kobject *dir, struct intel_engine_cs *engine)
>>
>> static void add_defaults(struct kobj_engine *parent)
>> {
>> - static const struct attribute *files[] = {
>> + static const struct attribute * const files[] = {
>> &max_spin_def.attr,
>> &stop_timeout_def.attr,
>> #if CONFIG_DRM_I915_HEARTBEAT_INTERVAL
>> @@ -483,7 +483,7 @@ static void add_defaults(struct kobj_engine *parent)
>>
>> void intel_engines_add_sysfs(struct drm_i915_private *i915)
>> {
>> - static const struct attribute *files[] = {
>> + static const struct attribute * const files[] = {
>> &name_attr.attr,
>> &class_attr.attr,
>> &inst_attr.attr,
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: make kobj attributes const (rev2)
2023-03-09 8:16 [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const Jani Nikula
` (3 preceding siblings ...)
2023-03-09 11:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: make kobj attributes const (rev2) Patchwork
@ 2023-03-11 1:26 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-03-11 1:26 UTC (permalink / raw
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 45146 bytes --]
== Series Details ==
Series: drm/i915/gt: make kobj attributes const (rev2)
URL : https://patchwork.freedesktop.org/series/114898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12829_full -> Patchwork_114898v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (8 -> 10)
------------------------------
Additional (2): shard-tglu-9 shard-tglu-10
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114898v2_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_capture@pi@vcs1:
- {shard-tglu}: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-1/igt@gem_exec_capture@pi@vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-2/igt@gem_exec_capture@pi@vcs1.html
* igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-1:
- {shard-tglu}: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-4/igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-3/igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-1.html
Known issues
------------
Here are the changes found in Patchwork_114898v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@crc32:
- shard-tglu-10: NOTRUN -> [SKIP][5] ([i915#6230])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@api_intel_bb@crc32.html
* igt@drm_buddy@all-tests:
- shard-tglu-10: NOTRUN -> [SKIP][6] ([i915#6433])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@drm_buddy@all-tests.html
* igt@fbdev@eof:
- shard-tglu-9: NOTRUN -> [SKIP][7] ([i915#2582])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@fbdev@eof.html
* igt@gem_ccs@block-copy-compressed:
- shard-tglu-10: NOTRUN -> [SKIP][8] ([i915#3555] / [i915#5325])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gem_ccs@block-copy-compressed.html
* igt@gem_close_race@multigpu-basic-threads:
- shard-tglu-9: NOTRUN -> [SKIP][9] ([i915#7697])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_close_race@multigpu-basic-threads.html
* igt@gem_create@create-ext-cpu-access-sanity-check:
- shard-tglu-9: NOTRUN -> [SKIP][10] ([i915#6335])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_create@create-ext-cpu-access-sanity-check.html
* igt@gem_ctx_sseu@engines:
- shard-tglu-10: NOTRUN -> [SKIP][11] ([i915#280])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gem_ctx_sseu@engines.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-glk2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-tglu-9: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_params@secure-non-master:
- shard-tglu-10: NOTRUN -> [SKIP][15] ([fdo#112283])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gem_exec_params@secure-non-master.html
* igt@gem_huc_copy@huc-copy:
- shard-tglu-9: NOTRUN -> [SKIP][16] ([i915#2190])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-random:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl1/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-tglu-9: NOTRUN -> [SKIP][18] ([i915#4613]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random:
- shard-tglu-10: NOTRUN -> [SKIP][19] ([i915#4613]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gem_lmem_swapping@random.html
* igt@gem_media_vme:
- shard-tglu-10: NOTRUN -> [SKIP][20] ([i915#284])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gem_media_vme.html
* igt@gem_pread@exhaustion:
- shard-tglu-9: NOTRUN -> [WARN][21] ([i915#2658])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_pread@exhaustion.html
* igt@gem_pxp@create-regular-buffer:
- shard-tglu-10: NOTRUN -> [SKIP][22] ([i915#4270]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gem_pxp@create-regular-buffer.html
* igt@gem_pxp@create-regular-context-2:
- shard-tglu-9: NOTRUN -> [SKIP][23] ([i915#4270]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_pxp@create-regular-context-2.html
* igt@gem_userptr_blits@create-destroy-unsync:
- shard-tglu-9: NOTRUN -> [SKIP][24] ([i915#3297])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_userptr_blits@create-destroy-unsync.html
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglu-10: NOTRUN -> [SKIP][25] ([i915#3297])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@gem_userptr_blits@vma-merge:
- shard-tglu-9: NOTRUN -> [FAIL][26] ([i915#3318])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gem_userptr_blits@vma-merge.html
* igt@gen3_render_tiledy_blits:
- shard-tglu-9: NOTRUN -> [SKIP][27] ([fdo#109289]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gen3_render_tiledy_blits.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][28] -> [ABORT][29] ([i915#5566])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-glk6/igt@gen9_exec_parse@allowed-single.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-glk6/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglu-9: NOTRUN -> [SKIP][30] ([i915#2527] / [i915#2856]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglu-10: NOTRUN -> [SKIP][31] ([i915#2527] / [i915#2856]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@gen9_exec_parse@cmd-crossing-page.html
* igt@i915_hwmon@hwmon-read:
- shard-tglu-10: NOTRUN -> [SKIP][32] ([i915#7707])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@i915_hwmon@hwmon-read.html
* igt@i915_module_load@resize-bar:
- shard-tglu-9: NOTRUN -> [SKIP][33] ([i915#6412])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@i915_module_load@resize-bar.html
* igt@i915_pm_backlight@basic-brightness:
- shard-tglu-10: NOTRUN -> [SKIP][34] ([i915#7561]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_dc@dc6-dpms:
- shard-tglu-9: NOTRUN -> [FAIL][35] ([i915#3989] / [i915#454])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-tglu-10: NOTRUN -> [FAIL][36] ([i915#3825])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@drm-resources-equal:
- shard-tglu-9: NOTRUN -> [SKIP][37] ([i915#3547])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-tglu-9: NOTRUN -> [SKIP][38] ([i915#1397])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglu-9: NOTRUN -> [SKIP][39] ([fdo#111644] / [i915#1397])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0:
- shard-tglu-10: NOTRUN -> [SKIP][40] ([i915#5286]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-tglu-10: NOTRUN -> [SKIP][41] ([fdo#111614]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglu-10: NOTRUN -> [SKIP][42] ([fdo#111615]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
* igt@kms_big_joiner@invalid-modeset:
- shard-tglu-9: NOTRUN -> [SKIP][43] ([i915#2705]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-a-bad-aux-stride-yf_tiled_ccs:
- shard-tglu-9: NOTRUN -> [SKIP][44] ([fdo#111615] / [i915#1845] / [i915#7651]) +7 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_ccs@pipe-a-bad-aux-stride-yf_tiled_ccs.html
* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271]) +34 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl1/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][46] ([i915#3689] / [i915#6095]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][47] ([fdo#111615] / [i915#3689]) +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][48] ([i915#3689]) +7 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_dg2_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][49] ([i915#6095]) +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_ccs@pipe-c-bad-rotation-90-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][50] ([i915#3689] / [i915#3886]) +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#3886])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium_audio@hdmi-audio-edid:
- shard-tglu-9: NOTRUN -> [SKIP][52] ([i915#7828]) +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_chamelium_audio@hdmi-audio-edid.html
* igt@kms_chamelium_color@ctm-negative:
- shard-tglu-10: NOTRUN -> [SKIP][53] ([fdo#111827]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_chamelium_color@ctm-negative.html
* igt@kms_chamelium_hpd@vga-hpd:
- shard-tglu-10: NOTRUN -> [SKIP][54] ([i915#7828]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_chamelium_hpd@vga-hpd.html
* igt@kms_color@ctm-green-to-red:
- shard-tglu-9: NOTRUN -> [SKIP][55] ([i915#3546])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_color@ctm-green-to-red.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-tglu-10: NOTRUN -> [SKIP][56] ([i915#3116] / [i915#3299])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@lic:
- shard-tglu-10: NOTRUN -> [SKIP][57] ([i915#6944] / [i915#7116] / [i915#7118]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_content_protection@lic.html
* igt@kms_content_protection@uevent@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][58] ([i915#1339])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl1/igt@kms_content_protection@uevent@pipe-a-dp-1.html
* igt@kms_cursor_crc@cursor-offscreen-128x42:
- shard-tglu-9: NOTRUN -> [SKIP][59] ([i915#1845]) +19 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_cursor_crc@cursor-offscreen-128x42.html
* igt@kms_cursor_crc@cursor-random-32x32:
- shard-tglu-10: NOTRUN -> [SKIP][60] ([i915#3555]) +5 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_cursor_crc@cursor-random-32x32.html
* igt@kms_cursor_crc@cursor-rapid-movement-512x170:
- shard-tglu-10: NOTRUN -> [SKIP][61] ([i915#3359])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_cursor_crc@cursor-rapid-movement-512x170.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-tglu-10: NOTRUN -> [SKIP][62] ([fdo#109274]) +4 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_cursor_legacy@cursorb-vs-flipa-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][63] -> [FAIL][64] ([i915#2346])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-tglu-10: NOTRUN -> [SKIP][65] ([i915#3804])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_dsc@dsc-with-formats:
- shard-tglu-9: NOTRUN -> [SKIP][66] ([i915#1845] / [i915#7651]) +77 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_dsc@dsc-with-formats.html
* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-tglu-10: NOTRUN -> [SKIP][67] ([fdo#109274] / [i915#3637]) +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#79])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-tglu-9: NOTRUN -> [SKIP][70] ([fdo#109274] / [i915#3637]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_flip@2x-plain-flip-fb-recreate.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][71] -> [FAIL][72] ([i915#2122])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-glk6/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-glk1/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@b-dp1:
- shard-apl: [PASS][73] -> [FAIL][74] ([i915#79])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-apl1/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl6/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-tglu-9: NOTRUN -> [SKIP][75] ([i915#3637]) +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-tglu-10: NOTRUN -> [SKIP][76] ([i915#2587] / [i915#2672]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-onoff:
- shard-tglu-10: NOTRUN -> [SKIP][77] ([fdo#109280]) +32 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary:
- shard-tglu-9: NOTRUN -> [SKIP][78] ([i915#1849]) +53 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_frontbuffer_tracking@fbcpsr-indfb-scaledprimary.html
* igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c:
- shard-tglu-10: NOTRUN -> [SKIP][79] ([fdo#109289]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_pipe_b_c_ivb@pipe-b-double-modeset-then-modeset-pipe-c.html
* igt@kms_plane@plane-position-hole@pipe-b-planes:
- shard-tglu-9: NOTRUN -> [SKIP][80] ([i915#1849] / [i915#3558]) +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_plane@plane-position-hole@pipe-b-planes.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-a-hdmi-a-1:
- shard-tglu-10: NOTRUN -> [SKIP][81] ([i915#5176]) +7 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25:
- shard-tglu-9: NOTRUN -> [SKIP][82] ([i915#6953] / [i915#8152])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_plane_scaling@planes-downscale-factor-0-25.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-1:
- shard-tglu-10: NOTRUN -> [SKIP][83] ([i915#5235]) +3 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-1.html
* igt@kms_prime@basic-modeset-hybrid:
- shard-tglu-9: NOTRUN -> [SKIP][84] ([i915#6524])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_prime@basic-modeset-hybrid.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-tglu-10: NOTRUN -> [SKIP][85] ([i915#658]) +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-tglu-9: NOTRUN -> [SKIP][86] ([i915#658]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr@basic:
- shard-tglu-9: NOTRUN -> [SKIP][87] ([fdo#110189]) +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_psr@basic.html
* igt@kms_psr@psr2_sprite_blt:
- shard-tglu-10: NOTRUN -> [SKIP][88] ([fdo#110189]) +17 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglu-9: NOTRUN -> [SKIP][89] ([i915#5461])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-tglu-9: NOTRUN -> [SKIP][90] ([fdo#111615] / [i915#1845])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html
* igt@kms_setmode@basic:
- shard-tglu-9: NOTRUN -> [SKIP][91] ([i915#3555]) +8 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_setmode@basic.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a:
- shard-tglu-9: NOTRUN -> [SKIP][92] ([fdo#109274]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#533])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-tglu-10: NOTRUN -> [SKIP][94] ([i915#2437])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@polling-small-buf:
- shard-tglu-9: NOTRUN -> [FAIL][95] ([i915#1722])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@perf@polling-small-buf.html
* igt@prime_vgem@basic-userptr:
- shard-tglu-9: NOTRUN -> [SKIP][96] ([fdo#109295] / [i915#3301])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@coherency-gtt:
- shard-tglu-10: NOTRUN -> [SKIP][97] ([fdo#109295] / [fdo#111656])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@prime_vgem@coherency-gtt.html
* igt@v3d/v3d_perfmon@get-values-invalid-perfmon:
- shard-tglu-9: NOTRUN -> [SKIP][98] ([fdo#109315] / [i915#2575]) +3 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@v3d/v3d_perfmon@get-values-invalid-perfmon.html
* igt@v3d/v3d_perfmon@get-values-invalid-pointer:
- shard-tglu-10: NOTRUN -> [SKIP][99] ([fdo#109315] / [i915#2575])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@v3d/v3d_perfmon@get-values-invalid-pointer.html
* igt@vc4/vc4_label_bo@set-bad-name:
- shard-tglu-9: NOTRUN -> [SKIP][100] ([i915#2575]) +5 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-9/igt@vc4/vc4_label_bo@set-bad-name.html
* igt@vc4/vc4_perfmon@get-values-invalid-pointer:
- shard-tglu-10: NOTRUN -> [SKIP][101] ([i915#2575]) +4 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-10/igt@vc4/vc4_perfmon@get-values-invalid-pointer.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][102] ([i915#7742]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@drm_fdinfo@virtual-idle.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][104] ([i915#6268]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-6/igt@gem_ctx_exec@basic-nohangcheck.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_balancer@fairslice:
- {shard-rkl}: [SKIP][106] ([i915#6259]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-5/igt@gem_exec_balancer@fairslice.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-2/igt@gem_exec_balancer@fairslice.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][108] ([i915#2842]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][110] ([i915#2842]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][112] ([i915#2842]) -> [PASS][113] +6 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-4/igt@gem_exec_fair@basic-pace@rcs0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-gtt-wc-noreloc:
- {shard-rkl}: [SKIP][114] ([i915#3281]) -> [PASS][115] +10 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-4/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
* igt@gem_exec_schedule@semaphore-power:
- {shard-rkl}: [SKIP][116] ([i915#7276]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-3/igt@gem_exec_schedule@semaphore-power.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@gem_exec_schedule@semaphore-power.html
* igt@gem_partial_pwrite_pread@write-uncached:
- {shard-rkl}: [SKIP][118] ([i915#3282]) -> [PASS][119] +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-4/igt@gem_partial_pwrite_pread@write-uncached.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@gem_partial_pwrite_pread@write-uncached.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][120] ([i915#5566]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-apl2/igt@gen9_exec_parse@allowed-single.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl1/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-start-out:
- {shard-rkl}: [SKIP][122] ([i915#2527]) -> [PASS][123] +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-1/igt@gen9_exec_parse@bb-start-out.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@gen9_exec_parse@bb-start-out.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-rkl}: [SKIP][124] ([i915#3361]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-5/igt@i915_pm_dc@dc6-dpms.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-3/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@cursor:
- {shard-tglu}: [SKIP][126] ([i915#1849]) -> [PASS][127] +11 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-6/igt@i915_pm_rpm@cursor.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-3/igt@i915_pm_rpm@cursor.html
* igt@i915_suspend@forcewake:
- shard-apl: [ABORT][128] ([i915#180]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-apl4/igt@i915_suspend@forcewake.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-apl1/igt@i915_suspend@forcewake.html
* igt@kms_atomic@plane-overlay-legacy:
- {shard-rkl}: [SKIP][130] ([i915#1845] / [i915#4098]) -> [PASS][131] +18 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-1/igt@kms_atomic@plane-overlay-legacy.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-6/igt@kms_atomic@plane-overlay-legacy.html
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- {shard-tglu}: [SKIP][132] ([i915#1845]) -> [PASS][133] +3 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-6/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-7/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- {shard-rkl}: [SKIP][134] ([i915#1849] / [i915#4098]) -> [PASS][135] +12 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-tglu}: [SKIP][136] ([i915#1849] / [i915#3558]) -> [PASS][137] +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-7/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- {shard-rkl}: [SKIP][138] ([i915#1849]) -> [PASS][139] +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_psr@cursor_mmap_cpu:
- {shard-rkl}: [SKIP][140] ([i915#1072]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-1/igt@kms_psr@cursor_mmap_cpu.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-6/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_universal_plane@cursor-fb-leak-pipe-d:
- {shard-tglu}: [SKIP][142] ([fdo#109274]) -> [PASS][143] +2 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-6/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-3/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html
* igt@kms_vblank@pipe-d-wait-forked-busy:
- {shard-tglu}: [SKIP][144] ([i915#1845] / [i915#7651]) -> [PASS][145] +24 similar issues
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-tglu-6/igt@kms_vblank@pipe-d-wait-forked-busy.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-tglu-3/igt@kms_vblank@pipe-d-wait-forked-busy.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][146] ([i915#4349]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-4/igt@perf_pmu@idle@rcs0.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@perf_pmu@idle@rcs0.html
* igt@prime_vgem@basic-fence-read:
- {shard-rkl}: [SKIP][148] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][149] +1 similar issue
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12829/shard-rkl-4/igt@prime_vgem@basic-fence-read.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/shard-rkl-5/igt@prime_vgem@basic-fence-read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8273]: https://gitlab.freedesktop.org/drm/intel/issues/8273
[i915#8275]: https://gitlab.freedesktop.org/drm/intel/issues/8275
Build changes
-------------
* Linux: CI_DRM_12829 -> Patchwork_114898v2
CI-20190529: 20190529
CI_DRM_12829: d947159409deea43f404f35cc758740c714c8888 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7185: 6707461ddb214bb8a75c5fcf2747941c9d9b11ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114898v2: d947159409deea43f404f35cc758740c714c8888 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114898v2/index.html
[-- Attachment #2: Type: text/html, Size: 48549 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const
2023-03-09 11:08 ` Das, Nirmoy
@ 2023-03-15 10:21 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2023-03-15 10:21 UTC (permalink / raw
To: Das, Nirmoy, intel-gfx; +Cc: Andrzej Hajda
On Thu, 09 Mar 2023, "Das, Nirmoy" <nirmoy.das@linux.intel.com> wrote:
> On 3/9/2023 9:16 AM, Jani Nikula wrote:
>> There's no need for any of these to be mutable, constify:
>>
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000020 files.0
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000050 files.1
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 timeslice_duration_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 preempt_timeout_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_def
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 name_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 class_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 inst_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 mmio_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 caps_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 all_caps_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 max_spin_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 stop_timeout_attr
>> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0000000000000038 heartbeat_interval_attr
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
>
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Thanks for the reviews, pushed to drm-intel-gt-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/gt/sysfs_engines.c | 36 ++++++++++++-------------
>> 1 file changed, 18 insertions(+), 18 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/sysfs_engines.c b/drivers/gpu/drm/i915/gt/sysfs_engines.c
>> index 7eae3265f8cd..021f51d9b456 100644
>> --- a/drivers/gpu/drm/i915/gt/sysfs_engines.c
>> +++ b/drivers/gpu/drm/i915/gt/sysfs_engines.c
>> @@ -27,7 +27,7 @@ name_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%s\n", kobj_to_engine(kobj)->name);
>> }
>>
>> -static struct kobj_attribute name_attr =
>> +static const struct kobj_attribute name_attr =
>> __ATTR(name, 0444, name_show, NULL);
>>
>> static ssize_t
>> @@ -36,7 +36,7 @@ class_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_class);
>> }
>>
>> -static struct kobj_attribute class_attr =
>> +static const struct kobj_attribute class_attr =
>> __ATTR(class, 0444, class_show, NULL);
>>
>> static ssize_t
>> @@ -45,7 +45,7 @@ inst_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%d\n", kobj_to_engine(kobj)->uabi_instance);
>> }
>>
>> -static struct kobj_attribute inst_attr =
>> +static const struct kobj_attribute inst_attr =
>> __ATTR(instance, 0444, inst_show, NULL);
>>
>> static ssize_t
>> @@ -54,7 +54,7 @@ mmio_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "0x%x\n", kobj_to_engine(kobj)->mmio_base);
>> }
>>
>> -static struct kobj_attribute mmio_attr =
>> +static const struct kobj_attribute mmio_attr =
>> __ATTR(mmio_base, 0444, mmio_show, NULL);
>>
>> static const char * const vcs_caps[] = {
>> @@ -125,7 +125,7 @@ caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return __caps_show(engine, engine->uabi_capabilities, buf, true);
>> }
>>
>> -static struct kobj_attribute caps_attr =
>> +static const struct kobj_attribute caps_attr =
>> __ATTR(capabilities, 0444, caps_show, NULL);
>>
>> static ssize_t
>> @@ -134,7 +134,7 @@ all_caps_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return __caps_show(kobj_to_engine(kobj), -1, buf, false);
>> }
>>
>> -static struct kobj_attribute all_caps_attr =
>> +static const struct kobj_attribute all_caps_attr =
>> __ATTR(known_capabilities, 0444, all_caps_show, NULL);
>>
>> static ssize_t
>> @@ -183,7 +183,7 @@ max_spin_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.max_busywait_duration_ns);
>> }
>>
>> -static struct kobj_attribute max_spin_attr =
>> +static const struct kobj_attribute max_spin_attr =
>> __ATTR(max_busywait_duration_ns, 0644, max_spin_show, max_spin_store);
>>
>> static ssize_t
>> @@ -194,7 +194,7 @@ max_spin_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.max_busywait_duration_ns);
>> }
>>
>> -static struct kobj_attribute max_spin_def =
>> +static const struct kobj_attribute max_spin_def =
>> __ATTR(max_busywait_duration_ns, 0444, max_spin_default, NULL);
>>
>> static ssize_t
>> @@ -237,7 +237,7 @@ timeslice_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.timeslice_duration_ms);
>> }
>>
>> -static struct kobj_attribute timeslice_duration_attr =
>> +static const struct kobj_attribute timeslice_duration_attr =
>> __ATTR(timeslice_duration_ms, 0644, timeslice_show, timeslice_store);
>>
>> static ssize_t
>> @@ -248,7 +248,7 @@ timeslice_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.timeslice_duration_ms);
>> }
>>
>> -static struct kobj_attribute timeslice_duration_def =
>> +static const struct kobj_attribute timeslice_duration_def =
>> __ATTR(timeslice_duration_ms, 0444, timeslice_default, NULL);
>>
>> static ssize_t
>> @@ -288,7 +288,7 @@ stop_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.stop_timeout_ms);
>> }
>>
>> -static struct kobj_attribute stop_timeout_attr =
>> +static const struct kobj_attribute stop_timeout_attr =
>> __ATTR(stop_timeout_ms, 0644, stop_show, stop_store);
>>
>> static ssize_t
>> @@ -299,7 +299,7 @@ stop_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.stop_timeout_ms);
>> }
>>
>> -static struct kobj_attribute stop_timeout_def =
>> +static const struct kobj_attribute stop_timeout_def =
>> __ATTR(stop_timeout_ms, 0444, stop_default, NULL);
>>
>> static ssize_t
>> @@ -344,7 +344,7 @@ preempt_timeout_show(struct kobject *kobj, struct kobj_attribute *attr,
>> return sysfs_emit(buf, "%lu\n", engine->props.preempt_timeout_ms);
>> }
>>
>> -static struct kobj_attribute preempt_timeout_attr =
>> +static const struct kobj_attribute preempt_timeout_attr =
>> __ATTR(preempt_timeout_ms, 0644, preempt_timeout_show, preempt_timeout_store);
>>
>> static ssize_t
>> @@ -356,7 +356,7 @@ preempt_timeout_default(struct kobject *kobj, struct kobj_attribute *attr,
>> return sysfs_emit(buf, "%lu\n", engine->defaults.preempt_timeout_ms);
>> }
>>
>> -static struct kobj_attribute preempt_timeout_def =
>> +static const struct kobj_attribute preempt_timeout_def =
>> __ATTR(preempt_timeout_ms, 0444, preempt_timeout_default, NULL);
>>
>> static ssize_t
>> @@ -400,7 +400,7 @@ heartbeat_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->props.heartbeat_interval_ms);
>> }
>>
>> -static struct kobj_attribute heartbeat_interval_attr =
>> +static const struct kobj_attribute heartbeat_interval_attr =
>> __ATTR(heartbeat_interval_ms, 0644, heartbeat_show, heartbeat_store);
>>
>> static ssize_t
>> @@ -411,7 +411,7 @@ heartbeat_default(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
>> return sysfs_emit(buf, "%lu\n", engine->defaults.heartbeat_interval_ms);
>> }
>>
>> -static struct kobj_attribute heartbeat_interval_def =
>> +static const struct kobj_attribute heartbeat_interval_def =
>> __ATTR(heartbeat_interval_ms, 0444, heartbeat_default, NULL);
>>
>> static void kobj_engine_release(struct kobject *kobj)
>> @@ -447,7 +447,7 @@ kobj_engine(struct kobject *dir, struct intel_engine_cs *engine)
>>
>> static void add_defaults(struct kobj_engine *parent)
>> {
>> - static const struct attribute *files[] = {
>> + static const struct attribute * const files[] = {
>> &max_spin_def.attr,
>> &stop_timeout_def.attr,
>> #if CONFIG_DRM_I915_HEARTBEAT_INTERVAL
>> @@ -483,7 +483,7 @@ static void add_defaults(struct kobj_engine *parent)
>>
>> void intel_engines_add_sysfs(struct drm_i915_private *i915)
>> {
>> - static const struct attribute *files[] = {
>> + static const struct attribute * const files[] = {
>> &name_attr.attr,
>> &class_attr.attr,
>> &inst_attr.attr,
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-03-15 10:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-09 8:16 [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const Jani Nikula
2023-03-09 10:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-03-09 10:57 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2023-03-09 12:47 ` Jani Nikula
2023-03-09 11:08 ` Das, Nirmoy
2023-03-15 10:21 ` Jani Nikula
2023-03-09 11:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: make kobj attributes const (rev2) Patchwork
2023-03-11 1:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.