* [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address
@ 2022-12-10 11:33 Krzysztof Kozlowski
2022-12-10 12:26 ` Konrad Dybcio
2022-12-28 4:36 ` Bjorn Andersson
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-10 11:33 UTC (permalink / raw
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
By coding style, unit address should not start with 0x.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 1a257f672887..a63dbd12230f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -1636,7 +1636,7 @@ uart7: serial@89c000 {
};
};
- gpi_dma1: dma-controller@0xa00000 {
+ gpi_dma1: dma-controller@a00000 {
#dma-cells = <3>;
compatible = "qcom,sdm845-gpi-dma";
reg = <0 0x00a00000 0 0x60000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address
2022-12-10 11:33 [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address Krzysztof Kozlowski
@ 2022-12-10 12:26 ` Konrad Dybcio
2022-12-11 20:15 ` Krzysztof Kozlowski
2022-12-28 4:36 ` Bjorn Andersson
1 sibling, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2022-12-10 12:26 UTC (permalink / raw
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 10.12.2022 12:33, Krzysztof Kozlowski wrote:
> By coding style, unit address should not start with 0x.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
We somehow keep running into solving the same style issues :P
https://lore.kernel.org/lkml/20220930191049.123256-8-konrad.dybcio@somainline.org/
Konrad
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 1a257f672887..a63dbd12230f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1636,7 +1636,7 @@ uart7: serial@89c000 {
> };
> };
>
> - gpi_dma1: dma-controller@0xa00000 {
> + gpi_dma1: dma-controller@a00000 {
> #dma-cells = <3>;
> compatible = "qcom,sdm845-gpi-dma";
> reg = <0 0x00a00000 0 0x60000>;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address
2022-12-10 12:26 ` Konrad Dybcio
@ 2022-12-11 20:15 ` Krzysztof Kozlowski
2022-12-28 4:03 ` Bjorn Andersson
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-11 20:15 UTC (permalink / raw
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 10/12/2022 13:26, Konrad Dybcio wrote:
>
>
> On 10.12.2022 12:33, Krzysztof Kozlowski wrote:
>> By coding style, unit address should not start with 0x.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> We somehow keep running into solving the same style issues :P
>
> https://lore.kernel.org/lkml/20220930191049.123256-8-konrad.dybcio@somainline.org/
>
Eh, this should have been just applied long time ago...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address
2022-12-11 20:15 ` Krzysztof Kozlowski
@ 2022-12-28 4:03 ` Bjorn Andersson
0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2022-12-28 4:03 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Konrad Dybcio, Andy Gross, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel
On Sun, Dec 11, 2022 at 09:15:36PM +0100, Krzysztof Kozlowski wrote:
> On 10/12/2022 13:26, Konrad Dybcio wrote:
> >
> >
> > On 10.12.2022 12:33, Krzysztof Kozlowski wrote:
> >> By coding style, unit address should not start with 0x.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> > We somehow keep running into solving the same style issues :P
> >
> > https://lore.kernel.org/lkml/20220930191049.123256-8-konrad.dybcio@somainline.org/
> >
>
> Eh, this should have been just applied long time ago...
>
That's patch 7 in a series, which I would be expecting to see respun
per your request for changes.
@Konrad, please put fixes like that first in your series - or just send
them separate from the series.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address
2022-12-10 11:33 [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address Krzysztof Kozlowski
2022-12-10 12:26 ` Konrad Dybcio
@ 2022-12-28 4:36 ` Bjorn Andersson
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2022-12-28 4:36 UTC (permalink / raw
To: krzysztof.kozlowski+dt, krzysztof.kozlowski, konrad.dybcio,
linux-kernel, robh+dt, devicetree, agross, linux-arm-msm
On Sat, 10 Dec 2022 12:33:40 +0100, Krzysztof Kozlowski wrote:
> By coding style, unit address should not start with 0x.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sdm845: drop 0x from unit address
commit: 1629063ec9d8a32111a63ce7250a7781376c492a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-28 4:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-10 11:33 [PATCH] arm64: dts: qcom: sdm845: drop 0x from unit address Krzysztof Kozlowski
2022-12-10 12:26 ` Konrad Dybcio
2022-12-11 20:15 ` Krzysztof Kozlowski
2022-12-28 4:03 ` Bjorn Andersson
2022-12-28 4:36 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.