* [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Add pmk8350 PMIC
@ 2022-12-07 8:40 Luca Weiss
2022-12-07 8:51 ` Konrad Dybcio
2022-12-28 4:36 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Luca Weiss @ 2022-12-07 8:40 UTC (permalink / raw
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
The PMK8350 (which is actually a PMK8003) is used for the RTC and has
ADC for thermals.
Since the adc_tm compatible used in PMK8350 is not yet supported, skip
configuring that and the associated thermal zone for now.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
.../boot/dts/qcom/sm7225-fairphone-fp4.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
index c456e9594ea5..df05e5dc8696 100644
--- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
+++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
@@ -5,7 +5,11 @@
/dts-v1/;
+/* PMK8350 (in reality a PMK8003) is configured to use SID6 instead of 0 */
+#define PMK8350_SID 6
+
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -13,6 +17,7 @@
#include "pm6150l.dtsi"
#include "pm6350.dtsi"
#include "pm7250b.dtsi"
+#include "pmk8350.dtsi"
/ {
model = "Fairphone 4";
@@ -426,6 +431,20 @@ conn-therm@1 {
};
};
+&pmk8350_rtc {
+ status = "okay";
+};
+
+&pmk8350_vadc {
+ adc-chan@644 {
+ reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "xo_therm";
+ };
+};
+
&qupv3_id_1 {
status = "okay";
};
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Add pmk8350 PMIC
2022-12-07 8:40 [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Add pmk8350 PMIC Luca Weiss
@ 2022-12-07 8:51 ` Konrad Dybcio
2022-12-28 4:36 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2022-12-07 8:51 UTC (permalink / raw
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 07/12/2022 09:40, Luca Weiss wrote:
> The PMK8350 (which is actually a PMK8003) is used for the RTC and has
> ADC for thermals.
>
> Since the adc_tm compatible used in PMK8350 is not yet supported, skip
> configuring that and the associated thermal zone for now.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> .../boot/dts/qcom/sm7225-fairphone-fp4.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index c456e9594ea5..df05e5dc8696 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -5,7 +5,11 @@
>
> /dts-v1/;
>
> +/* PMK8350 (in reality a PMK8003) is configured to use SID6 instead of 0 */
> +#define PMK8350_SID 6
> +
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> @@ -13,6 +17,7 @@
> #include "pm6150l.dtsi"
> #include "pm6350.dtsi"
> #include "pm7250b.dtsi"
> +#include "pmk8350.dtsi"
>
> / {
> model = "Fairphone 4";
> @@ -426,6 +431,20 @@ conn-therm@1 {
> };
> };
>
> +&pmk8350_rtc {
> + status = "okay";
> +};
> +
> +&pmk8350_vadc {
> + adc-chan@644 {
> + reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + qcom,pre-scaling = <1 1>;
> + label = "xo_therm";
> + };
> +};
> +
> &qupv3_id_1 {
> status = "okay";
> };
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Add pmk8350 PMIC
2022-12-07 8:40 [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Add pmk8350 PMIC Luca Weiss
2022-12-07 8:51 ` Konrad Dybcio
@ 2022-12-28 4:36 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-12-28 4:36 UTC (permalink / raw
To: luca.weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, krzysztof.kozlowski+dt, konrad.dybcio,
linux-kernel, agross, devicetree, robh+dt, phone-devel
On Wed, 7 Dec 2022 09:40:45 +0100, Luca Weiss wrote:
> The PMK8350 (which is actually a PMK8003) is used for the RTC and has
> ADC for thermals.
>
> Since the adc_tm compatible used in PMK8350 is not yet supported, skip
> configuring that and the associated thermal zone for now.
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sm7225-fairphone-fp4: Add pmk8350 PMIC
commit: 582e7c1026fa848a918a1db159bcae7c5fa7f0ce
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-28 4:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 8:40 [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Add pmk8350 PMIC Luca Weiss
2022-12-07 8:51 ` Konrad Dybcio
2022-12-28 4:36 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.