* [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible
@ 2022-12-06 23:17 Richard Acayan
2022-12-06 23:17 ` [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node Richard Acayan
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Richard Acayan @ 2022-12-06 23:17 UTC (permalink / raw
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree
Cc: Richard Acayan
There is some configuration in SDM670's QFPROM. Add the compatible for
it.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
- add ack tag
Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
index 2eab2f46cb65..01ec2143a3b5 100644
--- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
+++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
@@ -27,6 +27,7 @@ properties:
- qcom,sc7180-qfprom
- qcom,sc7280-qfprom
- qcom,sdm630-qfprom
+ - qcom,sdm670-qfprom
- qcom,sdm845-qfprom
- qcom,sm6115-qfprom
- const: qcom,qfprom
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node
2022-12-06 23:17 [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible Richard Acayan
@ 2022-12-06 23:17 ` Richard Acayan
2022-12-07 10:17 ` Konrad Dybcio
2022-12-07 16:59 ` Bjorn Andersson
2022-12-06 23:17 ` [PATCH 3/3] arm64: dts: qcom: sdm670: add missing usb hstx nvmem cell Richard Acayan
2022-12-28 4:36 ` (subset) [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible Bjorn Andersson
2 siblings, 2 replies; 7+ messages in thread
From: Richard Acayan @ 2022-12-06 23:17 UTC (permalink / raw
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree
Cc: Richard Acayan
Some hardware quirks and capabilities can be determined by reading the
fuse-programmable read-only memory. Add the QFPROM node so consumers
know if they need to do anything extra to support the hardware.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
Changes since v1:
- offset address by 0x4000 and zero-pad regs
arch/arm64/boot/dts/qcom/sdm670.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
index f93705bc549f..c78156e03d93 100644
--- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
@@ -731,6 +731,13 @@ gcc: clock-controller@100000 {
#power-domain-cells = <1>;
};
+ qfprom: qfprom@784000 {
+ compatible = "qcom,sdm670-qfprom", "qcom,qfprom";
+ reg = <0 0x00784000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
sdhc_1: mmc@7c4000 {
compatible = "qcom,sdm670-sdhci", "qcom,sdhci-msm-v5";
reg = <0 0x007c4000 0 0x1000>,
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sdm670: add missing usb hstx nvmem cell
2022-12-06 23:17 [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible Richard Acayan
2022-12-06 23:17 ` [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node Richard Acayan
@ 2022-12-06 23:17 ` Richard Acayan
2022-12-07 10:18 ` Konrad Dybcio
2022-12-28 4:36 ` (subset) [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible Bjorn Andersson
2 siblings, 1 reply; 7+ messages in thread
From: Richard Acayan @ 2022-12-06 23:17 UTC (permalink / raw
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree
Cc: Richard Acayan
This nvmem cell is present on SDM670 as well as SDM845. Add it in SDM670
so there is proper tuning.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
Changes since v1:
- remove "primary" indicator (SDM670 only has one USB controller)
arch/arm64/boot/dts/qcom/sdm670.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
index c78156e03d93..fcea26ba7fe9 100644
--- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
@@ -736,6 +736,11 @@ qfprom: qfprom@784000 {
reg = <0 0x00784000 0 0x1000>;
#address-cells = <1>;
#size-cells = <1>;
+
+ qusb2_hstx_trim: hstx-trim@1eb {
+ reg = <0x1eb 0x1>;
+ bits = <1 4>;
+ };
};
sdhc_1: mmc@7c4000 {
@@ -1418,6 +1423,8 @@ usb_1_hsphy: phy@88e2000 {
resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
+ nvmem-cells = <&qusb2_hstx_trim>;
+
status = "disabled";
};
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node
2022-12-06 23:17 ` [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node Richard Acayan
@ 2022-12-07 10:17 ` Konrad Dybcio
2022-12-07 16:59 ` Bjorn Andersson
1 sibling, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2022-12-07 10:17 UTC (permalink / raw
To: Richard Acayan, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree
On 07/12/2022 00:17, Richard Acayan wrote:
> Some hardware quirks and capabilities can be determined by reading the
> fuse-programmable read-only memory. Add the QFPROM node so consumers
> know if they need to do anything extra to support the hardware.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Changes since v1:
> - offset address by 0x4000 and zero-pad regs
>
> arch/arm64/boot/dts/qcom/sdm670.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> index f93705bc549f..c78156e03d93 100644
> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> @@ -731,6 +731,13 @@ gcc: clock-controller@100000 {
> #power-domain-cells = <1>;
> };
>
> + qfprom: qfprom@784000 {
> + compatible = "qcom,sdm670-qfprom", "qcom,qfprom";
> + reg = <0 0x00784000 0 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> sdhc_1: mmc@7c4000 {
> compatible = "qcom,sdm670-sdhci", "qcom,sdhci-msm-v5";
> reg = <0 0x007c4000 0 0x1000>,
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sdm670: add missing usb hstx nvmem cell
2022-12-06 23:17 ` [PATCH 3/3] arm64: dts: qcom: sdm670: add missing usb hstx nvmem cell Richard Acayan
@ 2022-12-07 10:18 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2022-12-07 10:18 UTC (permalink / raw
To: Richard Acayan, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree
On 07/12/2022 00:17, Richard Acayan wrote:
> This nvmem cell is present on SDM670 as well as SDM845. Add it in SDM670
> so there is proper tuning.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Changes since v1:
> - remove "primary" indicator (SDM670 only has one USB controller)
>
> arch/arm64/boot/dts/qcom/sdm670.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> index c78156e03d93..fcea26ba7fe9 100644
> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> @@ -736,6 +736,11 @@ qfprom: qfprom@784000 {
> reg = <0 0x00784000 0 0x1000>;
> #address-cells = <1>;
> #size-cells = <1>;
> +
> + qusb2_hstx_trim: hstx-trim@1eb {
> + reg = <0x1eb 0x1>;
> + bits = <1 4>;
> + };
> };
>
> sdhc_1: mmc@7c4000 {
> @@ -1418,6 +1423,8 @@ usb_1_hsphy: phy@88e2000 {
>
> resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
>
> + nvmem-cells = <&qusb2_hstx_trim>;
> +
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node
2022-12-06 23:17 ` [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node Richard Acayan
2022-12-07 10:17 ` Konrad Dybcio
@ 2022-12-07 16:59 ` Bjorn Andersson
1 sibling, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-12-07 16:59 UTC (permalink / raw
To: Richard Acayan
Cc: Andy Gross, Konrad Dybcio, Srinivas Kandagatla, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree
On Tue, Dec 06, 2022 at 06:17:30PM -0500, Richard Acayan wrote:
> Some hardware quirks and capabilities can be determined by reading the
> fuse-programmable read-only memory. Add the QFPROM node so consumers
> know if they need to do anything extra to support the hardware.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
PS. Please include a "vN" in the []-part of subject when resubmitting
patches. In this case passing -v 2 to git format-patch would do the
trick for you.
I will pick this up after the upcoming merge window.
Thanks,
Bjorn
> ---
> Changes since v1:
> - offset address by 0x4000 and zero-pad regs
>
> arch/arm64/boot/dts/qcom/sdm670.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> index f93705bc549f..c78156e03d93 100644
> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> @@ -731,6 +731,13 @@ gcc: clock-controller@100000 {
> #power-domain-cells = <1>;
> };
>
> + qfprom: qfprom@784000 {
> + compatible = "qcom,sdm670-qfprom", "qcom,qfprom";
> + reg = <0 0x00784000 0 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> sdhc_1: mmc@7c4000 {
> compatible = "qcom,sdm670-sdhci", "qcom,sdhci-msm-v5";
> reg = <0 0x007c4000 0 0x1000>,
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible
2022-12-06 23:17 [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible Richard Acayan
2022-12-06 23:17 ` [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node Richard Acayan
2022-12-06 23:17 ` [PATCH 3/3] arm64: dts: qcom: sdm670: add missing usb hstx nvmem cell Richard Acayan
@ 2022-12-28 4:36 ` Bjorn Andersson
2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-12-28 4:36 UTC (permalink / raw
To: srinivas.kandagatla, mailingradian, krzysztof.kozlowski+dt,
konrad.dybcio, robh+dt, devicetree, agross, linux-arm-msm
On Tue, 6 Dec 2022 18:17:28 -0500, Richard Acayan wrote:
> There is some configuration in SDM670's QFPROM. Add the compatible for
> it.
>
>
Applied, thanks!
[2/3] arm64: dts: qcom: sdm670: add qfprom node
commit: 7bff6f4351bf82c0b9279fc711b730d2d28b8b8c
[3/3] arm64: dts: qcom: sdm670: add missing usb hstx nvmem cell
commit: cb98187a6883c498b0702cedc1f59247e7857bea
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-28 4:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-06 23:17 [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible Richard Acayan
2022-12-06 23:17 ` [PATCH 2/3] arm64: dts: qcom: sdm670: add qfprom node Richard Acayan
2022-12-07 10:17 ` Konrad Dybcio
2022-12-07 16:59 ` Bjorn Andersson
2022-12-06 23:17 ` [PATCH 3/3] arm64: dts: qcom: sdm670: add missing usb hstx nvmem cell Richard Acayan
2022-12-07 10:18 ` Konrad Dybcio
2022-12-28 4:36 ` (subset) [PATCH 1/3] dt-bindings: nvmem: qfprom: add sdm670 compatible Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.