* [PATCH] utime.2, utimensat.2: explicitly mention ctime changing.
@ 2022-08-24 1:21 NeilBrown
2022-08-24 10:15 ` Jeff Layton
0 siblings, 1 reply; 6+ messages in thread
From: NeilBrown @ 2022-08-24 1:21 UTC (permalink / raw
To: Michael Kerrisk, linux-man; +Cc: Jeff Layton
utime and related calls always change the ctime. It is worth making
this explicit.
This is clear from the code (vfs_utimes() in fs/utimes.c always sets
ATTR_CTIME) and is documented in
https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html
Signed-off-by: NeilBrown <neilb@suse.de>
---
man2/utime.2 | 2 ++
man2/utimensat.2 | 3 +++
2 files changed, 5 insertions(+)
diff --git a/man2/utime.2 b/man2/utime.2
index 5338723574e2..7557d680afa3 100644
--- a/man2/utime.2
+++ b/man2/utime.2
@@ -39,6 +39,8 @@ to the
fields of
.I times
respectively.
+The status change time (ctime) will be set to the current time, even if the
+other time stamps don't actually change.
.PP
If
.I times
diff --git a/man2/utimensat.2 b/man2/utimensat.2
index 11cf3ee24129..2abf8e196ee1 100644
--- a/man2/utimensat.2
+++ b/man2/utimensat.2
@@ -101,6 +101,9 @@ If
.I times
is NULL, then both timestamps are set to the current time.
.\"
+.PP
+The status change time (ctime) will be set to the current time, even if the
+other time stamps don't actually change.
.SS Permissions requirements
To set both file timestamps to the current time (i.e.,
.I times
--
2.37.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] utime.2, utimensat.2: explicitly mention ctime changing.
2022-08-24 1:21 [PATCH] utime.2, utimensat.2: explicitly mention ctime changing NeilBrown
@ 2022-08-24 10:15 ` Jeff Layton
2022-08-24 11:49 ` Alejandro Colomar
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Layton @ 2022-08-24 10:15 UTC (permalink / raw
To: NeilBrown, Michael Kerrisk, linux-man
On Wed, 2022-08-24 at 11:21 +1000, NeilBrown wrote:
> utime and related calls always change the ctime. It is worth making
> this explicit.
> This is clear from the code (vfs_utimes() in fs/utimes.c always sets
> ATTR_CTIME) and is documented in
> https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
> man2/utime.2 | 2 ++
> man2/utimensat.2 | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/man2/utime.2 b/man2/utime.2
> index 5338723574e2..7557d680afa3 100644
> --- a/man2/utime.2
> +++ b/man2/utime.2
> @@ -39,6 +39,8 @@ to the
> fields of
> .I times
> respectively.
> +The status change time (ctime) will be set to the current time, even if the
> +other time stamps don't actually change.
> .PP
> If
> .I times
> diff --git a/man2/utimensat.2 b/man2/utimensat.2
> index 11cf3ee24129..2abf8e196ee1 100644
> --- a/man2/utimensat.2
> +++ b/man2/utimensat.2
> @@ -101,6 +101,9 @@ If
> .I times
> is NULL, then both timestamps are set to the current time.
> .\"
> +.PP
> +The status change time (ctime) will be set to the current time, even if the
> +other time stamps don't actually change.
> .SS Permissions requirements
> To set both file timestamps to the current time (i.e.,
> .I times
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] utime.2, utimensat.2: explicitly mention ctime changing.
2022-08-24 10:15 ` Jeff Layton
@ 2022-08-24 11:49 ` Alejandro Colomar
2022-08-25 0:20 ` NeilBrown
0 siblings, 1 reply; 6+ messages in thread
From: Alejandro Colomar @ 2022-08-24 11:49 UTC (permalink / raw
To: Jeff Layton, NeilBrown, Michael Kerrisk, linux-man
[-- Attachment #1.1: Type: text/plain, Size: 1690 bytes --]
Hi Neil and Jeff,
On 8/24/22 12:15, Jeff Layton wrote:
> On Wed, 2022-08-24 at 11:21 +1000, NeilBrown wrote:
>> utime and related calls always change the ctime. It is worth making
>> this explicit.
>> This is clear from the code (vfs_utimes() in fs/utimes.c always sets
>> ATTR_CTIME) and is documented in
>> https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html
>>
>> Signed-off-by: NeilBrown <neilb@suse.de>
>> ---
>> man2/utime.2 | 2 ++
>> man2/utimensat.2 | 3 +++
>> 2 files changed, 5 insertions(+)
>>
>> diff --git a/man2/utime.2 b/man2/utime.2
>> index 5338723574e2..7557d680afa3 100644
>> --- a/man2/utime.2
>> +++ b/man2/utime.2
>> @@ -39,6 +39,8 @@ to the
>> fields of
>> .I times
>> respectively.
>> +The status change time (ctime) will be set to the current time, even if the
>> +other time stamps don't actually change.
>> .PP
>> If
>> .I times
>> diff --git a/man2/utimensat.2 b/man2/utimensat.2
>> index 11cf3ee24129..2abf8e196ee1 100644
>> --- a/man2/utimensat.2
>> +++ b/man2/utimensat.2
>> @@ -101,6 +101,9 @@ If
>> .I times
>> is NULL, then both timestamps are set to the current time.
>> .\"
>> +.PP
>> +The status change time (ctime) will be set to the current time, even if the
>> +other time stamps don't actually change.
>> .SS Permissions requirements
>> To set both file timestamps to the current time (i.e.,
>> .I times
>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
Patch applied, with the tag. Thank you both!
Cheers,
Alex
P.S.: Please CC me in the patches, or I might not spot them.
--
Alejandro Colomar
<http://www.alejandro-colomar.es/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] utime.2, utimensat.2: explicitly mention ctime changing.
2022-08-24 11:49 ` Alejandro Colomar
@ 2022-08-25 0:20 ` NeilBrown
2022-08-25 8:37 ` Jakub Wilk
0 siblings, 1 reply; 6+ messages in thread
From: NeilBrown @ 2022-08-25 0:20 UTC (permalink / raw
To: Alejandro Colomar; +Cc: Jeff Layton, Michael Kerrisk, linux-man
On Wed, 24 Aug 2022, Alejandro Colomar wrote:
> Hi Neil and Jeff,
>
> On 8/24/22 12:15, Jeff Layton wrote:
> > On Wed, 2022-08-24 at 11:21 +1000, NeilBrown wrote:
> >> utime and related calls always change the ctime. It is worth making
> >> this explicit.
> >> This is clear from the code (vfs_utimes() in fs/utimes.c always sets
> >> ATTR_CTIME) and is documented in
> >> https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html
> >>
> >> Signed-off-by: NeilBrown <neilb@suse.de>
> >> ---
> >> man2/utime.2 | 2 ++
> >> man2/utimensat.2 | 3 +++
> >> 2 files changed, 5 insertions(+)
> >>
> >> diff --git a/man2/utime.2 b/man2/utime.2
> >> index 5338723574e2..7557d680afa3 100644
> >> --- a/man2/utime.2
> >> +++ b/man2/utime.2
> >> @@ -39,6 +39,8 @@ to the
> >> fields of
> >> .I times
> >> respectively.
> >> +The status change time (ctime) will be set to the current time, even if the
> >> +other time stamps don't actually change.
> >> .PP
> >> If
> >> .I times
> >> diff --git a/man2/utimensat.2 b/man2/utimensat.2
> >> index 11cf3ee24129..2abf8e196ee1 100644
> >> --- a/man2/utimensat.2
> >> +++ b/man2/utimensat.2
> >> @@ -101,6 +101,9 @@ If
> >> .I times
> >> is NULL, then both timestamps are set to the current time.
> >> .\"
> >> +.PP
> >> +The status change time (ctime) will be set to the current time, even if the
> >> +other time stamps don't actually change.
> >> .SS Permissions requirements
> >> To set both file timestamps to the current time (i.e.,
> >> .I times
> >
> > Reviewed-by: Jeff Layton <jlayton@kernel.org>
>
> Patch applied, with the tag. Thank you both!
Thanks.
>
> Cheers,
> Alex
>
> P.S.: Please CC me in the patches, or I might not spot them.
I will in future, but you might like to update
https://www.kernel.org/doc/man-pages/patches.html to make it clear that
"either" isn't really wanted and "both" maintainers should get the patch.
NeilBrown
>
> --
> Alejandro Colomar
> <http://www.alejandro-colomar.es/>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] utime.2, utimensat.2: explicitly mention ctime changing.
2022-08-25 0:20 ` NeilBrown
@ 2022-08-25 8:37 ` Jakub Wilk
2022-08-25 11:19 ` Alejandro Colomar
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Wilk @ 2022-08-25 8:37 UTC (permalink / raw
To: linux-man; +Cc: NeilBrown, Alejandro Colomar, Jeff Layton, Michael Kerrisk
* NeilBrown <neilb@suse.de>, 2022-08-25 10:20:
>I will in future, but you might like to update
>https://www.kernel.org/doc/man-pages/patches.html to make it clear that
>"either" isn't really wanted and "both" maintainers should get the
>patch.
Also: can we have this information directly in the CONTRIBUTING file?
--
Jakub Wilk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] utime.2, utimensat.2: explicitly mention ctime changing.
2022-08-25 8:37 ` Jakub Wilk
@ 2022-08-25 11:19 ` Alejandro Colomar
0 siblings, 0 replies; 6+ messages in thread
From: Alejandro Colomar @ 2022-08-25 11:19 UTC (permalink / raw
To: Jakub Wilk, linux-man; +Cc: NeilBrown, Jeff Layton, Michael Kerrisk
[-- Attachment #1.1: Type: text/plain, Size: 729 bytes --]
Hi Jakub, Neil,
On 8/25/22 10:37, Jakub Wilk wrote:
> * NeilBrown <neilb@suse.de>, 2022-08-25 10:20:
>> I will in future, but you might like to update
>> https://www.kernel.org/doc/man-pages/patches.html to make it clear
>> that "either" isn't really wanted and "both" maintainers should get
>> the patch.
>
> Also: can we have this information directly in the CONTRIBUTING file?
>
Yup, CONTRIBUTING updated:
<https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=974845c5c3a6d26318ac5d0ab6aaf493d5c43979>
However, I don't know what's the process to update the website, so it'll
take some time to update.
Cheers,
Alex
--
Alejandro Colomar
<http://www.alejandro-colomar.es/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-25 11:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-24 1:21 [PATCH] utime.2, utimensat.2: explicitly mention ctime changing NeilBrown
2022-08-24 10:15 ` Jeff Layton
2022-08-24 11:49 ` Alejandro Colomar
2022-08-25 0:20 ` NeilBrown
2022-08-25 8:37 ` Jakub Wilk
2022-08-25 11:19 ` Alejandro Colomar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.