All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] video: fbdev: fix warning comparing pointer to 0
@ 2022-03-11  2:56 ` Haowen Bai
  0 siblings, 0 replies; 4+ messages in thread
From: Haowen Bai @ 2022-03-11  2:56 UTC (permalink / raw
  To: deller; +Cc: linux-fbdev, dri-devel, linux-kernel, Haowen Bai

Fix the following coccicheck warning:
drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 4501e84..afdb6aa 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
 
 	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
 
-	if (info == 0) {
+	if (!info) {
 		release_mem_region(res_start, res_size);
 		return;
 	}
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] video: fbdev: fix warning comparing pointer to 0
@ 2022-03-11  2:56 ` Haowen Bai
  0 siblings, 0 replies; 4+ messages in thread
From: Haowen Bai @ 2022-03-11  2:56 UTC (permalink / raw
  To: deller; +Cc: linux-fbdev, Haowen Bai, linux-kernel, dri-devel

Fix the following coccicheck warning:
drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index 4501e84..afdb6aa 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
 
 	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
 
-	if (info == 0) {
+	if (!info) {
 		release_mem_region(res_start, res_size);
 		return;
 	}
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] video: fbdev: fix warning comparing pointer to 0
  2022-03-11  2:56 ` Haowen Bai
@ 2022-03-11  7:24   ` Helge Deller
  -1 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2022-03-11  7:24 UTC (permalink / raw
  To: Haowen Bai; +Cc: linux-fbdev, linux-kernel, dri-devel

On 3/11/22 03:56, Haowen Bai wrote:
> Fix the following coccicheck warning:
> drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/offb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 4501e84..afdb6aa 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
>
>  	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
>
> -	if (info == 0) {
> +	if (!info) {
>  		release_mem_region(res_start, res_size);
>  		return;
>  	}


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] video: fbdev: fix warning comparing pointer to 0
@ 2022-03-11  7:24   ` Helge Deller
  0 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2022-03-11  7:24 UTC (permalink / raw
  To: Haowen Bai; +Cc: linux-fbdev, dri-devel, linux-kernel

On 3/11/22 03:56, Haowen Bai wrote:
> Fix the following coccicheck warning:
> drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/offb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 4501e84..afdb6aa 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
>
>  	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
>
> -	if (info == 0) {
> +	if (!info) {
>  		release_mem_region(res_start, res_size);
>  		return;
>  	}


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-11  8:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-11  2:56 [PATCH] video: fbdev: fix warning comparing pointer to 0 Haowen Bai
2022-03-11  2:56 ` Haowen Bai
2022-03-11  7:24 ` Helge Deller
2022-03-11  7:24   ` Helge Deller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.