From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D61C48BD1 for ; Thu, 10 Jun 2021 15:33:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED6B0613E3 for ; Thu, 10 Jun 2021 15:33:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED6B0613E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrMgr-0006cX-KL for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 11:33:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrMeB-0000tI-FI for qemu-devel@nongnu.org; Thu, 10 Jun 2021 11:31:07 -0400 Received: from indium.canonical.com ([91.189.90.7]:46630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrMe5-0005Ua-8G for qemu-devel@nongnu.org; Thu, 10 Jun 2021 11:31:07 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.93 #5 (Debian)) id 1lrMe0-0003IJ-NV for ; Thu, 10 Jun 2021 15:30:56 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 821942E816B for ; Thu, 10 Jun 2021 15:30:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 10 Jun 2021 15:19:19 -0000 From: Thomas Huth <1918321@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Confirmed; importance=Undecided; assignee=None; X-Launchpad-Bug-Tags: block fuzzer X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: a1xndr th-huth X-Launchpad-Bug-Reporter: Alexander Bulekov (a1xndr) X-Launchpad-Bug-Modifier: Thomas Huth (th-huth) References: <161531961935.11554.15835639895023157218.malonedeb@chaenomeles.canonical.com> Message-Id: <162333835967.5693.18211320242959406822.malone@gac.canonical.com> Subject: [Bug 1918321] Re: [OSS-Fuzz] Issue 31875 megasas: Null-ptr dereference in megasas_finish_dcmd X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="b45bdbe3a00b6b668fa7f2069bd545c35c41f7f4"; Instance="production" X-Launchpad-Hash: 6085cff6ea9d6937b1a198ff64b3c8cff6889e99 Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1918321 <1918321@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is still reproducible with the current qemu git version (commit 7fe7fae8b48e3f9c647f) ** Tags added: block ** Changed in: qemu Status: New =3D> Confirmed -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918321 Title: [OSS-Fuzz] Issue 31875 megasas: Null-ptr dereference in megasas_finish_dcmd Status in QEMU: Confirmed Bug description: Hello, =3D=3D QTest Reproducer =3D=3D /* = * cat << EOF | ./qemu-system-i386 -display none -machine accel=3Dqtest, = -m \ * 512M -machine q35 -nodefaults -device megasas -device \ * scsi-cd,drive=3Dnull0 -blockdev \ * driver=3Dnull-co,read-zeroes=3Don,node-name=3Dnull0 -qtest stdio * outl 0xcf8 0x80000801 * outl 0xcfc 0x05000000 * outl 0xcf8 0x80000816 * outl 0xcfc 0x19000000 * write 0x1e1ed300 0x1 0x01 * write 0x1e1ed307 0x1 0x01 * write 0x1e1ed316 0x1 0x01 * write 0x1e1ed328 0x1 0x01 * write 0x1e1ed32f 0x1 0x01 * outl 0x1940 0x1e1ed300 * outl 0x19c0 0x00 * EOF */ static void null_deref_megasas_finish_dcmd(void) { QTestState *s =3D qtest_init( "-display none , -m 512M -machine q35 -nodefaults -device megasas= -device " "scsi-cd,drive=3Dnull0 -blockdev driver=3Dnull-co,read-zeroes=3Do= n,node-name=3Dnull0 "); qtest_outl(s, 0xcf8, 0x80000801); qtest_outl(s, 0xcfc, 0x05000000); qtest_outl(s, 0xcf8, 0x80000816); qtest_outl(s, 0xcfc, 0x19000000); qtest_bufwrite(s, 0x1e1ed300, "\x01", 0x1); qtest_bufwrite(s, 0x1e1ed307, "\x01", 0x1); qtest_bufwrite(s, 0x1e1ed316, "\x01", 0x1); qtest_bufwrite(s, 0x1e1ed328, "\x01", 0x1); qtest_bufwrite(s, 0x1e1ed32f, "\x01", 0x1); qtest_outl(s, 0x1940, 0x1e1ed300); qtest_outl(s, 0x19c0, 0x00); qtest_quit(s); } int main(int argc, char **argv) { const char *arch =3D qtest_get_arch(); g_test_init(&argc, &argv, NULL); if (strcmp(arch, "i386") =3D=3D 0) { qtest_add_func("fuzz/null_deref_megasas_finish_dcmd", null_deref_megasas_finish_dcmd); } return g_test_run(); } =3D=3D Stack Trace =3D=3D ../hw/scsi/megasas.c:1884:21: runtime error: member access within null po= inter of type 'union mfi_frame' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../hw/scsi/megasa= s.c:1884:21 in ../hw/scsi/megasas.c:1884:21: runtime error: member access within null po= inter of type 'struct mfi_frame_header' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../hw/scsi/megasa= s.c:1884:21 in AddressSanitizer:DEADLYSIGNAL =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D314546=3D=3DERROR: AddressSanitizer: SEGV on unknown address 0x0000= 00000003 (pc 0x55b1b4f4de73 bp 0x7ffcfc5a8bb0 sp 0x7ffcfc5a8900 T0) =3D=3D314546=3D=3DThe signal is caused by a WRITE memory access. =3D=3D314546=3D=3DHint: address points to the zero page. #0 0x55b1b4f4de73 in megasas_command_complete build/../hw/scsi/megasas.c:= 1884:40 #1 0x55b1b5613914 in scsi_req_complete build/../hw/scsi/scsi-bus.c:1515:5 #2 0x55b1b5448aeb in scsi_dma_complete_noio build/../hw/scsi/scsi-disk.c:= 345:9 #3 0x55b1b5446fc7 in scsi_dma_complete build/../hw/scsi/scsi-disk.c:366:5 #4 0x55b1b4fffc56 in dma_complete build/../softmmu/dma-helpers.c:121:9 #5 0x55b1b4fffc56 in dma_blk_cb build/../softmmu/dma-helpers.c:139:9 #6 0x55b1b6856016 in blk_aio_complete build/../block/block-backend.c:1412= :9 #7 0x55b1b6f48b06 in aio_bh_poll build/../util/async.c:164:13 #8 0x55b1b6f08cec in aio_dispatch build/../util/aio-posix.c:381:5 #9 0x55b1b6f4d59c in aio_ctx_dispatch build/../util/async.c:306:5 #10 0x7fd88c098baa in g_main_context_dispatch (/usr/lib/x86_64-linux-gnu/= libglib-2.0.so.0+0x51baa) #11 0x55b1b6f59a3c in glib_pollfds_poll build/../util/main-loop.c:232:9 #12 0x55b1b6f59a3c in os_host_main_loop_wait build/../util/main-loop.c:25= 5:5 #13 0x55b1b6f59a3c in main_loop_wait build/../util/main-loop.c:531:11 #14 0x55b1b61a78a9 in qemu_main_loop build/../softmmu/runstate.c:725:9 #15 0x55b1b4c751e5 in main build/../softmmu/main.c:50:5 #16 0x7fd88aec6d09 in __libc_start_main csu/../csu/libc-start.c:308:16 #17 0x55b1b4bc8bb9 in _start (system-i386+0x2b5fbb9) To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1918321/+subscriptions