[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf: Add an API for exporting sync files (v11)

From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Jason Ekstrand" <jason@jlekstrand.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf: Add an API for exporting sync files (v11)
Date: Tue, 25 May 2021 21:44:36 -0000	[thread overview]
Message-ID: <162197907682.1318.12791425834709814551@emeril.freedesktop.org> (raw)
In-Reply-To: <20210525211753.1086069-1-jason@jlekstrand.net>

== Series Details ==

Series: dma-buf: Add an API for exporting sync files (v11)
URL   : https://patchwork.freedesktop.org/series/90555/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
225a57e84149 dma-buf: Add dma_fence_array_for_each (v2)
-:75: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fence' - possible side-effects?
#75: FILE: include/linux/dma-fence-array.h:86:
+#define dma_fence_array_for_each(fence, index, head)			\
+	for (index = 0, fence = dma_fence_array_first(head); fence;	\
+	     ++(index), fence = dma_fence_array_next(head, index))

-:75: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#75: FILE: include/linux/dma-fence-array.h:86:
+#define dma_fence_array_for_each(fence, index, head)			\
+	for (index = 0, fence = dma_fence_array_first(head); fence;	\
+	     ++(index), fence = dma_fence_array_next(head, index))

-:75: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'head' - possible side-effects?
#75: FILE: include/linux/dma-fence-array.h:86:
+#define dma_fence_array_for_each(fence, index, head)			\
+	for (index = 0, fence = dma_fence_array_first(head); fence;	\
+	     ++(index), fence = dma_fence_array_next(head, index))

-:90: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '"Christian König" <ckoenig.leichtzumerken@gmail.com>'

total: 1 errors, 0 warnings, 3 checks, 57 lines checked
a26f8ef33498 dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)
-:68: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#68: FILE: drivers/dma-buf/dma-resv.c:434:
+				 unsigned *pshared_count,

-:821: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#821: FILE: include/linux/dma-resv.h:283:
+				 unsigned *pshared_count,

total: 0 errors, 2 warnings, 0 checks, 601 lines checked
8f674ac01f2f dma-buf: Add dma_resv_get_singleton_unlocked (v5)
-:63: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#63: FILE: drivers/dma-buf/dma-resv.c:55:
+#define dma_fence_deep_dive_for_each(fence, chain, index, head)	\
+	dma_fence_chain_for_each(chain, head)			\
+		dma_fence_array_for_each(fence, index, chain)

-:63: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'chain' - possible side-effects?
#63: FILE: drivers/dma-buf/dma-resv.c:55:
+#define dma_fence_deep_dive_for_each(fence, chain, index, head)	\
+	dma_fence_chain_for_each(chain, head)			\
+		dma_fence_array_for_each(fence, index, chain)

-:117: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#117: FILE: drivers/dma-buf/dma-resv.c:570:
+	fences = kmalloc_array(num_fences, sizeof(struct dma_fence*),

total: 2 errors, 0 warnings, 1 checks, 118 lines checked
94bae126528f dma-buf: Document DMA_BUF_IOCTL_SYNC
3dff9bbbbc2a dma-buf: Add an API for exporting sync files (v11)
46fac74a3274 RFC: dma-buf: Add an extra fence to dma_resv_get_singleton_unlocked
f3982039cd8a RFC: dma-buf: Add an API for importing sync files (v7)


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx