* [PATCH] gcc-configure: Enable the use of different symbol versioning
@ 2020-01-19 3:01 Alejandro Enedino Hernandez Samaniego
2020-01-20 0:22 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2020-01-19 3:01 UTC (permalink / raw
To: openembedded-core
While the gnu style for symbol versioning is the most usual,
--enable-symvers[=style] can be provided several values,
gnu, gnu-versioned-namespace, darwin, darwin-export, and sun,
depending on users needs.
Introduce the SYMVERS_CONF variable to allow the user to
configure the symbol versioning in shared libraries.
Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
---
meta/recipes-devtools/gcc/gcc-configure-common.inc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc
index 24ba8ce..bb4f692 100644
--- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
@@ -17,6 +17,8 @@ GCCTHREADS ?= "posix"
GCCPIE ??= ""
+SYMVERS_CONF ?= "--enable-symvers=gnu"
+
EXTRA_OECONF = "\
${@['--enable-clocale=generic', ''][d.getVar('USE_NLS') != 'no']} \
--with-gnu-ld \
@@ -27,7 +29,7 @@ EXTRA_OECONF = "\
${GCCPIE} \
--enable-c99 \
--enable-long-long \
- --enable-symvers=gnu \
+ ${SYMVERS_CONF} \
--enable-libstdcxx-pch \
--program-prefix=${TARGET_PREFIX} \
--without-local-prefix \
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gcc-configure: Enable the use of different symbol versioning
2020-01-19 3:01 [PATCH] gcc-configure: Enable the use of different symbol versioning Alejandro Enedino Hernandez Samaniego
@ 2020-01-20 0:22 ` Khem Raj
2020-01-20 0:29 ` Alejandro Enedino Hernandez Samaniego
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2020-01-20 0:22 UTC (permalink / raw
To: Alejandro Enedino Hernandez Samaniego
Cc: Patches and discussions about the oe-core layer
On Sat, Jan 18, 2020 at 7:02 PM Alejandro Enedino Hernandez Samaniego
<alejandro@enedino.org> wrote:
>
> While the gnu style for symbol versioning is the most usual,
> --enable-symvers[=style] can be provided several values,
> gnu, gnu-versioned-namespace, darwin, darwin-export, and sun,
> depending on users needs.
>
> Introduce the SYMVERS_CONF variable to allow the user to
> configure the symbol versioning in shared libraries.
>
> Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
> ---
> meta/recipes-devtools/gcc/gcc-configure-common.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> index 24ba8ce..bb4f692 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> @@ -17,6 +17,8 @@ GCCTHREADS ?= "posix"
>
> GCCPIE ??= ""
>
> +SYMVERS_CONF ?= "--enable-symvers=gnu"
> +
just turn the RHS into variable not full option
> EXTRA_OECONF = "\
> ${@['--enable-clocale=generic', ''][d.getVar('USE_NLS') != 'no']} \
> --with-gnu-ld \
> @@ -27,7 +29,7 @@ EXTRA_OECONF = "\
> ${GCCPIE} \
> --enable-c99 \
> --enable-long-long \
> - --enable-symvers=gnu \
> + ${SYMVERS_CONF} \
> --enable-libstdcxx-pch \
> --program-prefix=${TARGET_PREFIX} \
> --without-local-prefix \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gcc-configure: Enable the use of different symbol versioning
2020-01-20 0:22 ` Khem Raj
@ 2020-01-20 0:29 ` Alejandro Enedino Hernandez Samaniego
0 siblings, 0 replies; 3+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2020-01-20 0:29 UTC (permalink / raw
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]
Hey Khem,
On Sun, Jan 19, 2020, 4:22 PM Khem Raj <raj.khem@gmail.com> wrote:
> On Sat, Jan 18, 2020 at 7:02 PM Alejandro Enedino Hernandez Samaniego
> <alejandro@enedino.org> wrote:
> >
> > While the gnu style for symbol versioning is the most usual,
> > --enable-symvers[=style] can be provided several values,
> > gnu, gnu-versioned-namespace, darwin, darwin-export, and sun,
> > depending on users needs.
> >
> > Introduce the SYMVERS_CONF variable to allow the user to
> > configure the symbol versioning in shared libraries.
> >
> > Signed-off-by: Alejandro Enedino Hernandez Samaniego <
> alejandro@enedino.org>
> > ---
> > meta/recipes-devtools/gcc/gcc-configure-common.inc | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > index 24ba8ce..bb4f692 100644
> > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> > @@ -17,6 +17,8 @@ GCCTHREADS ?= "posix"
> >
> > GCCPIE ??= ""
> >
> > +SYMVERS_CONF ?= "--enable-symvers=gnu"
> > +
>
> just turn the RHS into variable not full option
>
I did think about that, and I can do it, but I think I would have to also
create a PACKAGECONFIG and since AFAIC no one is changing the style I'm not
sure it's worth the complication of the code, and this still allows us to
remove the enablement entirely, not just changing the style.
Alejandro
> > EXTRA_OECONF = "\
> > ${@['--enable-clocale=generic', ''][d.getVar('USE_NLS') != 'no']} \
> > --with-gnu-ld \
> > @@ -27,7 +29,7 @@ EXTRA_OECONF = "\
> > ${GCCPIE} \
> > --enable-c99 \
> > --enable-long-long \
> > - --enable-symvers=gnu \
> > + ${SYMVERS_CONF} \
> > --enable-libstdcxx-pch \
> > --program-prefix=${TARGET_PREFIX} \
> > --without-local-prefix \
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 3472 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-20 0:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-19 3:01 [PATCH] gcc-configure: Enable the use of different symbol versioning Alejandro Enedino Hernandez Samaniego
2020-01-20 0:22 ` Khem Raj
2020-01-20 0:29 ` Alejandro Enedino Hernandez Samaniego
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.