* [PATCH] qla2xxx: Fix warning reported by static checker
@ 2016-01-20 20:11 Himanshu Madhani
2016-01-20 21:39 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Himanshu Madhani @ 2016-01-20 20:11 UTC (permalink / raw
To: target-devel, nab; +Cc: giridhar.malavali, linux-scsi, himanshu.madhani
This patch fixes following warning
drivers/scsi/qla2xxx/qla_target.c:3587 qlt_do_ctio_completion()
warn: impossible condition '(logged_out == 41) => (0-1 == 41)'
drivers/scsi/qla2xxx/qla_target.c
3580 case CTIO_PORT_LOGGED_OUT:
3581 case CTIO_PORT_UNAVAILABLE:
3582 {
3583 bool logged_out = (status & 0xFFFF);
3584 ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
3585 "qla_target(%d): CTIO with %s status %x "
3586 "received (state %x, se_cmd %p)\n", vha->vp_idx,
3587 (logged_out == CTIO_PORT_LOGGED_OUT) ?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Bool cannot equal 0x26.
3588 "PORT LOGGED OUT" : "PORT UNAVAILABLE",
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
---
drivers/scsi/qla2xxx/qla_target.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 80651cd..829b534 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3597,12 +3597,13 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle,
case CTIO_PORT_LOGGED_OUT:
case CTIO_PORT_UNAVAILABLE:
{
- bool logged_out = (status & 0xFFFF);
+ bool logged_out =
+ (status & 0xFFFF) == CTIO_PORT_LOGGED_OUT;
+
ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
"qla_target(%d): CTIO with %s status %x "
"received (state %x, se_cmd %p)\n", vha->vp_idx,
- (logged_out == CTIO_PORT_LOGGED_OUT) ?
- "PORT LOGGED OUT" : "PORT UNAVAILABLE",
+ logged_out ? "PORT LOGGED OUT" : "PORT UNAVAILABLE",
status, cmd->state, se_cmd);
if (logged_out && cmd->sess) {
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qla2xxx: Fix warning reported by static checker
2016-01-20 20:11 [PATCH] qla2xxx: Fix warning reported by static checker Himanshu Madhani
@ 2016-01-20 21:39 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2016-01-20 21:39 UTC (permalink / raw
To: Himanshu Madhani; +Cc: target-devel, giridhar.malavali, linux-scsi
Hi Himanshu,
On Wed, 2016-01-20 at 15:11 -0500, Himanshu Madhani wrote:
> This patch fixes following warning
>
> drivers/scsi/qla2xxx/qla_target.c:3587 qlt_do_ctio_completion()
> warn: impossible condition '(logged_out == 41) => (0-1 == 41)'
>
> drivers/scsi/qla2xxx/qla_target.c
> 3580 case CTIO_PORT_LOGGED_OUT:
> 3581 case CTIO_PORT_UNAVAILABLE:
> 3582 {
> 3583 bool logged_out = (status & 0xFFFF);
> 3584 ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
> 3585 "qla_target(%d): CTIO with %s status %x "
> 3586 "received (state %x, se_cmd %p)\n", vha->vp_idx,
> 3587 (logged_out == CTIO_PORT_LOGGED_OUT) ?
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Bool cannot equal 0x26.
> 3588 "PORT LOGGED OUT" : "PORT UNAVAILABLE",
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
> Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 80651cd..829b534 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3597,12 +3597,13 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle,
> case CTIO_PORT_LOGGED_OUT:
> case CTIO_PORT_UNAVAILABLE:
> {
> - bool logged_out = (status & 0xFFFF);
> + bool logged_out =
> + (status & 0xFFFF) == CTIO_PORT_LOGGED_OUT;
> +
> ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
> "qla_target(%d): CTIO with %s status %x "
> "received (state %x, se_cmd %p)\n", vha->vp_idx,
> - (logged_out == CTIO_PORT_LOGGED_OUT) ?
> - "PORT LOGGED OUT" : "PORT UNAVAILABLE",
> + logged_out ? "PORT LOGGED OUT" : "PORT UNAVAILABLE",
> status, cmd->state, se_cmd);
>
> if (logged_out && cmd->sess) {
I picked up Arnd's patch earlier this morning, and will include this
better version in the post -rc1 fixes PULL request.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-20 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-20 20:11 [PATCH] qla2xxx: Fix warning reported by static checker Himanshu Madhani
2016-01-20 21:39 ` Nicholas A. Bellinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.