* [PATCH v2 1/2] cxl: fix build for GCC 4.6.x
@ 2016-01-08 18:30 Brian Norris
2016-01-08 18:30 ` [PATCH v2 2/2] cxl: use -Werror only with CONFIG_PPC_WERROR Brian Norris
2016-01-12 12:32 ` [v2,1/2] cxl: fix build for GCC 4.6.x Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Brian Norris @ 2016-01-08 18:30 UTC (permalink / raw
To: Ian Munsie, Michael Neuling
Cc: linuxppc-dev, linux-kernel, Brian Norris, Arnd Bergmann,
Joe Perches, Michal Marek, Michael Ellerman, Anton Blanchard
GCC 4.6.3 does not support -Wno-unused-const-variable. Instead, use the
kbuild infrastructure that checks if this options exists.
Fixes: 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable behaviour change")
Suggested-by: Michal Marek <mmarek@suse.com>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
v2: don't remove -Werror
drivers/misc/cxl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/Makefile b/drivers/misc/cxl/Makefile
index 6982f603fadc..ab6f392d3504 100644
--- a/drivers/misc/cxl/Makefile
+++ b/drivers/misc/cxl/Makefile
@@ -1,4 +1,4 @@
-ccflags-y := -Werror -Wno-unused-const-variable
+ccflags-y := -Werror $(call cc-disable-warning, unused-const-variable)
cxl-y += main.o file.o irq.o fault.o native.o
cxl-y += context.o sysfs.o debugfs.o pci.o trace.o
--
2.6.0.rc2.230.g3dd15c0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] cxl: use -Werror only with CONFIG_PPC_WERROR
2016-01-08 18:30 [PATCH v2 1/2] cxl: fix build for GCC 4.6.x Brian Norris
@ 2016-01-08 18:30 ` Brian Norris
2016-01-12 12:32 ` [v2,2/2] " Michael Ellerman
2016-01-12 12:32 ` [v2,1/2] cxl: fix build for GCC 4.6.x Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Brian Norris @ 2016-01-08 18:30 UTC (permalink / raw
To: Ian Munsie, Michael Neuling
Cc: linuxppc-dev, linux-kernel, Brian Norris, Arnd Bergmann,
Joe Perches, Michal Marek, Michael Ellerman, Anton Blanchard
Some developers really like to have -Werror enabled for their code, as
it helps to ensure warning free code. Others don't want -Werror, as it
(for example) can cause problems when newer (or older) compilers have
different sets of warnings, or new warnings can appear just when turning
up the warning level (e.g., make W=1 or W=2). Thus, it seems prudent to
have the use of -Werror be configurable.
It so happens that cxl is only built on PowerPC, and PowerPC already
has a nice set of Kconfig options for this, under CONFIG_PPC_WERROR. So
let's use that, and the world is a happy place again! (Note that
PPC_WERROR defaults to =y, so the common case compile should still be
enforcing -Werror.)
Fixes: d3d73f4b38a8 ("cxl: Compile with -Werror")
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
v2: new in v2
drivers/misc/cxl/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/Makefile b/drivers/misc/cxl/Makefile
index ab6f392d3504..be2ac5ce349f 100644
--- a/drivers/misc/cxl/Makefile
+++ b/drivers/misc/cxl/Makefile
@@ -1,4 +1,5 @@
-ccflags-y := -Werror $(call cc-disable-warning, unused-const-variable)
+ccflags-y := $(call cc-disable-warning, unused-const-variable)
+ccflags-$(CONFIG_PPC_WERROR) += -Werror
cxl-y += main.o file.o irq.o fault.o native.o
cxl-y += context.o sysfs.o debugfs.o pci.o trace.o
--
2.6.0.rc2.230.g3dd15c0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [v2,1/2] cxl: fix build for GCC 4.6.x
2016-01-08 18:30 [PATCH v2 1/2] cxl: fix build for GCC 4.6.x Brian Norris
2016-01-08 18:30 ` [PATCH v2 2/2] cxl: use -Werror only with CONFIG_PPC_WERROR Brian Norris
@ 2016-01-12 12:32 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-01-12 12:32 UTC (permalink / raw
To: Brian Norris, Ian Munsie, Michael Neuling
Cc: Arnd Bergmann, Anton Blanchard, linux-kernel, Michal Marek,
Joe Perches, Brian Norris, linuxppc-dev
On Fri, 2016-08-01 at 18:30:09 UTC, Brian Norris wrote:
> GCC 4.6.3 does not support -Wno-unused-const-variable. Instead, use the
> kbuild infrastructure that checks if this options exists.
>
> Fixes: 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable behaviour change")
> Suggested-by: Michal Marek <mmarek@suse.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/aa09545589ceeff884421d8eb3
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v2,2/2] cxl: use -Werror only with CONFIG_PPC_WERROR
2016-01-08 18:30 ` [PATCH v2 2/2] cxl: use -Werror only with CONFIG_PPC_WERROR Brian Norris
@ 2016-01-12 12:32 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-01-12 12:32 UTC (permalink / raw
To: Brian Norris, Ian Munsie, Michael Neuling
Cc: Arnd Bergmann, Anton Blanchard, linux-kernel, Michal Marek,
Joe Perches, Brian Norris, linuxppc-dev
On Fri, 2016-08-01 at 18:30:10 UTC, Brian Norris wrote:
> Some developers really like to have -Werror enabled for their code, as
> it helps to ensure warning free code. Others don't want -Werror, as it
> (for example) can cause problems when newer (or older) compilers have
> different sets of warnings, or new warnings can appear just when turning
> up the warning level (e.g., make W=1 or W=2). Thus, it seems prudent to
> have the use of -Werror be configurable.
>
> It so happens that cxl is only built on PowerPC, and PowerPC already
> has a nice set of Kconfig options for this, under CONFIG_PPC_WERROR. So
> let's use that, and the world is a happy place again! (Note that
> PPC_WERROR defaults to =y, so the common case compile should still be
> enforcing -Werror.)
>
> Fixes: d3d73f4b38a8 ("cxl: Compile with -Werror")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/57f7c3932516b9f7908d9b0a24
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-12 12:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-08 18:30 [PATCH v2 1/2] cxl: fix build for GCC 4.6.x Brian Norris
2016-01-08 18:30 ` [PATCH v2 2/2] cxl: use -Werror only with CONFIG_PPC_WERROR Brian Norris
2016-01-12 12:32 ` [v2,2/2] " Michael Ellerman
2016-01-12 12:32 ` [v2,1/2] cxl: fix build for GCC 4.6.x Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.