* [U-Boot] [PATCH v3 0/2] vexpress64: Juno: Add support for PCIe on Juno
@ 2015-10-19 10:08 Liviu Dudau
2015-10-19 10:08 ` [U-Boot] [PATCH v3 1/2] vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel Liviu Dudau
2015-10-19 10:08 ` [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge Liviu Dudau
0 siblings, 2 replies; 6+ messages in thread
From: Liviu Dudau @ 2015-10-19 10:08 UTC (permalink / raw
To: u-boot
Hello,
This patchset enables PCIe for ARM's Juno boards and configures the
host bridge's address translation block. This enables the Linux kernel
to boot on Juno r1 using just a device tree and the generic host bridge
driver.
No support has been added at this phase for the SATA or Ethernet devices
present on the PCIe bus.
Changelog:
- v3: Fix the error reported by Ryan Harkin on setting the virtual channel
credits.
- v3: fixed the check_patch.pl warnings on blank lines and use BIT() macro
- v3: change from udelay() to mdelay()
- v3: spelling fixes
- v2: Split XpressRICH3 code into pcie.c file and introduce vexpress64_pcie_init()
that can be called from board_init(). Suggested by Linus Walleij.
- v2: Set up the XpressRICH3 bridge class code to a valid value to correct the
incorrect reset value.
- v1: Original submission http://lists.denx.de/pipermail/u-boot/2015-October/229669.html
Liviu Dudau (2):
vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel.
vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge.
board/armltd/vexpress64/Makefile | 2 +-
board/armltd/vexpress64/pcie.c | 197 +++++++++++++++++++++++++++++++++++
board/armltd/vexpress64/pcie.h | 12 +++
board/armltd/vexpress64/vexpress64.c | 10 ++
include/configs/vexpress_aemv8a.h | 4 +-
5 files changed, 223 insertions(+), 2 deletions(-)
create mode 100644 board/armltd/vexpress64/pcie.c
create mode 100644 board/armltd/vexpress64/pcie.h
--
2.6.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 1/2] vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel.
2015-10-19 10:08 [U-Boot] [PATCH v3 0/2] vexpress64: Juno: Add support for PCIe on Juno Liviu Dudau
@ 2015-10-19 10:08 ` Liviu Dudau
2015-10-20 0:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-10-19 10:08 ` [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge Liviu Dudau
1 sibling, 1 reply; 6+ messages in thread
From: Liviu Dudau @ 2015-10-19 10:08 UTC (permalink / raw
To: u-boot
Juno comes with 8GB RAM, but U-Boot only passes 2GB to the kernel.
Declare a secondary memory bank and set the sizes correctly.
Signed-off-by: Liviu Dudau <Liviu.Dudau@foss.arm.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
---
board/armltd/vexpress64/vexpress64.c | 8 ++++++++
include/configs/vexpress_aemv8a.h | 4 +++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/board/armltd/vexpress64/vexpress64.c b/board/armltd/vexpress64/vexpress64.c
index 7cb4e00..6df9d60 100644
--- a/board/armltd/vexpress64/vexpress64.c
+++ b/board/armltd/vexpress64/vexpress64.c
@@ -38,6 +38,14 @@ int dram_init(void)
return 0;
}
+void dram_init_banksize(void)
+{
+ gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
+ gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+ gd->bd->bi_dram[1].start = PHYS_SDRAM_2;
+ gd->bd->bi_dram[1].size = PHYS_SDRAM_2_SIZE;
+}
+
/*
* Board specific reset that is system reset.
*/
diff --git a/include/configs/vexpress_aemv8a.h b/include/configs/vexpress_aemv8a.h
index ef3014d..0f2f1a3 100644
--- a/include/configs/vexpress_aemv8a.h
+++ b/include/configs/vexpress_aemv8a.h
@@ -168,11 +168,13 @@
#define CONFIG_SYS_LOAD_ADDR (V2M_BASE + 0x10000000)
/* Physical Memory Map */
-#define CONFIG_NR_DRAM_BANKS 1
+#define CONFIG_NR_DRAM_BANKS 2
#define PHYS_SDRAM_1 (V2M_BASE) /* SDRAM Bank #1 */
+#define PHYS_SDRAM_2 (0x880000000)
/* Top 16MB reserved for secure world use */
#define DRAM_SEC_SIZE 0x01000000
#define PHYS_SDRAM_1_SIZE 0x80000000 - DRAM_SEC_SIZE
+#define PHYS_SDRAM_2_SIZE 0x180000000
#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
/* Enable memtest */
--
2.6.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge.
2015-10-19 10:08 [U-Boot] [PATCH v3 0/2] vexpress64: Juno: Add support for PCIe on Juno Liviu Dudau
2015-10-19 10:08 ` [U-Boot] [PATCH v3 1/2] vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel Liviu Dudau
@ 2015-10-19 10:08 ` Liviu Dudau
2015-10-19 10:27 ` Ryan Harkin
2015-10-20 0:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
1 sibling, 2 replies; 6+ messages in thread
From: Liviu Dudau @ 2015-10-19 10:08 UTC (permalink / raw
To: u-boot
Juno R1 has an XpressRICH3 PCIe host bridge that needs to be initialised
in order for the Linux kernel to be able to enumerate the bus. Add
support code here that enables the host bridge, trains the links and
sets up the Address Translation Tables.
Signed-off-by: Liviu Dudau <Liviu.Dudau@foss.arm.com>
Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
---
board/armltd/vexpress64/Makefile | 2 +-
board/armltd/vexpress64/pcie.c | 197 +++++++++++++++++++++++++++++++++++
board/armltd/vexpress64/pcie.h | 12 +++
board/armltd/vexpress64/vexpress64.c | 2 +
4 files changed, 212 insertions(+), 1 deletion(-)
create mode 100644 board/armltd/vexpress64/pcie.c
create mode 100644 board/armltd/vexpress64/pcie.h
diff --git a/board/armltd/vexpress64/Makefile b/board/armltd/vexpress64/Makefile
index e009141..a35db40 100644
--- a/board/armltd/vexpress64/Makefile
+++ b/board/armltd/vexpress64/Makefile
@@ -5,4 +5,4 @@
# SPDX-License-Identifier: GPL-2.0+
#
-obj-y := vexpress64.o
+obj-y := vexpress64.o pcie.o
diff --git a/board/armltd/vexpress64/pcie.c b/board/armltd/vexpress64/pcie.c
new file mode 100644
index 0000000..7b999e8
--- /dev/null
+++ b/board/armltd/vexpress64/pcie.c
@@ -0,0 +1,197 @@
+/*
+ * Copyright (C) ARM Ltd 2015
+ *
+ * Author: Liviu Dudau <Liviu.Dudau@arm.com>
+ *
+ * SPDX-Licence-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <linux/bitops.h>
+#include <pci_ids.h>
+#include "pcie.h"
+
+/* XpressRICH3 support */
+#define XR3_CONFIG_BASE 0x7ff30000
+#define XR3_RESET_BASE 0x7ff20000
+
+#define XR3_PCI_ECAM_START 0x40000000
+#define XR3_PCI_ECAM_SIZE 28 /* as power of 2 = 0x10000000 */
+#define XR3_PCI_IOSPACE_START 0x5f800000
+#define XR3_PCI_IOSPACE_SIZE 23 /* as power of 2 = 0x800000 */
+#define XR3_PCI_MEMSPACE_START 0x50000000
+#define XR3_PCI_MEMSPACE_SIZE 27 /* as power of 2 = 0x8000000 */
+#define XR3_PCI_MEMSPACE64_START 0x4000000000
+#define XR3_PCI_MEMSPACE64_SIZE 33 /* as power of 2 = 0x200000000 */
+
+#define JUNO_V2M_MSI_START 0x2c1c0000
+#define JUNO_V2M_MSI_SIZE 12 /* as power of 2 = 4096 */
+
+#define XR3PCI_BASIC_STATUS 0x18
+#define XR3PCI_BS_GEN_MASK (0xf << 8)
+#define XR3PCI_BS_LINK_MASK 0xff
+
+#define XR3PCI_VIRTCHAN_CREDITS 0x90
+#define XR3PCI_BRIDGE_PCI_IDS 0x9c
+#define XR3PCI_PEX_SPC2 0xd8
+
+#define XR3PCI_ATR_PCIE_WIN0 0x600
+#define XR3PCI_ATR_PCIE_WIN1 0x700
+#define XR3PCI_ATR_AXI4_SLV0 0x800
+
+#define XR3PCI_ATR_TABLE_SIZE 0x20
+#define XR3PCI_ATR_SRC_ADDR_LOW 0x0
+#define XR3PCI_ATR_SRC_ADDR_HIGH 0x4
+#define XR3PCI_ATR_TRSL_ADDR_LOW 0x8
+#define XR3PCI_ATR_TRSL_ADDR_HIGH 0xc
+#define XR3PCI_ATR_TRSL_PARAM 0x10
+
+/* IDs used in the XR3PCI_ATR_TRSL_PARAM */
+#define XR3PCI_ATR_TRSLID_AXIDEVICE (0x420004)
+#define XR3PCI_ATR_TRSLID_AXIMEMORY (0x4e0004) /* Write-through, read/write allocate */
+#define XR3PCI_ATR_TRSLID_PCIE_CONF (0x000001)
+#define XR3PCI_ATR_TRSLID_PCIE_IO (0x020000)
+#define XR3PCI_ATR_TRSLID_PCIE_MEMORY (0x000000)
+
+#define XR3PCI_ECAM_OFFSET(b, d, o) (((b) << 20) | \
+ (PCI_SLOT(d) << 15) | \
+ (PCI_FUNC(d) << 12) | o)
+
+#define JUNO_RESET_CTRL 0x1004
+#define JUNO_RESET_CTRL_PHY BIT(0)
+#define JUNO_RESET_CTRL_RC BIT(1)
+
+#define JUNO_RESET_STATUS 0x1008
+#define JUNO_RESET_STATUS_PLL BIT(0)
+#define JUNO_RESET_STATUS_PHY BIT(1)
+#define JUNO_RESET_STATUS_RC BIT(2)
+#define JUNO_RESET_STATUS_MASK (JUNO_RESET_STATUS_PLL | \
+ JUNO_RESET_STATUS_PHY | \
+ JUNO_RESET_STATUS_RC)
+
+void xr3pci_set_atr_entry(unsigned long base, unsigned long src_addr,
+ unsigned long trsl_addr, int window_size,
+ int trsl_param)
+{
+ /* X3PCI_ATR_SRC_ADDR_LOW:
+ - bit 0: enable entry,
+ - bits 1-6: ATR window size: total size in bytes: 2^(ATR_WSIZE + 1)
+ - bits 7-11: reserved
+ - bits 12-31: start of source address
+ */
+ writel((u32)(src_addr & 0xfffff000) | (window_size - 1) << 1 | 1,
+ base + XR3PCI_ATR_SRC_ADDR_LOW);
+ writel((u32)(src_addr >> 32), base + XR3PCI_ATR_SRC_ADDR_HIGH);
+ writel((u32)(trsl_addr & 0xfffff000), base + XR3PCI_ATR_TRSL_ADDR_LOW);
+ writel((u32)(trsl_addr >> 32), base + XR3PCI_ATR_TRSL_ADDR_HIGH);
+ writel(trsl_param, base + XR3PCI_ATR_TRSL_PARAM);
+
+ printf("ATR entry: 0x%010lx %s 0x%010lx [0x%010llx] (param: 0x%06x)\n",
+ src_addr, (trsl_param & 0x400000) ? "<-" : "->", trsl_addr,
+ ((u64)1) << window_size, trsl_param);
+}
+
+void xr3pci_setup_atr(void)
+{
+ /* setup PCIe to CPU address translation tables */
+ unsigned long base = XR3_CONFIG_BASE + XR3PCI_ATR_PCIE_WIN0;
+
+ /* forward all writes from PCIe to GIC V2M (used for MSI) */
+ xr3pci_set_atr_entry(base, JUNO_V2M_MSI_START, JUNO_V2M_MSI_START,
+ JUNO_V2M_MSI_SIZE, XR3PCI_ATR_TRSLID_AXIDEVICE);
+
+ base += XR3PCI_ATR_TABLE_SIZE;
+
+ /* PCIe devices can write anywhere in memory */
+ xr3pci_set_atr_entry(base, PHYS_SDRAM_1, PHYS_SDRAM_1,
+ 31 /* grant access to all RAM under 4GB */,
+ XR3PCI_ATR_TRSLID_AXIMEMORY);
+ base += XR3PCI_ATR_TABLE_SIZE;
+ xr3pci_set_atr_entry(base, PHYS_SDRAM_2, PHYS_SDRAM_2,
+ XR3_PCI_MEMSPACE64_SIZE,
+ XR3PCI_ATR_TRSLID_AXIMEMORY);
+
+
+ /* setup CPU to PCIe address translation table */
+ base = XR3_CONFIG_BASE + XR3PCI_ATR_AXI4_SLV0;
+
+ /* setup ECAM space to bus configuration interface */
+ xr3pci_set_atr_entry(base, XR3_PCI_ECAM_START, 0, XR3_PCI_ECAM_SIZE,
+ XR3PCI_ATR_TRSLID_PCIE_CONF);
+
+ base += XR3PCI_ATR_TABLE_SIZE;
+
+ /* setup IO space translation */
+ xr3pci_set_atr_entry(base, XR3_PCI_IOSPACE_START, XR3_PCI_IOSPACE_START,
+ XR3_PCI_IOSPACE_SIZE, XR3PCI_ATR_TRSLID_PCIE_IO);
+
+ base += XR3PCI_ATR_TABLE_SIZE;
+
+ /* setup 32bit MEM space translation */
+ xr3pci_set_atr_entry(base, XR3_PCI_MEMSPACE_START, XR3_PCI_MEMSPACE_START,
+ XR3_PCI_MEMSPACE_SIZE, XR3PCI_ATR_TRSLID_PCIE_MEMORY);
+
+ base += XR3PCI_ATR_TABLE_SIZE;
+
+ /* setup 64bit MEM space translation */
+ xr3pci_set_atr_entry(base, XR3_PCI_MEMSPACE64_START, XR3_PCI_MEMSPACE64_START,
+ XR3_PCI_MEMSPACE64_SIZE, XR3PCI_ATR_TRSLID_PCIE_MEMORY);
+}
+
+void xr3pci_init(void)
+{
+ u32 val;
+ int timeout = 200;
+
+ /* Initialise the XpressRICH3 PCIe host bridge */
+
+ /* add credits */
+ writel(0x00f0b818, XR3_CONFIG_BASE + XR3PCI_VIRTCHAN_CREDITS);
+ writel(0x1, XR3_CONFIG_BASE + XR3PCI_VIRTCHAN_CREDITS + 4);
+ /* allow ECRC */
+ writel(0x6006, XR3_CONFIG_BASE + XR3PCI_PEX_SPC2);
+ /* setup the correct class code for the host bridge */
+ writel(PCI_CLASS_BRIDGE_PCI << 16, XR3_CONFIG_BASE + XR3PCI_BRIDGE_PCI_IDS);
+
+ /* reset phy and root complex */
+ writel(JUNO_RESET_CTRL_PHY | JUNO_RESET_CTRL_RC,
+ XR3_RESET_BASE + JUNO_RESET_CTRL);
+
+ do {
+ mdelay(1);
+ val = readl(XR3_RESET_BASE + JUNO_RESET_STATUS);
+ } while (--timeout &&
+ (val & JUNO_RESET_STATUS_MASK) != JUNO_RESET_STATUS_MASK);
+
+ if (!timeout) {
+ printf("PCI XR3 Root complex reset timed out\n");
+ return;
+ }
+
+ /* Wait for the link to train */
+ mdelay(20);
+ timeout = 20;
+
+ do {
+ mdelay(1);
+ val = readl(XR3_CONFIG_BASE + XR3PCI_BASIC_STATUS);
+ } while (--timeout && !(val & XR3PCI_BS_LINK_MASK));
+
+ if (!(val & XR3PCI_BS_LINK_MASK)) {
+ printf("Failed to negotiate a link!\n");
+ return;
+ }
+
+ printf("PCIe XR3 Host Bridge enabled: x%d link (Gen %d)\n",
+ val & XR3PCI_BS_LINK_MASK, (val & XR3PCI_BS_GEN_MASK) >> 8);
+
+ xr3pci_setup_atr();
+}
+
+void vexpress64_pcie_init(void)
+{
+#ifdef CONFIG_TARGET_VEXPRESS64_JUNO
+ xr3pci_init();
+#endif
+}
diff --git a/board/armltd/vexpress64/pcie.h b/board/armltd/vexpress64/pcie.h
new file mode 100644
index 0000000..1f923b7
--- /dev/null
+++ b/board/armltd/vexpress64/pcie.h
@@ -0,0 +1,12 @@
+#ifndef __VEXPRESS64_PCIE_H__
+#define __VEXPRESS64_PCIE_H__
+
+#ifdef CONFIG_TARGET_VEXPRESS64_JUNO
+void vexpress64_pcie_init(void);
+#else
+static inline void vexpress64_pcie_init(void)
+{
+}
+#endif
+
+#endif /* __VEXPRESS64_PCIE_H__ */
diff --git a/board/armltd/vexpress64/vexpress64.c b/board/armltd/vexpress64/vexpress64.c
index 6df9d60..f4e8084 100644
--- a/board/armltd/vexpress64/vexpress64.c
+++ b/board/armltd/vexpress64/vexpress64.c
@@ -13,6 +13,7 @@
#include <linux/compiler.h>
#include <dm/platdata.h>
#include <dm/platform_data/serial_pl01x.h>
+#include "pcie.h"
DECLARE_GLOBAL_DATA_PTR;
@@ -29,6 +30,7 @@ U_BOOT_DEVICE(vexpress_serials) = {
int board_init(void)
{
+ vexpress64_pcie_init();
return 0;
}
--
2.6.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge.
2015-10-19 10:08 ` [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge Liviu Dudau
@ 2015-10-19 10:27 ` Ryan Harkin
2015-10-20 0:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Ryan Harkin @ 2015-10-19 10:27 UTC (permalink / raw
To: u-boot
On 19 October 2015 at 11:08, Liviu Dudau <Liviu.Dudau@foss.arm.com> wrote:
> Juno R1 has an XpressRICH3 PCIe host bridge that needs to be initialised
> in order for the Linux kernel to be able to enumerate the bus. Add
> support code here that enables the host bridge, trains the links and
> sets up the Address Translation Tables.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@foss.arm.com>
> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
>
Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
---
> board/armltd/vexpress64/Makefile | 2 +-
> board/armltd/vexpress64/pcie.c | 197
> +++++++++++++++++++++++++++++++++++
> board/armltd/vexpress64/pcie.h | 12 +++
> board/armltd/vexpress64/vexpress64.c | 2 +
> 4 files changed, 212 insertions(+), 1 deletion(-)
> create mode 100644 board/armltd/vexpress64/pcie.c
> create mode 100644 board/armltd/vexpress64/pcie.h
>
> diff --git a/board/armltd/vexpress64/Makefile
> b/board/armltd/vexpress64/Makefile
> index e009141..a35db40 100644
> --- a/board/armltd/vexpress64/Makefile
> +++ b/board/armltd/vexpress64/Makefile
> @@ -5,4 +5,4 @@
> # SPDX-License-Identifier: GPL-2.0+
> #
>
> -obj-y := vexpress64.o
> +obj-y := vexpress64.o pcie.o
> diff --git a/board/armltd/vexpress64/pcie.c
> b/board/armltd/vexpress64/pcie.c
> new file mode 100644
> index 0000000..7b999e8
> --- /dev/null
> +++ b/board/armltd/vexpress64/pcie.c
> @@ -0,0 +1,197 @@
> +/*
> + * Copyright (C) ARM Ltd 2015
> + *
> + * Author: Liviu Dudau <Liviu.Dudau@arm.com>
> + *
> + * SPDX-Licence-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <linux/bitops.h>
> +#include <pci_ids.h>
> +#include "pcie.h"
> +
> +/* XpressRICH3 support */
> +#define XR3_CONFIG_BASE 0x7ff30000
> +#define XR3_RESET_BASE 0x7ff20000
> +
> +#define XR3_PCI_ECAM_START 0x40000000
> +#define XR3_PCI_ECAM_SIZE 28 /* as power of 2 =
> 0x10000000 */
> +#define XR3_PCI_IOSPACE_START 0x5f800000
> +#define XR3_PCI_IOSPACE_SIZE 23 /* as power of 2 =
> 0x800000 */
> +#define XR3_PCI_MEMSPACE_START 0x50000000
> +#define XR3_PCI_MEMSPACE_SIZE 27 /* as power of 2 =
> 0x8000000 */
> +#define XR3_PCI_MEMSPACE64_START 0x4000000000
> +#define XR3_PCI_MEMSPACE64_SIZE 33 /* as power of 2 =
> 0x200000000 */
> +
> +#define JUNO_V2M_MSI_START 0x2c1c0000
> +#define JUNO_V2M_MSI_SIZE 12 /* as power of 2 = 4096 */
> +
> +#define XR3PCI_BASIC_STATUS 0x18
> +#define XR3PCI_BS_GEN_MASK (0xf << 8)
> +#define XR3PCI_BS_LINK_MASK 0xff
> +
> +#define XR3PCI_VIRTCHAN_CREDITS 0x90
> +#define XR3PCI_BRIDGE_PCI_IDS 0x9c
> +#define XR3PCI_PEX_SPC2 0xd8
> +
> +#define XR3PCI_ATR_PCIE_WIN0 0x600
> +#define XR3PCI_ATR_PCIE_WIN1 0x700
> +#define XR3PCI_ATR_AXI4_SLV0 0x800
> +
> +#define XR3PCI_ATR_TABLE_SIZE 0x20
> +#define XR3PCI_ATR_SRC_ADDR_LOW 0x0
> +#define XR3PCI_ATR_SRC_ADDR_HIGH 0x4
> +#define XR3PCI_ATR_TRSL_ADDR_LOW 0x8
> +#define XR3PCI_ATR_TRSL_ADDR_HIGH 0xc
> +#define XR3PCI_ATR_TRSL_PARAM 0x10
> +
> +/* IDs used in the XR3PCI_ATR_TRSL_PARAM */
> +#define XR3PCI_ATR_TRSLID_AXIDEVICE (0x420004)
> +#define XR3PCI_ATR_TRSLID_AXIMEMORY (0x4e0004) /* Write-through,
> read/write allocate */
> +#define XR3PCI_ATR_TRSLID_PCIE_CONF (0x000001)
> +#define XR3PCI_ATR_TRSLID_PCIE_IO (0x020000)
> +#define XR3PCI_ATR_TRSLID_PCIE_MEMORY (0x000000)
> +
> +#define XR3PCI_ECAM_OFFSET(b, d, o) (((b) << 20) | \
> + (PCI_SLOT(d) << 15) | \
> + (PCI_FUNC(d) << 12) | o)
> +
> +#define JUNO_RESET_CTRL 0x1004
> +#define JUNO_RESET_CTRL_PHY BIT(0)
> +#define JUNO_RESET_CTRL_RC BIT(1)
> +
> +#define JUNO_RESET_STATUS 0x1008
> +#define JUNO_RESET_STATUS_PLL BIT(0)
> +#define JUNO_RESET_STATUS_PHY BIT(1)
> +#define JUNO_RESET_STATUS_RC BIT(2)
> +#define JUNO_RESET_STATUS_MASK (JUNO_RESET_STATUS_PLL | \
> + JUNO_RESET_STATUS_PHY | \
> + JUNO_RESET_STATUS_RC)
> +
> +void xr3pci_set_atr_entry(unsigned long base, unsigned long src_addr,
> + unsigned long trsl_addr, int window_size,
> + int trsl_param)
> +{
> + /* X3PCI_ATR_SRC_ADDR_LOW:
> + - bit 0: enable entry,
> + - bits 1-6: ATR window size: total size in bytes:
> 2^(ATR_WSIZE + 1)
> + - bits 7-11: reserved
> + - bits 12-31: start of source address
> + */
> + writel((u32)(src_addr & 0xfffff000) | (window_size - 1) << 1 | 1,
> + base + XR3PCI_ATR_SRC_ADDR_LOW);
> + writel((u32)(src_addr >> 32), base + XR3PCI_ATR_SRC_ADDR_HIGH);
> + writel((u32)(trsl_addr & 0xfffff000), base +
> XR3PCI_ATR_TRSL_ADDR_LOW);
> + writel((u32)(trsl_addr >> 32), base + XR3PCI_ATR_TRSL_ADDR_HIGH);
> + writel(trsl_param, base + XR3PCI_ATR_TRSL_PARAM);
> +
> + printf("ATR entry: 0x%010lx %s 0x%010lx [0x%010llx] (param:
> 0x%06x)\n",
> + src_addr, (trsl_param & 0x400000) ? "<-" : "->", trsl_addr,
> + ((u64)1) << window_size, trsl_param);
> +}
> +
> +void xr3pci_setup_atr(void)
> +{
> + /* setup PCIe to CPU address translation tables */
> + unsigned long base = XR3_CONFIG_BASE + XR3PCI_ATR_PCIE_WIN0;
> +
> + /* forward all writes from PCIe to GIC V2M (used for MSI) */
> + xr3pci_set_atr_entry(base, JUNO_V2M_MSI_START, JUNO_V2M_MSI_START,
> + JUNO_V2M_MSI_SIZE,
> XR3PCI_ATR_TRSLID_AXIDEVICE);
> +
> + base += XR3PCI_ATR_TABLE_SIZE;
> +
> + /* PCIe devices can write anywhere in memory */
> + xr3pci_set_atr_entry(base, PHYS_SDRAM_1, PHYS_SDRAM_1,
> + 31 /* grant access to all RAM under 4GB */,
> + XR3PCI_ATR_TRSLID_AXIMEMORY);
> + base += XR3PCI_ATR_TABLE_SIZE;
> + xr3pci_set_atr_entry(base, PHYS_SDRAM_2, PHYS_SDRAM_2,
> + XR3_PCI_MEMSPACE64_SIZE,
> + XR3PCI_ATR_TRSLID_AXIMEMORY);
> +
> +
> + /* setup CPU to PCIe address translation table */
> + base = XR3_CONFIG_BASE + XR3PCI_ATR_AXI4_SLV0;
> +
> + /* setup ECAM space to bus configuration interface */
> + xr3pci_set_atr_entry(base, XR3_PCI_ECAM_START, 0,
> XR3_PCI_ECAM_SIZE,
> + XR3PCI_ATR_TRSLID_PCIE_CONF);
> +
> + base += XR3PCI_ATR_TABLE_SIZE;
> +
> + /* setup IO space translation */
> + xr3pci_set_atr_entry(base, XR3_PCI_IOSPACE_START,
> XR3_PCI_IOSPACE_START,
> + XR3_PCI_IOSPACE_SIZE,
> XR3PCI_ATR_TRSLID_PCIE_IO);
> +
> + base += XR3PCI_ATR_TABLE_SIZE;
> +
> + /* setup 32bit MEM space translation */
> + xr3pci_set_atr_entry(base, XR3_PCI_MEMSPACE_START,
> XR3_PCI_MEMSPACE_START,
> + XR3_PCI_MEMSPACE_SIZE,
> XR3PCI_ATR_TRSLID_PCIE_MEMORY);
> +
> + base += XR3PCI_ATR_TABLE_SIZE;
> +
> + /* setup 64bit MEM space translation */
> + xr3pci_set_atr_entry(base, XR3_PCI_MEMSPACE64_START,
> XR3_PCI_MEMSPACE64_START,
> + XR3_PCI_MEMSPACE64_SIZE,
> XR3PCI_ATR_TRSLID_PCIE_MEMORY);
> +}
> +
> +void xr3pci_init(void)
> +{
> + u32 val;
> + int timeout = 200;
> +
> + /* Initialise the XpressRICH3 PCIe host bridge */
> +
> + /* add credits */
> + writel(0x00f0b818, XR3_CONFIG_BASE + XR3PCI_VIRTCHAN_CREDITS);
> + writel(0x1, XR3_CONFIG_BASE + XR3PCI_VIRTCHAN_CREDITS + 4);
> + /* allow ECRC */
> + writel(0x6006, XR3_CONFIG_BASE + XR3PCI_PEX_SPC2);
> + /* setup the correct class code for the host bridge */
> + writel(PCI_CLASS_BRIDGE_PCI << 16, XR3_CONFIG_BASE +
> XR3PCI_BRIDGE_PCI_IDS);
> +
> + /* reset phy and root complex */
> + writel(JUNO_RESET_CTRL_PHY | JUNO_RESET_CTRL_RC,
> + XR3_RESET_BASE + JUNO_RESET_CTRL);
> +
> + do {
> + mdelay(1);
> + val = readl(XR3_RESET_BASE + JUNO_RESET_STATUS);
> + } while (--timeout &&
> + (val & JUNO_RESET_STATUS_MASK) != JUNO_RESET_STATUS_MASK);
> +
> + if (!timeout) {
> + printf("PCI XR3 Root complex reset timed out\n");
> + return;
> + }
> +
> + /* Wait for the link to train */
> + mdelay(20);
> + timeout = 20;
> +
> + do {
> + mdelay(1);
> + val = readl(XR3_CONFIG_BASE + XR3PCI_BASIC_STATUS);
> + } while (--timeout && !(val & XR3PCI_BS_LINK_MASK));
> +
> + if (!(val & XR3PCI_BS_LINK_MASK)) {
> + printf("Failed to negotiate a link!\n");
> + return;
> + }
> +
> + printf("PCIe XR3 Host Bridge enabled: x%d link (Gen %d)\n",
> + val & XR3PCI_BS_LINK_MASK, (val & XR3PCI_BS_GEN_MASK) >> 8);
> +
> + xr3pci_setup_atr();
> +}
> +
> +void vexpress64_pcie_init(void)
> +{
> +#ifdef CONFIG_TARGET_VEXPRESS64_JUNO
> + xr3pci_init();
> +#endif
> +}
> diff --git a/board/armltd/vexpress64/pcie.h
> b/board/armltd/vexpress64/pcie.h
> new file mode 100644
> index 0000000..1f923b7
> --- /dev/null
> +++ b/board/armltd/vexpress64/pcie.h
> @@ -0,0 +1,12 @@
> +#ifndef __VEXPRESS64_PCIE_H__
> +#define __VEXPRESS64_PCIE_H__
> +
> +#ifdef CONFIG_TARGET_VEXPRESS64_JUNO
> +void vexpress64_pcie_init(void);
> +#else
> +static inline void vexpress64_pcie_init(void)
> +{
> +}
> +#endif
> +
> +#endif /* __VEXPRESS64_PCIE_H__ */
> diff --git a/board/armltd/vexpress64/vexpress64.c
> b/board/armltd/vexpress64/vexpress64.c
> index 6df9d60..f4e8084 100644
> --- a/board/armltd/vexpress64/vexpress64.c
> +++ b/board/armltd/vexpress64/vexpress64.c
> @@ -13,6 +13,7 @@
> #include <linux/compiler.h>
> #include <dm/platdata.h>
> #include <dm/platform_data/serial_pl01x.h>
> +#include "pcie.h"
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -29,6 +30,7 @@ U_BOOT_DEVICE(vexpress_serials) = {
>
> int board_init(void)
> {
> + vexpress64_pcie_init();
> return 0;
> }
>
> --
> 2.6.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-Boot, v3, 1/2] vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel.
2015-10-19 10:08 ` [U-Boot] [PATCH v3 1/2] vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel Liviu Dudau
@ 2015-10-20 0:07 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2015-10-20 0:07 UTC (permalink / raw
To: u-boot
On Mon, Oct 19, 2015 at 11:08:31AM +0100, Liviu Dudau wrote:
> Juno comes with 8GB RAM, but U-Boot only passes 2GB to the kernel.
> Declare a secondary memory bank and set the sizes correctly.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@foss.arm.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151019/16d30eb4/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-Boot, v3, 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge.
2015-10-19 10:08 ` [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge Liviu Dudau
2015-10-19 10:27 ` Ryan Harkin
@ 2015-10-20 0:07 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2015-10-20 0:07 UTC (permalink / raw
To: u-boot
On Mon, Oct 19, 2015 at 11:08:32AM +0100, Liviu Dudau wrote:
> Juno R1 has an XpressRICH3 PCIe host bridge that needs to be initialised
> in order for the Linux kernel to be able to enumerate the bus. Add
> support code here that enables the host bridge, trains the links and
> sets up the Address Translation Tables.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@foss.arm.com>
> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>
After tweaking so we always have the same prototype for
vexpress64_pcie_init,
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151019/e476ac42/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-20 0:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-19 10:08 [U-Boot] [PATCH v3 0/2] vexpress64: Juno: Add support for PCIe on Juno Liviu Dudau
2015-10-19 10:08 ` [U-Boot] [PATCH v3 1/2] vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel Liviu Dudau
2015-10-20 0:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-10-19 10:08 ` [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge Liviu Dudau
2015-10-19 10:27 ` Ryan Harkin
2015-10-20 0:07 ` [U-Boot] [U-Boot, v3, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.