* [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes
@ 2015-07-21 9:36 Mirza Krak
2015-07-21 15:56 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Mirza Krak @ 2015-07-21 9:36 UTC (permalink / raw
To: u-boot
From: Mirza Krak <mirza.krak@hostmobility.com>
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
---
Changes in v2:
* Dropped tegra30-slink compatible string, based on comment from Thierry Reding on v1 patch
arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
index b8c8a923017e..e4d7c7a83473 100644
--- a/arch/arm/dts/tegra20.dtsi
+++ b/arch/arm/dts/tegra20.dtsi
@@ -268,6 +268,50 @@
#pwm-cells = <2>;
};
+ spi at 7000d400 {
+ compatible = "nvidia,tegra20-slink";
+ reg = <0x7000d400 0x200>;
+ interrupts = <0 59 0x04>;
+ nvidia,dma-request-selector = <&apbdma 15>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 41>;
+ status = "disabled";
+ };
+
+ spi at 7000d600 {
+ compatible = "nvidia,tegra20-slink";
+ reg = <0x7000d600 0x200>;
+ interrupts = <0 82 0x04>;
+ nvidia,dma-request-selector = <&apbdma 16>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 44>;
+ status = "disabled";
+ };
+
+ spi at 7000d800 {
+ compatible = "nvidia,tegra20-slink";
+ reg = <0x7000d480 0x200>;
+ interrupts = <0 83 0x04>;
+ nvidia,dma-request-selector = <&apbdma 17>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 46>;
+ status = "disabled";
+ };
+
+ spi at 7000da00 {
+ compatible = "nvidia,tegra20-slink";
+ reg = <0x7000da00 0x200>;
+ interrupts = <0 93 0x04>;
+ nvidia,dma-request-selector = <&apbdma 18>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car 68>;
+ status = "disabled";
+ };
+
i2c at 7000c000 {
#address-cells = <1>;
#size-cells = <0>;
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes
2015-07-21 9:36 [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes Mirza Krak
@ 2015-07-21 15:56 ` Stephen Warren
2015-07-21 20:28 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2015-07-21 15:56 UTC (permalink / raw
To: u-boot
On 07/21/2015 03:36 AM, Mirza Krak wrote:
> From: Mirza Krak <mirza.krak@hostmobility.com>
>
> Add the device tree node for the SPI controllers found on Tegra20 SOCs.
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> + spi at 7000d400 {
> + compatible = "nvidia,tegra20-slink";
> + reg = <0x7000d400 0x200>;
> + interrupts = <0 59 0x04>;
> + nvidia,dma-request-selector = <&apbdma 15>;
That property doesn't seem to exist in the kernel DT, and "resets",
"reset-names", "dmas", "dma-names" are missing. I'd suggest simply
cutting/pasting from the kernel DT to make sure they stay in sync.
interrupts and clocks should also use the #defines to provide named
constants for better readability and the same consistency reasons.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes
2015-07-21 15:56 ` Stephen Warren
@ 2015-07-21 20:28 ` Simon Glass
2015-07-21 20:39 ` Mirza Krak
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2015-07-21 20:28 UTC (permalink / raw
To: u-boot
Hi,
On 21 July 2015 at 09:56, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 07/21/2015 03:36 AM, Mirza Krak wrote:
>>
>> From: Mirza Krak <mirza.krak@hostmobility.com>
>>
>> Add the device tree node for the SPI controllers found on Tegra20 SOCs.
>
>
>> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
>
>
>> + spi at 7000d400 {
>> + compatible = "nvidia,tegra20-slink";
>> + reg = <0x7000d400 0x200>;
>> + interrupts = <0 59 0x04>;
>> + nvidia,dma-request-selector = <&apbdma 15>;
>
>
> That property doesn't seem to exist in the kernel DT, and "resets",
> "reset-names", "dmas", "dma-names" are missing. I'd suggest simply
> cutting/pasting from the kernel DT to make sure they stay in sync.
>
> interrupts and clocks should also use the #defines to provide named
> constants for better readability and the same consistency reasons.
Also it's pretty easy to just copy over the kernel files. They should just work!
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes
2015-07-21 20:28 ` Simon Glass
@ 2015-07-21 20:39 ` Mirza Krak
0 siblings, 0 replies; 4+ messages in thread
From: Mirza Krak @ 2015-07-21 20:39 UTC (permalink / raw
To: u-boot
2015-07-21 22:28 GMT+02:00 Simon Glass <sjg@chromium.org>:
>
> Hi
>
> Also it's pretty easy to just copy over the kernel files. They should just work!
>
> Regards,
> Simon
Ok, will give it a go then.
--
Med V?nliga H?lsningar / Best Regards
*******************************************************************
Mirza Krak
Host Mobility AB
mirza.krak at hostmobility.com
Anders Personsgatan 12, 416 64 G?teborg
Sweden
http://www.hostmobility.com
Direct: +46 31 31 32 704
Phone: +46 31 31 32 700
Fax: +46 31 80 67 51
Mobile: +46 730 28 06 22
*******************************************************************
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-21 20:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-21 9:36 [U-Boot] [PATCH v2] ARM: tegra: Add Tegra20 SPI device nodes Mirza Krak
2015-07-21 15:56 ` Stephen Warren
2015-07-21 20:28 ` Simon Glass
2015-07-21 20:39 ` Mirza Krak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.