All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] openssl: always install openssl.cnf
@ 2015-05-25 17:20 Floris Bos
  2015-05-25 17:20 ` [Buildroot] [PATCH] postgresql: init script: wait till server has started Floris Bos
  2015-07-10 16:08 ` [Buildroot] [PATCH] openssl: always install openssl.cnf Thomas Petazzoni
  0 siblings, 2 replies; 5+ messages in thread
From: Floris Bos @ 2015-05-25 17:20 UTC (permalink / raw
  To: buildroot

Install openssl.cnf even when the OpenSSL binary is not selected,
because other packages that use the OpenSSL library may use it as
well.

E.g. PHP's methods to programmatically create private keys and
certificates depend on it.
See: http://php.net/manual/en/function.openssl-pkey-new.php

Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
---
 package/openssl/openssl.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
index f90c811..9cbf42d 100644
--- a/package/openssl/openssl.mk
+++ b/package/openssl/openssl.mk
@@ -19,7 +19,13 @@ define OPENSSL_DISABLE_APPS
 	$(SED) '/^build_apps/! s/build_apps//' $(@D)/Makefile.org
 	$(SED) '/^DIRS=/ s/apps//' $(@D)/Makefile.org
 endef
+# Do always install openssl.cnf as other packages may depend on it
+define OPENSSL_INSTALL_CNF
+	$(INSTALL) -m 0644 $(@D)/apps/openssl.cnf \
+		$(TARGET_DIR)/etc/ssl/openssl.cnf
+endef
 OPENSSL_PRE_CONFIGURE_HOOKS += OPENSSL_DISABLE_APPS
+OPENSSL_POST_INSTALL_TARGET_HOOKS += OPENSSL_INSTALL_CNF
 endif
 
 ifeq ($(BR2_PACKAGE_CRYPTODEV_LINUX),y)
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] postgresql: init script: wait till server has started
  2015-05-25 17:20 [Buildroot] [PATCH] openssl: always install openssl.cnf Floris Bos
@ 2015-05-25 17:20 ` Floris Bos
  2015-07-10 21:54   ` Yann E. MORIN
  2015-07-11  7:27   ` Thomas Petazzoni
  2015-07-10 16:08 ` [Buildroot] [PATCH] openssl: always install openssl.cnf Thomas Petazzoni
  1 sibling, 2 replies; 5+ messages in thread
From: Floris Bos @ 2015-05-25 17:20 UTC (permalink / raw
  To: buildroot

Adds "-w" option to init script to wait till the database server
has fully started and accepts connections before continuing.

Prevents other applications that depend on PostgreSQL from
failing to start, if the database server is not ready yet.
Times out after 60 seconds by default.

Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
---
 package/postgresql/S50postgresql | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/postgresql/S50postgresql b/package/postgresql/S50postgresql
index 86a8d83..a895bcf 100644
--- a/package/postgresql/S50postgresql
+++ b/package/postgresql/S50postgresql
@@ -13,7 +13,7 @@ fi
 
 start() {
 	echo -n "Starting postgresql: "
-	su - postgres -c '/usr/bin/pg_ctl start -D /var/lib/pgsql -l logfile'
+	su - postgres -c '/usr/bin/pg_ctl start -w -D /var/lib/pgsql -l logfile'
 	echo "OK"
 }
 stop() {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] openssl: always install openssl.cnf
  2015-05-25 17:20 [Buildroot] [PATCH] openssl: always install openssl.cnf Floris Bos
  2015-05-25 17:20 ` [Buildroot] [PATCH] postgresql: init script: wait till server has started Floris Bos
@ 2015-07-10 16:08 ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-07-10 16:08 UTC (permalink / raw
  To: buildroot

Dear Floris Bos,

On Mon, 25 May 2015 19:20:25 +0200, Floris Bos wrote:
> Install openssl.cnf even when the OpenSSL binary is not selected,
> because other packages that use the OpenSSL library may use it as
> well.
> 
> E.g. PHP's methods to programmatically create private keys and
> certificates depend on it.
> See: http://php.net/manual/en/function.openssl-pkey-new.php
> 
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> ---
>  package/openssl/openssl.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

I've marked this patch as Superseded, because since commit
http://git.buildroot.net/buildroot/commit/package/openssl?id=a7bc0b96233900a4f36cbb333c12ad64b03f8db9,
the openssl.conf file is always installed.

Let me know if that doesn't work for you.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] postgresql: init script: wait till server has started
  2015-05-25 17:20 ` [Buildroot] [PATCH] postgresql: init script: wait till server has started Floris Bos
@ 2015-07-10 21:54   ` Yann E. MORIN
  2015-07-11  7:27   ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2015-07-10 21:54 UTC (permalink / raw
  To: buildroot

Floris, All,

On 2015-05-25 19:20 +0200, Floris Bos spake thusly:
> Adds "-w" option to init script to wait till the database server
> has fully started and accepts connections before continuing.
> 
> Prevents other applications that depend on PostgreSQL from
> failing to start, if the database server is not ready yet.
> Times out after 60 seconds by default.
> 
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/postgresql/S50postgresql | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/postgresql/S50postgresql b/package/postgresql/S50postgresql
> index 86a8d83..a895bcf 100644
> --- a/package/postgresql/S50postgresql
> +++ b/package/postgresql/S50postgresql
> @@ -13,7 +13,7 @@ fi
>  
>  start() {
>  	echo -n "Starting postgresql: "
> -	su - postgres -c '/usr/bin/pg_ctl start -D /var/lib/pgsql -l logfile'
> +	su - postgres -c '/usr/bin/pg_ctl start -w -D /var/lib/pgsql -l logfile'
>  	echo "OK"
>  }
>  stop() {
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH] postgresql: init script: wait till server has started
  2015-05-25 17:20 ` [Buildroot] [PATCH] postgresql: init script: wait till server has started Floris Bos
  2015-07-10 21:54   ` Yann E. MORIN
@ 2015-07-11  7:27   ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-07-11  7:27 UTC (permalink / raw
  To: buildroot

Dear Floris Bos,

On Mon, 25 May 2015 19:20:26 +0200, Floris Bos wrote:
> Adds "-w" option to init script to wait till the database server
> has fully started and accepts connections before continuing.
> 
> Prevents other applications that depend on PostgreSQL from
> failing to start, if the database server is not ready yet.
> Times out after 60 seconds by default.
> 
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> ---
>  package/postgresql/S50postgresql | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-07-11  7:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-25 17:20 [Buildroot] [PATCH] openssl: always install openssl.cnf Floris Bos
2015-05-25 17:20 ` [Buildroot] [PATCH] postgresql: init script: wait till server has started Floris Bos
2015-07-10 21:54   ` Yann E. MORIN
2015-07-11  7:27   ` Thomas Petazzoni
2015-07-10 16:08 ` [Buildroot] [PATCH] openssl: always install openssl.cnf Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.