* [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-11-28 10:10 ` Madalin Bucur
0 siblings, 0 replies; 12+ messages in thread
From: Madalin Bucur @ 2014-11-28 10:10 UTC (permalink / raw
To: devicetree, linuxppc-dev, netdev
Cc: scottwood, Emilian.Medve, Igal.Liberman, Madalin Bucur
Add the device tree binding document for the DPAA corenet node
and DPAA Ethernet nodes.
Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
---
Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
new file mode 100644
index 0000000..822c668
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
@@ -0,0 +1,31 @@
+*DPAA corenet
+
+The corenet bus containing all DPAA Ethernet nodes.
+
+Required property
+ - compatible: string property. Must include "fsl,dpaa". Can include
+ also "fsl,<SoC>-dpaa".
+
+Example:
+
+fsl,dpaa {
+ compatible = "fsl,p4080-dpaa", "fsl,dpaa";
+};
+
+*DPAA Ethernet
+
+DPAA Ethernet implements an Ethernet interface on top of the functionality
+offered by the DPAA accelerators: QMan, BMan, FMan. It contains a reference
+to the FMan MAC node used (dTSEC, TGEC, MEMAC). This construct is used by
+u-boot for the boot-time device tree fix-up.
+
+Required properties
+ - compatible: standard string property. Must include "fsl,dpa-ethernet".
+ - fsl,fman-mac: phandle that references a node describing the used DPAA MAC.
+
+Example:
+
+ethernet0 {
+ compatible = "fsl,dpa-ethernet";
+ fsl,fman-mac = <&enet0>;
+};
--
1.7.11.7
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-11-28 10:10 ` Madalin Bucur
0 siblings, 0 replies; 12+ messages in thread
From: Madalin Bucur @ 2014-11-28 10:10 UTC (permalink / raw
To: devicetree, linuxppc-dev, netdev
Cc: scottwood, Emilian.Medve, Igal.Liberman, Madalin Bucur
Add the device tree binding document for the DPAA corenet node
and DPAA Ethernet nodes.
Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
---
Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
new file mode 100644
index 0000000..822c668
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
@@ -0,0 +1,31 @@
+*DPAA corenet
+
+The corenet bus containing all DPAA Ethernet nodes.
+
+Required property
+ - compatible: string property. Must include "fsl,dpaa". Can include
+ also "fsl,<SoC>-dpaa".
+
+Example:
+
+fsl,dpaa {
+ compatible = "fsl,p4080-dpaa", "fsl,dpaa";
+};
+
+*DPAA Ethernet
+
+DPAA Ethernet implements an Ethernet interface on top of the functionality
+offered by the DPAA accelerators: QMan, BMan, FMan. It contains a reference
+to the FMan MAC node used (dTSEC, TGEC, MEMAC). This construct is used by
+u-boot for the boot-time device tree fix-up.
+
+Required properties
+ - compatible: standard string property. Must include "fsl,dpa-ethernet".
+ - fsl,fman-mac: phandle that references a node describing the used DPAA MAC.
+
+Example:
+
+ethernet0 {
+ compatible = "fsl,dpa-ethernet";
+ fsl,fman-mac = <&enet0>;
+};
--
1.7.11.7
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-11-28 10:10 ` Madalin Bucur
0 siblings, 0 replies; 12+ messages in thread
From: Madalin Bucur @ 2014-11-28 10:10 UTC (permalink / raw
To: devicetree, linuxppc-dev, netdev
Cc: scottwood, Igal.Liberman, Emilian.Medve, Madalin Bucur
Add the device tree binding document for the DPAA corenet node
and DPAA Ethernet nodes.
Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
---
Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
new file mode 100644
index 0000000..822c668
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
@@ -0,0 +1,31 @@
+*DPAA corenet
+
+The corenet bus containing all DPAA Ethernet nodes.
+
+Required property
+ - compatible: string property. Must include "fsl,dpaa". Can include
+ also "fsl,<SoC>-dpaa".
+
+Example:
+
+fsl,dpaa {
+ compatible = "fsl,p4080-dpaa", "fsl,dpaa";
+};
+
+*DPAA Ethernet
+
+DPAA Ethernet implements an Ethernet interface on top of the functionality
+offered by the DPAA accelerators: QMan, BMan, FMan. It contains a reference
+to the FMan MAC node used (dTSEC, TGEC, MEMAC). This construct is used by
+u-boot for the boot-time device tree fix-up.
+
+Required properties
+ - compatible: standard string property. Must include "fsl,dpa-ethernet".
+ - fsl,fman-mac: phandle that references a node describing the used DPAA MAC.
+
+Example:
+
+ethernet0 {
+ compatible = "fsl,dpa-ethernet";
+ fsl,fman-mac = <&enet0>;
+};
--
1.7.11.7
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Documentation: bindings: net: DPAA corenet binding document
2014-11-28 10:10 ` Madalin Bucur
(?)
@ 2014-12-02 4:39 ` Scott Wood
-1 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2014-12-02 4:39 UTC (permalink / raw
To: madalin.bucur
Cc: devicetree, linuxppc-dev, netdev, Emilian.Medve, Igal.Liberman
On Fri, 2014-11-28 at 12:10 +0200, Madalin Bucur wrote:
> Add the device tree binding document for the DPAA corenet node
> and DPAA Ethernet nodes.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> ---
> Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
>
> diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> new file mode 100644
> index 0000000..822c668
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> @@ -0,0 +1,31 @@
> +*DPAA corenet
> +
> +The corenet bus containing all DPAA Ethernet nodes.
What does this have to do with corenet?
> +Required property
> + - compatible: string property. Must include "fsl,dpaa". Can include
> + also "fsl,<SoC>-dpaa".
No need for the <SoC> part. As we previously discussed, the only
purpose of this node is backwards compatibility with the U-Boot MAC
address fixup -- if U-Boot doesn't look for the <SoC> version, then
don't complicate things.
Though, I can't find where U-Boot references this node. Are you sure
it's not using the ethernet%d aliases like everything else, in which
case why do we need this node at all?
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-12-02 4:39 ` Scott Wood
0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2014-12-02 4:39 UTC (permalink / raw
To: madalin.bucur
Cc: devicetree, linuxppc-dev, netdev, Emilian.Medve, Igal.Liberman
On Fri, 2014-11-28 at 12:10 +0200, Madalin Bucur wrote:
> Add the device tree binding document for the DPAA corenet node
> and DPAA Ethernet nodes.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> ---
> Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
>
> diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> new file mode 100644
> index 0000000..822c668
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> @@ -0,0 +1,31 @@
> +*DPAA corenet
> +
> +The corenet bus containing all DPAA Ethernet nodes.
What does this have to do with corenet?
> +Required property
> + - compatible: string property. Must include "fsl,dpaa". Can include
> + also "fsl,<SoC>-dpaa".
No need for the <SoC> part. As we previously discussed, the only
purpose of this node is backwards compatibility with the U-Boot MAC
address fixup -- if U-Boot doesn't look for the <SoC> version, then
don't complicate things.
Though, I can't find where U-Boot references this node. Are you sure
it's not using the ethernet%d aliases like everything else, in which
case why do we need this node at all?
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-12-02 4:39 ` Scott Wood
0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2014-12-02 4:39 UTC (permalink / raw
To: madalin.bucur
Cc: devicetree, linuxppc-dev, Igal.Liberman, Emilian.Medve, netdev
On Fri, 2014-11-28 at 12:10 +0200, Madalin Bucur wrote:
> Add the device tree binding document for the DPAA corenet node
> and DPAA Ethernet nodes.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> ---
> Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
>
> diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> new file mode 100644
> index 0000000..822c668
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> @@ -0,0 +1,31 @@
> +*DPAA corenet
> +
> +The corenet bus containing all DPAA Ethernet nodes.
What does this have to do with corenet?
> +Required property
> + - compatible: string property. Must include "fsl,dpaa". Can include
> + also "fsl,<SoC>-dpaa".
No need for the <SoC> part. As we previously discussed, the only
purpose of this node is backwards compatibility with the U-Boot MAC
address fixup -- if U-Boot doesn't look for the <SoC> version, then
don't complicate things.
Though, I can't find where U-Boot references this node. Are you sure
it's not using the ethernet%d aliases like everything else, in which
case why do we need this node at all?
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] Documentation: bindings: net: DPAA corenet binding document
2014-12-02 4:39 ` Scott Wood
@ 2014-12-02 12:12 ` Madalin-Cristian Bucur
-1 siblings, 0 replies; 12+ messages in thread
From: Madalin-Cristian Bucur @ 2014-12-02 12:12 UTC (permalink / raw
To: Scott Wood
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, Emilian Medve,
Igal.Liberman@freescale.com, galak@codeaurora.org,
linuxppc-dev@lists.ozlabs.org
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, December 02, 2014 6:40 AM
> On Fri, 2014-11-28 at 12:10 +0200, Madalin Bucur wrote:
> > Add the device tree binding document for the DPAA corenet node
> > and DPAA Ethernet nodes.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> > ---
> > Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31
> ++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > new file mode 100644
> > index 0000000..822c668
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > @@ -0,0 +1,31 @@
> > +*DPAA corenet
> > +
> > +The corenet bus containing all DPAA Ethernet nodes.
>
> What does this have to do with corenet?
>
The corenet-generic platform code uses this compatible. Here are some excerpts
from the platform code found in SDK arch/powerpc/platforms/85xx/corenet_generic.c
...
* Corenet based SoC DS Setup
*
* Maintained by Kumar Gala (see MAINTAINERS for contact information)
*
* Copyright 2009-2011 Freescale Semiconductor Inc.
...
static const struct of_device_id of_device_ids[] = {
{
.compatible = "simple-bus"
},
{
.compatible = "fsl,dpaa"
},
...
int __init corenet_gen_publish_devices(void)
{
return of_platform_bus_probe(NULL, of_device_ids, NULL);
}
...
> > +Required property
> > + - compatible: string property. Must include "fsl,dpaa". Can include
> > + also "fsl,<SoC>-dpaa".
>
> No need for the <SoC> part. As we previously discussed, the only
> purpose of this node is backwards compatibility with the U-Boot MAC
> address fixup -- if U-Boot doesn't look for the <SoC> version, then
> don't complicate things.
>
> Though, I can't find where U-Boot references this node. Are you sure
> it's not using the ethernet%d aliases like everything else, in which
> case why do we need this node at all?
>
> -Scott
>
The initial (Freescale SDK) binding document contained those compatibles,
not sure what the initial intent was for the <SoC> variants.
The "fsl,dpaa" node is of interest to the DPAA Ethernet because it is
the parent of the "fsl,dpa-ethernet" nodes.
Madalin
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-12-02 12:12 ` Madalin-Cristian Bucur
0 siblings, 0 replies; 12+ messages in thread
From: Madalin-Cristian Bucur @ 2014-12-02 12:12 UTC (permalink / raw
To: Scott Wood
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, Emilian Medve,
Igal.Liberman@freescale.com, galak@codeaurora.org,
linuxppc-dev@lists.ozlabs.org
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBUdWVzZGF5LCBEZWNlbWJlciAwMiwgMjAxNCA2OjQwIEFNDQo+IE9uIEZyaSwgMjAx
NC0xMS0yOCBhdCAxMjoxMCArMDIwMCwgTWFkYWxpbiBCdWN1ciB3cm90ZToNCj4gPiBBZGQgdGhl
IGRldmljZSB0cmVlIGJpbmRpbmcgZG9jdW1lbnQgZm9yIHRoZSBEUEFBIGNvcmVuZXQgbm9kZQ0K
PiA+IGFuZCBEUEFBIEV0aGVybmV0IG5vZGVzLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogTWFk
YWxpbiBCdWN1ciA8bWFkYWxpbi5idWN1ckBmcmVlc2NhbGUuY29tPg0KPiA+IC0tLQ0KPiA+ICBE
b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2ZzbC1kcGFhLnR4dCB8IDMxDQo+
ICsrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlv
bnMoKykNCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i
aW5kaW5ncy9uZXQvZnNsLWRwYWEudHh0DQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRh
dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9mc2wtZHBhYS50eHQNCj4gYi9Eb2N1bWVudGF0
aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2ZzbC1kcGFhLnR4dA0KPiA+IG5ldyBmaWxlIG1v
ZGUgMTAwNjQ0DQo+ID4gaW5kZXggMDAwMDAwMC4uODIyYzY2OA0KPiA+IC0tLSAvZGV2L251bGwN
Cj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2ZzbC1kcGFh
LnR4dA0KPiA+IEBAIC0wLDAgKzEsMzEgQEANCj4gPiArKkRQQUEgY29yZW5ldA0KPiA+ICsNCj4g
PiArVGhlIGNvcmVuZXQgYnVzIGNvbnRhaW5pbmcgYWxsIERQQUEgRXRoZXJuZXQgbm9kZXMuDQo+
IA0KPiBXaGF0IGRvZXMgdGhpcyBoYXZlIHRvIGRvIHdpdGggY29yZW5ldD8NCj4gDQpUaGUgY29y
ZW5ldC1nZW5lcmljIHBsYXRmb3JtIGNvZGUgdXNlcyB0aGlzIGNvbXBhdGlibGUuIEhlcmUgYXJl
IHNvbWUgZXhjZXJwdHMNCmZyb20gdGhlIHBsYXRmb3JtIGNvZGUgZm91bmQgaW4gU0RLIGFyY2gv
cG93ZXJwYy9wbGF0Zm9ybXMvODV4eC9jb3JlbmV0X2dlbmVyaWMuYw0KLi4uDQogKiBDb3JlbmV0
IGJhc2VkIFNvQyBEUyBTZXR1cA0KICoNCiAqIE1haW50YWluZWQgYnkgS3VtYXIgR2FsYSAoc2Vl
IE1BSU5UQUlORVJTIGZvciBjb250YWN0IGluZm9ybWF0aW9uKQ0KICoNCiAqIENvcHlyaWdodCAy
MDA5LTIwMTEgRnJlZXNjYWxlIFNlbWljb25kdWN0b3IgSW5jLg0KLi4uDQpzdGF0aWMgY29uc3Qg
c3RydWN0IG9mX2RldmljZV9pZCBvZl9kZXZpY2VfaWRzW10gPSB7DQogICAgICAgIHsNCiAgICAg
ICAgICAgICAgICAuY29tcGF0aWJsZSAgICAgPSAic2ltcGxlLWJ1cyINCiAgICAgICAgfSwNCiAg
ICAgICAgew0KICAgICAgICAgICAgICAgIC5jb21wYXRpYmxlICAgICA9ICJmc2wsZHBhYSINCiAg
ICAgICAgfSwNCi4uLg0KaW50IF9faW5pdCBjb3JlbmV0X2dlbl9wdWJsaXNoX2RldmljZXModm9p
ZCkNCnsNCiAgICAgICAgcmV0dXJuIG9mX3BsYXRmb3JtX2J1c19wcm9iZShOVUxMLCBvZl9kZXZp
Y2VfaWRzLCBOVUxMKTsNCn0NCi4uLg0KPiA+ICtSZXF1aXJlZCBwcm9wZXJ0eQ0KPiA+ICsgLSBj
b21wYXRpYmxlOiBzdHJpbmcgcHJvcGVydHkuICBNdXN0IGluY2x1ZGUgImZzbCxkcGFhIi4gQ2Fu
IGluY2x1ZGUNCj4gPiArICAgYWxzbyAiZnNsLDxTb0M+LWRwYWEiLg0KPiANCj4gTm8gbmVlZCBm
b3IgdGhlIDxTb0M+IHBhcnQuICBBcyB3ZSBwcmV2aW91c2x5IGRpc2N1c3NlZCwgdGhlIG9ubHkN
Cj4gcHVycG9zZSBvZiB0aGlzIG5vZGUgaXMgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgd2l0aCB0
aGUgVS1Cb290IE1BQw0KPiBhZGRyZXNzIGZpeHVwIC0tIGlmIFUtQm9vdCBkb2Vzbid0IGxvb2sg
Zm9yIHRoZSA8U29DPiB2ZXJzaW9uLCB0aGVuDQo+IGRvbid0IGNvbXBsaWNhdGUgdGhpbmdzLg0K
PiANCj4gVGhvdWdoLCBJIGNhbid0IGZpbmQgd2hlcmUgVS1Cb290IHJlZmVyZW5jZXMgdGhpcyBu
b2RlLiAgQXJlIHlvdSBzdXJlDQo+IGl0J3Mgbm90IHVzaW5nIHRoZSBldGhlcm5ldCVkIGFsaWFz
ZXMgbGlrZSBldmVyeXRoaW5nIGVsc2UsIGluIHdoaWNoDQo+IGNhc2Ugd2h5IGRvIHdlIG5lZWQg
dGhpcyBub2RlIGF0IGFsbD8NCj4gDQo+IC1TY290dA0KPiANCg0KVGhlIGluaXRpYWwgKEZyZWVz
Y2FsZSBTREspIGJpbmRpbmcgZG9jdW1lbnQgY29udGFpbmVkIHRob3NlIGNvbXBhdGlibGVzLA0K
bm90IHN1cmUgd2hhdCB0aGUgaW5pdGlhbCBpbnRlbnQgd2FzIGZvciB0aGUgPFNvQz4gdmFyaWFu
dHMuDQoNClRoZSAiZnNsLGRwYWEiIG5vZGUgaXMgb2YgaW50ZXJlc3QgdG8gdGhlIERQQUEgRXRo
ZXJuZXQgYmVjYXVzZSBpdCBpcw0KdGhlIHBhcmVudCBvZiB0aGUgImZzbCxkcGEtZXRoZXJuZXQi
IG5vZGVzLg0KDQpNYWRhbGluDQo=
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Documentation: bindings: net: DPAA corenet binding document
2014-12-02 12:12 ` Madalin-Cristian Bucur
@ 2014-12-02 23:03 ` Scott Wood
-1 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2014-12-02 23:03 UTC (permalink / raw
To: Bucur Madalin-Cristian-B32716
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Medve Emilian-EMMEDVE1, Liberman Igal-B31950,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
On Tue, 2014-12-02 at 06:12 -0600, Bucur Madalin-Cristian-B32716 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, December 02, 2014 6:40 AM
> > On Fri, 2014-11-28 at 12:10 +0200, Madalin Bucur wrote:
> > > Add the device tree binding document for the DPAA corenet node
> > > and DPAA Ethernet nodes.
> > >
> > > Signed-off-by: Madalin Bucur <madalin.bucur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > ---
> > > Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31
> > ++++++++++++++++++++++
> > > 1 file changed, 31 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > > new file mode 100644
> > > index 0000000..822c668
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > > @@ -0,0 +1,31 @@
> > > +*DPAA corenet
> > > +
> > > +The corenet bus containing all DPAA Ethernet nodes.
> >
> > What does this have to do with corenet?
> >
> The corenet-generic platform code uses this compatible.
That doesn't make it a "corenet bus". It's not a bus at all.
> > > +Required property
> > > + - compatible: string property. Must include "fsl,dpaa". Can include
> > > + also "fsl,<SoC>-dpaa".
> >
> > No need for the <SoC> part. As we previously discussed, the only
> > purpose of this node is backwards compatibility with the U-Boot MAC
> > address fixup -- if U-Boot doesn't look for the <SoC> version, then
> > don't complicate things.
> >
> > Though, I can't find where U-Boot references this node. Are you sure
> > it's not using the ethernet%d aliases like everything else, in which
> > case why do we need this node at all?
> >
> > -Scott
> >
>
> The initial (Freescale SDK) binding document contained those compatibles,
> not sure what the initial intent was for the <SoC> variants.
>
> The "fsl,dpaa" node is of interest to the DPAA Ethernet because it is
> the parent of the "fsl,dpa-ethernet" nodes.
I'm not interested in what the SDK binding says, or what the SDK kernel
does. I'm interested in whether there's a U-Boot compatibility issue,
as was previously alleged. If there isn't, then there's no need for
fsl,dpaa *or* fsl,dpa-ethernet.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-12-02 23:03 ` Scott Wood
0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2014-12-02 23:03 UTC (permalink / raw
To: Bucur Madalin-Cristian-B32716
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
Medve Emilian-EMMEDVE1, Liberman Igal-B31950,
galak@codeaurora.org, linuxppc-dev@lists.ozlabs.org
On Tue, 2014-12-02 at 06:12 -0600, Bucur Madalin-Cristian-B32716 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, December 02, 2014 6:40 AM
> > On Fri, 2014-11-28 at 12:10 +0200, Madalin Bucur wrote:
> > > Add the device tree binding document for the DPAA corenet node
> > > and DPAA Ethernet nodes.
> > >
> > > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> > > ---
> > > Documentation/devicetree/bindings/net/fsl-dpaa.txt | 31
> > ++++++++++++++++++++++
> > > 1 file changed, 31 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > > new file mode 100644
> > > index 0000000..822c668
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/fsl-dpaa.txt
> > > @@ -0,0 +1,31 @@
> > > +*DPAA corenet
> > > +
> > > +The corenet bus containing all DPAA Ethernet nodes.
> >
> > What does this have to do with corenet?
> >
> The corenet-generic platform code uses this compatible.
That doesn't make it a "corenet bus". It's not a bus at all.
> > > +Required property
> > > + - compatible: string property. Must include "fsl,dpaa". Can include
> > > + also "fsl,<SoC>-dpaa".
> >
> > No need for the <SoC> part. As we previously discussed, the only
> > purpose of this node is backwards compatibility with the U-Boot MAC
> > address fixup -- if U-Boot doesn't look for the <SoC> version, then
> > don't complicate things.
> >
> > Though, I can't find where U-Boot references this node. Are you sure
> > it's not using the ethernet%d aliases like everything else, in which
> > case why do we need this node at all?
> >
> > -Scott
> >
>
> The initial (Freescale SDK) binding document contained those compatibles,
> not sure what the initial intent was for the <SoC> variants.
>
> The "fsl,dpaa" node is of interest to the DPAA Ethernet because it is
> the parent of the "fsl,dpa-ethernet" nodes.
I'm not interested in what the SDK binding says, or what the SDK kernel
does. I'm interested in whether there's a U-Boot compatibility issue,
as was previously alleged. If there isn't, then there's no need for
fsl,dpaa *or* fsl,dpa-ethernet.
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Documentation: bindings: net: DPAA corenet binding document
2014-12-02 23:03 ` Scott Wood
@ 2014-12-03 22:01 ` Scott Wood
-1 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2014-12-03 22:01 UTC (permalink / raw
To: Bucur Madalin-Cristian-B32716
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, Medve Emilian-EMMEDVE1,
Liberman Igal-B31950, galak@codeaurora.org, Shaohui Xie
On Tue, 2014-12-02 at 17:03 -0600, Scott Wood wrote:
> On Tue, 2014-12-02 at 06:12 -0600, Bucur Madalin-Cristian-B32716 wrote:
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Tuesday, December 02, 2014 6:40 AM
> > >
> > > No need for the <SoC> part. As we previously discussed, the only
> > > purpose of this node is backwards compatibility with the U-Boot MAC
> > > address fixup -- if U-Boot doesn't look for the <SoC> version, then
> > > don't complicate things.
> > >
> > > Though, I can't find where U-Boot references this node. Are you sure
> > > it's not using the ethernet%d aliases like everything else, in which
> > > case why do we need this node at all?
> > >
> > > -Scott
> > >
> >
> > The initial (Freescale SDK) binding document contained those compatibles,
> > not sure what the initial intent was for the <SoC> variants.
> >
> > The "fsl,dpaa" node is of interest to the DPAA Ethernet because it is
> > the parent of the "fsl,dpa-ethernet" nodes.
>
> I'm not interested in what the SDK binding says, or what the SDK kernel
> does. I'm interested in whether there's a U-Boot compatibility issue,
> as was previously alleged. If there isn't, then there's no need for
> fsl,dpaa *or* fsl,dpa-ethernet.
OK, I found the U-Boot fixup in question. It's not for MAC addresses,
but for marking disabled ports as disabled. It marks the dpa-ethernet
node as disabled, based on it having an fsl,fman-mac property that
points to the MAC node.
U-Boot also disables the MAC node itself, so it doesn't matter if it
doesn't find fsl,fman-mac -- except for the special case of fm1-dtsec1,
which is always kept enabled because it's used for MDIO for all ports.
Based on http://patchwork.ozlabs.org/patch/410770/ there's a separate
node for mdio, so why can't we mark the MAC disabled? Assuming that
there's no real problem in marking the fm1-dtsec1 MAC node disabled, we
can consider this to be a bug in U-Boot which can be worked around by
having the fm1-dtsec1 mac node have an fsl,fman-mac property that points
to itself. This property would only go on the fm1-dtsec1 mac node and
would only be in device trees for SoCs that are supported by U-Boots old
enough to not have had the bug be fixed.
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Documentation: bindings: net: DPAA corenet binding document
@ 2014-12-03 22:01 ` Scott Wood
0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2014-12-03 22:01 UTC (permalink / raw
To: Bucur Madalin-Cristian-B32716
Cc: devicetree@vger.kernel.org, Shaohui Xie, netdev@vger.kernel.org,
Medve Emilian-EMMEDVE1, Liberman Igal-B31950,
galak@codeaurora.org, linuxppc-dev@lists.ozlabs.org
On Tue, 2014-12-02 at 17:03 -0600, Scott Wood wrote:
> On Tue, 2014-12-02 at 06:12 -0600, Bucur Madalin-Cristian-B32716 wrote:
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Tuesday, December 02, 2014 6:40 AM
> > >
> > > No need for the <SoC> part. As we previously discussed, the only
> > > purpose of this node is backwards compatibility with the U-Boot MAC
> > > address fixup -- if U-Boot doesn't look for the <SoC> version, then
> > > don't complicate things.
> > >
> > > Though, I can't find where U-Boot references this node. Are you sure
> > > it's not using the ethernet%d aliases like everything else, in which
> > > case why do we need this node at all?
> > >
> > > -Scott
> > >
> >
> > The initial (Freescale SDK) binding document contained those compatibles,
> > not sure what the initial intent was for the <SoC> variants.
> >
> > The "fsl,dpaa" node is of interest to the DPAA Ethernet because it is
> > the parent of the "fsl,dpa-ethernet" nodes.
>
> I'm not interested in what the SDK binding says, or what the SDK kernel
> does. I'm interested in whether there's a U-Boot compatibility issue,
> as was previously alleged. If there isn't, then there's no need for
> fsl,dpaa *or* fsl,dpa-ethernet.
OK, I found the U-Boot fixup in question. It's not for MAC addresses,
but for marking disabled ports as disabled. It marks the dpa-ethernet
node as disabled, based on it having an fsl,fman-mac property that
points to the MAC node.
U-Boot also disables the MAC node itself, so it doesn't matter if it
doesn't find fsl,fman-mac -- except for the special case of fm1-dtsec1,
which is always kept enabled because it's used for MDIO for all ports.
Based on http://patchwork.ozlabs.org/patch/410770/ there's a separate
node for mdio, so why can't we mark the MAC disabled? Assuming that
there's no real problem in marking the fm1-dtsec1 MAC node disabled, we
can consider this to be a bug in U-Boot which can be worked around by
having the fm1-dtsec1 mac node have an fsl,fman-mac property that points
to itself. This property would only go on the fm1-dtsec1 mac node and
would only be in device trees for SoCs that are supported by U-Boots old
enough to not have had the bug be fixed.
-Scott
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-12-03 22:01 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-28 10:10 [PATCH] Documentation: bindings: net: DPAA corenet binding document Madalin Bucur
2014-11-28 10:10 ` Madalin Bucur
2014-11-28 10:10 ` Madalin Bucur
2014-12-02 4:39 ` Scott Wood
2014-12-02 4:39 ` Scott Wood
2014-12-02 4:39 ` Scott Wood
2014-12-02 12:12 ` Madalin-Cristian Bucur
2014-12-02 12:12 ` Madalin-Cristian Bucur
[not found] ` <BL2PR03MB545CC342CA6A408D2FD5CF6E67A0-AZ66ij2kwaa1tTsckATbNOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-12-02 23:03 ` Scott Wood
2014-12-02 23:03 ` Scott Wood
2014-12-03 22:01 ` Scott Wood
2014-12-03 22:01 ` Scott Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.