* [PATCH] thermal: Fix error path in thermal_init()
@ 2014-12-03 21:20 Luis Henriques
2014-12-08 4:17 ` Zhang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Luis Henriques @ 2014-12-03 21:20 UTC (permalink / raw
To: Zhang Rui, Eduardo Valentin
Cc: linux-pm, linux-kernel, Luis Henriques, stable
thermal_unregister_governors() and class_unregister() were being called in
the wrong order.
Fixes: 80a26a5c22b9 ("Thermal: build thermal governors into thermal_sys module")
Cc: stable@vger.kernel.org
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
drivers/thermal/thermal_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 43b90709585f..488e9bfd996b 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1835,10 +1835,10 @@ static int __init thermal_init(void)
exit_netlink:
genetlink_exit();
-unregister_governors:
- thermal_unregister_governors();
unregister_class:
class_unregister(&thermal_class);
+unregister_governors:
+ thermal_unregister_governors();
error:
idr_destroy(&thermal_tz_idr);
idr_destroy(&thermal_cdev_idr);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: Fix error path in thermal_init()
2014-12-03 21:20 [PATCH] thermal: Fix error path in thermal_init() Luis Henriques
@ 2014-12-08 4:17 ` Zhang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Zhang Rui @ 2014-12-08 4:17 UTC (permalink / raw
To: Luis Henriques; +Cc: Eduardo Valentin, linux-pm, linux-kernel, stable
On Wed, 2014-12-03 at 21:20 +0000, Luis Henriques wrote:
> thermal_unregister_governors() and class_unregister() were being called in
> the wrong order.
>
> Fixes: 80a26a5c22b9 ("Thermal: build thermal governors into thermal_sys module")
> Cc: stable@vger.kernel.org
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
applied.
thanks,
rui
> ---
> drivers/thermal/thermal_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 43b90709585f..488e9bfd996b 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1835,10 +1835,10 @@ static int __init thermal_init(void)
>
> exit_netlink:
> genetlink_exit();
> -unregister_governors:
> - thermal_unregister_governors();
> unregister_class:
> class_unregister(&thermal_class);
> +unregister_governors:
> + thermal_unregister_governors();
> error:
> idr_destroy(&thermal_tz_idr);
> idr_destroy(&thermal_cdev_idr);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-08 4:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 21:20 [PATCH] thermal: Fix error path in thermal_init() Luis Henriques
2014-12-08 4:17 ` Zhang Rui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.